From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] nvmet: add eui64 field to nvme_ns and populate via configfs
Date: Wed, 31 May 2017 13:24:03 +0200 [thread overview]
Message-ID: <51b921ed-e9f9-0eb2-7625-6053dbca6a82@suse.de> (raw)
In-Reply-To: <20170531094631.GC10718@lst.de>
On 05/31/2017 11:46 AM, Christoph Hellwig wrote:
> On Tue, May 30, 2017 at 11:45:25AM +0200, Johannes Thumshirn wrote:
>> Mostly consistency. The current nvme host code has the EUI sprinkled all
>> around. Sure I can drop it, but then what's the point in evaluating it
>> on the host side? Other targets may send it, so we need in on the host
>> and do we care about potentially awkward host implementations with Linux
>> as a target? Also it's rather handy for testing as well, after all it's
>> not too much and complex code.
>
> There's only one place in the host code proper (discounting the
> scsi translation mess), and that's because the field is still better
> than not having any uniqueue identifier. But I don't think we should
> spread it any further.
OK I'll drop it in my next re-send (which should hopefully be somewhen
today)
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH 3/7] nvmet: add eui64 field to nvme_ns and populate via configfs
Date: Wed, 31 May 2017 13:24:03 +0200 [thread overview]
Message-ID: <51b921ed-e9f9-0eb2-7625-6053dbca6a82@suse.de> (raw)
In-Reply-To: <20170531094631.GC10718@lst.de>
On 05/31/2017 11:46 AM, Christoph Hellwig wrote:
> On Tue, May 30, 2017@11:45:25AM +0200, Johannes Thumshirn wrote:
>> Mostly consistency. The current nvme host code has the EUI sprinkled all
>> around. Sure I can drop it, but then what's the point in evaluating it
>> on the host side? Other targets may send it, so we need in on the host
>> and do we care about potentially awkward host implementations with Linux
>> as a target? Also it's rather handy for testing as well, after all it's
>> not too much and complex code.
>
> There's only one place in the host code proper (discounting the
> scsi translation mess), and that's because the field is still better
> than not having any uniqueue identifier. But I don't think we should
> spread it any further.
OK I'll drop it in my next re-send (which should hopefully be somewhen
today)
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-05-31 11:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 8:08 [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:08 ` [PATCH 1/7] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:18 ` Hannes Reinecke
2017-05-30 8:18 ` Hannes Reinecke
2017-05-30 8:08 ` [PATCH 2/7] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:20 ` Hannes Reinecke
2017-05-30 8:20 ` Hannes Reinecke
2017-05-30 9:24 ` Christoph Hellwig
2017-05-30 9:24 ` Christoph Hellwig
2017-05-30 9:48 ` Johannes Thumshirn
2017-05-30 9:48 ` Johannes Thumshirn
2017-05-31 9:45 ` Christoph Hellwig
2017-05-31 9:45 ` Christoph Hellwig
2017-05-30 8:08 ` [PATCH 3/7] nvmet: add eui64 " Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:21 ` Hannes Reinecke
2017-05-30 8:21 ` Hannes Reinecke
2017-05-30 9:25 ` Christoph Hellwig
2017-05-30 9:25 ` Christoph Hellwig
2017-05-30 9:45 ` Johannes Thumshirn
2017-05-30 9:45 ` Johannes Thumshirn
2017-05-31 9:46 ` Christoph Hellwig
2017-05-31 9:46 ` Christoph Hellwig
2017-05-31 11:24 ` Johannes Thumshirn [this message]
2017-05-31 11:24 ` Johannes Thumshirn
2017-05-30 8:08 ` [PATCH 4/7] nvme: also report include the EUI-64 in identify NS report Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:22 ` Hannes Reinecke
2017-05-30 8:22 ` Hannes Reinecke
2017-05-30 9:27 ` Christoph Hellwig
2017-05-30 9:27 ` Christoph Hellwig
2017-05-30 8:08 ` [PATCH 5/7] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:24 ` Hannes Reinecke
2017-05-30 8:24 ` Hannes Reinecke
2017-05-30 11:04 ` Max Gurtovoy
2017-05-30 14:20 ` Johannes Thumshirn
2017-05-30 8:08 ` [PATCH 6/7] nvme: get list of namespace descriptors Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:30 ` Hannes Reinecke
2017-05-30 8:30 ` Hannes Reinecke
2017-05-30 8:08 ` [PATCH 7/7] nvme: provide UUID value to userspace Johannes Thumshirn
2017-05-30 8:08 ` Johannes Thumshirn
2017-05-30 8:31 ` Hannes Reinecke
2017-05-30 8:31 ` Hannes Reinecke
2017-05-30 9:30 ` Christoph Hellwig
2017-05-30 9:30 ` Christoph Hellwig
2017-05-30 10:23 ` Johannes Thumshirn
2017-05-30 10:23 ` Johannes Thumshirn
2017-05-31 9:43 ` [PATCH 0/7] Implement NVMe Namespace Descriptor Identification Christoph Hellwig
2017-05-31 9:43 ` Christoph Hellwig
2017-05-31 11:22 ` Johannes Thumshirn
2017-05-31 11:22 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b921ed-e9f9-0eb2-7625-6053dbca6a82@suse.de \
--to=jthumshirn@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.