All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kbuild: deb-pkg: get rid of |flex:native workaround from Build-Depends
@ 2022-11-17  1:30 Masahiro Yamada
  2022-11-17 16:50 ` Ben Hutchings
  0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2022-11-17  1:30 UTC (permalink / raw)
  To: linux-kbuild
  Cc: Masahiro Yamada, Ben Hutchings, Nathan Chancellor,
	Nick Desaulniers, Nicolas Schier, linux-kernel

"| flex:native" was a workaround (suggested by Ben, see Link) because
"MultiArch: foreign" was missing in the flex package on some old distros
when commit e3a22850664f ("deb-pkg: generate correct build dependencies")
was applied.

It seems fixing the flex package has been completed. Get rid of the
workaround.

Link: https://lore.kernel.org/linux-kbuild/ab49b0582ef12b14b1a68877263b81813e2492a2.camel@decadent.org.uk/
Link: https://wiki.debian.org/CrossBuildPackagingGuidelines
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/package/mkdebian | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index 60a2a63a5e90..852d13e738c5 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -175,7 +175,7 @@ Section: kernel
 Priority: optional
 Maintainer: $maintainer
 Rules-Requires-Root: no
-Build-Depends: bc, rsync, kmod, cpio, bison, flex | flex:native $extra_build_depends
+Build-Depends: bc, rsync, kmod, cpio, bison, flex $extra_build_depends
 Homepage: https://www.kernel.org/
 
 Package: $packagename-$version
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kbuild: deb-pkg: get rid of |flex:native workaround from Build-Depends
  2022-11-17  1:30 [PATCH] kbuild: deb-pkg: get rid of |flex:native workaround from Build-Depends Masahiro Yamada
@ 2022-11-17 16:50 ` Ben Hutchings
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2022-11-17 16:50 UTC (permalink / raw)
  To: Masahiro Yamada, linux-kbuild
  Cc: Nathan Chancellor, Nick Desaulniers, Nicolas Schier, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1432 bytes --]

On Thu, 2022-11-17 at 10:30 +0900, Masahiro Yamada wrote:
> "| flex:native" was a workaround (suggested by Ben, see Link) because
> "MultiArch: foreign" was missing in the flex package on some old distros
> when commit e3a22850664f ("deb-pkg: generate correct build dependencies")
> was applied.
> 
> It seems fixing the flex package has been completed. Get rid of the
> workaround.
> 
> Link: https://lore.kernel.org/linux-kbuild/ab49b0582ef12b14b1a68877263b81813e2492a2.camel@decadent.org.uk/
> Link: https://wiki.debian.org/CrossBuildPackagingGuidelines
> Cc: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Ben Hutchings <ben@decadent.org.uk>

> ---
> 
>  scripts/package/mkdebian | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> index 60a2a63a5e90..852d13e738c5 100755
> --- a/scripts/package/mkdebian
> +++ b/scripts/package/mkdebian
> @@ -175,7 +175,7 @@ Section: kernel
>  Priority: optional
>  Maintainer: $maintainer
>  Rules-Requires-Root: no
> -Build-Depends: bc, rsync, kmod, cpio, bison, flex | flex:native $extra_build_depends
> +Build-Depends: bc, rsync, kmod, cpio, bison, flex $extra_build_depends
>  Homepage: https://www.kernel.org/
>  
>  Package: $packagename-$version

-- 
Ben Hutchings
Larkinson's Law: All laws are basically false.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-17 17:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17  1:30 [PATCH] kbuild: deb-pkg: get rid of |flex:native workaround from Build-Depends Masahiro Yamada
2022-11-17 16:50 ` Ben Hutchings

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.