[PATCH] clocksource: add an "menu" item to Kconfig

[PATCH] clocksource: add an "menu" item to Kconfig

[Sebastian Andrzej Siewior]

This patch adds a menu item to clocksource' Kconfig file. Without it the
changeable items look somehow lost in the main drivers' menu

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/clocksource/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index d0e207b..95660d8 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -1,3 +1,5 @@
+menu "Clocksource Framework"
+
 config CLKSRC_OF
 	bool
 
@@ -123,3 +125,4 @@ config VF_PIT_TIMER
 	bool
 	help
 	  Support for Period Interrupt Timer on Freescale Vybrid Family SoCs.
+endmenu
-- 
1.8.3.2

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[John Stultz]

On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
> This patch adds a menu item to clocksource' Kconfig file. Without it the
> changeable items look somehow lost in the main drivers' menu

So I'd like to push back on this a bit and ask why we need user-visible 
clocksource config options?

I'm much prefer the platform options select the needed clocksources, and 
not leave it up to the user (who really doesn't want to go digging 
around to find the clocksource sub-menu under drivers, and scan a list 
of 100 options that aren't possible on their hardware).

For an example of what I consider bad behavior here, see the RTC driver 
directory - at a certain point they just become hashes: "Oh no.. you 
selected rtc-387aae6fd, on your hardware, you need rtc-adfb8e5".

It really just seems like it forces more unnecessary options on the user 
and more ways to build a kernel that won't boot.

I do get you're trying to fix up the bad situation, caused by 
user-prompts slipping into the Kconfig.

But I might prefer a patch closer to whats below.

thanks
-john


diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b7b9b04..b3050db 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -57,14 +57,14 @@ config CLKSRC_NOMADIK_MTU_SCHED_CLOCK
  	  Use the Multi Timer Unit as the sched_clock.
  
  config CLKSRC_DBX500_PRCMU
-	bool "Clocksource PRCMU Timer"
+	bool
  	depends on UX500_SOC_DB8500
  	default y
  	help
  	  Use the always on PRCMU Timer as clocksource
  
  config CLKSRC_DBX500_PRCMU_SCHED_CLOCK
-	bool "Clocksource PRCMU Timer sched_clock"
+	bool
  	depends on (CLKSRC_DBX500_PRCMU && !CLKSRC_NOMADIK_MTU_SCHED_CLOCK)
  	default y
  	help

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[Sebastian Andrzej Siewior]

On 08/07/2013 06:21 PM, John Stultz wrote:
> On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
>> This patch adds a menu item to clocksource' Kconfig file. Without it the
>> changeable items look somehow lost in the main drivers' menu
> 
> So I'd like to push back on this a bit and ask why we need user-visible
> clocksource config options?

There was one visible Option if I remember correctly. I added two and
was wondering once I found them. I do have a PCI card which provides a
clock source and clock events device. So I assumed select <m|y> would
be doable.

> I'm much prefer the platform options select the needed clocksources, and
> not leave it up to the user (who really doesn't want to go digging
> around to find the clocksource sub-menu under drivers, and scan a list
> of 100 options that aren't possible on their hardware).
> 
> For an example of what I consider bad behavior here, see the RTC driver
> directory - at a certain point they just become hashes: "Oh no.. you
> selected rtc-387aae6fd, on your hardware, you need rtc-adfb8e5".
> 
> It really just seems like it forces more unnecessary options on the user
> and more ways to build a kernel that won't boot.
> 
> I do get you're trying to fix up the bad situation, caused by
> user-prompts slipping into the Kconfig.

Yes, that is fine. That PCI device is divided into multiple devices so
once it is enabled I could use "select" for required clock source.

> But I might prefer a patch closer to whats below.

Okay.

> 
> thanks
> -john


Sebastian

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[John Stultz]

On 08/07/2013 09:30 AM, Sebastian Andrzej Siewior wrote:
> On 08/07/2013 06:21 PM, John Stultz wrote:
>> On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
>>> This patch adds a menu item to clocksource' Kconfig file. Without it the
>>> changeable items look somehow lost in the main drivers' menu
>> So I'd like to push back on this a bit and ask why we need user-visible
>> clocksource config options?
> There was one visible Option if I remember correctly. I added two and
> was wondering once I found them. I do have a PCI card which provides a
> clock source and clock events device. So I assumed select <m|y> would
> be doable.

PCI card, eh? (Heh. In writing my previous mail, I think I even wrote 
"These are clocksources soldered to the motherboard, not pci cards!", 
but deleted it as it didn't seem useful. :)

So I think that's actually a first for clocksource drivers.

So, if there are genuinely cross-architecture pluggable clocksources, 
that aren't part of a platform definition, I would be ok with making an 
exception. But I'd want to make sure that we kept a high-bar for adding 
clocksource options, so that folks don't just clutter up the Kconfig menu.

That said, Daniel (now cc'ed - sorry for not cc'ing you earlier!) is now 
in charge of the clocksource directory, so my objections and wishes 
aren't as important as his.

thanks
-john

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[Daniel Lezcano]

On 08/07/2013 06:58 PM, John Stultz wrote:
> On 08/07/2013 09:30 AM, Sebastian Andrzej Siewior wrote:
>> On 08/07/2013 06:21 PM, John Stultz wrote:
>>> On 08/07/2013 03:56 AM, Sebastian Andrzej Siewior wrote:
>>>> This patch adds a menu item to clocksource' Kconfig file. Without it
>>>> the
>>>> changeable items look somehow lost in the main drivers' menu
>>> So I'd like to push back on this a bit and ask why we need user-visible
>>> clocksource config options?
>> There was one visible Option if I remember correctly. I added two and
>> was wondering once I found them. I do have a PCI card which provides a
>> clock source and clock events device. So I assumed select <m|y> would
>> be doable.
> 
> PCI card, eh? (Heh. In writing my previous mail, I think I even wrote
> "These are clocksources soldered to the motherboard, not pci cards!",
> but deleted it as it didn't seem useful. :)
> 
> So I think that's actually a first for clocksource drivers.
> 
> So, if there are genuinely cross-architecture pluggable clocksources,
> that aren't part of a platform definition, I would be ok with making an
> exception. But I'd want to make sure that we kept a high-bar for adding
> clocksource options, so that folks don't just clutter up the Kconfig menu.
> 
> That said, Daniel (now cc'ed - sorry for not cc'ing you earlier!) is now
> in charge of the clocksource directory, so my objections and wishes
> aren't as important as his.

Sebastian,

instead of adding a menu item in the Kconfig, is it possible to have
this Kconfig PCI board support to select the right driver ?

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[Sebastian Andrzej Siewior]

On 08/12/2013 02:55 PM, Daniel Lezcano wrote:
> Sebastian,

Hi Daniel,

> instead of adding a menu item in the Kconfig, is it possible to have
> this Kconfig PCI board support to select the right driver ?

I decided to go with only with "tristate" so it does not pop up in
Kconfig and will be selected by the MFD/PCI driver. Is this what you
have in mind?

> Thanks
>   -- Daniel

Sebastian

Re: [PATCH] clocksource: add an "menu" item to Kconfig

[Daniel Lezcano]

On 08/12/2013 03:04 PM, Sebastian Andrzej Siewior wrote:
> On 08/12/2013 02:55 PM, Daniel Lezcano wrote:
>> Sebastian,
> 
> Hi Daniel,
> 
>> instead of adding a menu item in the Kconfig, is it possible to have
>> this Kconfig PCI board support to select the right driver ?
> 
> I decided to go with only with "tristate" so it does not pop up in
> Kconfig and will be selected by the MFD/PCI driver. Is this what you
> have in mind?

Yes, right. The clocksource's Kconfig is kept untouched.

Thanks
  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog