From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Chunyou Tang <tangchunyou@163.com>
Cc: gustavoars@kernel.org, sam@ravnborg.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, tangchunyou@yulong.com
Subject: Re: [PATCH] drivers/video/fbdev:modify 0 to NULL
Date: Wed, 17 Mar 2021 20:54:41 -0500 [thread overview]
Message-ID: <5202c72d-4246-1a4e-37fa-7caf2d9c1ce3@embeddedor.com> (raw)
In-Reply-To: <20210318104718.00005767@163.com>
On 3/17/21 21:47, Chunyou Tang wrote:
> I think "if (info == NULL)" is more intuitive,and there have many
> compare likes "if (info == NULL)" in this file.
In that case, all those instances should be changed to if (!foo), instead.
--
Gustavo
WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Chunyou Tang <tangchunyou@163.com>
Cc: linux-fbdev@vger.kernel.org, sam@ravnborg.org,
gustavoars@kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, tangchunyou@yulong.com
Subject: Re: [PATCH] drivers/video/fbdev:modify 0 to NULL
Date: Wed, 17 Mar 2021 20:54:41 -0500 [thread overview]
Message-ID: <5202c72d-4246-1a4e-37fa-7caf2d9c1ce3@embeddedor.com> (raw)
In-Reply-To: <20210318104718.00005767@163.com>
On 3/17/21 21:47, Chunyou Tang wrote:
> I think "if (info == NULL)" is more intuitive,and there have many
> compare likes "if (info == NULL)" in this file.
In that case, all those instances should be changed to if (!foo), instead.
--
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-18 3:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 2:33 [PATCH] drivers/video/fbdev:modify 0 to NULL ChunyouTang
2021-03-18 2:33 ` ChunyouTang
2021-03-18 1:41 ` Gustavo A. R. Silva
2021-03-18 1:41 ` Gustavo A. R. Silva
2021-03-18 2:47 ` Chunyou Tang
2021-03-18 2:47 ` Chunyou Tang
2021-03-18 1:54 ` Gustavo A. R. Silva [this message]
2021-03-18 1:54 ` Gustavo A. R. Silva
2021-03-18 2:56 ` Chunyou Tang
2021-03-18 2:56 ` Chunyou Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202c72d-4246-1a4e-37fa-7caf2d9c1ce3@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tangchunyou@163.com \
--cc=tangchunyou@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.