* [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()
@ 2013-08-12 13:24 ` Libo Chen
0 siblings, 0 replies; 6+ messages in thread
From: Libo Chen @ 2013-08-12 13:24 UTC (permalink / raw)
To: pantelis.antoniou, vbordug, David Miller
Cc: linuxppc-dev, netdev, LKML, Li Zefan
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
.../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
fep->ops->free_bd(ndev);
fep->ops->cleanup_data(ndev);
- dev_set_drvdata(fep->dev, NULL);
of_node_put(fep->fpi->phy_node);
free_netdev(ndev);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()
@ 2013-08-12 13:24 ` Libo Chen
0 siblings, 0 replies; 6+ messages in thread
From: Libo Chen @ 2013-08-12 13:24 UTC (permalink / raw)
To: pantelis.antoniou, vbordug, David Miller
Cc: netdev, Li Zefan, linuxppc-dev, LKML
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
.../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
fep->ops->free_bd(ndev);
fep->ops->cleanup_data(ndev);
- dev_set_drvdata(fep->dev, NULL);
of_node_put(fep->fpi->phy_node);
free_netdev(ndev);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()
2013-08-12 13:24 ` Libo Chen
@ 2013-08-12 18:16 ` Sergei Shtylyov
-1 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2013-08-12 18:16 UTC (permalink / raw)
To: Libo Chen
Cc: pantelis.antoniou, vbordug, David Miller, linuxppc-dev, netdev,
LKML, Li Zefan
On 08/12/2013 05:24 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index 8de53a1..7e3de10 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
>
> fep->ops->free_bd(ndev);
> fep->ops->cleanup_data(ndev);
> - dev_set_drvdata(fep->dev, NULL);
> of_node_put(fep->fpi->phy_node);
> free_netdev(ndev);
> return 0;
Changelog simply doesn't match the patch.
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata()
@ 2013-08-12 18:16 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2013-08-12 18:16 UTC (permalink / raw)
To: Libo Chen; +Cc: netdev, LKML, Li Zefan, vbordug, linuxppc-dev, David Miller
On 08/12/2013 05:24 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> index 8de53a1..7e3de10 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> @@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
>
> fep->ops->free_bd(ndev);
> fep->ops->cleanup_data(ndev);
> - dev_set_drvdata(fep->dev, NULL);
> of_node_put(fep->fpi->phy_node);
> free_netdev(ndev);
> return 0;
Changelog simply doesn't match the patch.
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH RESEND 4/8] net: fs_enet: remove unnecessary dev_set_drvdata()
2013-08-12 13:24 ` Libo Chen
@ 2013-08-14 3:39 ` Libo Chen
-1 siblings, 0 replies; 6+ messages in thread
From: Libo Chen @ 2013-08-14 3:39 UTC (permalink / raw)
To: David Miller, vbordug, pantelis.antoniou
Cc: linuxppc-dev, netdev, LKML, Li Zefan
unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
fep->ops->free_bd(ndev);
fep->ops->cleanup_data(ndev);
- dev_set_drvdata(fep->dev, NULL);
of_node_put(fep->fpi->phy_node);
free_netdev(ndev);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RESEND 4/8] net: fs_enet: remove unnecessary dev_set_drvdata()
@ 2013-08-14 3:39 ` Libo Chen
0 siblings, 0 replies; 6+ messages in thread
From: Libo Chen @ 2013-08-14 3:39 UTC (permalink / raw)
To: David Miller, vbordug, pantelis.antoniou
Cc: netdev, Li Zefan, linuxppc-dev, LKML
unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index 8de53a1..7e3de10 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -1122,7 +1122,6 @@ static int fs_enet_remove(struct platform_device *ofdev)
fep->ops->free_bd(ndev);
fep->ops->cleanup_data(ndev);
- dev_set_drvdata(fep->dev, NULL);
of_node_put(fep->fpi->phy_node);
free_netdev(ndev);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-14 3:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-12 13:24 [PATCH 4/8] net: fs_enet: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 13:24 ` Libo Chen
2013-08-12 18:16 ` Sergei Shtylyov
2013-08-12 18:16 ` Sergei Shtylyov
2013-08-14 3:39 ` [PATCH RESEND 4/8] net: fs_enet: remove unnecessary dev_set_drvdata() Libo Chen
2013-08-14 3:39 ` Libo Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.