All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
@ 2013-08-13 17:11 Saul Wold
  2013-08-13 17:23 ` Laszlo Papp
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Saul Wold @ 2013-08-13 17:11 UTC (permalink / raw)
  To: openembedded-core

This shows an example of the config fragment support that
both the linux-yocto and busybox recipes use. This example
is specific to busybox.

By adding busybox CONFIG options into a .cfg file and then
adding that .cfg file to SRC_URI the merge_config.sh script will
correctly handle these CONFIG options during the do_configure task.

v2: fixed FILESEXTRAPATHS

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
 meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
 2 files changed, 6 insertions(+)
 create mode 100644 meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
 create mode 100644 meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend

diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
new file mode 100644
index 0000000..42c6730
--- /dev/null
+++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
@@ -0,0 +1 @@
+CONFIG_RFKILL=n
diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
new file mode 100644
index 0000000..641f04a4
--- /dev/null
+++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
@@ -0,0 +1,5 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
+
+SRC_URI += " \
+	    file://no_rfkill.cfg \
+           "
-- 
1.8.1.4



^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:11 [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example Saul Wold
@ 2013-08-13 17:23 ` Laszlo Papp
  2013-08-13 17:23   ` Laszlo Papp
  2013-08-13 17:26 ` Mark Hatle
  2013-08-13 18:39 ` Otavio Salvador
  2 siblings, 1 reply; 11+ messages in thread
From: Laszlo Papp @ 2013-08-13 17:23 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

How will this know which files exactly to disregard in the busybox include
file (".inc")?

Could you please give that to the commit message as explanation?


On Tue, Aug 13, 2013 at 6:11 PM, Saul Wold <sgw@linux.intel.com> wrote:

> This shows an example of the config fragment support that
> both the linux-yocto and busybox recipes use. This example
> is specific to busybox.
>
> By adding busybox CONFIG options into a .cfg file and then
> adding that .cfg file to SRC_URI the merge_config.sh script will
> correctly handle these CONFIG options during the do_configure task.
>
> v2: fixed FILESEXTRAPATHS
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>  meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644
> meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>  create mode 100644
> meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>
> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> new file mode 100644
> index 0000000..42c6730
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> @@ -0,0 +1 @@
> +CONFIG_RFKILL=n
> diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> new file mode 100644
> index 0000000..641f04a4
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> @@ -0,0 +1,5 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +SRC_URI += " \
> +           file://no_rfkill.cfg \
> +           "
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2703 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:23 ` Laszlo Papp
@ 2013-08-13 17:23   ` Laszlo Papp
  2013-08-13 17:33     ` Mark Hatle
  0 siblings, 1 reply; 11+ messages in thread
From: Laszlo Papp @ 2013-08-13 17:23 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]

s/which files/which lines/


On Tue, Aug 13, 2013 at 6:23 PM, Laszlo Papp <lpapp@kde.org> wrote:

> How will this know which files exactly to disregard in the busybox include
> file (".inc")?
>
> Could you please give that to the commit message as explanation?
>
>
> On Tue, Aug 13, 2013 at 6:11 PM, Saul Wold <sgw@linux.intel.com> wrote:
>
>> This shows an example of the config fragment support that
>> both the linux-yocto and busybox recipes use. This example
>> is specific to busybox.
>>
>> By adding busybox CONFIG options into a .cfg file and then
>> adding that .cfg file to SRC_URI the merge_config.sh script will
>> correctly handle these CONFIG options during the do_configure task.
>>
>> v2: fixed FILESEXTRAPATHS
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>  meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>>  meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>>  2 files changed, 6 insertions(+)
>>  create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>>  create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>>
>> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> new file mode 100644
>> index 0000000..42c6730
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> @@ -0,0 +1 @@
>> +CONFIG_RFKILL=n
>> diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> new file mode 100644
>> index 0000000..641f04a4
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> @@ -0,0 +1,5 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +SRC_URI += " \
>> +           file://no_rfkill.cfg \
>> +           "
>> --
>> 1.8.1.4
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>

[-- Attachment #2: Type: text/html, Size: 3130 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:11 [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example Saul Wold
  2013-08-13 17:23 ` Laszlo Papp
@ 2013-08-13 17:26 ` Mark Hatle
  2013-08-13 17:40   ` Darren Hart
  2013-08-13 17:46   ` Saul Wold
  2013-08-13 18:39 ` Otavio Salvador
  2 siblings, 2 replies; 11+ messages in thread
From: Mark Hatle @ 2013-08-13 17:26 UTC (permalink / raw)
  To: openembedded-core

On 8/13/13 12:11 PM, Saul Wold wrote:
> This shows an example of the config fragment support that
> both the linux-yocto and busybox recipes use. This example
> is specific to busybox.
>
> By adding busybox CONFIG options into a .cfg file and then
> adding that .cfg file to SRC_URI the merge_config.sh script will
> correctly handle these CONFIG options during the do_configure task.
>
> v2: fixed FILESEXTRAPATHS
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>   meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>   2 files changed, 6 insertions(+)
>   create mode 100644 meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>   create mode 100644 meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>
> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> new file mode 100644
> index 0000000..42c6730
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> @@ -0,0 +1 @@
> +CONFIG_RFKILL=n

Should be "# CONFIG_RFKILL is not set", I believe the =n will work, but it 
doesn't following the kconfig conventions.

--Mark

> diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> new file mode 100644
> index 0000000..641f04a4
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> @@ -0,0 +1,5 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +SRC_URI += " \
> +	    file://no_rfkill.cfg \
> +           "
>



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:23   ` Laszlo Papp
@ 2013-08-13 17:33     ` Mark Hatle
  2013-08-13 17:40       ` Laszlo Papp
  0 siblings, 1 reply; 11+ messages in thread
From: Mark Hatle @ 2013-08-13 17:33 UTC (permalink / raw)
  To: openembedded-core

On 8/13/13 12:23 PM, Laszlo Papp wrote:
> s/which files/which lines/

The kernel configuration mechanism has a tool that will combine the original 
configuration, and any listed configuration fragments (.cfg files).  It will 
combine these, and then filter them in such a way that last-in wins.

See the Yocto Project Linux Kernel Development manual, section 2.2.3:

http://www.yoctoproject.org/docs/current/kernel-dev/kernel-dev.html#changing-the-configuration

--Mark

> On Tue, Aug 13, 2013 at 6:23 PM, Laszlo Papp <lpapp@kde.org
> <mailto:lpapp@kde.org>> wrote:
>
>     How will this know which files exactly to disregard in the busybox include
>     file (".inc")?
>
>     Could you please give that to the commit message as explanation?
>
>
>     On Tue, Aug 13, 2013 at 6:11 PM, Saul Wold <sgw@linux.intel.com
>     <mailto:sgw@linux.intel.com>> wrote:
>
>         This shows an example of the config fragment support that
>         both the linux-yocto and busybox recipes use. This example
>         is specific to busybox.
>
>         By adding busybox CONFIG options into a .cfg file and then
>         adding that .cfg file to SRC_URI the merge_config.sh script will
>         correctly handle these CONFIG options during the do_configure task.
>
>         v2: fixed FILESEXTRAPATHS
>
>         Signed-off-by: Saul Wold <sgw@linux.intel.com <mailto:sgw@linux.intel.com>>
>         ---
>           meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>           meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>           2 files changed, 6 insertions(+)
>           create mode 100644
>         meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>           create mode 100644
>         meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>
>         diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>         b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>         new file mode 100644
>         index 0000000..42c6730
>         --- /dev/null
>         +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>         @@ -0,0 +1 @@
>         +CONFIG_RFKILL=n
>         diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>         b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>         new file mode 100644
>         index 0000000..641f04a4
>         --- /dev/null
>         +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>         @@ -0,0 +1,5 @@
>         +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>         +
>         +SRC_URI += " \
>         +           file://no_rfkill.cfg \
>         +           "
>         --
>         1.8.1.4
>
>         _______________________________________________
>         Openembedded-core mailing list
>         Openembedded-core@lists.openembedded.org
>         <mailto:Openembedded-core@lists.openembedded.org>
>         http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:26 ` Mark Hatle
@ 2013-08-13 17:40   ` Darren Hart
  2013-08-13 17:46   ` Saul Wold
  1 sibling, 0 replies; 11+ messages in thread
From: Darren Hart @ 2013-08-13 17:40 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

On Tue, 2013-08-13 at 12:26 -0500, Mark Hatle wrote:
> On 8/13/13 12:11 PM, Saul Wold wrote:
> > This shows an example of the config fragment support that
> > both the linux-yocto and busybox recipes use. This example
> > is specific to busybox.
> >
> > By adding busybox CONFIG options into a .cfg file and then
> > adding that .cfg file to SRC_URI the merge_config.sh script will
> > correctly handle these CONFIG options during the do_configure task.
> >
> > v2: fixed FILESEXTRAPATHS
> >
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >   meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
> >   meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
> >   2 files changed, 6 insertions(+)
> >   create mode 100644 meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> >   create mode 100644 meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> >
> > diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> > new file mode 100644
> > index 0000000..42c6730
> > --- /dev/null
> > +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> > @@ -0,0 +1 @@
> > +CONFIG_RFKILL=n
> 
> Should be "# CONFIG_RFKILL is not set", I believe the =n will work, but it 
> doesn't following the kconfig conventions.

Seconded. Or Thirded since I responded to V1 similarly. :-)

> 
> --Mark
> 
> > diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> > new file mode 100644
> > index 0000000..641f04a4
> > --- /dev/null
> > +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> > @@ -0,0 +1,5 @@
> > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > +
> > +SRC_URI += " \
> > +	    file://no_rfkill.cfg \
> > +           "
> >
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel




^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:33     ` Mark Hatle
@ 2013-08-13 17:40       ` Laszlo Papp
  2013-08-13 17:58         ` Mark Hatle
  0 siblings, 1 reply; 11+ messages in thread
From: Laszlo Papp @ 2013-08-13 17:40 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Tue, Aug 13, 2013 at 6:33 PM, Mark Hatle <mark.hatle@windriver.com>wrote:

> On 8/13/13 12:23 PM, Laszlo Papp wrote:
>
>> s/which files/which lines/
>>
>
> The kernel configuration mechanism has a tool that will combine the
> original configuration, and any listed configuration fragments (.cfg
> files).  It will combine these, and then filter them in such a way that
> last-in wins.
>
> See the Yocto Project Linux Kernel Development manual, section 2.2.3:
>
> http://www.yoctoproject.org/**docs/current/kernel-dev/**
> kernel-dev.html#changing-the-**configuration<http://www.yoctoproject.org/docs/current/kernel-dev/kernel-dev.html#changing-the-configuration>


Could you please clarify how that is related to my question? What I wanna
understand is: I set something in the config as I wish, and then the
bitbake file is getting chopped respectively like with "ifdef/elif" etc in
C/C++, but this time inside the python script defined in the bitbake file.

I am well aware of that you can customize the defconfig, but my question
was about the python function.

[-- Attachment #2: Type: text/html, Size: 1594 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:26 ` Mark Hatle
  2013-08-13 17:40   ` Darren Hart
@ 2013-08-13 17:46   ` Saul Wold
  1 sibling, 0 replies; 11+ messages in thread
From: Saul Wold @ 2013-08-13 17:46 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

On 08/13/2013 10:26 AM, Mark Hatle wrote:
> On 8/13/13 12:11 PM, Saul Wold wrote:
>> This shows an example of the config fragment support that
>> both the linux-yocto and busybox recipes use. This example
>> is specific to busybox.
>>
>> By adding busybox CONFIG options into a .cfg file and then
>> adding that .cfg file to SRC_URI the merge_config.sh script will
>> correctly handle these CONFIG options during the do_configure task.
>>
>> v2: fixed FILESEXTRAPATHS
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>   meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>>   meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>>   2 files changed, 6 insertions(+)
>>   create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>>   create mode 100644
>> meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>>
>> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> new file mode 100644
>> index 0000000..42c6730
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>> @@ -0,0 +1 @@
>> +CONFIG_RFKILL=n
>
> Should be "# CONFIG_RFKILL is not set", I believe the =n will work, but
> it doesn't following the kconfig conventions.
>
Yup, the commented out version works also, I will update the patch (v3), 
with


> --Mark
>
>> diff --git
>> a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> new file mode 100644
>> index 0000000..641f04a4
>> --- /dev/null
>> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>> @@ -0,0 +1,5 @@
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>> +
>> +SRC_URI += " \
>> +        file://no_rfkill.cfg \
>> +           "
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:40       ` Laszlo Papp
@ 2013-08-13 17:58         ` Mark Hatle
  2013-08-13 18:02           ` Bruce Ashfield
  0 siblings, 1 reply; 11+ messages in thread
From: Mark Hatle @ 2013-08-13 17:58 UTC (permalink / raw)
  To: Laszlo Papp; +Cc: openembedded-core

On 8/13/13 12:40 PM, Laszlo Papp wrote:
> On Tue, Aug 13, 2013 at 6:33 PM, Mark Hatle <mark.hatle@windriver.com
> <mailto:mark.hatle@windriver.com>> wrote:
>
>     On 8/13/13 12:23 PM, Laszlo Papp wrote:
>
>         s/which files/which lines/
>
>
>     The kernel configuration mechanism has a tool that will combine the original
>     configuration, and any listed configuration fragments (.cfg files).  It will
>     combine these, and then filter them in such a way that last-in wins.
>
>     See the Yocto Project Linux Kernel Development manual, section 2.2.3:
>
>     http://www.yoctoproject.org/__docs/current/kernel-dev/__kernel-dev.html#changing-the-__configuration
>     <http://www.yoctoproject.org/docs/current/kernel-dev/kernel-dev.html#changing-the-configuration>
>
>
> Could you please clarify how that is related to my question? What I wanna
> understand is: I set something in the config as I wish, and then the bitbake
> file is getting chopped respectively like with "ifdef/elif" etc in C/C++, but
> this time inside the python script defined in the bitbake file.

You asked: How will this know which lines exactly to disregard in the busybox 
include file (".inc")?

My answer is that, according to the quoted documentation, the tooling, as 
described in the above URL, does this as a last-in processing, based on the 
filename(s) of the SRC_URI components.

> I am well aware of that you can customize the defconfig, but my question was
> about the python function.

Specifically for the busybox package, the python fragement "find_cfgs(d):" 
located in the busybox.inc file finds the .cfg files, and collects them into a 
list.  They are then processed by the 'merge_config.sh' script that is called as 
part of the do_configure task.

I believe the merge_config script is provided as part of the linux-libc-headers 
or linux-yocto package, but I may be incorrect on that.

--Mark


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:58         ` Mark Hatle
@ 2013-08-13 18:02           ` Bruce Ashfield
  0 siblings, 0 replies; 11+ messages in thread
From: Bruce Ashfield @ 2013-08-13 18:02 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

On Tue, Aug 13, 2013 at 1:58 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
> On 8/13/13 12:40 PM, Laszlo Papp wrote:
>>
>> On Tue, Aug 13, 2013 at 6:33 PM, Mark Hatle <mark.hatle@windriver.com
>> <mailto:mark.hatle@windriver.com>> wrote:
>>
>>     On 8/13/13 12:23 PM, Laszlo Papp wrote:
>>
>>         s/which files/which lines/
>>
>>
>>     The kernel configuration mechanism has a tool that will combine the
>> original
>>     configuration, and any listed configuration fragments (.cfg files).
>> It will
>>     combine these, and then filter them in such a way that last-in wins.
>>
>>     See the Yocto Project Linux Kernel Development manual, section 2.2.3:
>>
>>
>> http://www.yoctoproject.org/__docs/current/kernel-dev/__kernel-dev.html#changing-the-__configuration
>>
>>
>> <http://www.yoctoproject.org/docs/current/kernel-dev/kernel-dev.html#changing-the-configuration>
>>
>>
>> Could you please clarify how that is related to my question? What I wanna
>> understand is: I set something in the config as I wish, and then the
>> bitbake
>> file is getting chopped respectively like with "ifdef/elif" etc in C/C++,
>> but
>> this time inside the python script defined in the bitbake file.
>
>
> You asked: How will this know which lines exactly to disregard in the
> busybox include file (".inc")?
>
> My answer is that, according to the quoted documentation, the tooling, as
> described in the above URL, does this as a last-in processing, based on the
> filename(s) of the SRC_URI components.
>
>
>> I am well aware of that you can customize the defconfig, but my question
>> was
>> about the python function.
>
>
> Specifically for the busybox package, the python fragement "find_cfgs(d):"
> located in the busybox.inc file finds the .cfg files, and collects them into
> a list.  They are then processed by the 'merge_config.sh' script that is
> called as part of the do_configure task.
>
> I believe the merge_config script is provided as part of the
> linux-libc-headers or linux-yocto package, but I may be incorrect on that.

close, it's from the kern-tools package, but it is an upstream kernel script. We
use it from kern-tools to avoid fetching the kernel to use it for busybox.

Bruce

>
> --Mark
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example
  2013-08-13 17:11 [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example Saul Wold
  2013-08-13 17:23 ` Laszlo Papp
  2013-08-13 17:26 ` Mark Hatle
@ 2013-08-13 18:39 ` Otavio Salvador
  2 siblings, 0 replies; 11+ messages in thread
From: Otavio Salvador @ 2013-08-13 18:39 UTC (permalink / raw)
  To: Saul Wold; +Cc: Patches and discussions about the oe-core layer

On Tue, Aug 13, 2013 at 2:11 PM, Saul Wold <sgw@linux.intel.com> wrote:
> This shows an example of the config fragment support that
> both the linux-yocto and busybox recipes use. This example
> is specific to busybox.
>
> By adding busybox CONFIG options into a .cfg file and then
> adding that .cfg file to SRC_URI the merge_config.sh script will
> correctly handle these CONFIG options during the do_configure task.
>
> v2: fixed FILESEXTRAPATHS

This should be bellow --- line or it ends in the commit log.

> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg   | 1 +
>  meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644 meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
>  create mode 100644 meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
>
> diff --git a/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> new file mode 100644
> index 0000000..42c6730
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox/no_rfkill.cfg
> @@ -0,0 +1 @@
> +CONFIG_RFKILL=n
> diff --git a/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> new file mode 100644
> index 0000000..641f04a4
> --- /dev/null
> +++ b/meta-skeleton/recipes-core/busybox/busybox_1.21.1.bbappend
> @@ -0,0 +1,5 @@
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> +
> +SRC_URI += " \
> +           file://no_rfkill.cfg \
> +           "
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2013-08-13 18:39 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-13 17:11 [PATCH 2/2 v2] meta-skeleton: Add busybox config fragment example Saul Wold
2013-08-13 17:23 ` Laszlo Papp
2013-08-13 17:23   ` Laszlo Papp
2013-08-13 17:33     ` Mark Hatle
2013-08-13 17:40       ` Laszlo Papp
2013-08-13 17:58         ` Mark Hatle
2013-08-13 18:02           ` Bruce Ashfield
2013-08-13 17:26 ` Mark Hatle
2013-08-13 17:40   ` Darren Hart
2013-08-13 17:46   ` Saul Wold
2013-08-13 18:39 ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.