All of lore.kernel.org
 help / color / mirror / Atom feed
* RealTek Inverted Mic Patch
@ 2013-08-15 20:27 Nathanael D. Noblet
  2013-08-16  6:20   ` Takashi Iwai
  0 siblings, 1 reply; 4+ messages in thread
From: Nathanael D. Noblet @ 2013-08-15 20:27 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, David Henningsson, Kailang Yang,
	alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

Hello,

   I have hardware that suffers from an internal phase inverted mic that 
isn't properly detected. Below is a patch that fixes the issue for my 
particular hardware.

Pre patch alsa-info:

http://www.alsa-project.org/db/?f=a922c77ddf473a8f478ec334fa9dca684f213b59

Post patch alsa-info:
http://www.alsa-project.org/db/?f=14cd25b323d3bbb02fabbac78e62851569893c3f

Incase you care. The patch is small. I don't know if you need any kind 
of signed off/written by etc for something so small. In any case there 
is no intellectual property in this at all. Feel free to do as you wish 
with it. However including it in the kernel would make my life easier.

Thanks,
-- 
Nathanael d. Noblet
t 403.875.4613

[-- Attachment #2: alsa-realtek-inverted-mic.patch --]
[-- Type: text/x-patch, Size: 523 bytes --]

--- a/sound/pci/hda/patch_realtek.c.org	2013-08-15 13:17:49.804492932 -0600
+++ b/sound/pci/hda/patch_realtek.c	2013-08-15 13:18:40.582364931 -0600
@@ -4208,6 +4208,7 @@
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
 	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
+    SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
 
 #if 0
 	/* Below is a quirk table taken from the old code.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: RealTek Inverted Mic Patch
  2013-08-15 20:27 RealTek Inverted Mic Patch Nathanael D. Noblet
@ 2013-08-16  6:20   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2013-08-16  6:20 UTC (permalink / raw)
  To: Nathanael D. Noblet
  Cc: Jaroslav Kysela, David Henningsson, Kailang Yang, alsa-devel,
	linux-kernel

At Thu, 15 Aug 2013 14:27:07 -0600,
Nathanael D. Noblet wrote:
> 
> Hello,
> 
>    I have hardware that suffers from an internal phase inverted mic that 
> isn't properly detected. Below is a patch that fixes the issue for my 
> particular hardware.
> 
> Pre patch alsa-info:
> 
> http://www.alsa-project.org/db/?f=a922c77ddf473a8f478ec334fa9dca684f213b59
> 
> Post patch alsa-info:
> http://www.alsa-project.org/db/?f=14cd25b323d3bbb02fabbac78e62851569893c3f
> 
> Incase you care. The patch is small. I don't know if you need any kind 
> of signed off/written by etc for something so small. In any case there 
> is no intellectual property in this at all. Feel free to do as you wish 
> with it. However including it in the kernel would make my life easier.

Thanks, I fixed it in sound git tree now.


Takashi

> 
> Thanks,
> -- 
> Nathanael d. Noblet
> t 403.875.4613
> [2 alsa-realtek-inverted-mic.patch <text/x-patch (7bit)>]
> --- a/sound/pci/hda/patch_realtek.c.org	2013-08-15 13:17:49.804492932 -0600
> +++ b/sound/pci/hda/patch_realtek.c	2013-08-15 13:18:40.582364931 -0600
> @@ -4208,6 +4208,7 @@
>  	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
>  	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
>  	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
> +    SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
>  
>  #if 0
>  	/* Below is a quirk table taken from the old code.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: RealTek Inverted Mic Patch
@ 2013-08-16  6:20   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2013-08-16  6:20 UTC (permalink / raw)
  To: Nathanael D. Noblet
  Cc: alsa-devel, Kailang Yang, linux-kernel, David Henningsson

At Thu, 15 Aug 2013 14:27:07 -0600,
Nathanael D. Noblet wrote:
> 
> Hello,
> 
>    I have hardware that suffers from an internal phase inverted mic that 
> isn't properly detected. Below is a patch that fixes the issue for my 
> particular hardware.
> 
> Pre patch alsa-info:
> 
> http://www.alsa-project.org/db/?f=a922c77ddf473a8f478ec334fa9dca684f213b59
> 
> Post patch alsa-info:
> http://www.alsa-project.org/db/?f=14cd25b323d3bbb02fabbac78e62851569893c3f
> 
> Incase you care. The patch is small. I don't know if you need any kind 
> of signed off/written by etc for something so small. In any case there 
> is no intellectual property in this at all. Feel free to do as you wish 
> with it. However including it in the kernel would make my life easier.

Thanks, I fixed it in sound git tree now.


Takashi

> 
> Thanks,
> -- 
> Nathanael d. Noblet
> t 403.875.4613
> [2 alsa-realtek-inverted-mic.patch <text/x-patch (7bit)>]
> --- a/sound/pci/hda/patch_realtek.c.org	2013-08-15 13:17:49.804492932 -0600
> +++ b/sound/pci/hda/patch_realtek.c	2013-08-15 13:18:40.582364931 -0600
> @@ -4208,6 +4208,7 @@
>  	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
>  	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
>  	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
> +    SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
>  
>  #if 0
>  	/* Below is a quirk table taken from the old code.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: RealTek Inverted Mic Patch
  2013-08-16  6:20   ` Takashi Iwai
  (?)
@ 2013-08-16 15:28   ` Nathanael D. Noblet
  -1 siblings, 0 replies; 4+ messages in thread
From: Nathanael D. Noblet @ 2013-08-16 15:28 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Jaroslav Kysela, David Henningsson, Kailang Yang, alsa-devel,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hello,

   Thanks for applying it - there is one more piece of hardware that 
needs the same type of fix. Here's an updated patch...
just the addition of

SND_PCI_QUIRK(0x1025, 0x022f, "Acer Aspire One", ALC662_FIXUP_INV_DMIC),

over and above what was already in the last patch..

On 08/16/2013 12:20 AM, Takashi Iwai wrote:
> At Thu, 15 Aug 2013 14:27:07 -0600,
> Nathanael D. Noblet wrote:
>>
>> Hello,
>>
>>     I have hardware that suffers from an internal phase inverted mic that
>> isn't properly detected. Below is a patch that fixes the issue for my
>> particular hardware.
>>
>> Pre patch alsa-info:
>>
>> http://www.alsa-project.org/db/?f=a922c77ddf473a8f478ec334fa9dca684f213b59
>>
>> Post patch alsa-info:
>> http://www.alsa-project.org/db/?f=14cd25b323d3bbb02fabbac78e62851569893c3f
>>
>> Incase you care. The patch is small. I don't know if you need any kind
>> of signed off/written by etc for something so small. In any case there
>> is no intellectual property in this at all. Feel free to do as you wish
>> with it. However including it in the kernel would make my life easier.
>
> Thanks, I fixed it in sound git tree now.
>
>
> Takashi
>
>>
>> Thanks,
>> --
>> Nathanael d. Noblet
>> t 403.875.4613
>> [2 alsa-realtek-inverted-mic.patch <text/x-patch (7bit)>]
>> --- a/sound/pci/hda/patch_realtek.c.org	2013-08-15 13:17:49.804492932 -0600
>> +++ b/sound/pci/hda/patch_realtek.c	2013-08-15 13:18:40.582364931 -0600
>> @@ -4208,6 +4208,7 @@
>>   	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
>>   	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
>>   	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
>> +    SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
>>
>>   #if 0
>>   	/* Below is a quirk table taken from the old code.
>


-- 
Nathanael d. Noblet
t 403.875.4613

[-- Attachment #2: alsa-realtek-inverted-mic.patch --]
[-- Type: text/x-patch, Size: 591 bytes --]

--- a/sound/pci/hda/patch_realtek.c	2013-08-15 13:17:49.804492932 -0600
+++ b/sound/pci/hda/patch_realtek.c	2013-08-15 15:17:46.390273328 -0600
@@ -4208,6 +4208,8 @@
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
 	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
+	SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
+	SND_PCI_QUIRK(0x1025, 0x022f, "Acer Aspire One", ALC662_FIXUP_INV_DMIC),
 
 #if 0
 	/* Below is a quirk table taken from the old code.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-16 15:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-15 20:27 RealTek Inverted Mic Patch Nathanael D. Noblet
2013-08-16  6:20 ` Takashi Iwai
2013-08-16  6:20   ` Takashi Iwai
2013-08-16 15:28   ` Nathanael D. Noblet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.