* [RESEND][PATCH 1/2] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated
@ 2016-10-21 1:09 Axel Lin
2016-10-21 1:09 ` [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu Axel Lin
[not found] ` <CGME20161021010940epcas1p1bf0feb2d8401d44adbcbd7f399d30f64@epcas1p1.samsung.com>
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-10-21 1:09 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, linux-pm,
linux-samsung-soc, Axel Lin
The rest of the code uses ARRAY_SIZE to count the number of entries in
ppmu_events array. The NULL terminated entry makes ARRAY_SIZE return
off-by-one value.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
---
This patch was sent on https://patchwork.kernel.org/patch/9342637/
drivers/devfreq/event/exynos-ppmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index f55cf0e..c9ffaf0 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -90,8 +90,6 @@ struct __exynos_ppmu_events {
PPMU_EVENT(d1-cpu),
PPMU_EVENT(d1-general),
PPMU_EVENT(d1-rt),
-
- { /* sentinel */ },
};
static int exynos_ppmu_find_ppmu_id(struct devfreq_event_dev *edev)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu
2016-10-21 1:09 [RESEND][PATCH 1/2] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated Axel Lin
@ 2016-10-21 1:09 ` Axel Lin
[not found] ` <CGME20161021010940epcas1p1bf0feb2d8401d44adbcbd7f399d30f64@epcas1p1.samsung.com>
1 sibling, 0 replies; 3+ messages in thread
From: Axel Lin @ 2016-10-21 1:09 UTC (permalink / raw)
To: Rafael J . Wysocki
Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, linux-pm,
linux-samsung-soc, Axel Lin
The mutex is not used at all, remove it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
---
This patch was sent on https://patchwork.kernel.org/patch/9341097/
drivers/devfreq/event/exynos-ppmu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index f55cf0e..251692b 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -15,7 +15,6 @@
#include <linux/io.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/mutex.h>
#include <linux/of_address.h>
#include <linux/platform_device.h>
#include <linux/suspend.h>
@@ -34,7 +33,6 @@ struct exynos_ppmu {
unsigned int num_events;
struct device *dev;
- struct mutex lock;
struct exynos_ppmu_data ppmu;
};
@@ -463,7 +461,6 @@ static int exynos_ppmu_probe(struct platform_device *pdev)
if (!info)
return -ENOMEM;
- mutex_init(&info->lock);
info->dev = &pdev->dev;
/* Parse dt data to get resource */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu
[not found] ` <CGME20161021010940epcas1p1bf0feb2d8401d44adbcbd7f399d30f64@epcas1p1.samsung.com>
@ 2016-10-27 0:29 ` MyungJoo Ham
0 siblings, 0 replies; 3+ messages in thread
From: MyungJoo Ham @ 2016-10-27 0:29 UTC (permalink / raw)
To: Axel Lin, Rafael J . Wysocki
Cc: Chanwoo Choi, Kyungmin Park, linux-pm, linux-samsung-soc
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
> --------- Original Message ---------
> Sender : Axel Lin <axel.lin@ingics.com>
> Date : 2016-10-21 10:09 (GMT+9)
> Title : [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu
>
> The mutex is not used at all, remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Both patches are stacked in for-4.9-rc branch.
Thanks.
Cheers,
MyungJoo
> ---
>
> This patch was sent on https://patchwork.kernel.org/patch/9341097/
> drivers/devfreq/event/exynos-ppmu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-27 0:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-21 1:09 [RESEND][PATCH 1/2] PM / devfreq: exynos-ppmu: ppmu_events array should not be NULL terminated Axel Lin
2016-10-21 1:09 ` [RESEND][PATCH 2/2] PM / devfreq: exynos-ppmu: Remove unused mutex from struct exynos_ppmu Axel Lin
[not found] ` <CGME20161021010940epcas1p1bf0feb2d8401d44adbcbd7f399d30f64@epcas1p1.samsung.com>
2016-10-27 0:29 ` MyungJoo Ham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.