* [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options
@ 2013-08-19 16:04 Simon Busch
2013-08-19 16:09 ` Phil Blundell
0 siblings, 1 reply; 5+ messages in thread
From: Simon Busch @ 2013-08-19 16:04 UTC (permalink / raw)
To: openembedded-core
In some cases as distribution just wants to extend the default PACKAGECONFIG instead of
rewriting it completely. Therefor having a PACKAGECONFIG_DISTRO variable which is empty
by default and included in PACKAGECONFIG helps a lot.
Signed-off-by: Simon Busch <morphis@gravedo.de>
---
meta/recipes-graphics/mesa/mesa.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index 447e186..2875158 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -23,9 +23,11 @@ inherit autotools pkgconfig pythonnative gettext
EXTRA_OECONF = "--enable-shared-glapi"
+PACKAGECONFIG_DISTRO ??= ""
PACKAGECONFIG ??= "egl gles dri \
${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}\
${@base_contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)}\
+ ${PACKAGECONFIG_DISTRO} \
"
X11_DEPS = "xf86driproto glproto virtual/libx11 libxext libxxf86vm libxdamage libxfixes"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options
2013-08-19 16:04 [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options Simon Busch
@ 2013-08-19 16:09 ` Phil Blundell
2013-08-19 16:28 ` Simon Busch
0 siblings, 1 reply; 5+ messages in thread
From: Phil Blundell @ 2013-08-19 16:09 UTC (permalink / raw)
To: Simon Busch; +Cc: openembedded-core
On Mon, 2013-08-19 at 18:04 +0200, Simon Busch wrote:
> In some cases as distribution just wants to extend the default PACKAGECONFIG instead of
> rewriting it completely. Therefor having a PACKAGECONFIG_DISTRO variable which is empty
> by default and included in PACKAGECONFIG helps a lot.
Can't those distros just use PACKAGECONFIG_append?
p.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options
2013-08-19 16:09 ` Phil Blundell
@ 2013-08-19 16:28 ` Simon Busch
2013-08-19 16:58 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Simon Busch @ 2013-08-19 16:28 UTC (permalink / raw)
To: Phil Blundell; +Cc: openembedded-core
Am 19.08.2013 18:09, schrieb Phil Blundell:
> On Mon, 2013-08-19 at 18:04 +0200, Simon Busch wrote:
>> In some cases as distribution just wants to extend the default PACKAGECONFIG instead of
>> rewriting it completely. Therefor having a PACKAGECONFIG_DISTRO variable which is empty
>> by default and included in PACKAGECONFIG helps a lot.
>
> Can't those distros just use PACKAGECONFIG_append?
They can. I tried with PACKAGECONFIG += which didn't worked and I
thought it would be the same with PACKAGECONFIG_append cause of
PACKAGECONFIG being weak assignment in mesa.inc. But as it seems +=
takes higher than the weak assignment and overrides PACKAGECONFIG where
_append only appends.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options
2013-08-19 16:28 ` Simon Busch
@ 2013-08-19 16:58 ` Paul Eggleton
2013-08-19 19:00 ` Simon Busch
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2013-08-19 16:58 UTC (permalink / raw)
To: Simon Busch; +Cc: openembedded-core
On Monday 19 August 2013 18:28:02 Simon Busch wrote:
> Am 19.08.2013 18:09, schrieb Phil Blundell:
> > On Mon, 2013-08-19 at 18:04 +0200, Simon Busch wrote:
> >> In some cases as distribution just wants to extend the default
> >> PACKAGECONFIG instead of rewriting it completely. Therefor having a
> >> PACKAGECONFIG_DISTRO variable which is empty by default and included in
> >> PACKAGECONFIG helps a lot.
> >
> > Can't those distros just use PACKAGECONFIG_append?
>
> They can. I tried with PACKAGECONFIG += which didn't worked and I
> thought it would be the same with PACKAGECONFIG_append cause of
> PACKAGECONFIG being weak assignment in mesa.inc. But as it seems +=
> takes higher than the weak assignment and overrides PACKAGECONFIG where
> _append only appends.
It's being set in the recipe with ??= which is the weakest form of assignment,
so this behaviour is expected. I just tested this in local.conf and it works:
PACKAGECONFIG_append_pn-mesa = " something"
BTW, outside of a recipe (or bbappend) you should always use a pn- override
with PACKAGECONFIG or you'll be affecting more than just the recipe you intend
to.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options
2013-08-19 16:58 ` Paul Eggleton
@ 2013-08-19 19:00 ` Simon Busch
0 siblings, 0 replies; 5+ messages in thread
From: Simon Busch @ 2013-08-19 19:00 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
Am 19.08.2013 18:58, schrieb Paul Eggleton:
> On Monday 19 August 2013 18:28:02 Simon Busch wrote:
>> Am 19.08.2013 18:09, schrieb Phil Blundell:
>>> On Mon, 2013-08-19 at 18:04 +0200, Simon Busch wrote:
>>>> In some cases as distribution just wants to extend the default
>>>> PACKAGECONFIG instead of rewriting it completely. Therefor having a
>>>> PACKAGECONFIG_DISTRO variable which is empty by default and included in
>>>> PACKAGECONFIG helps a lot.
>>>
>>> Can't those distros just use PACKAGECONFIG_append?
>>
>> They can. I tried with PACKAGECONFIG += which didn't worked and I
>> thought it would be the same with PACKAGECONFIG_append cause of
>> PACKAGECONFIG being weak assignment in mesa.inc. But as it seems +=
>> takes higher than the weak assignment and overrides PACKAGECONFIG where
>> _append only appends.
>
> It's being set in the recipe with ??= which is the weakest form of assignment,
> so this behaviour is expected. I just tested this in local.conf and it works:
>
> PACKAGECONFIG_append_pn-mesa = " something"
>
> BTW, outside of a recipe (or bbappend) you should always use a pn- override
> with PACKAGECONFIG or you'll be affecting more than just the recipe you intend
> to.
Thank you very much for the good explanation.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-19 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-19 16:04 [PATCH] mesa: add PACKAGECONFIG_DISTRO variable for distro specific options Simon Busch
2013-08-19 16:09 ` Phil Blundell
2013-08-19 16:28 ` Simon Busch
2013-08-19 16:58 ` Paul Eggleton
2013-08-19 19:00 ` Simon Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.