[PATCH 1/2] of: add vendor prefix for Mentor Graphics

[PATCH 1/2] of: add vendor prefix for Mentor Graphics

[Sebastian Andrzej Siewior]

This prefix is currently used for the musb driver.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 366ce9b..3065e79 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -36,6 +36,7 @@ linux	Linux-specific binding
 lsi	LSI Corp. (LSI Logic)
 marvell	Marvell Technology Group Ltd.
 maxim	Maxim Integrated Products
+mentor	Mentor Graphics
 mosaixtech	Mosaix Technologies, Inc.
 national	National Semiconductor
 nintendo	Nintendo
-- 
1.8.4.rc2

[PATCH 2/2] dt: dbx5x0: remove mentor,musb binding

[Sebastian Andrzej Siewior]

The "mentor,musb" binding isn't documented so I was about to document
it.
The node is missing a few properties for configuration like
"multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure
"missing" is the right word here because some of those informations
might be obtained from the chip itself but it is not done (yet).
Further the ePARP 2.3.1 says the matching goes from left to right taking
the fist match. Right now there is jus a driver for
"stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that
it is simply possible to have a generic since even for DMA we have
ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I
mean within musb and not the dma code.

For that reason (that I am not sure a generic musb binding is possible and
how its binding / required properties will look like) and the reason that
we have here a minor binding without a driver to look at I suggest to
remove that binding.
If the majority of people prefer to keep this binding I'm curious how
the documentation of the binding should look like.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 Documentation/devicetree/bindings/usb/ux500-usb.txt | 2 +-
 arch/arm/boot/dts/dbx5x0.dtsi                       | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/ux500-usb.txt b/Documentation/devicetree/bindings/usb/ux500-usb.txt
index 330d6ec..439a41c 100644
--- a/Documentation/devicetree/bindings/usb/ux500-usb.txt
+++ b/Documentation/devicetree/bindings/usb/ux500-usb.txt
@@ -15,7 +15,7 @@ Ux500 MUSB
 Example:
 
 usb_per5@a03e0000 {
-	compatible = "stericsson,db8500-musb", "mentor,musb";
+	compatible = "stericsson,db8500-musb";
 	reg = <0xa03e0000 0x10000>;
 	interrupts = <0 23 0x4>;
 	interrupt-names = "mc";
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index a152945..4522aff8 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -177,8 +177,7 @@
 		};
 
 		usb_per5@a03e0000 {
-			compatible = "stericsson,db8500-musb",
-				"mentor,musb";
+			compatible = "stericsson,db8500-musb";
 			reg = <0xa03e0000 0x10000>;
 			interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "mc";
-- 
1.8.4.rc2

Re: [PATCH 1/2] of: add vendor prefix for Mentor Graphics

[Stephen Warren]

On 08/20/2013 10:40 AM, Sebastian Andrzej Siewior wrote:
> This prefix is currently used for the musb driver.

The series,
Acked-by: Stephen Warren <swarren@nvidia.com>

Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding

[Lee Jones]

> The "mentor,musb" binding isn't documented so I was about to document
> it.
> The node is missing a few properties for configuration like
> "multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure
> "missing" is the right word here because some of those informations
> might be obtained from the chip itself but it is not done (yet).
> Further the ePARP 2.3.1 says the matching goes from left to right taking
> the fist match. Right now there is jus a driver for
> "stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that
> it is simply possible to have a generic since even for DMA we have
> ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I
> mean within musb and not the dma code.
> 
> For that reason (that I am not sure a generic musb binding is possible and
> how its binding / required properties will look like) and the reason that
> we have here a minor binding without a driver to look at I suggest to
> remove that binding.
> If the majority of people prefer to keep this binding I'm curious how
> the documentation of the binding should look like.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/ux500-usb.txt | 2 +-
>  arch/arm/boot/dts/dbx5x0.dtsi                       | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ux500-usb.txt b/Documentation/devicetree/bindings/usb/ux500-usb.txt
> index 330d6ec..439a41c 100644
> --- a/Documentation/devicetree/bindings/usb/ux500-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/ux500-usb.txt
> @@ -15,7 +15,7 @@ Ux500 MUSB
>  Example:
>  
>  usb_per5@a03e0000 {
> -	compatible = "stericsson,db8500-musb", "mentor,musb";
> +	compatible = "stericsson,db8500-musb";
>  	reg = <0xa03e0000 0x10000>;
>  	interrupts = <0 23 0x4>;
>  	interrupt-names = "mc";
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index a152945..4522aff8 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -177,8 +177,7 @@
>  		};
>  
>  		usb_per5@a03e0000 {
> -			compatible = "stericsson,db8500-musb",
> -				"mentor,musb";
> +			compatible = "stericsson,db8500-musb";
>  			reg = <0xa03e0000 0x10000>;
>  			interrupts = <0 23 IRQ_TYPE_LEVEL_HIGH>;
>  			interrupt-names = "mc";
> -- 
> 1.8.4.rc2
> 

Patch looks fine to me, but you probably want to CC the maintainer.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding

[Sebastian Andrzej Siewior]

On 08/21/2013 10:31 AM, Lee Jones wrote:
> Patch looks fine to me, but you probably want to CC the maintainer.

Who do you have in mind?

Sebastian

Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding

[Lee Jones]

On Wed, 21 Aug 2013, Sebastian Andrzej Siewior wrote:

> On 08/21/2013 10:31 AM, Lee Jones wrote:
> > Patch looks fine to me, but you probably want to CC the maintainer.
> 
> Who do you have in mind?

Linus Walleij. I already CC'ed him.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] dt: dbx5x0: remove mentor,musb binding

[Linus Walleij]

On Tue, Aug 20, 2013 at 6:40 PM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:

> The "mentor,musb" binding isn't documented so I was about to document
> it.
> The node is missing a few properties for configuration like
> "multipoint", "dyn_fifo", "num_eps" or "ram_bits". However I am not sure
> "missing" is the right word here because some of those informations
> might be obtained from the chip itself but it is not done (yet).
> Further the ePARP 2.3.1 says the matching goes from left to right taking
> the fist match. Right now there is jus a driver for
> "stericsson,db8500-musb" and none for "mentor,musb". I'm not 100% that
> it is simply possible to have a generic since even for DMA we have
> ifdefs in the driver between "generic mentor dma" and "ux500 dma" and I
> mean within musb and not the dma code.
>
> For that reason (that I am not sure a generic musb binding is possible and
> how its binding / required properties will look like) and the reason that
> we have here a minor binding without a driver to look at I suggest to
> remove that binding.
> If the majority of people prefer to keep this binding I'm curious how
> the documentation of the binding should look like.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Patch applied to my ux500-devicetree branch.

Yours,
Linus Walleij

Re: [PATCH 1/2] of: add vendor prefix for Mentor Graphics

[Mark Rutland]

On Fri, Dec 20, 2013 at 05:26:02PM +0000, Kumar Gala wrote:
> 
> On Dec 19, 2013, at 10:25 AM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> 
> > This prefix is currently used for the musb driver.
> > 
> > Acked-by: Stephen Warren <swarren@nvidia.com>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> > 1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > index 8c75d85..cb5c438 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -43,6 +43,7 @@ linux	Linux-specific binding
> > lsi	LSI Corp. (LSI Logic)
> > marvell	Marvell Technology Group Ltd.
> > maxim	Maxim Integrated Products
> > +mentor	Mentor Graphics
> 
> file like we should use ‘ment’, but not sure if we are going away from ticker symbols or not.

In general we've been heading towards full names rather than stock
ticker symbols. It's far easier for a human to make an educated guess
without searching.

I'm certainly happy with mentor as a vendor prefix.

Mark.

> 
> > microchip	Microchip Technology Inc.
> > mosaixtech	Mosaix Technologies, Inc.
> > national	National Semiconductor
> > -- 
> > 1.8.5.1
> > 
> 
> - k
> 
> -- 
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> 
> 

Re: [PATCH 1/2] of: add vendor prefix for Mentor Graphics

[Kumar Gala]

On Dec 19, 2013, at 10:25 AM, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> This prefix is currently used for the musb driver.
> 
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 8c75d85..cb5c438 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -43,6 +43,7 @@ linux	Linux-specific binding
> lsi	LSI Corp. (LSI Logic)
> marvell	Marvell Technology Group Ltd.
> maxim	Maxim Integrated Products
> +mentor	Mentor Graphics

file like we should use ‘ment’, but not sure if we are going away from ticker symbols or not.

> microchip	Microchip Technology Inc.
> mosaixtech	Mosaix Technologies, Inc.
> national	National Semiconductor
> -- 
> 1.8.5.1
> 

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

[PATCH 1/2] of: add vendor prefix for Mentor Graphics

[Sebastian Andrzej Siewior]

This prefix is currently used for the musb driver.

Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 8c75d85..cb5c438 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -43,6 +43,7 @@ linux	Linux-specific binding
 lsi	LSI Corp. (LSI Logic)
 marvell	Marvell Technology Group Ltd.
 maxim	Maxim Integrated Products
+mentor	Mentor Graphics
 microchip	Microchip Technology Inc.
 mosaixtech	Mosaix Technologies, Inc.
 national	National Semiconductor
-- 
1.8.5.1