* [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1
@ 2013-08-19 9:25 Kevin Wolf
2013-08-19 13:08 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kevin Wolf @ 2013-08-19 9:25 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
By the time that qemu 1.7 will be released, enough time will has passed
since qemu 1.1, which is the first version to understand version 3
images, that changing the default shouldn't hurt many people any more
and the benefits of using the new format outweigh the pain.
qemu-iotests already runs with compat=1.1 by default.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3376901..42ea7ec 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options)
int flags = 0;
size_t cluster_size = DEFAULT_CLUSTER_SIZE;
int prealloc = 0;
- int version = 2;
+ int version = 3;
/* Read out options */
while (options && options->name) {
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1
2013-08-19 9:25 [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 Kevin Wolf
@ 2013-08-19 13:08 ` Stefan Hajnoczi
2013-08-19 16:06 ` Eric Blake
2013-08-23 11:05 ` Ján Tomko
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2013-08-19 13:08 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Mon, Aug 19, 2013 at 11:25:33AM +0200, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
s/has/have/
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the benefits of using the new format outweigh the pain.
In particular, compat=1.1 images include:
* Feature bit fields which make the format more easily extensible
* Zero clusters for data cluster preallocation, discard, efficient zero
block migration, or block-backup
* Lazy refcounts
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1
2013-08-19 9:25 [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 Kevin Wolf
2013-08-19 13:08 ` Stefan Hajnoczi
@ 2013-08-19 16:06 ` Eric Blake
2013-08-23 11:05 ` Ján Tomko
2 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2013-08-19 16:06 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, stefanha
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On 08/19/2013 03:25 AM, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the benefits of using the new format outweigh the pain.
>
> qemu-iotests already runs with compat=1.1 by default.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Libvirt is currently being patched to explicitly request older formats
when needed; that should land in libvirt before qmeu 1.7, so from that
point of view, I have no objection to this.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1
2013-08-19 9:25 [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 Kevin Wolf
2013-08-19 13:08 ` Stefan Hajnoczi
2013-08-19 16:06 ` Eric Blake
@ 2013-08-23 11:05 ` Ján Tomko
2013-08-27 8:00 ` Kevin Wolf
2 siblings, 1 reply; 5+ messages in thread
From: Ján Tomko @ 2013-08-23 11:05 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, stefanha
On 08/19/2013 11:25 AM, Kevin Wolf wrote:
> By the time that qemu 1.7 will be released, enough time will has passed
> since qemu 1.1, which is the first version to understand version 3
> images, that changing the default shouldn't hurt many people any more
> and the benefits of using the new format outweigh the pain.
>
> qemu-iotests already runs with compat=1.1 by default.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 3376901..42ea7ec 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options)
> int flags = 0;
> size_t cluster_size = DEFAULT_CLUSTER_SIZE;
> int prealloc = 0;
> - int version = 2;
> + int version = 3;
>
> /* Read out options */
> while (options && options->name) {
>
This does not affect qemu-img (or bdrv_img_create), as it gets overwritten
with 2 when BLOCK_OPT_COMPAT_LEVEL is present in options, but the value is NULL.
Should this go into qcow2_create_options[] as well?
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1
2013-08-23 11:05 ` Ján Tomko
@ 2013-08-27 8:00 ` Kevin Wolf
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Wolf @ 2013-08-27 8:00 UTC (permalink / raw)
To: Ján Tomko; +Cc: qemu-devel, stefanha
Am 23.08.2013 um 13:05 hat Ján Tomko geschrieben:
> On 08/19/2013 11:25 AM, Kevin Wolf wrote:
> > By the time that qemu 1.7 will be released, enough time will has passed
> > since qemu 1.1, which is the first version to understand version 3
> > images, that changing the default shouldn't hurt many people any more
> > and the benefits of using the new format outweigh the pain.
> >
> > qemu-iotests already runs with compat=1.1 by default.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > block/qcow2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/qcow2.c b/block/qcow2.c
> > index 3376901..42ea7ec 100644
> > --- a/block/qcow2.c
> > +++ b/block/qcow2.c
> > @@ -1402,7 +1402,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options)
> > int flags = 0;
> > size_t cluster_size = DEFAULT_CLUSTER_SIZE;
> > int prealloc = 0;
> > - int version = 2;
> > + int version = 3;
> >
> > /* Read out options */
> > while (options && options->name) {
> >
>
> This does not affect qemu-img (or bdrv_img_create), as it gets overwritten
> with 2 when BLOCK_OPT_COMPAT_LEVEL is present in options, but the value is NULL.
Whoops... Thanks for catching this, I'll send a v2.
> Should this go into qcow2_create_options[] as well?
Not sure what you want to change in the options array? It doesn't seem
to denote a default.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-27 8:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-19 9:25 [Qemu-devel] [PATCH] qcow2: Change default for new images to compat=1.1 Kevin Wolf
2013-08-19 13:08 ` Stefan Hajnoczi
2013-08-19 16:06 ` Eric Blake
2013-08-23 11:05 ` Ján Tomko
2013-08-27 8:00 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.