All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-07-17 16:23 ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-omap, linux-arm-kernel; +Cc: Paul Walmsley, Mark A. Greer

From: "Mark A. Greer" <mgreer@animalcreek.com>

Long overdue patches to add the device tree updates and
documentation for the SHAM and AES modules on the am33xx.
The supporting code is already in the mainline kernel.

This series is based on the current mainline kernel,
c0d15cc (linked-list: Remove __list_for_each).

Changes from v1:
 - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>

Mark A. Greer (2):
  ARM: dts: Add SHAM data and documentation for AM33XX
  ARM: dts: Add AES data and documentation for AM33XX

 .../devicetree/bindings/crypto/omap-aes.txt        | 35 ++++++++++++++++++++++
 .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  8 +++++
 arch/arm/boot/dts/am335x-evm.dts                   |  8 +++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  8 +++++
 arch/arm/boot/dts/am33xx.dtsi                      | 21 +++++++++++++
 6 files changed, 113 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

-- 
1.7.12


^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-07-17 16:23 ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: "Mark A. Greer" <mgreer@animalcreek.com>

Long overdue patches to add the device tree updates and
documentation for the SHAM and AES modules on the am33xx.
The supporting code is already in the mainline kernel.

This series is based on the current mainline kernel,
c0d15cc (linked-list: Remove __list_for_each).

Changes from v1:
 - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>

Mark A. Greer (2):
  ARM: dts: Add SHAM data and documentation for AM33XX
  ARM: dts: Add AES data and documentation for AM33XX

 .../devicetree/bindings/crypto/omap-aes.txt        | 35 ++++++++++++++++++++++
 .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  8 +++++
 arch/arm/boot/dts/am335x-evm.dts                   |  8 +++++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  8 +++++
 arch/arm/boot/dts/am33xx.dtsi                      | 21 +++++++++++++
 6 files changed, 113 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

-- 
1.7.12

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX
  2013-07-17 16:23 ` Mark A. Greer
@ 2013-07-17 16:23   ` Mark A. Greer
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-omap, linux-arm-kernel; +Cc: Paul Walmsley, Mark A. Greer

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX SHAM module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the SHAM module.

CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
---
 .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
 5 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt b/Documentation/devicetree/bindings/crypto/omap-sham.txt
new file mode 100644
index 0000000..c6d1202
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
@@ -0,0 +1,33 @@
+OMAP SoC SHA crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  SHAM versions:
+  - "ti,omap2-sham" for OMAP2 & OMAP3.
+  - "ti,omap4-sham" for OMAP4 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the SHAM module
+- reg : Offset and length of the register set for the module
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this module.
+- interrupts : the interrupt number for the SHAM module.
+
+Optional properties:
+- dmas: DMA controller phandle and DMA request ordered pair.
+	Only one rx pair is valid per SHAM module.
+- dma-names: DMA request name. This string corresponds 1:1 with
+	the ordered pair in dmas. The string naming is to be
+	"rx" for RX request.
+
+Example:
+	/* AM335x */
+	sham: sham@53100000 {
+		compatible = "ti,omap4-sham";
+		ti,hwmods = "sham";
+		reg = <0x53100000 0x200>;
+		interrupt-parent = <&intc>;
+		interrupts = <109>;
+		dmas = <&edma 36>;
+		dma-names = "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index 444b4ed..bc75b2c 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -234,3 +234,7 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 3aee1a4..9b8c56d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -488,3 +488,7 @@
 		ti,adc-channels = <4 5 6 7>;
 	};
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 0c8ad17..61dc5d4 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -402,3 +402,7 @@
 	phy_id = <&davinci_mdio>, <1>;
 	phy-mode = "rgmii-txid";
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..63a5e95 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -530,5 +530,15 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		sham: sham@53100000 {
+			compatible = "ti,omap4-sham";
+			ti,hwmods = "sham";
+			reg = <0x53100000 0x200>;
+			interrupt-parent = <&intc>;
+			interrupts = <109>;
+			dmas = <&edma 36>;
+			dma-names = "rx";
+		};
 	};
 };
-- 
1.7.12


^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX
@ 2013-07-17 16:23   ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX SHAM module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the SHAM module.

CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
---
 .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
 5 files changed, 55 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt b/Documentation/devicetree/bindings/crypto/omap-sham.txt
new file mode 100644
index 0000000..c6d1202
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
@@ -0,0 +1,33 @@
+OMAP SoC SHA crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  SHAM versions:
+  - "ti,omap2-sham" for OMAP2 & OMAP3.
+  - "ti,omap4-sham" for OMAP4 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the SHAM module
+- reg : Offset and length of the register set for the module
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this module.
+- interrupts : the interrupt number for the SHAM module.
+
+Optional properties:
+- dmas: DMA controller phandle and DMA request ordered pair.
+	Only one rx pair is valid per SHAM module.
+- dma-names: DMA request name. This string corresponds 1:1 with
+	the ordered pair in dmas. The string naming is to be
+	"rx" for RX request.
+
+Example:
+	/* AM335x */
+	sham: sham at 53100000 {
+		compatible = "ti,omap4-sham";
+		ti,hwmods = "sham";
+		reg = <0x53100000 0x200>;
+		interrupt-parent = <&intc>;
+		interrupts = <109>;
+		dmas = <&edma 36>;
+		dma-names = "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index 444b4ed..bc75b2c 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -234,3 +234,7 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 3aee1a4..9b8c56d 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -488,3 +488,7 @@
 		ti,adc-channels = <4 5 6 7>;
 	};
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 0c8ad17..61dc5d4 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -402,3 +402,7 @@
 	phy_id = <&davinci_mdio>, <1>;
 	phy-mode = "rgmii-txid";
 };
+
+&sham {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..63a5e95 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -530,5 +530,15 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		sham: sham at 53100000 {
+			compatible = "ti,omap4-sham";
+			ti,hwmods = "sham";
+			reg = <0x53100000 0x200>;
+			interrupt-parent = <&intc>;
+			interrupts = <109>;
+			dmas = <&edma 36>;
+			dma-names = "rx";
+		};
 	};
 };
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH v2 2/2] ARM: dts: Add AES data and documentation for AM33XX
  2013-07-17 16:23 ` Mark A. Greer
@ 2013-07-17 16:23   ` Mark A. Greer
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-omap, linux-arm-kernel; +Cc: Paul Walmsley, Mark A. Greer

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX AES module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the AES module.

CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
---
 .../devicetree/bindings/crypto/omap-aes.txt        | 35 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 11 +++++++
 5 files changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-aes.txt b/Documentation/devicetree/bindings/crypto/omap-aes.txt
new file mode 100644
index 0000000..b51d12f
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-aes.txt
@@ -0,0 +1,35 @@
+OMAP SoC AES crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  AES versions:
+  - "ti,omap2-aes" for OMAP2.
+  - "ti,omap3-aes" for OMAP3.
+  - "ti,omap4-aes" for OMAP4 and AM33XX.
+  Note that the OMAP2 and 3 versions are compatible (OMAP3 supports
+  more algorithms) but they are incompatible with OMAP4.
+- ti,hwmods: Name of the hwmod associated with the AES odule
+- reg : Offset and length of the register set for the module
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this module.
+- interrupts : the interrupt number for the AES odule.
+
+Optional properties:
+- dmas: DMA controller phandle and DMA request ordered pairs.
+- dma-names: DMA request names. This string corresponds 1:1 with
+	the ordered pairs in dmas. The string naming is to be
+	"tx" for TX request and "rx" for RX request.
+
+Example:
+	/* AM335x */
+	aes: aes@53500000 {
+		compatible = "ti,omap4-aes";
+		ti,hwmods = "aes";
+		reg = <0x53500000 0xa0>;
+		interrupt-parent = <&intc>;
+		interrupts = <102>;
+		dmas = <&edma 6
+			&edma 5>;
+		dma-names = "tx", "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index bc75b2c..0cb454e 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -238,3 +238,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 9b8c56d..76ba004 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -492,3 +492,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 61dc5d4..025a47e 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -406,3 +406,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 63a5e95..2a7ff0f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -540,5 +540,16 @@
 			dmas = <&edma 36>;
 			dma-names = "rx";
 		};
+
+		aes: aes@53500000 {
+			compatible = "ti,omap4-aes";
+			ti,hwmods = "aes";
+			reg = <0x53500000 0xa0>;
+			interrupt-parent = <&intc>;
+			interrupts = <102>;
+			dmas = <&edma 6
+				&edma 5>;
+			dma-names = "tx", "rx";
+		};
 	};
 };
-- 
1.7.12


^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH v2 2/2] ARM: dts: Add AES data and documentation for AM33XX
@ 2013-07-17 16:23   ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-07-17 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: "Mark A. Greer" <mgreer@animalcreek.com>

Add the generic AM33XX AES module's device tree data and
enable it for the am335x-evm, am335x-evmsk, and am335x-bone
platforms.  Also add Documentation file describing the data
for the AES module.

CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
---
 .../devicetree/bindings/crypto/omap-aes.txt        | 35 ++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
 arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
 arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
 arch/arm/boot/dts/am33xx.dtsi                      | 11 +++++++
 5 files changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/crypto/omap-aes.txt

diff --git a/Documentation/devicetree/bindings/crypto/omap-aes.txt b/Documentation/devicetree/bindings/crypto/omap-aes.txt
new file mode 100644
index 0000000..b51d12f
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/omap-aes.txt
@@ -0,0 +1,35 @@
+OMAP SoC AES crypto Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  AES versions:
+  - "ti,omap2-aes" for OMAP2.
+  - "ti,omap3-aes" for OMAP3.
+  - "ti,omap4-aes" for OMAP4 and AM33XX.
+  Note that the OMAP2 and 3 versions are compatible (OMAP3 supports
+  more algorithms) but they are incompatible with OMAP4.
+- ti,hwmods: Name of the hwmod associated with the AES odule
+- reg : Offset and length of the register set for the module
+- interrupt-parent : the phandle for the interrupt controller that
+  services interrupts for this module.
+- interrupts : the interrupt number for the AES odule.
+
+Optional properties:
+- dmas: DMA controller phandle and DMA request ordered pairs.
+- dma-names: DMA request names. This string corresponds 1:1 with
+	the ordered pairs in dmas. The string naming is to be
+	"tx" for TX request and "rx" for RX request.
+
+Example:
+	/* AM335x */
+	aes: aes at 53500000 {
+		compatible = "ti,omap4-aes";
+		ti,hwmods = "aes";
+		reg = <0x53500000 0xa0>;
+		interrupt-parent = <&intc>;
+		interrupts = <102>;
+		dmas = <&edma 6
+			&edma 5>;
+		dma-names = "tx", "rx";
+	};
diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
index bc75b2c..0cb454e 100644
--- a/arch/arm/boot/dts/am335x-bone.dts
+++ b/arch/arm/boot/dts/am335x-bone.dts
@@ -238,3 +238,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 9b8c56d..76ba004 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -492,3 +492,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts b/arch/arm/boot/dts/am335x-evmsk.dts
index 61dc5d4..025a47e 100644
--- a/arch/arm/boot/dts/am335x-evmsk.dts
+++ b/arch/arm/boot/dts/am335x-evmsk.dts
@@ -406,3 +406,7 @@
 &sham {
 	status = "okay";
 };
+
+&aes {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 63a5e95..2a7ff0f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -540,5 +540,16 @@
 			dmas = <&edma 36>;
 			dma-names = "rx";
 		};
+
+		aes: aes at 53500000 {
+			compatible = "ti,omap4-aes";
+			ti,hwmods = "aes";
+			reg = <0x53500000 0xa0>;
+			interrupt-parent = <&intc>;
+			interrupts = <102>;
+			dmas = <&edma 6
+				&edma 5>;
+			dma-names = "tx", "rx";
+		};
 	};
 };
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-07-17 16:23 ` Mark A. Greer
@ 2013-08-21  0:13   ` Paul Walmsley
  -1 siblings, 0 replies; 28+ messages in thread
From: Paul Walmsley @ 2013-08-21  0:13 UTC (permalink / raw)
  To: bcousson; +Cc: Mark A. Greer, linux-omap, linux-arm-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 554 bytes --]

Hi Benoît,

On Wed, 17 Jul 2013, Mark A. Greer wrote:

> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> Long overdue patches to add the device tree updates and
> documentation for the SHAM and AES modules on the am33xx.
> The supporting code is already in the mainline kernel.
> 
> This series is based on the current mainline kernel,
> c0d15cc (linked-list: Remove __list_for_each).
> 
> Changes from v1:
>  - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>

I guess you should take these patches?


- Paul

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-21  0:13   ` Paul Walmsley
  0 siblings, 0 replies; 28+ messages in thread
From: Paul Walmsley @ 2013-08-21  0:13 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Beno?t,

On Wed, 17 Jul 2013, Mark A. Greer wrote:

> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> Long overdue patches to add the device tree updates and
> documentation for the SHAM and AES modules on the am33xx.
> The supporting code is already in the mainline kernel.
> 
> This series is based on the current mainline kernel,
> c0d15cc (linked-list: Remove __list_for_each).
> 
> Changes from v1:
>  - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>

I guess you should take these patches?


- Paul

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-21  0:13   ` Paul Walmsley
@ 2013-08-21 13:31     ` Benoit Cousson
  -1 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-21 13:31 UTC (permalink / raw)
  To: Paul Walmsley, Mark A. Greer; +Cc: linux-omap, linux-arm-kernel

Hi Paul,

On 21/08/2013 02:13, Paul Walmsley wrote:
> Hi Benoît,
>
> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>
>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>
>> Long overdue patches to add the device tree updates and
>> documentation for the SHAM and AES modules on the am33xx.
>> The supporting code is already in the mainline kernel.
>>
>> This series is based on the current mainline kernel,
>> c0d15cc (linked-list: Remove __list_for_each).
>>
>> Changes from v1:
>>   - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>
>
> I guess you should take these patches?

You're right, I should, I've just never seen them :-(
Thanks for the pointer.

Mark,

After a quick search on Google, I did not see any comment on these 
patches. Did you get any review so far?

Thanks,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-21 13:31     ` Benoit Cousson
  0 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-21 13:31 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Paul,

On 21/08/2013 02:13, Paul Walmsley wrote:
> Hi Beno?t,
>
> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>
>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>
>> Long overdue patches to add the device tree updates and
>> documentation for the SHAM and AES modules on the am33xx.
>> The supporting code is already in the mainline kernel.
>>
>> This series is based on the current mainline kernel,
>> c0d15cc (linked-list: Remove __list_for_each).
>>
>> Changes from v1:
>>   - Added missing '};' as pointed out by Lokesh Vutla <lokeshvutla@ti.com>
>
> I guess you should take these patches?

You're right, I should, I've just never seen them :-(
Thanks for the pointer.

Mark,

After a quick search on Google, I did not see any comment on these 
patches. Did you get any review so far?

Thanks,
Benoit

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-21 13:31     ` Benoit Cousson
@ 2013-08-21 13:41       ` Benoit Cousson
  -1 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-21 13:41 UTC (permalink / raw)
  To: Mark A. Greer; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel

Hi Mark,

In fact I cannot even apply these patches since they are referring the 
the edma controller node that does not seem to be there in 3.11-rc6.

Is this EDMA series supposed to be merged for 3.12? If this is the case, 
where can I find a reference GIT for it?

Thanks,
Benoit

On 21/08/2013 15:31, Benoit Cousson wrote:
> Hi Paul,
>
> On 21/08/2013 02:13, Paul Walmsley wrote:
>> Hi Benoît,
>>
>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>
>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>
>>> Long overdue patches to add the device tree updates and
>>> documentation for the SHAM and AES modules on the am33xx.
>>> The supporting code is already in the mainline kernel.
>>>
>>> This series is based on the current mainline kernel,
>>> c0d15cc (linked-list: Remove __list_for_each).
>>>
>>> Changes from v1:
>>>   - Added missing '};' as pointed out by Lokesh Vutla
>>> <lokeshvutla@ti.com>
>>
>> I guess you should take these patches?
>
> You're right, I should, I've just never seen them :-(
> Thanks for the pointer.
>
> Mark,
>
> After a quick search on Google, I did not see any comment on these
> patches. Did you get any review so far?
>
> Thanks,
> Benoit
>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-21 13:41       ` Benoit Cousson
  0 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-21 13:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mark,

In fact I cannot even apply these patches since they are referring the 
the edma controller node that does not seem to be there in 3.11-rc6.

Is this EDMA series supposed to be merged for 3.12? If this is the case, 
where can I find a reference GIT for it?

Thanks,
Benoit

On 21/08/2013 15:31, Benoit Cousson wrote:
> Hi Paul,
>
> On 21/08/2013 02:13, Paul Walmsley wrote:
>> Hi Beno?t,
>>
>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>
>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>
>>> Long overdue patches to add the device tree updates and
>>> documentation for the SHAM and AES modules on the am33xx.
>>> The supporting code is already in the mainline kernel.
>>>
>>> This series is based on the current mainline kernel,
>>> c0d15cc (linked-list: Remove __list_for_each).
>>>
>>> Changes from v1:
>>>   - Added missing '};' as pointed out by Lokesh Vutla
>>> <lokeshvutla@ti.com>
>>
>> I guess you should take these patches?
>
> You're right, I should, I've just never seen them :-(
> Thanks for the pointer.
>
> Mark,
>
> After a quick search on Google, I did not see any comment on these
> patches. Did you get any review so far?
>
> Thanks,
> Benoit
>

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-21 13:41       ` Benoit Cousson
@ 2013-08-21 20:31         ` Mark A. Greer
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-21 20:31 UTC (permalink / raw)
  To: Benoit Cousson; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel

On Wed, Aug 21, 2013 at 03:41:06PM +0200, Benoit Cousson wrote:
> Hi Mark,

Hi Benoit.

> In fact I cannot even apply these patches since they are referring
> the the edma controller node that does not seem to be there in
> 3.11-rc6.

I just applied them on top of k.o fd3930f (proc: more readdir
conversion bug-fixes) without issue.  I also went through the
resulting code and it looked okay.

Which repo are you applying them to?

If I should put them on top of another repo/branch, just let
me know which one.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-21 20:31         ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-21 20:31 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 21, 2013 at 03:41:06PM +0200, Benoit Cousson wrote:
> Hi Mark,

Hi Benoit.

> In fact I cannot even apply these patches since they are referring
> the the edma controller node that does not seem to be there in
> 3.11-rc6.

I just applied them on top of k.o fd3930f (proc: more readdir
conversion bug-fixes) without issue.  I also went through the
resulting code and it looked okay.

Which repo are you applying them to?

If I should put them on top of another repo/branch, just let
me know which one.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-21 13:31     ` Benoit Cousson
@ 2013-08-21 20:40       ` Mark A. Greer
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-21 20:40 UTC (permalink / raw)
  To: Benoit Cousson; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel

On Wed, Aug 21, 2013 at 03:31:11PM +0200, Benoit Cousson wrote:

> Mark,
> 
> After a quick search on Google, I did not see any comment on these
> patches. Did you get any review so far?

Some people reviewed v1.  The entire thread starts here:

	http://www.spinics.net/lists/arm-kernel/msg259079.html

Joel Fernandes <joelf@ti.com> had given his "Tested-by" but
Lokesh Vutla <lokeshvutla@ti.com> found an issue so I made
and posted v2 which is what you have now.  I haven't received
any comments on v2.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-21 20:40       ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-21 20:40 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 21, 2013 at 03:31:11PM +0200, Benoit Cousson wrote:

> Mark,
> 
> After a quick search on Google, I did not see any comment on these
> patches. Did you get any review so far?

Some people reviewed v1.  The entire thread starts here:

	http://www.spinics.net/lists/arm-kernel/msg259079.html

Joel Fernandes <joelf@ti.com> had given his "Tested-by" but
Lokesh Vutla <lokeshvutla@ti.com> found an issue so I made
and posted v2 which is what you have now.  I haven't received
any comments on v2.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-21 13:41       ` Benoit Cousson
@ 2013-08-22  3:50         ` Lokesh Vutla
  -1 siblings, 0 replies; 28+ messages in thread
From: Lokesh Vutla @ 2013-08-22  3:50 UTC (permalink / raw)
  To: Benoit Cousson; +Cc: Mark A. Greer, Paul Walmsley, linux-omap, linux-arm-kernel

Hi Benoit,
On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
> Hi Mark,
> 
> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
> 
> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
The following EDMA support dt patch series from Joel is needed :
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html
http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92177.html

Thanks and Regards,
Lokesh
> 
> Thanks,
> Benoit
> 
> On 21/08/2013 15:31, Benoit Cousson wrote:
>> Hi Paul,
>>
>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>> Hi Benoît,
>>>
>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>
>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>
>>>> Long overdue patches to add the device tree updates and
>>>> documentation for the SHAM and AES modules on the am33xx.
>>>> The supporting code is already in the mainline kernel.
>>>>
>>>> This series is based on the current mainline kernel,
>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>
>>>> Changes from v1:
>>>>   - Added missing '};' as pointed out by Lokesh Vutla
>>>> <lokeshvutla@ti.com>
>>>
>>> I guess you should take these patches?
>>
>> You're right, I should, I've just never seen them :-(
>> Thanks for the pointer.
>>
>> Mark,
>>
>> After a quick search on Google, I did not see any comment on these
>> patches. Did you get any review so far?
>>
>> Thanks,
>> Benoit
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-22  3:50         ` Lokesh Vutla
  0 siblings, 0 replies; 28+ messages in thread
From: Lokesh Vutla @ 2013-08-22  3:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Benoit,
On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
> Hi Mark,
> 
> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
> 
> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
The following EDMA support dt patch series from Joel is needed :
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92176.html
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92177.html

Thanks and Regards,
Lokesh
> 
> Thanks,
> Benoit
> 
> On 21/08/2013 15:31, Benoit Cousson wrote:
>> Hi Paul,
>>
>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>> Hi Beno?t,
>>>
>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>
>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>
>>>> Long overdue patches to add the device tree updates and
>>>> documentation for the SHAM and AES modules on the am33xx.
>>>> The supporting code is already in the mainline kernel.
>>>>
>>>> This series is based on the current mainline kernel,
>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>
>>>> Changes from v1:
>>>>   - Added missing '};' as pointed out by Lokesh Vutla
>>>> <lokeshvutla@ti.com>
>>>
>>> I guess you should take these patches?
>>
>> You're right, I should, I've just never seen them :-(
>> Thanks for the pointer.
>>
>> Mark,
>>
>> After a quick search on Google, I did not see any comment on these
>> patches. Did you get any review so far?
>>
>> Thanks,
>> Benoit
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-22  3:50         ` Lokesh Vutla
@ 2013-08-22  8:34           ` Benoit Cousson
  -1 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-22  8:34 UTC (permalink / raw)
  To: Lokesh Vutla; +Cc: Mark A. Greer, Paul Walmsley, linux-omap, linux-arm-kernel

Hi Lokesh,

On 22/08/2013 05:50, Lokesh Vutla wrote:
> Hi Benoit,
> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>> Hi Mark,
>>
>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>
>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
> The following EDMA support dt patch series from Joel is needed :
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92177.html

Thanks, it works a little bit better with these patches :-)

What about the EDMA driver? Is this already in mainline or planned for 3.12?

Thanks,
Benoit

>
> Thanks and Regards,
> Lokesh
>>
>> Thanks,
>> Benoit
>>
>> On 21/08/2013 15:31, Benoit Cousson wrote:
>>> Hi Paul,
>>>
>>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>>> Hi Benoît,
>>>>
>>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>>
>>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>>
>>>>> Long overdue patches to add the device tree updates and
>>>>> documentation for the SHAM and AES modules on the am33xx.
>>>>> The supporting code is already in the mainline kernel.
>>>>>
>>>>> This series is based on the current mainline kernel,
>>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>>
>>>>> Changes from v1:
>>>>>    - Added missing '};' as pointed out by Lokesh Vutla
>>>>> <lokeshvutla@ti.com>
>>>>
>>>> I guess you should take these patches?
>>>
>>> You're right, I should, I've just never seen them :-(
>>> Thanks for the pointer.
>>>
>>> Mark,
>>>
>>> After a quick search on Google, I did not see any comment on these
>>> patches. Did you get any review so far?
>>>
>>> Thanks,
>>> Benoit
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-22  8:34           ` Benoit Cousson
  0 siblings, 0 replies; 28+ messages in thread
From: Benoit Cousson @ 2013-08-22  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Lokesh,

On 22/08/2013 05:50, Lokesh Vutla wrote:
> Hi Benoit,
> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>> Hi Mark,
>>
>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>
>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
> The following EDMA support dt patch series from Joel is needed :
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92176.html
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92177.html

Thanks, it works a little bit better with these patches :-)

What about the EDMA driver? Is this already in mainline or planned for 3.12?

Thanks,
Benoit

>
> Thanks and Regards,
> Lokesh
>>
>> Thanks,
>> Benoit
>>
>> On 21/08/2013 15:31, Benoit Cousson wrote:
>>> Hi Paul,
>>>
>>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>>> Hi Beno?t,
>>>>
>>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>>
>>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>>
>>>>> Long overdue patches to add the device tree updates and
>>>>> documentation for the SHAM and AES modules on the am33xx.
>>>>> The supporting code is already in the mainline kernel.
>>>>>
>>>>> This series is based on the current mainline kernel,
>>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>>
>>>>> Changes from v1:
>>>>>    - Added missing '};' as pointed out by Lokesh Vutla
>>>>> <lokeshvutla@ti.com>
>>>>
>>>> I guess you should take these patches?
>>>
>>> You're right, I should, I've just never seen them :-(
>>> Thanks for the pointer.
>>>
>>> Mark,
>>>
>>> After a quick search on Google, I did not see any comment on these
>>> patches. Did you get any review so far?
>>>
>>> Thanks,
>>> Benoit
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-22  8:34           ` Benoit Cousson
@ 2013-08-22  8:54             ` Lokesh Vutla
  -1 siblings, 0 replies; 28+ messages in thread
From: Lokesh Vutla @ 2013-08-22  8:54 UTC (permalink / raw)
  To: Benoit Cousson
  Cc: Mark A. Greer, Paul Walmsley, linux-omap, linux-arm-kernel,
	Fernandes, Joel

Hi Benoit,

On Thursday 22 August 2013 02:04 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 22/08/2013 05:50, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>>> Hi Mark,
>>>
>>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>>
>>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
>> The following EDMA support dt patch series from Joel is needed :
>> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html
>> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92177.html
> 
> Thanks, it works a little bit better with these patches :-)
> 
> What about the EDMA driver? Is this already in mainline or planned for 3.12?
Its already in mainline..:)

Thanks and regards,
Lokesh
> 
> Thanks,
> Benoit
> 
>>
>> Thanks and Regards,
>> Lokesh
>>>
>>> Thanks,
>>> Benoit
>>>
>>> On 21/08/2013 15:31, Benoit Cousson wrote:
>>>> Hi Paul,
>>>>
>>>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>>>> Hi Benoît,
>>>>>
>>>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>>>
>>>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>>>
>>>>>> Long overdue patches to add the device tree updates and
>>>>>> documentation for the SHAM and AES modules on the am33xx.
>>>>>> The supporting code is already in the mainline kernel.
>>>>>>
>>>>>> This series is based on the current mainline kernel,
>>>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>>>
>>>>>> Changes from v1:
>>>>>>    - Added missing '};' as pointed out by Lokesh Vutla
>>>>>> <lokeshvutla@ti.com>
>>>>>
>>>>> I guess you should take these patches?
>>>>
>>>> You're right, I should, I've just never seen them :-(
>>>> Thanks for the pointer.
>>>>
>>>> Mark,
>>>>
>>>> After a quick search on Google, I did not see any comment on these
>>>> patches. Did you get any review so far?
>>>>
>>>> Thanks,
>>>> Benoit
>>>>
>>>
>>> -- 
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-22  8:54             ` Lokesh Vutla
  0 siblings, 0 replies; 28+ messages in thread
From: Lokesh Vutla @ 2013-08-22  8:54 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Benoit,

On Thursday 22 August 2013 02:04 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 22/08/2013 05:50, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>>> Hi Mark,
>>>
>>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>>
>>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
>> The following EDMA support dt patch series from Joel is needed :
>> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92176.html
>> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92177.html
> 
> Thanks, it works a little bit better with these patches :-)
> 
> What about the EDMA driver? Is this already in mainline or planned for 3.12?
Its already in mainline..:)

Thanks and regards,
Lokesh
> 
> Thanks,
> Benoit
> 
>>
>> Thanks and Regards,
>> Lokesh
>>>
>>> Thanks,
>>> Benoit
>>>
>>> On 21/08/2013 15:31, Benoit Cousson wrote:
>>>> Hi Paul,
>>>>
>>>> On 21/08/2013 02:13, Paul Walmsley wrote:
>>>>> Hi Beno?t,
>>>>>
>>>>> On Wed, 17 Jul 2013, Mark A. Greer wrote:
>>>>>
>>>>>> From: "Mark A. Greer" <mgreer@animalcreek.com>
>>>>>>
>>>>>> Long overdue patches to add the device tree updates and
>>>>>> documentation for the SHAM and AES modules on the am33xx.
>>>>>> The supporting code is already in the mainline kernel.
>>>>>>
>>>>>> This series is based on the current mainline kernel,
>>>>>> c0d15cc (linked-list: Remove __list_for_each).
>>>>>>
>>>>>> Changes from v1:
>>>>>>    - Added missing '};' as pointed out by Lokesh Vutla
>>>>>> <lokeshvutla@ti.com>
>>>>>
>>>>> I guess you should take these patches?
>>>>
>>>> You're right, I should, I've just never seen them :-(
>>>> Thanks for the pointer.
>>>>
>>>> Mark,
>>>>
>>>> After a quick search on Google, I did not see any comment on these
>>>> patches. Did you get any review so far?
>>>>
>>>> Thanks,
>>>> Benoit
>>>>
>>>
>>> -- 
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo at vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX
  2013-07-17 16:23   ` Mark A. Greer
@ 2013-08-22 14:08     ` Mark Rutland
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark Rutland @ 2013-08-22 14:08 UTC (permalink / raw)
  To: Mark A. Greer; +Cc: Paul Walmsley, linux-omap, linux-arm-kernel

On Wed, Jul 17, 2013 at 05:23:41PM +0100, Mark A. Greer wrote:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> Add the generic AM33XX SHAM module's device tree data and
> enable it for the am335x-evm, am335x-evmsk, and am335x-bone
> platforms.  Also add Documentation file describing the data
> for the SHAM module.
> 
> CC: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
>  .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++++
>  arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
>  arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
>  arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
>  arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
>  5 files changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
> 
> diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt b/Documentation/devicetree/bindings/crypto/omap-sham.txt
> new file mode 100644
> index 0000000..c6d1202
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
> @@ -0,0 +1,33 @@
> +OMAP SoC SHA crypto Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  SHAM versions:
> +  - "ti,omap2-sham" for OMAP2 & OMAP3.
> +  - "ti,omap4-sham" for OMAP4 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the SHAM module
> +- reg : Offset and length of the register set for the module
> +- interrupt-parent : the phandle for the interrupt controller that
> +  services interrupts for this module.
> +- interrupts : the interrupt number for the SHAM module.
> +
> +Optional properties:
> +- dmas: DMA controller phandle and DMA request ordered pair.
> +	Only one rx pair is valid per SHAM module.

This may be a little late, but...

Nit: A dma specifier may have many cells, so calling it "pair" is not
necessarily correct:

dmas = <&dma0 432 7 5>,
       <&dma1 3>,
       <&dma0 212 1 13>;

You could instead say:

- dmas: DMA specifier for the rx dma. See the DMA client binding,
        Documentation/devicetree/bindings/dma/dma.txt

> +- dma-names: DMA request name. This string corresponds 1:1 with
> +	the ordered pair in dmas. The string naming is to be
> +	"rx" for RX request.

Similarly:

 - dma-names: DMA request name. Should be "rx" if a dma is present.

It would be nice to get the bindings using consistent terminology so we
don't confuse everyone further.

Thanks,
Mark.

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX
@ 2013-08-22 14:08     ` Mark Rutland
  0 siblings, 0 replies; 28+ messages in thread
From: Mark Rutland @ 2013-08-22 14:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jul 17, 2013 at 05:23:41PM +0100, Mark A. Greer wrote:
> From: "Mark A. Greer" <mgreer@animalcreek.com>
> 
> Add the generic AM33XX SHAM module's device tree data and
> enable it for the am335x-evm, am335x-evmsk, and am335x-bone
> platforms.  Also add Documentation file describing the data
> for the SHAM module.
> 
> CC: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
>  .../devicetree/bindings/crypto/omap-sham.txt       | 33 ++++++++++++++++++++++
>  arch/arm/boot/dts/am335x-bone.dts                  |  4 +++
>  arch/arm/boot/dts/am335x-evm.dts                   |  4 +++
>  arch/arm/boot/dts/am335x-evmsk.dts                 |  4 +++
>  arch/arm/boot/dts/am33xx.dtsi                      | 10 +++++++
>  5 files changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/omap-sham.txt
> 
> diff --git a/Documentation/devicetree/bindings/crypto/omap-sham.txt b/Documentation/devicetree/bindings/crypto/omap-sham.txt
> new file mode 100644
> index 0000000..c6d1202
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/omap-sham.txt
> @@ -0,0 +1,33 @@
> +OMAP SoC SHA crypto Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  SHAM versions:
> +  - "ti,omap2-sham" for OMAP2 & OMAP3.
> +  - "ti,omap4-sham" for OMAP4 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the SHAM module
> +- reg : Offset and length of the register set for the module
> +- interrupt-parent : the phandle for the interrupt controller that
> +  services interrupts for this module.
> +- interrupts : the interrupt number for the SHAM module.
> +
> +Optional properties:
> +- dmas: DMA controller phandle and DMA request ordered pair.
> +	Only one rx pair is valid per SHAM module.

This may be a little late, but...

Nit: A dma specifier may have many cells, so calling it "pair" is not
necessarily correct:

dmas = <&dma0 432 7 5>,
       <&dma1 3>,
       <&dma0 212 1 13>;

You could instead say:

- dmas: DMA specifier for the rx dma. See the DMA client binding,
        Documentation/devicetree/bindings/dma/dma.txt

> +- dma-names: DMA request name. This string corresponds 1:1 with
> +	the ordered pair in dmas. The string naming is to be
> +	"rx" for RX request.

Similarly:

 - dma-names: DMA request name. Should be "rx" if a dma is present.

It would be nice to get the bindings using consistent terminology so we
don't confuse everyone further.

Thanks,
Mark.

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-22  8:34           ` Benoit Cousson
@ 2013-08-22 21:24             ` Mark A. Greer
  -1 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-22 21:24 UTC (permalink / raw)
  To: Benoit Cousson; +Cc: Lokesh Vutla, Paul Walmsley, linux-omap, linux-arm-kernel

On Thu, Aug 22, 2013 at 10:34:06AM +0200, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 22/08/2013 05:50, Lokesh Vutla wrote:
> >Hi Benoit,
> >On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
> >>Hi Mark,
> >>
> >>In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
> >>
> >>Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
> >The following EDMA support dt patch series from Joel is needed :
> >http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html
> >http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92177.html
> 
> Thanks, it works a little bit better with these patches :-)

Yeah, sorry.

Given Mark Rutland's comments in another email, let me respin and send v3.
I'll put a comment about the dependencies this time.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-22 21:24             ` Mark A. Greer
  0 siblings, 0 replies; 28+ messages in thread
From: Mark A. Greer @ 2013-08-22 21:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 22, 2013 at 10:34:06AM +0200, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 22/08/2013 05:50, Lokesh Vutla wrote:
> >Hi Benoit,
> >On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
> >>Hi Mark,
> >>
> >>In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
> >>
> >>Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
> >The following EDMA support dt patch series from Joel is needed :
> >http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92176.html
> >http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92177.html
> 
> Thanks, it works a little bit better with these patches :-)

Yeah, sorry.

Given Mark Rutland's comments in another email, let me respin and send v3.
I'll put a comment about the dependencies this time.

Mark
--

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
  2013-08-22 21:24             ` Mark A. Greer
@ 2013-08-23 16:53               ` Joel Fernandes
  -1 siblings, 0 replies; 28+ messages in thread
From: Joel Fernandes @ 2013-08-23 16:53 UTC (permalink / raw)
  To: Mark A. Greer
  Cc: Benoit Cousson, Lokesh Vutla, Paul Walmsley, linux-omap,
	linux-arm-kernel

On 08/22/2013 04:24 PM, Mark A. Greer wrote:
> On Thu, Aug 22, 2013 at 10:34:06AM +0200, Benoit Cousson wrote:
>> Hi Lokesh,
>>
>> On 22/08/2013 05:50, Lokesh Vutla wrote:
>>> Hi Benoit,
>>> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>>>> Hi Mark,
>>>>
>>>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>>>
>>>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
>>> The following EDMA support dt patch series from Joel is needed :
>>> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html
>>> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92177.html
>>
>> Thanks, it works a little bit better with these patches :-)
> 
> Yeah, sorry.
> 
> Given Mark Rutland's comments in another email, let me respin and send v3.
> I'll put a comment about the dependencies this time.

Just sanity tested these patches on v3.11-rc6 too.

Drivers register successfully after passing the boot crypto testmgr tests.

bash-4.2# cat /proc/crypto | grep -i omap
driver       : ctr-aes-omap
driver       : cbc-aes-omap
driver       : ecb-aes-omap
driver       : omap-hmac-sha256
driver       : omap-hmac-sha224
driver       : omap-sha256
driver       : omap-sha224
driver       : omap-hmac-md5
driver       : omap-hmac-sha1
driver       : omap-md5
driver       : omap-sha1


Thanks,

-Joel

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information
@ 2013-08-23 16:53               ` Joel Fernandes
  0 siblings, 0 replies; 28+ messages in thread
From: Joel Fernandes @ 2013-08-23 16:53 UTC (permalink / raw)
  To: linux-arm-kernel

On 08/22/2013 04:24 PM, Mark A. Greer wrote:
> On Thu, Aug 22, 2013 at 10:34:06AM +0200, Benoit Cousson wrote:
>> Hi Lokesh,
>>
>> On 22/08/2013 05:50, Lokesh Vutla wrote:
>>> Hi Benoit,
>>> On Wednesday 21 August 2013 07:11 PM, Benoit Cousson wrote:
>>>> Hi Mark,
>>>>
>>>> In fact I cannot even apply these patches since they are referring the the edma controller node that does not seem to be there in 3.11-rc6.
>>>>
>>>> Is this EDMA series supposed to be merged for 3.12? If this is the case, where can I find a reference GIT for it?
>>> The following EDMA support dt patch series from Joel is needed :
>>> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92176.html
>>> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg92177.html
>>
>> Thanks, it works a little bit better with these patches :-)
> 
> Yeah, sorry.
> 
> Given Mark Rutland's comments in another email, let me respin and send v3.
> I'll put a comment about the dependencies this time.

Just sanity tested these patches on v3.11-rc6 too.

Drivers register successfully after passing the boot crypto testmgr tests.

bash-4.2# cat /proc/crypto | grep -i omap
driver       : ctr-aes-omap
driver       : cbc-aes-omap
driver       : ecb-aes-omap
driver       : omap-hmac-sha256
driver       : omap-hmac-sha224
driver       : omap-sha256
driver       : omap-sha224
driver       : omap-hmac-md5
driver       : omap-hmac-sha1
driver       : omap-md5
driver       : omap-sha1


Thanks,

-Joel

^ permalink raw reply	[flat|nested] 28+ messages in thread
end of thread, other threads:[~2013-08-23 16:54 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 16:23 [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information Mark A. Greer
2013-07-17 16:23 ` Mark A. Greer
2013-07-17 16:23 ` [PATCH v2 1/2] ARM: dts: Add SHAM data and documentation for AM33XX Mark A. Greer
2013-07-17 16:23   ` Mark A. Greer
2013-08-22 14:08   ` Mark Rutland
2013-08-22 14:08     ` Mark Rutland
2013-07-17 16:23 ` [PATCH v2 2/2] ARM: dts: Add AES " Mark A. Greer
2013-07-17 16:23   ` Mark A. Greer
2013-08-21  0:13 ` [PATCH v2 0/2] ARM: dts: Add SHAM and AES DT information Paul Walmsley
2013-08-21  0:13   ` Paul Walmsley
2013-08-21 13:31   ` Benoit Cousson
2013-08-21 13:31     ` Benoit Cousson
2013-08-21 13:41     ` Benoit Cousson
2013-08-21 13:41       ` Benoit Cousson
2013-08-21 20:31       ` Mark A. Greer
2013-08-21 20:31         ` Mark A. Greer
2013-08-22  3:50       ` Lokesh Vutla
2013-08-22  3:50         ` Lokesh Vutla
2013-08-22  8:34         ` Benoit Cousson
2013-08-22  8:34           ` Benoit Cousson
2013-08-22  8:54           ` Lokesh Vutla
2013-08-22  8:54             ` Lokesh Vutla
2013-08-22 21:24           ` Mark A. Greer
2013-08-22 21:24             ` Mark A. Greer
2013-08-23 16:53             ` Joel Fernandes
2013-08-23 16:53               ` Joel Fernandes
2013-08-21 20:40     ` Mark A. Greer
2013-08-21 20:40       ` Mark A. Greer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.