From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Brian Foster <bfoster@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] Re: XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file: fs/xfs/xfs_trans_buf.c, line: 568
Date: Thu, 29 Aug 2013 07:37:42 -0500 [thread overview]
Message-ID: <521F4096.9040707@sgi.com> (raw)
In-Reply-To: <20130826041330.GU6023@dastard>
On 08/25/13 23:13, Dave Chinner wrote:
> xfs: fix calculation of the number of node entries in a dir3 node
>
> From: Dave Chinner<dchinner@redhat.com>
>
> The calculation doesn't take into account the size of the dir v3
> header, so overestimates the hash entries in a node. This causes
> directory buffer overruns when splitting and merging nodes.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
Makes sense to me for the inode v3 assert.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
The remove assert with the same test must be in common code; it can be
triggered in both versions of the inode (Linux 3.10 - TOT). The assert
on the remove may require the test to be run until the filesystem is
full before doing the remove.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-29 12:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 18:28 XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file: fs/xfs/xfs_trans_buf.c, line: 568 Brian Foster
2013-08-23 13:18 ` Mark Tinguely
2013-08-23 13:30 ` Brian Foster
2013-08-23 13:57 ` Mark Tinguely
2013-08-23 16:49 ` Brian Foster
2013-08-23 18:01 ` Mark Tinguely
2013-08-26 4:13 ` [PATCH] " Dave Chinner
2013-08-26 13:36 ` Brian Foster
2013-08-26 15:00 ` Mark Tinguely
2013-08-26 21:04 ` Dave Chinner
2013-08-26 21:19 ` Mark Tinguely
2013-08-27 13:04 ` Mark Tinguely
2013-08-26 20:26 ` Michael L. Semon
2013-08-29 12:37 ` Mark Tinguely [this message]
2013-08-30 14:56 ` Ben Myers
2013-09-12 23:51 ` Mark Tinguely
2013-09-16 15:44 ` Christoph Hellwig
2013-09-16 17:30 ` Mark Tinguely
2013-09-16 17:41 ` Michael L. Semon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F4096.9040707@sgi.com \
--to=tinguely@sgi.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.