* [RFC, PATCH] ARM: PJ4: don't use PJ4B code on PJ4
@ 2015-12-18 15:21 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-18 15:21 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Jason Cooper, Andrew Lunn, Gregory Clement,
Sebastian Hesselbarth, rmk+kernel, linux-kernel, Will Deacon
We can have multiplatform kernels with PJ4 (Dove, MMP2) in combination
with PJ4B (Armada 370) or PJ4B-MP (Berlin, Armada XP), and the processor
functions that are defined for PJ4B use a mask that covers all three
core types, rather than using the default ARMv7 type for the original
PJ4.
This adds a second entry for PJ4B-MP, so we at least get a consistent
behavior between single-machine kernels and combined ones.
I suspect however that we actually want different contents for each
of the three cores, as PJ4B and PJ4B-MP appear to be at least as
different as PJ4 is from PJ4B, in particular the support for
the standard architecture extensions like IDIV and LPAE, and the
PJ4B_ERRATA_4742 workaround apparently does not apply to PJ4B-MP
but might apply to PJ4.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 049be07053eb ("ARM: 7754/1: Fix the CPU ID and the mask associated to the PJ4B")
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 0f92d575a304..c9384c4780ea 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -576,10 +576,17 @@ __v7_ca8_proc_info:
#ifdef CONFIG_CPU_PJ4B
.type __v7_pj4b_proc_info, #object
__v7_pj4b_proc_info:
- .long 0x560f5800
- .long 0xff0fff00
+ .long 0x562f5840
+ .long 0xfffffff0
__v7_proc __v7_pj4b_proc_info, __v7_pj4b_setup, proc_fns = pj4b_processor_functions
.size __v7_pj4b_proc_info, . - __v7_pj4b_proc_info
+
+ .type __v7_pj4bmp_proc_info, #object
+__v7_pj4bmp_proc_info:
+ .long 0x561f5810
+ .long 0xfffffff0
+ __v7_proc __v7_pj4bmp_proc_info, __v7_pj4b_setup, proc_fns = pj4b_processor_functions
+ .size __v7_pj4bmp_proc_info, . - __v7_pj4bmp_proc_info
#endif
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFC, PATCH] ARM: PJ4: don't use PJ4B code on PJ4
@ 2015-12-18 15:21 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-18 15:21 UTC (permalink / raw)
To: linux-arm-kernel
We can have multiplatform kernels with PJ4 (Dove, MMP2) in combination
with PJ4B (Armada 370) or PJ4B-MP (Berlin, Armada XP), and the processor
functions that are defined for PJ4B use a mask that covers all three
core types, rather than using the default ARMv7 type for the original
PJ4.
This adds a second entry for PJ4B-MP, so we at least get a consistent
behavior between single-machine kernels and combined ones.
I suspect however that we actually want different contents for each
of the three cores, as PJ4B and PJ4B-MP appear to be at least as
different as PJ4 is from PJ4B, in particular the support for
the standard architecture extensions like IDIV and LPAE, and the
PJ4B_ERRATA_4742 workaround apparently does not apply to PJ4B-MP
but might apply to PJ4.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 049be07053eb ("ARM: 7754/1: Fix the CPU ID and the mask associated to the PJ4B")
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 0f92d575a304..c9384c4780ea 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -576,10 +576,17 @@ __v7_ca8_proc_info:
#ifdef CONFIG_CPU_PJ4B
.type __v7_pj4b_proc_info, #object
__v7_pj4b_proc_info:
- .long 0x560f5800
- .long 0xff0fff00
+ .long 0x562f5840
+ .long 0xfffffff0
__v7_proc __v7_pj4b_proc_info, __v7_pj4b_setup, proc_fns = pj4b_processor_functions
.size __v7_pj4b_proc_info, . - __v7_pj4b_proc_info
+
+ .type __v7_pj4bmp_proc_info, #object
+__v7_pj4bmp_proc_info:
+ .long 0x561f5810
+ .long 0xfffffff0
+ __v7_proc __v7_pj4bmp_proc_info, __v7_pj4b_setup, proc_fns = pj4b_processor_functions
+ .size __v7_pj4bmp_proc_info, . - __v7_pj4bmp_proc_info
#endif
/*
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-18 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 15:21 [RFC, PATCH] ARM: PJ4: don't use PJ4B code on PJ4 Arnd Bergmann
2015-12-18 15:21 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.