All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial@nongnu.org,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list
Date: Fri, 30 Aug 2013 18:02:46 +0200	[thread overview]
Message-ID: <5220C226.1080905@redhat.com> (raw)
In-Reply-To: <5220C0B7.4030108@suse.de>

Il 30/08/2013 17:56, Andreas Färber ha scritto:
> Am 30.08.2013 17:45, schrieb Paolo Bonzini:
>> Il 13/08/2013 12:38, Hervé Poussineau ha scritto:
>>>
>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>> ---
>>>  include/hw/isa/isa.h |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h
>>> index 495bcf3..fa45a5b 100644
>>> --- a/include/hw/isa/isa.h
>>> +++ b/include/hw/isa/isa.h
>>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start);
>>>   * @dev: the ISADevice against which these are registered; may be NULL.
>>>   * @start: the base I/O port against which the portio->offset is applied.
>>>   * @portio: the ports, sorted by offset.
>>> - * @opaque: passed into the old_portio callbacks.
>>> + * @opaque: passed into the portio callbacks.
>>>   * @name: passed into memory_region_init_io.
>>>   */
>>>  void isa_register_portio_list(ISADevice *dev, uint16_t start,
>>>
>>
>> Ping.
> 
> If you actually give it a Reviewed-by I can take it through qom-next.
> 
> Commit message does not point to a commit X for trivial verification
> that it is in fact correct since X.

Commit b40acf9 (ioport: Switch dispatching to memory core layer,
2013-06-24) removed all instances of old_portio except this, one in
docs/memory.txt, and one in hw/ppc/spapr_pci.c.

Paolo

  reply	other threads:[~2013-08-30 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13 10:38 [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list Hervé Poussineau
2013-08-18 20:05 ` Hervé Poussineau
2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini
2013-08-30 15:56   ` Andreas Färber
2013-08-30 16:02     ` Paolo Bonzini [this message]
2013-08-30 17:24       ` Andreas Färber
2013-08-30 17:05     ` Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220C226.1080905@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.