* [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list @ 2013-08-13 10:38 Hervé Poussineau 2013-08-18 20:05 ` Hervé Poussineau 2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini 0 siblings, 2 replies; 7+ messages in thread From: Hervé Poussineau @ 2013-08-13 10:38 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-trivial, Hervé Poussineau Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> --- include/hw/isa/isa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 495bcf3..fa45a5b 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); * @dev: the ISADevice against which these are registered; may be NULL. * @start: the base I/O port against which the portio->offset is applied. * @portio: the ports, sorted by offset. - * @opaque: passed into the old_portio callbacks. + * @opaque: passed into the portio callbacks. * @name: passed into memory_region_init_io. */ void isa_register_portio_list(ISADevice *dev, uint16_t start, -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-13 10:38 [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list Hervé Poussineau @ 2013-08-18 20:05 ` Hervé Poussineau 2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini 1 sibling, 0 replies; 7+ messages in thread From: Hervé Poussineau @ 2013-08-18 20:05 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-trivial Ping. Hervé Poussineau a écrit : > Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> > --- > include/hw/isa/isa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h > index 495bcf3..fa45a5b 100644 > --- a/include/hw/isa/isa.h > +++ b/include/hw/isa/isa.h > @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); > * @dev: the ISADevice against which these are registered; may be NULL. > * @start: the base I/O port against which the portio->offset is applied. > * @portio: the ports, sorted by offset. > - * @opaque: passed into the old_portio callbacks. > + * @opaque: passed into the portio callbacks. > * @name: passed into memory_region_init_io. > */ > void isa_register_portio_list(ISADevice *dev, uint16_t start, ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-13 10:38 [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list Hervé Poussineau 2013-08-18 20:05 ` Hervé Poussineau @ 2013-08-30 15:45 ` Paolo Bonzini 2013-08-30 15:56 ` Andreas Färber 1 sibling, 1 reply; 7+ messages in thread From: Paolo Bonzini @ 2013-08-30 15:45 UTC (permalink / raw) To: Hervé Poussineau; +Cc: qemu-trivial, qemu-devel Il 13/08/2013 12:38, Hervé Poussineau ha scritto: > > Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> > --- > include/hw/isa/isa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h > index 495bcf3..fa45a5b 100644 > --- a/include/hw/isa/isa.h > +++ b/include/hw/isa/isa.h > @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); > * @dev: the ISADevice against which these are registered; may be NULL. > * @start: the base I/O port against which the portio->offset is applied. > * @portio: the ports, sorted by offset. > - * @opaque: passed into the old_portio callbacks. > + * @opaque: passed into the portio callbacks. > * @name: passed into memory_region_init_io. > */ > void isa_register_portio_list(ISADevice *dev, uint16_t start, > Ping. Paolo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini @ 2013-08-30 15:56 ` Andreas Färber 2013-08-30 16:02 ` Paolo Bonzini 2013-08-30 17:05 ` Hervé Poussineau 0 siblings, 2 replies; 7+ messages in thread From: Andreas Färber @ 2013-08-30 15:56 UTC (permalink / raw) To: Paolo Bonzini; +Cc: qemu-trivial, Hervé Poussineau, qemu-devel Am 30.08.2013 17:45, schrieb Paolo Bonzini: > Il 13/08/2013 12:38, Hervé Poussineau ha scritto: >> >> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >> --- >> include/hw/isa/isa.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >> index 495bcf3..fa45a5b 100644 >> --- a/include/hw/isa/isa.h >> +++ b/include/hw/isa/isa.h >> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); >> * @dev: the ISADevice against which these are registered; may be NULL. >> * @start: the base I/O port against which the portio->offset is applied. >> * @portio: the ports, sorted by offset. >> - * @opaque: passed into the old_portio callbacks. >> + * @opaque: passed into the portio callbacks. >> * @name: passed into memory_region_init_io. >> */ >> void isa_register_portio_list(ISADevice *dev, uint16_t start, >> > > Ping. If you actually give it a Reviewed-by I can take it through qom-next. Commit message does not point to a commit X for trivial verification that it is in fact correct since X. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-30 15:56 ` Andreas Färber @ 2013-08-30 16:02 ` Paolo Bonzini 2013-08-30 17:24 ` Andreas Färber 2013-08-30 17:05 ` Hervé Poussineau 1 sibling, 1 reply; 7+ messages in thread From: Paolo Bonzini @ 2013-08-30 16:02 UTC (permalink / raw) To: Andreas Färber; +Cc: qemu-trivial, Hervé Poussineau, qemu-devel Il 30/08/2013 17:56, Andreas Färber ha scritto: > Am 30.08.2013 17:45, schrieb Paolo Bonzini: >> Il 13/08/2013 12:38, Hervé Poussineau ha scritto: >>> >>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >>> --- >>> include/hw/isa/isa.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >>> index 495bcf3..fa45a5b 100644 >>> --- a/include/hw/isa/isa.h >>> +++ b/include/hw/isa/isa.h >>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); >>> * @dev: the ISADevice against which these are registered; may be NULL. >>> * @start: the base I/O port against which the portio->offset is applied. >>> * @portio: the ports, sorted by offset. >>> - * @opaque: passed into the old_portio callbacks. >>> + * @opaque: passed into the portio callbacks. >>> * @name: passed into memory_region_init_io. >>> */ >>> void isa_register_portio_list(ISADevice *dev, uint16_t start, >>> >> >> Ping. > > If you actually give it a Reviewed-by I can take it through qom-next. > > Commit message does not point to a commit X for trivial verification > that it is in fact correct since X. Commit b40acf9 (ioport: Switch dispatching to memory core layer, 2013-06-24) removed all instances of old_portio except this, one in docs/memory.txt, and one in hw/ppc/spapr_pci.c. Paolo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-30 16:02 ` Paolo Bonzini @ 2013-08-30 17:24 ` Andreas Färber 0 siblings, 0 replies; 7+ messages in thread From: Andreas Färber @ 2013-08-30 17:24 UTC (permalink / raw) To: Paolo Bonzini, Hervé Poussineau; +Cc: qemu-trivial, qemu-devel Am 30.08.2013 18:02, schrieb Paolo Bonzini: > Il 30/08/2013 17:56, Andreas Färber ha scritto: >> Am 30.08.2013 17:45, schrieb Paolo Bonzini: >>> Il 13/08/2013 12:38, Hervé Poussineau ha scritto: >>>> >>>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >>>> --- >>>> include/hw/isa/isa.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >>>> index 495bcf3..fa45a5b 100644 >>>> --- a/include/hw/isa/isa.h >>>> +++ b/include/hw/isa/isa.h >>>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); >>>> * @dev: the ISADevice against which these are registered; may be NULL. >>>> * @start: the base I/O port against which the portio->offset is applied. >>>> * @portio: the ports, sorted by offset. >>>> - * @opaque: passed into the old_portio callbacks. >>>> + * @opaque: passed into the portio callbacks. >>>> * @name: passed into memory_region_init_io. >>>> */ >>>> void isa_register_portio_list(ISADevice *dev, uint16_t start, >>>> >>> >>> Ping. >> >> If you actually give it a Reviewed-by I can take it through qom-next. >> >> Commit message does not point to a commit X for trivial verification >> that it is in fact correct since X. > > Commit b40acf9 (ioport: Switch dispatching to memory core layer, > 2013-06-24) removed all instances of old_portio Thanks, I've copied it into the commit message and consider this an Acked-by. Applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas > except this, one in > docs/memory.txt, and one in hw/ppc/spapr_pci.c. > > Paolo > -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list 2013-08-30 15:56 ` Andreas Färber 2013-08-30 16:02 ` Paolo Bonzini @ 2013-08-30 17:05 ` Hervé Poussineau 1 sibling, 0 replies; 7+ messages in thread From: Hervé Poussineau @ 2013-08-30 17:05 UTC (permalink / raw) To: Andreas Färber; +Cc: qemu-trivial, Paolo Bonzini, qemu-devel Andreas Färber a écrit : > Am 30.08.2013 17:45, schrieb Paolo Bonzini: >> Il 13/08/2013 12:38, Hervé Poussineau ha scritto: >>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> >>> --- >>> include/hw/isa/isa.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >>> index 495bcf3..fa45a5b 100644 >>> --- a/include/hw/isa/isa.h >>> +++ b/include/hw/isa/isa.h >>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegion *io, uint16_t start); >>> * @dev: the ISADevice against which these are registered; may be NULL. >>> * @start: the base I/O port against which the portio->offset is applied. >>> * @portio: the ports, sorted by offset. >>> - * @opaque: passed into the old_portio callbacks. >>> + * @opaque: passed into the portio callbacks. >>> * @name: passed into memory_region_init_io. >>> */ >>> void isa_register_portio_list(ISADevice *dev, uint16_t start, >>> >> Ping. > > If you actually give it a Reviewed-by I can take it through qom-next. > > Commit message does not point to a commit X for trivial verification > that it is in fact correct since X. Just above the changed line, the ports variable is named "portio", not "old_portio". Hervé ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-30 17:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-08-13 10:38 [Qemu-devel] [PATCH for-1.6] isa: fix documentation of isa_register_portio_list Hervé Poussineau 2013-08-18 20:05 ` Hervé Poussineau 2013-08-30 15:45 ` [Qemu-devel] PING " Paolo Bonzini 2013-08-30 15:56 ` Andreas Färber 2013-08-30 16:02 ` Paolo Bonzini 2013-08-30 17:24 ` Andreas Färber 2013-08-30 17:05 ` Hervé Poussineau
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.