From: Rohit Vaswani <rvaswani@codeaurora.org> To: Kumar Gala <galak@codeaurora.org> Cc: David Brown <davidb@codeaurora.org>, Rob Herring <rob.herring@calxeda.com>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Stephen Warren <swarren@wwwdotorg.org>, Ian Campbell <ian.campbell@citrix.com>, Russell King <linux@arm.linux.org.uk>, Daniel Walker <dwalker@fifo99.com>, Bryan Huntsman <bryanh@codeaurora.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCHv2 1/2] ARM: msm: Add support for MSM8974 Dragonboard Date: Fri, 06 Sep 2013 09:58:37 -0700 [thread overview] Message-ID: <522A09BD.3090802@codeaurora.org> (raw) In-Reply-To: <97899226-465A-4B78-9FFD-B6B14136420B@codeaurora.org> On 9/6/2013 7:28 AM, Kumar Gala wrote: > On Sep 5, 2013, at 7:04 PM, Rohit Vaswani wrote: > >> diff --git a/arch/arm/boot/dts/msm8974-db.dts b/arch/arm/boot/dts/msm8974-db.dts >> new file mode 100644 >> index 0000000..74106a8 >> --- /dev/null >> +++ b/arch/arm/boot/dts/msm8974-db.dts >> @@ -0,0 +1,7 @@ >> +/include/ "msm8974.dtsi" >> + >> +/ { >> + model = "Qualcomm MSM8974 Dragonboard"; >> + compatible = "qcom,msm8974-db", "qcom,msm8974"; >> +}; >> + >> diff --git a/arch/arm/boot/dts/msm8974.dtsi b/arch/arm/boot/dts/msm8974.dtsi >> new file mode 100644 >> index 0000000..aa3bb2f >> --- /dev/null >> +++ b/arch/arm/boot/dts/msm8974.dtsi >> @@ -0,0 +1,30 @@ >> +/dts-v1/; >> + >> +/include/ "skeleton.dtsi" >> + >> +/ { >> + model = "Qualcomm MSM8974"; >> + compatible = "qcom,msm8974"; >> + interrupt-parent = <&intc>; >> + >> + soc: soc { }; >> +}; >> + >> +&soc { > We should probably have: > > #address-cells = <1>; > #size-cells = <1>; > ranges; > compatible = "simple-bus"; Sure. Not sure how that got left off. > >> + intc: interrupt-controller@f9000000 { >> + compatible = "qcom,msm-qgic2"; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + reg = < 0xf9000000 0x1000 >, >> + < 0xf9002000 0x1000 >; >> + }; >> + > Let's be consistent on white space around < > Done. > >> + timer { >> + compatible = "arm,armv7-timer"; >> + interrupts = <1 2 0xf08>, >> + <1 3 0xf08>, >> + <1 4 0xf08>, >> + <1 1 0xf08>; >> + clock-frequency = <19200000>; >> + }; > > >> +}; Thanks, Rohit Vaswani -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: rvaswani@codeaurora.org (Rohit Vaswani) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 1/2] ARM: msm: Add support for MSM8974 Dragonboard Date: Fri, 06 Sep 2013 09:58:37 -0700 [thread overview] Message-ID: <522A09BD.3090802@codeaurora.org> (raw) In-Reply-To: <97899226-465A-4B78-9FFD-B6B14136420B@codeaurora.org> On 9/6/2013 7:28 AM, Kumar Gala wrote: > On Sep 5, 2013, at 7:04 PM, Rohit Vaswani wrote: > >> diff --git a/arch/arm/boot/dts/msm8974-db.dts b/arch/arm/boot/dts/msm8974-db.dts >> new file mode 100644 >> index 0000000..74106a8 >> --- /dev/null >> +++ b/arch/arm/boot/dts/msm8974-db.dts >> @@ -0,0 +1,7 @@ >> +/include/ "msm8974.dtsi" >> + >> +/ { >> + model = "Qualcomm MSM8974 Dragonboard"; >> + compatible = "qcom,msm8974-db", "qcom,msm8974"; >> +}; >> + >> diff --git a/arch/arm/boot/dts/msm8974.dtsi b/arch/arm/boot/dts/msm8974.dtsi >> new file mode 100644 >> index 0000000..aa3bb2f >> --- /dev/null >> +++ b/arch/arm/boot/dts/msm8974.dtsi >> @@ -0,0 +1,30 @@ >> +/dts-v1/; >> + >> +/include/ "skeleton.dtsi" >> + >> +/ { >> + model = "Qualcomm MSM8974"; >> + compatible = "qcom,msm8974"; >> + interrupt-parent = <&intc>; >> + >> + soc: soc { }; >> +}; >> + >> +&soc { > We should probably have: > > #address-cells = <1>; > #size-cells = <1>; > ranges; > compatible = "simple-bus"; Sure. Not sure how that got left off. > >> + intc: interrupt-controller at f9000000 { >> + compatible = "qcom,msm-qgic2"; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + reg = < 0xf9000000 0x1000 >, >> + < 0xf9002000 0x1000 >; >> + }; >> + > Let's be consistent on white space around < > Done. > >> + timer { >> + compatible = "arm,armv7-timer"; >> + interrupts = <1 2 0xf08>, >> + <1 3 0xf08>, >> + <1 4 0xf08>, >> + <1 1 0xf08>; >> + clock-frequency = <19200000>; >> + }; > > >> +}; Thanks, Rohit Vaswani -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-09-06 16:58 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-09-06 0:04 [PATCHv2 1/2] ARM: msm: Add support for MSM8974 Dragonboard Rohit Vaswani 2013-09-06 0:04 ` Rohit Vaswani 2013-09-06 0:04 ` [PATCHv2 2/2] defconfig: msm_defconfig: Enable CONFIG_ARCH_MSM8974 Rohit Vaswani 2013-09-06 0:04 ` Rohit Vaswani 2013-09-06 12:56 ` Christopher Covington 2013-09-06 12:56 ` Christopher Covington 2013-09-06 16:29 ` Stephen Boyd 2013-09-06 16:29 ` Stephen Boyd 2013-09-06 14:22 ` [PATCHv2 1/2] ARM: msm: Add support for MSM8974 Dragonboard Kumar Gala 2013-09-06 14:22 ` Kumar Gala 2013-09-06 16:57 ` Rohit Vaswani 2013-09-06 16:57 ` Rohit Vaswani 2013-09-06 17:01 ` Kumar Gala 2013-09-06 17:01 ` Kumar Gala 2013-09-06 14:28 ` Kumar Gala 2013-09-06 14:28 ` Kumar Gala 2013-09-06 16:58 ` Rohit Vaswani [this message] 2013-09-06 16:58 ` Rohit Vaswani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=522A09BD.3090802@codeaurora.org \ --to=rvaswani@codeaurora.org \ --cc=bryanh@codeaurora.org \ --cc=davidb@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dwalker@fifo99.com \ --cc=galak@codeaurora.org \ --cc=ian.campbell@citrix.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=swarren@wwwdotorg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.