* [PATCH] arm: mach-davinci: mark __maybe_unused struct
@ 2013-09-04 18:00 Brian Norris
2013-09-12 10:43 ` Sekhar Nori
0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2013-09-04 18:00 UTC (permalink / raw)
To: linux-arm-kernel
If neither CONFIG_SND_DM365_AIC3X_CODEC nor CONFIG_SND_DM365_VOICE_CODEC
are defined, we may get warnings like:
arch/arm/mach-davinci/board-dm365-evm.c:179:33: warning: 'dm365_evm_snd_data' defined but not used [-Wunused-variable]
To fix this, just mark the struct as __maybe_unused.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Russell King <linux@arm.linux.org.uk>
---
arch/arm/mach-davinci/board-dm365-evm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
index 4cdb61c..9be953e 100644
--- a/arch/arm/mach-davinci/board-dm365-evm.c
+++ b/arch/arm/mach-davinci/board-dm365-evm.c
@@ -176,7 +176,7 @@ static struct at24_platform_data eeprom_info = {
.context = (void *)0x7f00,
};
-static struct snd_platform_data dm365_evm_snd_data = {
+static struct snd_platform_data dm365_evm_snd_data __maybe_unused = {
.asp_chan_q = EVENTQ_3,
};
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm: mach-davinci: mark __maybe_unused struct
2013-09-04 18:00 [PATCH] arm: mach-davinci: mark __maybe_unused struct Brian Norris
@ 2013-09-12 10:43 ` Sekhar Nori
0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2013-09-12 10:43 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 04 September 2013 11:30 PM, Brian Norris wrote:
> If neither CONFIG_SND_DM365_AIC3X_CODEC nor CONFIG_SND_DM365_VOICE_CODEC
> are defined, we may get warnings like:
>
> arch/arm/mach-davinci/board-dm365-evm.c:179:33: warning: 'dm365_evm_snd_data' defined but not used [-Wunused-variable]
>
> To fix this, just mark the struct as __maybe_unused.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Russell King <linux@arm.linux.org.uk>
Thanks, will queue this for -rc cycle. For future, please note that
subject line of DaVinci patches need to be prefixed "ARM: davinci: ".
Also, the subject should highlight the answer to "Why?" rather than
"How?". So, while committing I changed the headline to:
ARM: davinci: dm365 evm: fix unused variable warning
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-12 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-04 18:00 [PATCH] arm: mach-davinci: mark __maybe_unused struct Brian Norris
2013-09-12 10:43 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.