All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: 'Tomasz Figa' <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	'Andrzej Hajda' <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	'Mike Turquette'
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	'Kyungmin Park'
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-samsung-soc
	<linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 00/12] clk/exynos convert clock IDs to macros
Date: Mon, 16 Sep 2013 16:33:45 +0200	[thread overview]
Message-ID: <523716C9.3000204@samsung.com> (raw)
In-Reply-To: <070001ceafa5$d4d81a40$7e884ec0$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On 09/12/2013 12:50 PM, Kukjin Kim wrote:
> Well...I'm not sure changing to use macro is better or not at this moment...

I think it is. ;) It's really less error prone to have symbolic names instead
of the plain numbers. The clock ids are defined in one place and it is more
clear what a clock is by looking at symbolic name. It's especially annoying 
to use plain numbers where are are many clock in a single node, like 10 or 
more. What are you main concerns with this ?

--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/12] clk/exynos convert clock IDs to macros
Date: Mon, 16 Sep 2013 16:33:45 +0200	[thread overview]
Message-ID: <523716C9.3000204@samsung.com> (raw)
In-Reply-To: <070001ceafa5$d4d81a40$7e884ec0$%kim@samsung.com>

On 09/12/2013 12:50 PM, Kukjin Kim wrote:
> Well...I'm not sure changing to use macro is better or not at this moment...

I think it is. ;) It's really less error prone to have symbolic names instead
of the plain numbers. The clock ids are defined in one place and it is more
clear what a clock is by looking at symbolic name. It's especially annoying 
to use plain numbers where are are many clock in a single node, like 10 or 
more. What are you main concerns with this ?

--
Regards,
Sylwester

  parent reply	other threads:[~2013-09-16 14:33 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 10:12 [PATCH v2 00/12] clk/exynos convert clock IDs to macros Andrzej Hajda
2013-09-06 10:12 ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 01/12] ARM: exynos4: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 02/12] ARM: dts: exynos4: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 03/12] clk: exynos4: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 04/12] ARM: exynos5250: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 05/12] ARM: dts: exynos5250: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 06/12] clk: exynos5250: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 07/12] ARM: exynos5420: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 08/12] ARM: dts: exynos5420: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 09/12] clk: exynos5420: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 10/12] ARM: exynos5440: create a DT header defining CLK IDs Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 11/12] ARM: dts: exynos5440: convert magic numbers to macros in clock bindings Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 10:12 ` [PATCH v2 12/12] clk: exynos5440: replace clock ID private enums with IDs from DT header Andrzej Hajda
2013-09-06 10:12   ` Andrzej Hajda
2013-09-06 11:19 ` [PATCH v2 00/12] clk/exynos convert clock IDs to macros Tomasz Figa
2013-09-06 11:19   ` Tomasz Figa
2013-09-12 10:50   ` Kukjin Kim
2013-09-12 10:50     ` Kukjin Kim
2013-09-12 11:12     ` Tomasz Figa
2013-09-12 11:12       ` Tomasz Figa
     [not found]     ` <070001ceafa5$d4d81a40$7e884ec0$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-16 14:33       ` Sylwester Nawrocki [this message]
2013-09-16 14:33         ` Sylwester Nawrocki
     [not found]         ` <523716C9.3000204-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-09-16 19:37           ` Mike Turquette
2013-09-16 19:37             ` Mike Turquette
2013-09-26 12:21             ` Andrzej Hajda
2013-09-26 12:21               ` Andrzej Hajda
2013-09-30 10:11             ` Kukjin Kim
2013-09-30 10:11               ` Kukjin Kim
     [not found]               ` <06c101cebdc5$75a83d10$60f8b730$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-10-02  1:09                 ` Mike Turquette
2013-10-02  1:09                   ` Mike Turquette
2013-10-05  2:16                   ` Kukjin Kim
2013-10-05  2:16                     ` Kukjin Kim
2013-10-06 20:27                     ` RE: " Mike Turquette
2013-10-06 20:27                       ` Mike Turquette
2013-10-07  8:46                       ` Andrzej Hajda
2013-10-07  8:46                         ` Andrzej Hajda
2013-10-28 14:31                         ` Andrzej Hajda
2013-10-28 14:31                           ` Andrzej Hajda
2013-10-28 15:03                           ` Kukjin Kim
2013-10-28 15:03                             ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=523716C9.3000204@samsung.com \
    --to=s.nawrocki-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
    --cc=a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.