* [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
@ 2013-09-19 2:45 Alexey Kardashevskiy
2013-09-27 8:02 ` Alexey Kardashevskiy
0 siblings, 1 reply; 10+ messages in thread
From: Alexey Kardashevskiy @ 2013-09-19 2:45 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, Peter Maydell, Paolo Bonzini
This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Changes:
v3:
* changed comments
v2:
* added Doc Comments
* removed error_print
---
include/sysemu/kvm.h | 21 +++++++++++++++++++++
kvm-all.c | 18 ++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index c7bc07b..9080ffe 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
void kvm_pc_gsi_handler(void *opaque, int n, int level);
void kvm_pc_setup_irq_routing(bool pci_enabled);
void kvm_init_irq_routing(KVMState *s);
+
+/**
+ * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
+ * @id: The register ID
+ * @addr: The pointer to a value must point to a variable of the correct
+ * type/size for the register being accessed.
+ *
+ * Returns: 0 on success, or a negative errno on failure.
+ */
+int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
+
+/**
+ * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
+ * @id: The register ID
+ * @addr: The pointer to a value must point to a variable of the correct
+ * type/size for the register being accessed.
+ *
+ * Returns: 0 on success, or a negative errno on failure.
+ */
+int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
+
#endif
diff --git a/kvm-all.c b/kvm-all.c
index ded7fc8..cdc32ec 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
{
return kvm_arch_on_sigbus(code, addr);
}
+
+int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
+{
+ struct kvm_one_reg reg = {
+ .id = id,
+ .addr = (uintptr_t)addr,
+ };
+ return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
+}
+
+int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
+{
+ struct kvm_one_reg reg = {
+ .id = id,
+ .addr = (uintptr_t)addr,
+ };
+ return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
+}
--
1.8.4.rc4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2013-09-19 2:45 [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers Alexey Kardashevskiy
@ 2013-09-27 8:02 ` Alexey Kardashevskiy
2013-09-27 8:59 ` Paolo Bonzini
0 siblings, 1 reply; 10+ messages in thread
From: Alexey Kardashevskiy @ 2013-09-27 8:02 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Maydell, qemu-devel, Paolo Bonzini
On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote:
> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
Ping?
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> Changes:
> v3:
> * changed comments
>
> v2:
> * added Doc Comments
> * removed error_print
> ---
> include/sysemu/kvm.h | 21 +++++++++++++++++++++
> kvm-all.c | 18 ++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index c7bc07b..9080ffe 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
> void kvm_pc_gsi_handler(void *opaque, int n, int level);
> void kvm_pc_setup_irq_routing(bool pci_enabled);
> void kvm_init_irq_routing(KVMState *s);
> +
> +/**
> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
> + * @id: The register ID
> + * @addr: The pointer to a value must point to a variable of the correct
> + * type/size for the register being accessed.
> + *
> + * Returns: 0 on success, or a negative errno on failure.
> + */
> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
> +
> +/**
> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
> + * @id: The register ID
> + * @addr: The pointer to a value must point to a variable of the correct
> + * type/size for the register being accessed.
> + *
> + * Returns: 0 on success, or a negative errno on failure.
> + */
> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
> +
> #endif
> diff --git a/kvm-all.c b/kvm-all.c
> index ded7fc8..cdc32ec 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
> {
> return kvm_arch_on_sigbus(code, addr);
> }
> +
> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
> +{
> + struct kvm_one_reg reg = {
> + .id = id,
> + .addr = (uintptr_t)addr,
> + };
> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
> +}
> +
> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
> +{
> + struct kvm_one_reg reg = {
> + .id = id,
> + .addr = (uintptr_t)addr,
> + };
> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
> +}
>
--
Alexey
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2013-09-27 8:02 ` Alexey Kardashevskiy
@ 2013-09-27 8:59 ` Paolo Bonzini
2013-09-27 9:08 ` Alexey Kardashevskiy
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Bonzini @ 2013-09-27 8:59 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Maydell, qemu-devel
Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto:
> On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote:
>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>
> Ping?
>
>
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>> Changes:
>> v3:
>> * changed comments
>>
>> v2:
>> * added Doc Comments
>> * removed error_print
>> ---
>> include/sysemu/kvm.h | 21 +++++++++++++++++++++
>> kvm-all.c | 18 ++++++++++++++++++
>> 2 files changed, 39 insertions(+)
>>
>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>> index c7bc07b..9080ffe 100644
>> --- a/include/sysemu/kvm.h
>> +++ b/include/sysemu/kvm.h
>> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>> void kvm_pc_gsi_handler(void *opaque, int n, int level);
>> void kvm_pc_setup_irq_routing(bool pci_enabled);
>> void kvm_init_irq_routing(KVMState *s);
>> +
>> +/**
>> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
>> + * @id: The register ID
>> + * @addr: The pointer to a value must point to a variable of the correct
>> + * type/size for the register being accessed.
>> + *
>> + * Returns: 0 on success, or a negative errno on failure.
>> + */
>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>> +
>> +/**
>> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
>> + * @id: The register ID
>> + * @addr: The pointer to a value must point to a variable of the correct
>> + * type/size for the register being accessed.
>> + *
>> + * Returns: 0 on success, or a negative errno on failure.
>> + */
>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
>> +
>> #endif
>> diff --git a/kvm-all.c b/kvm-all.c
>> index ded7fc8..cdc32ec 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
>> {
>> return kvm_arch_on_sigbus(code, addr);
>> }
>> +
>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
>> +{
>> + struct kvm_one_reg reg = {
>> + .id = id,
>> + .addr = (uintptr_t)addr,
>> + };
>> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
>> +}
>> +
>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
>> +{
>> + struct kvm_one_reg reg = {
>> + .id = id,
>> + .addr = (uintptr_t)addr,
>> + };
>> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
>> +}
>>
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Include it with the acked-by together with the first patch that needs
it. Alex can pick it up.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2013-09-27 8:59 ` Paolo Bonzini
@ 2013-09-27 9:08 ` Alexey Kardashevskiy
2013-09-27 9:37 ` Paolo Bonzini
2014-03-20 12:35 ` Alexey Kardashevskiy
0 siblings, 2 replies; 10+ messages in thread
From: Alexey Kardashevskiy @ 2013-09-27 9:08 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, qemu-devel
On 09/27/2013 06:59 PM, Paolo Bonzini wrote:
> Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto:
>> On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote:
>>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>>
>> Ping?
>>
>>
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>> Changes:
>>> v3:
>>> * changed comments
>>>
>>> v2:
>>> * added Doc Comments
>>> * removed error_print
>>> ---
>>> include/sysemu/kvm.h | 21 +++++++++++++++++++++
>>> kvm-all.c | 18 ++++++++++++++++++
>>> 2 files changed, 39 insertions(+)
>>>
>>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>>> index c7bc07b..9080ffe 100644
>>> --- a/include/sysemu/kvm.h
>>> +++ b/include/sysemu/kvm.h
>>> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>>> void kvm_pc_gsi_handler(void *opaque, int n, int level);
>>> void kvm_pc_setup_irq_routing(bool pci_enabled);
>>> void kvm_init_irq_routing(KVMState *s);
>>> +
>>> +/**
>>> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
>>> + * @id: The register ID
>>> + * @addr: The pointer to a value must point to a variable of the correct
>>> + * type/size for the register being accessed.
>>> + *
>>> + * Returns: 0 on success, or a negative errno on failure.
>>> + */
>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>>> +
>>> +/**
>>> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
>>> + * @id: The register ID
>>> + * @addr: The pointer to a value must point to a variable of the correct
>>> + * type/size for the register being accessed.
>>> + *
>>> + * Returns: 0 on success, or a negative errno on failure.
>>> + */
>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
>>> +
>>> #endif
>>> diff --git a/kvm-all.c b/kvm-all.c
>>> index ded7fc8..cdc32ec 100644
>>> --- a/kvm-all.c
>>> +++ b/kvm-all.c
>>> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
>>> {
>>> return kvm_arch_on_sigbus(code, addr);
>>> }
>>> +
>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
>>> +{
>>> + struct kvm_one_reg reg = {
>>> + .id = id,
>>> + .addr = (uintptr_t)addr,
>>> + };
>>> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
>>> +}
>>> +
>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
>>> +{
>>> + struct kvm_one_reg reg = {
>>> + .id = id,
>>> + .addr = (uintptr_t)addr,
>>> + };
>>> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
>>> +}
>>>
>>
>>
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Include it with the acked-by together with the first patch that needs
> it. Alex can pick it up.
Why to wait?
Alex, please pick it up.
The first patch which needs it is "[PATCH] spapr: add "compat" machine
option", posted earlier today.
--
Alexey
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2013-09-27 9:08 ` Alexey Kardashevskiy
@ 2013-09-27 9:37 ` Paolo Bonzini
2014-03-20 12:35 ` Alexey Kardashevskiy
1 sibling, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2013-09-27 9:37 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Maydell, qemu-devel
Il 27/09/2013 11:08, Alexey Kardashevskiy ha scritto:
>> > Include it with the acked-by together with the first patch that needs
>> > it. Alex can pick it up.
>
> Why to wait?
>
> Alex, please pick it up.
>
> The first patch which needs it is "[PATCH] spapr: add "compat" machine
> option", posted earlier today.
Perfect. I just didn't want to force Alex to wait for the next pull
request from me or Gleb.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2013-09-27 9:08 ` Alexey Kardashevskiy
2013-09-27 9:37 ` Paolo Bonzini
@ 2014-03-20 12:35 ` Alexey Kardashevskiy
2014-03-26 14:23 ` Alexey Kardashevskiy
1 sibling, 1 reply; 10+ messages in thread
From: Alexey Kardashevskiy @ 2014-03-20 12:35 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, qemu-devel
On 09/27/2013 07:08 PM, Alexey Kardashevskiy wrote:
> On 09/27/2013 06:59 PM, Paolo Bonzini wrote:
>> Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto:
>>> On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote:
>>>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>>>
>>> Ping?
>>>
>>>
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>> ---
>>>> Changes:
>>>> v3:
>>>> * changed comments
>>>>
>>>> v2:
>>>> * added Doc Comments
>>>> * removed error_print
>>>> ---
>>>> include/sysemu/kvm.h | 21 +++++++++++++++++++++
>>>> kvm-all.c | 18 ++++++++++++++++++
>>>> 2 files changed, 39 insertions(+)
>>>>
>>>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>>>> index c7bc07b..9080ffe 100644
>>>> --- a/include/sysemu/kvm.h
>>>> +++ b/include/sysemu/kvm.h
>>>> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>>>> void kvm_pc_gsi_handler(void *opaque, int n, int level);
>>>> void kvm_pc_setup_irq_routing(bool pci_enabled);
>>>> void kvm_init_irq_routing(KVMState *s);
>>>> +
>>>> +/**
>>>> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
>>>> + * @id: The register ID
>>>> + * @addr: The pointer to a value must point to a variable of the correct
>>>> + * type/size for the register being accessed.
>>>> + *
>>>> + * Returns: 0 on success, or a negative errno on failure.
>>>> + */
>>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>>>> +
>>>> +/**
>>>> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
>>>> + * @id: The register ID
>>>> + * @addr: The pointer to a value must point to a variable of the correct
>>>> + * type/size for the register being accessed.
>>>> + *
>>>> + * Returns: 0 on success, or a negative errno on failure.
>>>> + */
>>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
>>>> +
>>>> #endif
>>>> diff --git a/kvm-all.c b/kvm-all.c
>>>> index ded7fc8..cdc32ec 100644
>>>> --- a/kvm-all.c
>>>> +++ b/kvm-all.c
>>>> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
>>>> {
>>>> return kvm_arch_on_sigbus(code, addr);
>>>> }
>>>> +
>>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
>>>> +{
>>>> + struct kvm_one_reg reg = {
>>>> + .id = id,
>>>> + .addr = (uintptr_t)addr,
>>>> + };
>>>> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
>>>> +}
>>>> +
>>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
>>>> +{
>>>> + struct kvm_one_reg reg = {
>>>> + .id = id,
>>>> + .addr = (uintptr_t)addr,
>>>> + };
>>>> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
>>>> +}
>>>>
>>>
>>>
>>
>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Include it with the acked-by together with the first patch that needs
>> it. Alex can pick it up.
>
>
> Why to wait?
>
> Alex, please pick it up.
>
> The first patch which needs it is "[PATCH] spapr: add "compat" machine
> option", posted earlier today.
Alex did not pick it up. And I use this patch in 2 of my series
(client-arch-support and power8 migration patch) so I would really love not
to post it twice. This does not need to go to 2.0-lalala but would be nice
to have it in some kvm-next. Thanks!
--
Alexey
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2014-03-20 12:35 ` Alexey Kardashevskiy
@ 2014-03-26 14:23 ` Alexey Kardashevskiy
2014-03-26 14:35 ` Paolo Bonzini
0 siblings, 1 reply; 10+ messages in thread
From: Alexey Kardashevskiy @ 2014-03-26 14:23 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, qemu-devel
On 03/20/2014 11:35 PM, Alexey Kardashevskiy wrote:
> On 09/27/2013 07:08 PM, Alexey Kardashevskiy wrote:
>> On 09/27/2013 06:59 PM, Paolo Bonzini wrote:
>>> Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto:
>>>> On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote:
>>>>> This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls.
>>>>
>>>> Ping?
>>>>
>>>>
>>>>>
>>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>>> ---
>>>>> Changes:
>>>>> v3:
>>>>> * changed comments
>>>>>
>>>>> v2:
>>>>> * added Doc Comments
>>>>> * removed error_print
>>>>> ---
>>>>> include/sysemu/kvm.h | 21 +++++++++++++++++++++
>>>>> kvm-all.c | 18 ++++++++++++++++++
>>>>> 2 files changed, 39 insertions(+)
>>>>>
>>>>> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
>>>>> index c7bc07b..9080ffe 100644
>>>>> --- a/include/sysemu/kvm.h
>>>>> +++ b/include/sysemu/kvm.h
>>>>> @@ -319,4 +319,25 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s, EventNotifier *n, int virq);
>>>>> void kvm_pc_gsi_handler(void *opaque, int n, int level);
>>>>> void kvm_pc_setup_irq_routing(bool pci_enabled);
>>>>> void kvm_init_irq_routing(KVMState *s);
>>>>> +
>>>>> +/**
>>>>> + * kvm_set_one_reg - set a register value in KVM via KVM_SET_ONE_REG ioctl
>>>>> + * @id: The register ID
>>>>> + * @addr: The pointer to a value must point to a variable of the correct
>>>>> + * type/size for the register being accessed.
>>>>> + *
>>>>> + * Returns: 0 on success, or a negative errno on failure.
>>>>> + */
>>>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr);
>>>>> +
>>>>> +/**
>>>>> + * kvm_get_one_reg - get a register value from KVM via KVM_GET_ONE_REG ioctl
>>>>> + * @id: The register ID
>>>>> + * @addr: The pointer to a value must point to a variable of the correct
>>>>> + * type/size for the register being accessed.
>>>>> + *
>>>>> + * Returns: 0 on success, or a negative errno on failure.
>>>>> + */
>>>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr);
>>>>> +
>>>>> #endif
>>>>> diff --git a/kvm-all.c b/kvm-all.c
>>>>> index ded7fc8..cdc32ec 100644
>>>>> --- a/kvm-all.c
>>>>> +++ b/kvm-all.c
>>>>> @@ -2049,3 +2049,21 @@ int kvm_on_sigbus(int code, void *addr)
>>>>> {
>>>>> return kvm_arch_on_sigbus(code, addr);
>>>>> }
>>>>> +
>>>>> +int kvm_set_one_reg(CPUState *cs, uint64_t id, void *addr)
>>>>> +{
>>>>> + struct kvm_one_reg reg = {
>>>>> + .id = id,
>>>>> + .addr = (uintptr_t)addr,
>>>>> + };
>>>>> + return kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, ®);
>>>>> +}
>>>>> +
>>>>> +int kvm_get_one_reg(CPUState *cs, uint64_t id, void *addr)
>>>>> +{
>>>>> + struct kvm_one_reg reg = {
>>>>> + .id = id,
>>>>> + .addr = (uintptr_t)addr,
>>>>> + };
>>>>> + return kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®);
>>>>> +}
>>>>>
>>>>
>>>>
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> Include it with the acked-by together with the first patch that needs
>>> it. Alex can pick it up.
>>
>>
>> Why to wait?
>>
>> Alex, please pick it up.
>>
>> The first patch which needs it is "[PATCH] spapr: add "compat" machine
>> option", posted earlier today.
>
> Alex did not pick it up. And I use this patch in 2 of my series
> (client-arch-support and power8 migration patch) so I would really love not
> to post it twice. This does not need to go to 2.0-lalala but would be nice
> to have it in some kvm-next. Thanks!
Paolo, ping!
Thanks!
--
Alexey
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2014-03-26 14:23 ` Alexey Kardashevskiy
@ 2014-03-26 14:35 ` Paolo Bonzini
2014-05-02 2:38 ` Alexey Kardashevskiy
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Bonzini @ 2014-03-26 14:35 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Maydell, qemu-devel
Il 26/03/2014 15:23, Alexey Kardashevskiy ha scritto:
>> Alex did not pick it up. And I use this patch in 2 of my series
>> (client-arch-support and power8 migration patch) so I would really love not
>> to post it twice. This does not need to go to 2.0-lalala but would be nice
>> to have it in some kvm-next. Thanks!
>
>
> Paolo, ping!
Applying it now to uq/master, thanks.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2014-03-26 14:35 ` Paolo Bonzini
@ 2014-05-02 2:38 ` Alexey Kardashevskiy
2014-05-02 8:36 ` Paolo Bonzini
0 siblings, 1 reply; 10+ messages in thread
From: Alexey Kardashevskiy @ 2014-05-02 2:38 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, qemu-devel
On 03/27/2014 01:35 AM, Paolo Bonzini wrote:
> Il 26/03/2014 15:23, Alexey Kardashevskiy ha scritto:
>>> Alex did not pick it up. And I use this patch in 2 of my series
>>> (client-arch-support and power8 migration patch) so I would really love not
>>> to post it twice. This does not need to go to 2.0-lalala but would be nice
>>> to have it in some kvm-next. Thanks!
>>
>>
>> Paolo, ping!
>
> Applying it now to uq/master, thanks.
I looked at git://github.com/bonzini/qemu.git, "uq/master", it is 7 months
old so I am obviously looking at the wrong repo. Where exactly did the subj
patch go? Or you just do not push "uq/master" very often? :) Thanks!
--
Alexey
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers
2014-05-02 2:38 ` Alexey Kardashevskiy
@ 2014-05-02 8:36 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2014-05-02 8:36 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Maydell, qemu-devel
> > Applying it now to uq/master, thanks.
>
> I looked at git://github.com/bonzini/qemu.git, "uq/master", it is 7 months
> old so I am obviously looking at the wrong repo. Where exactly did the subj
> patch go? Or you just do not push "uq/master" very often? :) Thanks!
It's git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git -- I'll add to my
workflow to push uq/master to github as well, thanks for the suggestion.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-05-02 8:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-19 2:45 [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers Alexey Kardashevskiy
2013-09-27 8:02 ` Alexey Kardashevskiy
2013-09-27 8:59 ` Paolo Bonzini
2013-09-27 9:08 ` Alexey Kardashevskiy
2013-09-27 9:37 ` Paolo Bonzini
2014-03-20 12:35 ` Alexey Kardashevskiy
2014-03-26 14:23 ` Alexey Kardashevskiy
2014-03-26 14:35 ` Paolo Bonzini
2014-05-02 2:38 ` Alexey Kardashevskiy
2014-05-02 8:36 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.