* [PATCH v3 00/11] xen: arm: rework early bring up
@ 2013-09-27 10:16 Ian Campbell
2013-09-27 10:20 ` [PATCH v3 01/11] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
` (10 more replies)
0 siblings, 11 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:16 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, Tim Deegan, Stefano Stabellini
The following reworks early bring up on ARM to use a separate set of
boot pagetables. This simplifies things by avoiding the need to bring up
all CPUs in lock step, which in turn allows us to do secondary CPU
bringup in C code.
Unfortunately the main bulk of this change is a single large patch which
is hard to decompose any further since it is basically pulling on the
thread and then knitting a new jumper from it.
With these changes Xen now absolutely requires that the bootloader calls
the hypervisor in HYP mode, the previous workarounds have been removed.
For use on models a bootwrapper is now required. See
git://xenbits.xen.org/people/ianc/boot-wrapper.git xen-arm32
git://xenbits.xen.org/people/ianc/boot-wrapper-aarch64.git xen-arm64
I have implemented support for CPU bringup on the fastmodel vexpress
platforms (v7and v8) here. Julien reports that it works on a real
vexpress to.
I'm hoping that those of you with access to other platforms will
implement the required cpu_up platform hook, it should be pretty simple
in each case, I think. (Update: I've implemented exynos5 now)
It should now also be possible to implement PSCI, but I have not done
so.
Most of this is all acked but I had to rebase which involved some real
changes to reposting. I have retained acks...
Changes since v2:
* rebased, resolved some conflicts due to e.g. Julien's
logical_cpu work
* dsb in smp_up_cpu wait loop (already reposted)
* fixes to MIDR symbols (needed to be just U not UL, otherwise
-Werror=overflow can complain, see patch for details)
* Resolve the two TODOs:
* Merge the arch_cpu_init loop into the existing
smp_init_maps loop
* Implemented exynos5 support (kept separate since it is
new)
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 01/11] xen: arm: Load xen under 4GB on 32-bit
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch Ian Campbell
` (9 subsequent siblings)
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
We need to be able to use a 1:1 mapping during bring up.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Tim Deegan <tim@xen.org>
---
xen/arch/arm/setup.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 1d0b5e9..f0436d7 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -258,6 +258,14 @@ static paddr_t __init get_xen_paddr(void)
if ( !e )
continue;
+#ifdef CONFIG_ARM_32
+ /* Xen must be under 4GB */
+ if ( e > 0x100000000ULL )
+ e = 0x100000000ULL;
+ if ( e < bank->start )
+ continue;
+#endif
+
s = e - min_size;
if ( s > paddr )
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
2013-09-27 10:20 ` [PATCH v3 01/11] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 12:19 ` Julien Grall
2013-09-27 10:20 ` [PATCH v3 03/11] xen: arm: Log the raw MIDR on boot Ian Campbell
` (8 subsequent siblings)
10 siblings, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
midway, omap5 and exynos are all 32-bit only platforms. This avoids needing
CONFIG_ARM_32 ifdefs around the SMP callbacks on such platforms.
Vexpress is both.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/platforms/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
index 4aa82e8..7535801 100644
--- a/xen/arch/arm/platforms/Makefile
+++ b/xen/arch/arm/platforms/Makefile
@@ -1,4 +1,4 @@
obj-y += vexpress.o
-obj-y += exynos5.o
-obj-y += midway.o
-obj-y += omap5.o
+obj-$(CONFIG_ARM_32) += exynos5.o
+obj-$(CONFIG_ARM_32) += midway.o
+obj-$(CONFIG_ARM_32) += omap5.o
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 03/11] xen: arm: Log the raw MIDR on boot.
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
2013-09-27 10:20 ` [PATCH v3 01/11] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-27 10:20 ` [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 04/11] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
` (7 subsequent siblings)
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Tim Deegan <tim@xen.org>
---
v2: Fixed overlong line
---
xen/arch/arm/setup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index f0436d7..ee1f639 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -83,8 +83,9 @@ static void __init processor_id(void)
printk("Huh, cpu architecture %x, expected 0xf (defined by cpuid)\n",
c->midr.architecture);
- printk("Processor: \"%s\", variant: 0x%x, part 0x%03x, rev 0x%x\n",
- implementer, c->midr.variant, c->midr.part_number, c->midr.revision);
+ printk("Processor: %08"PRIx32": \"%s\", variant: 0x%x, part 0x%03x, rev 0x%x\n",
+ c->midr.bits, implementer,
+ c->midr.variant, c->midr.part_number, c->midr.revision);
#if defined(CONFIG_ARM_64)
printk("64-bit Execution:\n");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 04/11] xen: arm: make sure we stay within the memory bank during mm setup
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (2 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 03/11] xen: arm: Log the raw MIDR on boot Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 05/11] xen: arm: add two new device tree helpers Ian Campbell
` (6 subsequent siblings)
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Otherwise if there is a module in another bank we can run off the end.
Rename *n to *end to make it clearer what is happening.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
v3: typoes.
v2: Improve commend. s/*n/*end/
---
xen/arch/arm/setup.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index ee1f639..07338e1 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -207,9 +207,11 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e,
* Return the end of the non-module region starting at s. In other
* words return s the start of the next modules after s.
*
- * Also returns the end of that module in *n.
+ * On input *end is the end of the region which should be considered
+ * and it is updated to reflect the end of the module, clipped to the
+ * end of the region if it would run over.
*/
-static paddr_t __init next_module(paddr_t s, paddr_t *n)
+static paddr_t __init next_module(paddr_t s, paddr_t *end)
{
struct dt_module_info *mi = &early_info.modules;
paddr_t lowest = ~(paddr_t)0;
@@ -224,8 +226,10 @@ static paddr_t __init next_module(paddr_t s, paddr_t *n)
continue;
if ( mod_s > lowest )
continue;
+ if ( mod_s > *end )
+ continue;
lowest = mod_s;
- *n = mod_e;
+ *end = min(*end, mod_e);
}
return lowest;
}
@@ -454,6 +458,9 @@ static void __init setup_mm(unsigned long dtb_paddr, size_t dtb_size)
e = n = bank_end;
}
+ if ( e > bank_end )
+ e = bank_end;
+
setup_xenheap_mappings(s>>PAGE_SHIFT, (e-s)>>PAGE_SHIFT);
xenheap_mfn_end = e;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 05/11] xen: arm: add two new device tree helpers
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (3 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 04/11] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
` (5 subsequent siblings)
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
- dt_property_read_u64
- dt_find_node_by_type
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
v2: fix some typos
rebase and update for change to some underlying functions (added dt_ prefix)
---
xen/common/device_tree.c | 29 +++++++++++++++++++++++++++++
xen/include/xen/device_tree.h | 17 +++++++++++++++++
2 files changed, 46 insertions(+)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 9a16650..fc87b6d 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -493,6 +493,21 @@ bool_t dt_property_read_u32(const struct dt_device_node *np,
return 1;
}
+
+bool_t dt_property_read_u64(const struct dt_device_node *np,
+ const char *name, u64 *out_value)
+{
+ u32 len;
+ const __be32 *val;
+
+ val = dt_get_property(np, name, &len);
+ if ( !val || len < sizeof(*out_value) )
+ return 0;
+
+ *out_value = dt_read_number(val, 2);
+
+ return 1;
+}
int dt_property_read_string(const struct dt_device_node *np,
const char *propname, const char **out_string)
{
@@ -558,6 +573,20 @@ struct dt_device_node *dt_find_node_by_name(struct dt_device_node *from,
return np;
}
+struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from,
+ const char *type)
+{
+ struct dt_device_node *np;
+ struct dt_device_node *dt;
+
+ dt = from ? from->allnext : dt_host;
+ dt_for_each_device_node(dt, np)
+ if ( np->type && (dt_node_cmp(np->type, type) == 0) )
+ break;
+
+ return np;
+}
+
struct dt_device_node *dt_find_node_by_path(const char *path)
{
struct dt_device_node *np;
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
index 7810f53..c126656 100644
--- a/xen/include/xen/device_tree.h
+++ b/xen/include/xen/device_tree.h
@@ -351,6 +351,17 @@ const void *dt_get_property(const struct dt_device_node *np,
bool_t dt_property_read_u32(const struct dt_device_node *np,
const char *name, u32 *out_value);
/**
+ * dt_property_read_u64 - Helper to read a u64 property.
+ * @np: node to get the value
+ * @name: name of the property
+ * @out_value: pointer to return value
+ *
+ * Return true if get the desired value.
+ */
+bool_t dt_property_read_u64(const struct dt_device_node *np,
+ const char *name, u64 *out_value);
+
+/**
* dt_property_read_string - Find and read a string from a property
* @np: Device node from which the property value is to be read
* @propname: Name of the property to be searched
@@ -399,6 +410,12 @@ struct dt_device_node *dt_find_node_by_name(struct dt_device_node *node,
const char *name);
/**
+ * dt_find_node_by_type - Find a node by its "type" property
+ */
+struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from,
+ const char *type);
+
+/**
* df_find_node_by_alias - Find a node matching an alias
* @alias: The alias to match
*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (4 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 05/11] xen: arm: add two new device tree helpers Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 12:23 ` Julien Grall
2013-09-27 10:20 ` [PATCH v3 07/11] xen: arm: implement smp initialisation callbacks for exynos5 Ian Campbell
` (4 subsequent siblings)
10 siblings, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Includes an implementation for vexpress using the sysflags interface and
support for the ARMv8 "spin-table" method.
Unused until the next patch, split out to simplify review.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
Acked-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/arm32/Makefile | 1 +
xen/arch/arm/arm32/head.S | 2 +-
xen/arch/arm/arm32/smpboot.c | 29 ++++++++++++
xen/arch/arm/arm64/Makefile | 1 +
xen/arch/arm/arm64/head.S | 1 +
xen/arch/arm/arm64/smpboot.c | 89 +++++++++++++++++++++++++++++++++++++
xen/arch/arm/platform.c | 18 ++++++++
xen/arch/arm/platforms/vexpress.c | 38 ++++++++++++++++
xen/include/asm-arm/platform.h | 9 ++++
xen/include/asm-arm/smp.h | 9 ++++
10 files changed, 196 insertions(+), 1 deletion(-)
create mode 100644 xen/arch/arm/arm32/smpboot.c
create mode 100644 xen/arch/arm/arm64/smpboot.c
diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
index 18522dc..463b1f5 100644
--- a/xen/arch/arm/arm32/Makefile
+++ b/xen/arch/arm/arm32/Makefile
@@ -7,5 +7,6 @@ obj-y += proc-v7.o
obj-y += traps.o
obj-y += domain.o
obj-y += vfp.o
+obj-y += smpboot.o
obj-$(EARLY_PRINTK) += debug.o
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index fce18a2..8cb31a2 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -59,7 +59,7 @@
* or the initial pagetable code below will need adjustment. */
.global start
start:
-
+GLOBAL(init_secondary) /* currently unused */
/* zImage magic header, see:
* http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
*/
diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c
new file mode 100644
index 0000000..88fe8fb
--- /dev/null
+++ b/xen/arch/arm/arm32/smpboot.c
@@ -0,0 +1,29 @@
+#include <xen/device_tree.h>
+#include <xen/init.h>
+#include <xen/smp.h>
+#include <asm/platform.h>
+
+int __init arch_smp_init(void)
+{
+ return platform_smp_init();
+}
+
+int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
+{
+ /* TODO handle PSCI init */
+ return 0;
+}
+
+int __init arch_cpu_up(int cpu)
+{
+ return platform_cpu_up(cpu);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
index e06a0a9..30fb480 100644
--- a/xen/arch/arm/arm64/Makefile
+++ b/xen/arch/arm/arm64/Makefile
@@ -6,5 +6,6 @@ obj-y += mode_switch.o
obj-y += traps.o
obj-y += domain.o
obj-y += vfp.o
+obj-y += smpboot.o
obj-$(EARLY_PRINTK) += debug.o
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 4495f72..7cecac3 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -65,6 +65,7 @@
.global start
start:
+GLOBAL(init_secondary) /* currently unused */
/*
* DO NOT MODIFY. Image header expected by Linux boot-loaders.
*/
diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c
new file mode 100644
index 0000000..8239590
--- /dev/null
+++ b/xen/arch/arm/arm64/smpboot.c
@@ -0,0 +1,89 @@
+#include <xen/cpu.h>
+#include <xen/lib.h>
+#include <xen/init.h>
+#include <xen/errno.h>
+#include <xen/mm.h>
+#include <xen/smp.h>
+
+struct smp_enable_ops {
+ int (*prepare_cpu)(int);
+};
+
+static paddr_t cpu_release_addr[NR_CPUS];
+static struct smp_enable_ops smp_enable_ops[NR_CPUS];
+
+static int __init smp_spin_table_cpu_up(int cpu)
+{
+ paddr_t *release;
+
+ if (!cpu_release_addr[cpu])
+ {
+ printk("CPU%d: No release addr\n", cpu);
+ return -ENODEV;
+ }
+
+ release = __va(cpu_release_addr[cpu]);
+
+ release[0] = __pa(init_secondary);
+ flush_xen_data_tlb_range_va((vaddr_t)release, sizeof(*release));
+
+ sev();
+ return 0;
+}
+
+static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn)
+{
+ if ( !dt_property_read_u64(dn, "cpu-release-addr", &cpu_release_addr[cpu]) )
+ {
+ printk("CPU%d has no cpu-release-addr\n", cpu);
+ return;
+ }
+
+ smp_enable_ops[cpu].prepare_cpu = smp_spin_table_cpu_up;
+}
+
+int __init arch_smp_init(void)
+{
+ /* Nothing */
+ return 0;
+}
+
+int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
+{
+ const char *enable_method;
+
+ enable_method = dt_get_property(dn, "enable-method", NULL);
+ if (!enable_method)
+ {
+ printk("CPU%d has no enable method\n", cpu);
+ return -EINVAL;
+ }
+
+ if ( !strcmp(enable_method, "spin-table") )
+ smp_spin_table_init(cpu, dn);
+ /* TODO: method "psci" */
+ else
+ {
+ printk("CPU%d has unknown enable method \"%s\"\n", cpu, enable_method);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+int __init arch_cpu_up(int cpu)
+{
+ if ( !smp_enable_ops[cpu].prepare_cpu )
+ return -ENODEV;
+
+ return smp_enable_ops[cpu].prepare_cpu(cpu);
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index db79368..db135f8 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -105,6 +105,24 @@ int __init platform_specific_mapping(struct domain *d)
return res;
}
+#ifdef CONFIG_ARM_32
+int __init platform_cpu_up(int cpu)
+{
+ if ( platform && platform->cpu_up )
+ return platform->cpu_up(cpu);
+
+ return -EAGAIN;
+}
+
+int __init platform_smp_init(void)
+{
+ if ( platform && platform->smp_init )
+ return platform->smp_init();
+
+ return 0;
+}
+#endif
+
void platform_reset(void)
{
if ( platform && platform->reset )
diff --git a/xen/arch/arm/platforms/vexpress.c b/xen/arch/arm/platforms/vexpress.c
index 22c0c13..be0516f 100644
--- a/xen/arch/arm/platforms/vexpress.c
+++ b/xen/arch/arm/platforms/vexpress.c
@@ -22,6 +22,7 @@
#include <xen/mm.h>
#include <xen/vmap.h>
#include <asm/io.h>
+#include <asm/gic.h>
#define DCC_SHIFT 26
#define FUNCTION_SHIFT 20
@@ -120,6 +121,39 @@ static void vexpress_reset(void)
iounmap(sp810);
}
+#ifdef CONFIG_ARM_32
+
+static int vexpress_smp_init(void)
+{
+ void __iomem *sysflags;
+
+ sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
+ if ( !sysflags )
+ {
+ dprintk(XENLOG_ERR, "Unable to map vexpress MMIO\n");
+ return -EFAULT;
+ }
+
+ printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
+ __pa(init_secondary), init_secondary);
+ writel(~0, sysflags + V2M_SYS_FLAGSCLR);
+ writel(__pa(init_secondary), sysflags + V2M_SYS_FLAGSSET);
+
+ iounmap(sysflags);
+
+ return 0;
+}
+
+static int vexpress_cpu_up(int cpu)
+{
+ /* Nothing to do here, the generic sev() will suffice to kick CPUs
+ * out of either the firmware or our own smp_up_cpu gate,
+ * depending on where they have ended up. */
+
+ return 0;
+}
+#endif
+
static const char * const vexpress_dt_compat[] __initdata =
{
"arm,vexpress",
@@ -144,6 +178,10 @@ static const struct dt_device_match vexpress_blacklist_dev[] __initconst =
PLATFORM_START(vexpress, "VERSATILE EXPRESS")
.compatible = vexpress_dt_compat,
+#ifdef CONFIG_ARM_32
+ .smp_init = vexpress_smp_init,
+ .cpu_up = vexpress_cpu_up,
+#endif
.reset = vexpress_reset,
.blacklist_dev = vexpress_blacklist_dev,
PLATFORM_END
diff --git a/xen/include/asm-arm/platform.h b/xen/include/asm-arm/platform.h
index a19dbf7..dbd2a15 100644
--- a/xen/include/asm-arm/platform.h
+++ b/xen/include/asm-arm/platform.h
@@ -15,6 +15,11 @@ struct platform_desc {
/* Platform initialization */
int (*init)(void);
int (*init_time)(void);
+#ifdef CONFIG_ARM_32
+ /* SMP */
+ int (*smp_init)(void);
+ int (*cpu_up)(int cpu);
+#endif
/* Specific mapping for dom0 */
int (*specific_mapping)(struct domain *d);
/* Platform reset */
@@ -43,6 +48,10 @@ struct platform_desc {
int __init platform_init(void);
int __init platform_init_time(void);
int __init platform_specific_mapping(struct domain *d);
+#ifdef CONFIG_ARM_32
+int platform_smp_init(void);
+int platform_cpu_up(int cpu);
+#endif
void platform_reset(void);
void platform_poweroff(void);
bool_t platform_has_quirk(uint32_t quirk);
diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h
index 1c2746b..1added5 100644
--- a/xen/include/asm-arm/smp.h
+++ b/xen/include/asm-arm/smp.h
@@ -4,6 +4,7 @@
#ifndef __ASSEMBLY__
#include <xen/config.h>
#include <xen/cpumask.h>
+#include <xen/device_tree.h>
#include <asm/current.h>
#endif
@@ -22,9 +23,17 @@ extern void stop_cpu(void);
extern void
make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset);
+extern int arch_smp_init(void);
+extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
+extern int arch_cpu_up(int cpu);
+
+/* Secondary CPU entry point */
+extern void init_secondary(void);
+
extern void smp_clear_cpu_maps (void);
extern int smp_get_max_cpus (void);
#endif
+
/*
* Local variables:
* mode: C
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 07/11] xen: arm: implement smp initialisation callbacks for exynos5
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (5 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
` (3 subsequent siblings)
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
These were removed in "xen: arm: rewrite start of day page table and cpu bring
up". This code is based on that assembly code but is compile tested only.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/platforms/exynos5.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/xen/arch/arm/platforms/exynos5.c b/xen/arch/arm/platforms/exynos5.c
index 36d2325..08dc12d 100644
--- a/xen/arch/arm/platforms/exynos5.c
+++ b/xen/arch/arm/platforms/exynos5.c
@@ -65,6 +65,35 @@ static int exynos5_specific_mapping(struct domain *d)
return 0;
}
+static int exynos5_smp_init(void)
+{
+ void __iomem *sysram;
+
+ sysram = ioremap_nocache(S5P_PA_SYSRAM, PAGE_SIZE);
+ if ( !sysram )
+ {
+ dprintk(XENLOG_ERR, "Unable to map exynos5 MMIO\n");
+ return -EFAULT;
+ }
+
+ printk("Set SYSRAM to %"PRIpaddr" (%p)\n",
+ __pa(init_secondary), init_secondary);
+ writel(__pa(init_secondary), sysram);
+
+ iounmap(sysram);
+
+ return 0;
+}
+
+static int exynos5_cpu_up(int cpu)
+{
+ /* Nothing to do here, the generic sev() will suffice to kick CPUs
+ * out of either the firmware or our own smp_up_cpu gate,
+ * depending on where they have ended up. */
+
+ return 0;
+}
+
static void exynos5_reset(void)
{
void __iomem *pmu;
@@ -107,6 +136,8 @@ PLATFORM_START(exynos5, "SAMSUNG EXYNOS5")
.compatible = exynos5_dt_compat,
.init_time = exynos5_init_time,
.specific_mapping = exynos5_specific_mapping,
+ .smp_init = exynos5_smp_init,
+ .cpu_up = exynos5_cpu_up,
.reset = exynos5_reset,
.quirks = exynos5_quirks,
.blacklist_dev = exynos5_blacklist_dev,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (6 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 07/11] xen: arm: implement smp initialisation callbacks for exynos5 Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 12:30 ` Julien Grall
2013-09-27 13:30 ` Julien Grall
2013-09-27 10:20 ` [PATCH v3 09/11] xen: arm: use symbolic names for MPIDR bits Ian Campbell
` (2 subsequent siblings)
10 siblings, 2 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
This is unfortunately a rather large monolithic patch.
Rather than bringing up all CPUs in lockstep as we setup paging and relocate
Xen instead create a simplified set of dedicated boot time pagetables.
This allows secondary CPUs to remain powered down or in the firmware until we
actually want to enable them. The bringup is now done later on in C and can be
driven by DT etc. I have included code for the vexpress platform, but other
platforms will need to be added.
The mechanism for deciding how to bring up a CPU differs between arm32 and
arm64. On arm32 it is essentially a per-platform property, with the exception
of PSCI which can be implemented globally (but isn't here). On arm64 there is a
per-cpu property in the device tree.
Secondary CPUs are brought up directly into the relocated Xen image, instead of
relying on being able to launch on the unrelocated Xen and hoping that it
hasn't been clobbered.
As part of this change drop support for switching from secure mode to NS HYP as
well as the early CPU kick. Xen now requires that it is launched in NS HYP
mode and that firmware configure things such that secondary CPUs can be woken
up by a primarly CPU in HYP mode. This may require fixes to bootloaders or the
use of a boot wrapper.
The changes done here (re)exposed an issue with relocating Xen and the compiler
spilling values to the stack between the copy and the actual switch to the
relocaed copy of Xen in setup_pagetables. Therefore switch to doing the copy
and switch in a single asm function where we can control precisely what gets
spilled to the stack etc.
Since we now have a separate set of boot pagetables it is much easier to build
the real Xen pagetables inplace before relocating rather than the more complex
approach of rewriting the pagetables in the relocated copy before switching.
This will also enable Xen to be loaded above the 4GB boundary on 64-bit.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: add a dsb before the smp_up_cpu wait loop.
move arch_smp_init() and arch_cpu_init() int init_cpus_maps() which I
rename to smp_init_cpus().
v2: Lots of review feedback from Julien and Tim
Reintroduce a smp_up_cpu gate. We cannot reliably wake a single CPU so we
add our own gate. However it is purely in the relocated image.
---
xen/arch/arm/arm32/Makefile | 1 -
xen/arch/arm/arm32/head.S | 391 ++++++++++++++++++-----------
xen/arch/arm/arm32/mode_switch.S | 158 ------------
xen/arch/arm/arm64/Makefile | 1 -
xen/arch/arm/arm64/head.S | 396 ++++++++++++++++++++----------
xen/arch/arm/arm64/mode_switch.S | 89 -------
xen/arch/arm/mm.c | 192 +++++++++------
xen/arch/arm/setup.c | 26 +-
xen/arch/arm/smpboot.c | 57 ++---
xen/include/asm-arm/mm.h | 3 +-
xen/include/asm-arm/platforms/exynos5.h | 14 --
xen/include/asm-arm/platforms/vexpress.h | 11 -
xen/include/asm-arm/smp.h | 6 -
13 files changed, 672 insertions(+), 673 deletions(-)
delete mode 100644 xen/arch/arm/arm32/mode_switch.S
delete mode 100644 xen/arch/arm/arm64/mode_switch.S
diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
index 463b1f5..aacdcb9 100644
--- a/xen/arch/arm/arm32/Makefile
+++ b/xen/arch/arm/arm32/Makefile
@@ -1,7 +1,6 @@
subdir-y += lib
obj-y += entry.o
-obj-y += mode_switch.o
obj-y += proc-v7.o
obj-y += traps.o
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 8cb31a2..946394c 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -37,6 +37,25 @@
#include EARLY_PRINTK_INC
#endif
+/*
+ * Common register usage in this file:
+ * r0 -
+ * r1 -
+ * r2 -
+ * r3 -
+ * r4 -
+ * r5 -
+ * r6 -
+ * r7 - CPUID
+ * r8 - DTB address (boot CPU only)
+ * r9 - paddr(start)
+ * r10 - phys offset
+ * r11 - UART address
+ * r12 - is_secondary_cpu
+ * r13 - SP
+ * r14 - LR
+ * r15 - PC
+ */
/* Macro to print a string to the UART, if there is one.
* Clobbers r0-r3. */
#ifdef EARLY_PRINTK
@@ -59,7 +78,6 @@
* or the initial pagetable code below will need adjustment. */
.global start
start:
-GLOBAL(init_secondary) /* currently unused */
/* zImage magic header, see:
* http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
*/
@@ -77,7 +95,6 @@ past_zImage:
cpsid aif /* Disable all interrupts */
/* Save the bootloader arguments in less-clobberable registers */
- mov r5, r1 /* r5: ARM-linux machine type */
mov r8, r2 /* r8 := DTB base address */
/* Find out where we are */
@@ -91,53 +108,55 @@ past_zImage:
add r8, r10 /* r8 := paddr(DTB) */
#endif
- /* Are we the boot CPU? */
- mov r12, #0 /* r12 := CPU ID */
- mrc CP32(r0, MPIDR)
- tst r0, #(1<<31) /* Multiprocessor extension supported? */
- beq boot_cpu
- tst r0, #(1<<30) /* Uniprocessor system? */
- bne boot_cpu
- bics r12, r0, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
- beq boot_cpu /* If we're CPU 0, boot now */
-
- /* Non-boot CPUs wait here to be woken up one at a time. */
-1: dsb
- ldr r0, =smp_up_cpu /* VA of gate */
- add r0, r0, r10 /* PA of gate */
- ldr r1, [r0] /* Which CPU is being booted? */
- teq r1, r12 /* Is it us? */
- wfene
- bne 1b
+ mov r12, #0 /* r12 := is_secondary_cpu */
+
+ b common_start
+
+GLOBAL(init_secondary)
+ cpsid aif /* Disable all interrupts */
+
+ /* Find out where we are */
+ ldr r0, =start
+ adr r9, start /* r9 := paddr (start) */
+ sub r10, r9, r0 /* r10 := phys-offset */
+
+ mov r12, #1 /* r12 := is_secondary_cpu */
+
+common_start:
+ mov r7, #0 /* r7 := CPU ID. Initialy zero until we
+ * find that multiprocessor extensions are
+ * present and the system is SMP */
+ mrc CP32(r1, MPIDR)
+ tst r1, #(1<<31) /* Multiprocessor extension supported? */
+ beq 1f
+ tst r1, #(1<<30) /* Uniprocessor system? */
+ bne 1f
+ bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
+1:
+
+ /* Non-boot CPUs wait here until __cpu_up is ready for them */
+ teq r12, #0
+ beq 1f
+
+ ldr r0, =smp_up_cpu
+ add r0, r0, r10 /* Apply physical offset */
+ dsb
+2: ldr r1, [r0]
+ cmp r1, r7
+ beq 1f
+ wfe
+ b 2b
+1:
-boot_cpu:
#ifdef EARLY_PRINTK
ldr r11, =EARLY_UART_BASE_ADDRESS /* r11 := UART base address */
- teq r12, #0 /* CPU 0 sets up the UART too */
+ teq r12, #0 /* Boot CPU sets up the UART too */
bleq init_uart
PRINT("- CPU ")
- mov r0, r12
+ mov r0, r7
bl putn
PRINT(" booting -\r\n")
#endif
- /* Secondary CPUs doesn't have machine ID
- * - Store machine ID on boot CPU
- * - Load machine ID on secondary CPUs
- * Machine ID is needed in kick_cpus and enter_hyp_mode */
- ldr r0, =machine_id /* VA of machine_id */
- add r0, r0, r10 /* PA of machine_id */
- teq r12, #0
- streq r5, [r0] /* On boot CPU save machine ID */
- ldrne r5, [r0] /* If non boot cpu r5 := machine ID */
-
- /* Wake up secondary cpus */
- teq r12, #0
- bleq kick_cpus
-
- PRINT("- Machine ID ")
- mov r0, r5
- bl putn
- PRINT(" -\r\n")
/* Check that this CPU has Hyp mode */
mrc CP32(r0, ID_PFR1)
@@ -147,28 +166,19 @@ boot_cpu:
PRINT("- CPU doesn't support the virtualization extensions -\r\n")
b fail
1:
- /* Check if we're already in it */
+
+ /* Check that we're already in Hyp mode */
mrs r0, cpsr
and r0, r0, #0x1f /* Mode is in the low 5 bits of CPSR */
teq r0, #0x1a /* Hyp Mode? */
- bne 1f
- PRINT("- Started in Hyp mode -\r\n")
- b hyp
-1:
- /* Otherwise, it must have been Secure Supervisor mode */
- mrc CP32(r0, SCR)
- tst r0, #0x1 /* Not-Secure bit set? */
- beq 1f
- PRINT("- CPU is not in Hyp mode or Secure state -\r\n")
+ beq hyp
+
+ /* OK, we're boned. */
+ PRINT("- Xen must be entered in NS Hyp mode -\r\n" \
+ "- Please update the bootloader -\r\n")
b fail
-1:
- /* OK, we're in Secure state. */
- PRINT("- Started in Secure state -\r\n- Entering Hyp mode -\r\n")
- ldr r0, =enter_hyp_mode /* VA of function */
- adr lr, hyp /* Set return address for call */
- add pc, r0, r10 /* Call PA of function */
-hyp:
+hyp: PRINT("- Xen starting in Hyp mode -\r\n")
/* Zero BSS On the boot CPU to avoid nasty surprises */
teq r12, #0
@@ -208,8 +218,8 @@ skip_bss:
bl putn
PRINT(" -\r\n")
b fail
-
2:
+
/* Jump to cpu_init */
ldr r1, [r1, #PROCINFO_cpu_init] /* r1 := vaddr(init func) */
adr lr, cpu_init_done /* Save return address */
@@ -242,68 +252,69 @@ cpu_init_done:
ldr r0, =(HSCTLR_BASE|SCTLR_A)
mcr CP32(r0, HSCTLR)
+ /* Rebuild the boot pagetable's first-level entries. The structure
+ * is described in mm.c.
+ *
+ * After the CPU enables paging it will add the fixmap mapping
+ * to these page tables, however this may clash with the 1:1
+ * mapping. So each CPU must rebuild the page tables here with
+ * the 1:1 in place. */
+
/* Write Xen's PT's paddr into the HTTBR */
ldr r4, =boot_pgtable
- add r4, r4, r10 /* r4 := paddr (xen_pagetable) */
- mov r5, #0 /* r4:r5 is paddr (xen_pagetable) */
+ add r4, r4, r10 /* r4 := paddr (boot_pagetable) */
+ mov r5, #0 /* r4:r5 is paddr (boot_pagetable) */
mcrr CP64(r4, r5, HTTBR)
- /* Non-boot CPUs don't need to rebuild the pagetable */
- teq r12, #0
- bne pt_ready
-
- /* console fixmap */
-#if defined(EARLY_PRINTK)
- ldr r1, =xen_fixmap
- add r1, r1, r10 /* r1 := paddr (xen_fixmap) */
- mov r3, #0
- lsr r2, r11, #12
- lsl r2, r2, #12 /* 4K aligned paddr of UART */
- orr r2, r2, #PT_UPPER(DEV_L3)
- orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
- strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
-#endif
-
- /* Build the baseline idle pagetable's first-level entries */
- ldr r1, =xen_second
- add r1, r1, r10 /* r1 := paddr (xen_second) */
+ /* Setup boot_pgtable: */
+ ldr r1, =boot_second
+ add r1, r1, r10 /* r1 := paddr (boot_second) */
mov r3, #0x0
- orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of xen_second */
+
+ /* ... map boot_second in boot_pgtable[0] */
+ orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of boot_second */
orr r2, r2, #PT_LOWER(PT) /* (+ rights for linear PT) */
strd r2, r3, [r4, #0] /* Map it in slot 0 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #8] /* Map 2nd page in slot 1 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #16] /* Map 3rd page in slot 2 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #24] /* Map 4th page in slot 3 */
-
- /* Now set up the second-level entries */
- orr r2, r9, #PT_UPPER(MEM)
- orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB normal map of Xen */
- mov r4, r9, lsr #18 /* Slot for paddr(start) */
- strd r2, r3, [r1, r4] /* Map Xen there */
- ldr r4, =start
- lsr r4, #18 /* Slot for vaddr(start) */
- strd r2, r3, [r1, r4] /* Map Xen there too */
-
- /* xen_fixmap pagetable */
- ldr r2, =xen_fixmap
- add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
- orr r2, r2, #PT_UPPER(PT)
- orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
- add r4, r4, #8
- strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
- mov r3, #0x0
- lsr r2, r8, #21
- lsl r2, r2, #21 /* 2MB-aligned paddr of DTB */
- orr r2, r2, #PT_UPPER(MEM)
- orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
- add r4, r4, #8
- strd r2, r3, [r1, r4] /* Map it in the early boot slot */
+ /* ... map of paddr(start) in boot_pgtable */
+ lsrs r1, r9, #30 /* Offset of base paddr in boot_pgtable */
+ beq 1f /* If it is in slot 0 then map in boot_second
+ * later on */
+ lsl r2, r1, #30 /* Base address for 1GB mapping */
+ orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
+ orr r2, r2, #PT_LOWER(MEM)
+ lsl r1, r1, #3 /* r1 := Slot offset */
+ strd r2, r3, [r4, r1] /* Mapping of paddr(start) */
+
+1: /* Setup boot_second: */
+ ldr r4, =boot_second
+ add r4, r4, r10 /* r1 := paddr (boot_second) */
+
+ lsr r2, r9, #20 /* Base address for 2MB mapping */
+ lsl r2, r2, #20
+ orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
+ orr r2, r2, #PT_LOWER(MEM)
+
+ /* ... map of vaddr(start) in boot_second */
+ ldr r1, =start
+ lsr r1, #18 /* Slot for vaddr(start) */
+ strd r2, r3, [r4, r1] /* Map vaddr(start) */
+
+ /* ... map of paddr(start) in boot_second */
+ lsrs r1, r9, #30 /* Base paddr */
+ bne 1f /* If paddr(start) is not in slot 0
+ * then the mapping was done in
+ * boot_pgtable above */
+
+ mov r1, r9, lsr #18 /* Slot for paddr(start) */
+ strd r2, r3, [r4, r1] /* Map Xen there */
+1:
+
+ /* Defer fixmap and dtb mapping until after paging enabled, to
+ * avoid them clashing with the 1:1 mapping. */
+
+ /* boot pagetable setup complete */
-pt_ready:
PRINT("- Turning on paging -\r\n")
ldr r1, =paging /* Explicit vaddr, not RIP-relative */
@@ -315,11 +326,53 @@ pt_ready:
mov pc, r1 /* Get a proper vaddr into PC */
paging:
+ /* Now we can install the fixmap and dtb mappings, since we
+ * don't need the 1:1 map any more */
+ dsb
+#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
+ /* Non-boot CPUs don't need to rebuild the fixmap itself, just
+ * the mapping from boot_second to xen_fixmap */
+ teq r12, #0
+ bne 1f
+
+ /* Add UART to the fixmap table */
+ ldr r1, =xen_fixmap /* r1 := vaddr (xen_fixmap) */
+ mov r3, #0
+ lsr r2, r11, #12
+ lsl r2, r2, #12 /* 4K aligned paddr of UART */
+ orr r2, r2, #PT_UPPER(DEV_L3)
+ orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
+ strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+1:
+
+ /* Map fixmap into boot_second */
+ ldr r1, =boot_second /* r1 := vaddr (xen_fixmap) */
+ ldr r2, =xen_fixmap
+ add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
+ orr r2, r2, #PT_UPPER(PT)
+ orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
+ ldr r4, =FIXMAP_ADDR(0)
+ mov r4, r4, lsr #18 /* r4 := Slot for FIXMAP(0) */
+ strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
-#ifdef EARLY_PRINTK
/* Use a virtual address to access the UART. */
ldr r11, =FIXMAP_ADDR(FIXMAP_CONSOLE)
#endif
+ /* Map the DTB in the boot misc slot */
+ teq r12, #0 /* Only on boot CPU */
+ bne 1f
+
+ ldr r1, =boot_second
+ mov r3, #0x0
+ lsr r2, r8, #21
+ lsl r2, r2, #21 /* r2: 2MB-aligned paddr of DTB */
+ orr r2, r2, #PT_UPPER(MEM)
+ orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
+ ldr r4, =BOOT_MISC_VIRT_START
+ mov r4, r4, lsr #18 /* Slot for BOOT_MISC_VIRT_START */
+ strd r2, r3, [r1, r4] /* Map it in the early boot slot */
+ dsb
+1:
PRINT("- Ready -\r\n")
@@ -327,10 +380,10 @@ paging:
teq r12, #0
beq launch
- /* Non-boot CPUs need to move on to the relocated pagetables */
- mov r0, #0
- ldr r4, =boot_ttbr /* VA of HTTBR value stashed by CPU 0 */
- add r4, r4, r10 /* PA of it */
+ /* Non-boot CPUs need to move on to the proper pagetables, which were
+ * setup in init_secondary_pagetables. */
+
+ ldr r4, =init_ttbr /* VA of HTTBR value stashed by CPU 0 */
ldrd r4, r5, [r4] /* Actual value */
dsb
mcrr CP64(r4, r5, HTTBR)
@@ -342,29 +395,6 @@ paging:
dsb /* Ensure completion of TLB+BP flush */
isb
- /* Non-boot CPUs report that they've got this far */
- ldr r0, =ready_cpus
-1: ldrex r1, [r0] /* { read # of ready CPUs } */
- add r1, r1, #1 /* Atomically { ++ } */
- strex r2, r1, [r0] /* { writeback } */
- teq r2, #0
- bne 1b
- dsb
- mcr CP32(r0, DCCMVAC) /* flush D-Cache */
- dsb
-
- /* Here, the non-boot CPUs must wait again -- they're now running on
- * the boot CPU's pagetables so it's safe for the boot CPU to
- * overwrite the non-relocated copy of Xen. Once it's done that,
- * and brought up the memory allocator, non-boot CPUs can get their
- * own stacks and enter C. */
-1: wfe
- dsb
- ldr r0, =smp_up_cpu
- ldr r1, [r0] /* Which CPU is being booted? */
- teq r1, r12 /* Is it us? */
- bne 1b
-
launch:
ldr r0, =init_data
add r0, #INITINFO_stack /* Find the boot-time stack */
@@ -373,7 +403,7 @@ launch:
sub sp, #CPUINFO_sizeof /* Make room for CPU save record */
mov r0, r10 /* Marshal args: - phys_offset */
mov r1, r8 /* - DTB address */
- movs r2, r12 /* - CPU ID */
+ movs r2, r7 /* - CPU ID */
beq start_xen /* and disappear into the land of C */
b start_secondary /* (to the appropriate entry point) */
@@ -383,6 +413,82 @@ fail: PRINT("- Boot failed -\r\n")
1: wfe
b 1b
+/* Copy Xen to new location and switch TTBR
+ * r1:r0 ttbr
+ * r2 source address
+ * r3 destination address
+ * [sp]=>r4 length
+ *
+ * Source and destination must be word aligned, length is rounded up
+ * to a 16 byte boundary.
+ *
+ * MUST BE VERY CAREFUL when saving things to RAM over the copy */
+ENTRY(relocate_xen)
+ push {r4,r5,r6,r7,r8,r9,r10,r11}
+
+ ldr r4, [sp, #8*4] /* Get 4th argument from stack */
+
+ /* Copy 16 bytes at a time using:
+ * r5: counter
+ * r6: data
+ * r7: data
+ * r8: data
+ * r9: data
+ * r10: source
+ * r11: destination
+ */
+ mov r5, r4
+ mov r10, r2
+ mov r11, r3
+1: ldmia r10!, {r6, r7, r8, r9}
+ stmia r11!, {r6, r7, r8, r9}
+
+ subs r5, r5, #16
+ bgt 1b
+
+ /* Flush destination from dcache using:
+ * r5: counter
+ * r6: step
+ * r7: vaddr
+ */
+ dsb /* So the CPU issues all writes to the range */
+
+ mov r5, r4
+ ldr r6, =cacheline_bytes /* r6 := step */
+ ldr r6, [r6]
+ mov r7, r3
+
+1: mcr CP32(r7, DCCMVAC)
+
+ add r7, r7, r6
+ subs r5, r5, r6
+ bgt 1b
+
+ dsb /* Ensure the flushes happen before
+ * continuing */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
+ mcr CP32(r0, ICIALLU) /* Flush I-cache */
+ mcr CP32(r0, BPIALL) /* Flush branch predictor */
+ dsb /* Ensure completion of TLB+BP flush */
+ isb
+
+ mcrr CP64(r0, r1, HTTBR)
+
+ dsb /* ensure memory accesses do not cross
+ * over the TTBR0 write */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
+ mcr CP32(r0, ICIALLU) /* Flush I-cache */
+ mcr CP32(r0, BPIALL) /* Flush branch predictor */
+ dsb /* Ensure completion of TLB+BP flush */
+ isb
+
+ pop {r4, r5,r6,r7,r8,r9,r10,r11}
+
+ mov pc, lr
#ifdef EARLY_PRINTK
/* Bring up the UART.
@@ -439,9 +545,6 @@ putn: mov pc, lr
#endif /* !EARLY_PRINTK */
-/* Place holder for machine ID */
-machine_id: .word 0x0
-
/*
* Local variables:
* mode: ASM
diff --git a/xen/arch/arm/arm32/mode_switch.S b/xen/arch/arm/arm32/mode_switch.S
deleted file mode 100644
index 2cd5888..0000000
--- a/xen/arch/arm/arm32/mode_switch.S
+++ /dev/null
@@ -1,158 +0,0 @@
-/*
- * xen/arch/arm/mode_switch.S
- *
- * Start-of day code to take a CPU from Secure mode to Hyp mode.
- *
- * Tim Deegan <tim@xen.org>
- * Copyright (c) 2011-2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <asm/config.h>
-#include <asm/page.h>
-#include <asm/platforms/vexpress.h>
-#include <asm/platforms/exynos5.h>
-#include <asm/asm_defns.h>
-#include <asm/gic.h>
-
-/* Wake up secondary cpus
- * This code relies on Machine ID and only works for Vexpress and the Arndale
- * TODO: Move this code either later (via platform specific desc) or in a bootwrapper
- * r5: Machine ID
- * Clobber r0 r2 */
-GLOBAL(kick_cpus)
- ldr r0, =MACH_TYPE_SMDK5250
- teq r5, r0 /* Are we running on the arndale? */
- beq kick_cpus_arndale
- /* otherwise versatile express */
- /* write start paddr to v2m sysreg FLAGSSET register */
- ldr r0, =(V2M_SYS_MMIO_BASE) /* base V2M sysreg MMIO address */
- dsb
- mov r2, #0xffffffff
- str r2, [r0, #(V2M_SYS_FLAGSCLR)]
- dsb
- ldr r2, =start
- add r2, r2, r10
- str r2, [r0, #(V2M_SYS_FLAGSSET)]
- dsb
- ldr r2, =V2M_GIC_BASE_ADDRESS /* r2 := VE gic base address */
- b kick_cpus_sgi
-kick_cpus_arndale:
- /* write start paddr to CPU 1 sysreg register */
- ldr r0, =(S5P_PA_SYSRAM)
- ldr r2, =start
- add r2, r2, r10
- str r2, [r0]
- dsb
- ldr r2, =EXYNOS5_GIC_BASE_ADDRESS /* r2 := Exynos5 gic base address */
-kick_cpus_sgi:
- /* send an interrupt */
- ldr r0, =GIC_DR_OFFSET /* GIC distributor offset */
- add r0, r2 /* r0 := r0 + gic base address */
- mov r2, #0x1
- str r2, [r0, #(GICD_CTLR * 4)] /* enable distributor */
- mov r2, #0xfe0000
- str r2, [r0, #(GICD_SGIR * 4)] /* send IPI to everybody, SGI0 = Event check */
- dsb
- str r2, [r0, #(GICD_CTLR * 4)] /* disable distributor */
- mov pc, lr
-
-
-/* Get up a CPU into Hyp mode. Clobbers r0-r3.
- *
- * r5: Machine ID
- * r12: CPU number
- *
- * This code is specific to the VE model/Arndale, and not intended to be used
- * on production systems. As such it's a bit hackier than the main
- * boot code in head.S. In future it will be replaced by better
- * integration with the bootloader/firmware so that Xen always starts
- * in Hyp mode.
- * Clobber r0 - r4 */
-GLOBAL(enter_hyp_mode)
- mov r3, lr /* Put return address in non-banked reg */
- cpsid aif, #0x16 /* Enter Monitor mode */
- mrc CP32(r0, SCR)
- orr r0, r0, #0x100 /* Set HCE */
- orr r0, r0, #0xb1 /* Set SCD, AW, FW and NS */
- bic r0, r0, #0xe /* Clear EA, FIQ and IRQ */
- mcr CP32(r0, SCR)
-
- ldr r2, =MACH_TYPE_SMDK5250 /* r4 := Arndale machine ID */
- /* By default load Arndale defaults values */
- ldr r0, =EXYNOS5_TIMER_FREQUENCY /* r0 := timer's frequency */
- ldr r1, =EXYNOS5_GIC_BASE_ADDRESS /* r1 := GIC base address */
- /* If it's not the Arndale machine ID, load VE values */
- teq r5, r2
- ldrne r0, =V2M_TIMER_FREQUENCY
- ldrne r1, =V2M_GIC_BASE_ADDRESS
-
- /* Ugly: the system timer's frequency register is only
- * programmable in Secure state. Since we don't know where its
- * memory-mapped control registers live, we can't find out the
- * right frequency. */
- mcr CP32(r0, CNTFRQ)
-
- mrc CP32(r0,NSACR)
- ldr r4, =0x3fff /* Allow access to all co-processors in NS mode */
- orr r0, r0, r4
- orr r0, r0, #(1<<18) /* CA7/CA15: Allow access to ACTLR.SMP in NS mode */
- mcr CP32(r0, NSACR)
-
- add r0, r1, #GIC_DR_OFFSET
- /* Disable the GIC distributor, on the boot CPU only */
- mov r4, #0
- teq r12, #0 /* Is this the boot CPU? */
- streq r4, [r0]
- /* Continuing ugliness: Set up the GIC so NS state owns interrupts,
- * The first 32 interrupts (SGIs & PPIs) must be configured on all
- * CPUs while the remainder are SPIs and only need to be done one, on
- * the boot CPU. */
- add r0, r0, #0x80 /* GICD_IGROUP0 */
- mov r2, #0xffffffff /* All interrupts to group 1 */
- str r2, [r0] /* Interrupts 0-31 (SGI & PPI) */
- teq r12, #0 /* Boot CPU? */
- bne skip_spis /* Don't route SPIs on secondary CPUs */
-
- add r4, r1, #GIC_DR_OFFSET
- ldr r4, [r4, #4] /* r4 := Interrupt Controller Type Reg */
- and r4, r4, #GICD_TYPE_LINES /* r4 := number of SPIs */
-1: teq r4, #0
- beq skip_spis
- add r0, r0, #4 /* Go to the new group */
- str r2, [r0] /* Update the group */
- sub r4, r4, #1
- b 1b
-skip_spis:
- /* Disable the GIC CPU interface on all processors */
- add r0, r1, #GIC_CR_OFFSET
- mov r1, #0
- str r1, [r0]
- /* Must drop priority mask below 0x80 before entering NS state */
- ldr r1, =0xff
- str r1, [r0, #0x4] /* -> GICC_PMR */
- /* Reset a few config registers */
- mov r0, #0
- mcr CP32(r0, FCSEIDR)
- mcr CP32(r0, CONTEXTIDR)
-
- mrs r0, cpsr /* Copy the CPSR */
- add r0, r0, #0x4 /* 0x16 (Monitor) -> 0x1a (Hyp) */
- msr spsr_cxsf, r0 /* into the SPSR */
- movs pc, r3 /* Exception-return into Hyp mode */
-
-/*
- * Local variables:
- * mode: ASM
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
index 30fb480..5d28bad 100644
--- a/xen/arch/arm/arm64/Makefile
+++ b/xen/arch/arm/arm64/Makefile
@@ -1,7 +1,6 @@
subdir-y += lib
obj-y += entry.o
-obj-y += mode_switch.o
obj-y += traps.o
obj-y += domain.o
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 7cecac3..b327770 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -33,6 +33,41 @@
#include EARLY_PRINTK_INC
#endif
+/*
+ * Common register usage in this file:
+ * x0 -
+ * x1 -
+ * x2 -
+ * x3 -
+ * x4 -
+ * x5 -
+ * x6 -
+ * x7 -
+ * x8 -
+ * x9 -
+ * x10 -
+ * x11 -
+ * x12 -
+ * x13 -
+ * x14 -
+ * x15 -
+ * x16 -
+ * x17 -
+ * x18 -
+ * x19 - paddr(start)
+ * x20 - phys offset
+ * x21 - DTB address (boot cpu only)
+ * x22 - is_secondary_cpu
+ * x23 - UART address
+ * x24 - cpuid
+ * x25 -
+ * x26 -
+ * x27 -
+ * x28 -
+ * x29 -
+ * x30 - lr
+ */
+
/* Macro to print a string to the UART, if there is one.
* Clobbers x0-x3. */
#ifdef EARLY_PRINTK
@@ -65,7 +100,6 @@
.global start
start:
-GLOBAL(init_secondary) /* currently unused */
/*
* DO NOT MODIFY. Image header expected by Linux boot-loaders.
*/
@@ -100,69 +134,73 @@ real_start:
add x21, x21, x20 /* x21 := paddr(DTB) */
#endif
- /* Are we the boot CPU? */
- mov x22, #0 /* x22 := CPU ID */
+ mov x22, #0 /* x22 := is_secondary_cpu */
+
+ b common_start
+
+GLOBAL(init_secondary)
+ msr DAIFSet, 0xf /* Disable all interrupts */
+
+ /* Find out where we are */
+ ldr x0, =start
+ adr x19, start /* x19 := paddr (start) */
+ sub x20, x19, x0 /* x20 := phys-offset */
+
+ mov x22, #1 /* x22 := is_secondary_cpu */
+
+common_start:
+ mov x24, #0 /* x24 := CPU ID. Initialy zero until we
+ * find that multiprocessor extensions are
+ * present and the system is SMP */
mrs x0, mpidr_el1
- tbz x0, 31, boot_cpu /* Multiprocessor extension supported? */
- tbnz x0, 30, boot_cpu /* Uniprocessor system? */
+ tbz x0, 31, 1f /* Multiprocessor extension not supported? */
+ tbnz x0, 30, 1f /* Uniprocessor system? */
mov x13, #(0xff << 24)
- bics x22, x0, x13 /* Mask out flags to get CPU ID */
- b.eq boot_cpu /* If we're CPU 0, boot now */
-
- /* Non-boot CPUs wait here to be woken up one at a time. */
-1: dsb sy
- ldr x0, =smp_up_cpu /* VA of gate */
- add x0, x0, x20 /* PA of gate */
- ldr x1, [x0] /* Which CPU is being booted? */
- cmp x1, x22 /* Is it us? */
- b.eq 2f
+ bic x24, x0, x13 /* Mask out flags to get CPU ID */
+1:
+
+ /* Non-boot CPUs wait here until __cpu_up is ready for them */
+ cbz x22, 1f
+
+ ldr x0, =smp_up_cpu
+ add x0, x0, x20 /* Apply physical offset */
+ dsb sy
+2: ldr x1, [x0]
+ cmp x1, x24
+ beq 1f
wfe
- b 1b
-2:
+ b 2b
+1:
-boot_cpu:
#ifdef EARLY_PRINTK
ldr x23, =EARLY_UART_BASE_ADDRESS /* x23 := UART base address */
cbnz x22, 1f
-#ifdef EARLY_PRINTK_INIT_UART
- bl init_uart /* CPU 0 sets up the UART too */
-#endif
+ bl init_uart /* Boot CPU sets up the UART too */
1: PRINT("- CPU ")
- mov x0, x22
+ mov x0, x24
bl putn
PRINT(" booting -\r\n")
#endif
PRINT("- Current EL ")
- mrs x0, CurrentEL
+ mrs x4, CurrentEL
+ mov x0, x4
bl putn
PRINT(" -\r\n")
- /* Are we in EL3 */
- mrs x0, CurrentEL
- cmp x0, #PSR_MODE_EL3t
- ccmp x0, #PSR_MODE_EL3h, #0x4, ne
- b.eq 1f /* Yes */
-
/* Are we in EL2 */
- cmp x0, #PSR_MODE_EL2t
- ccmp x0, #PSR_MODE_EL2h, #0x4, ne
- b.eq 2f /* Yes */
+ cmp x4, #PSR_MODE_EL2t
+ ccmp x4, #PSR_MODE_EL2h, #0x4, ne
+ b.eq el2 /* Yes */
- /* Otherwise, it must have been EL0 or EL1 */
- PRINT("- CPU is not in EL3 or EL2 -\r\n")
- b fail
+ /* OK, we're boned. */
+ PRINT("- Xen must be entered in NS EL2 mode -\r\n" \
+ "- Please update the bootloader -\r\n")
+ b fail
-1: PRINT("- Started in EL3 -\r\n- Entering EL2 -\r\n")
- ldr x1, =enter_el2_mode /* VA of function */
- add x1, x1, x20 /* PA of function */
- adr x30, el2 /* Set return address for call */
- br x1 /* Call function */
+el2: PRINT("- Xen starting at EL2 -\r\n")
-2: PRINT("- Started in EL2 mode -\r\n")
-
-el2:
/* Zero BSS On the boot CPU to avoid nasty surprises */
cbnz x22, skip_bss
@@ -177,9 +215,10 @@ el2:
b.lo 1b
skip_bss:
-
PRINT("- Setting up control registers -\r\n")
+ /* XXXX call PROCINFO_cpu_init here */
+
/* Set up memory attribute type tables */
ldr x0, =MAIRVAL
msr mair_el2, x0
@@ -193,7 +232,7 @@ skip_bss:
ldr x0, =0x80802500
msr tcr_el2, x0
- /* Set up the HSCTLR:
+ /* Set up the SCTLR_EL2:
* Exceptions in LE ARM,
* Low-latency IRQs disabled,
* Write-implies-XN disabled (for now),
@@ -204,69 +243,90 @@ skip_bss:
ldr x0, =(HSCTLR_BASE|SCTLR_A)
msr SCTLR_EL2, x0
- /* Write Xen's PT's paddr into the HTTBR */
+ /* Rebuild the boot pagetable's first-level entries. The structure
+ * is described in mm.c.
+ *
+ * After the CPU enables paging it will add the fixmap mapping
+ * to these page tables, however this may clash with the 1:1
+ * mapping. So each CPU must rebuild the page tables here with
+ * the 1:1 in place. */
+
+ /* Write Xen's PT's paddr into TTBR0_EL2 */
ldr x4, =boot_pgtable
- add x4, x4, x20 /* x4 := paddr (xen_pagetable) */
+ add x4, x4, x20 /* x4 := paddr (boot_pagetable) */
msr TTBR0_EL2, x4
- /* Non-boot CPUs don't need to rebuild the pagetable */
- cbnz x22, pt_ready
-
+ /* Setup boot_pgtable: */
ldr x1, =boot_first
- add x1, x1, x20 /* x1 := paddr (xen_first) */
- mov x3, #PT_PT /* x2 := table map of xen_first */
- orr x2, x1, x3 /* (+ rights for linear PT) */
- str x2, [x4, #0] /* Map it in slot 0 */
+ add x1, x1, x20 /* x1 := paddr (boot_first) */
- mov x4, x1 /* Next level into xen_first */
+ /* ... map boot_first in boot_pgtable[0] */
+ mov x3, #PT_PT /* x2 := table map of boot_first */
+ orr x2, x1, x3 /* + rights for linear PT */
+ str x2, [x4, #0] /* Map it in slot 0 */
- /* console fixmap */
- ldr x1, =xen_fixmap
- add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
- lsr x2, x23, #12
- lsl x2, x2, #12 /* 4K aligned paddr of UART */
- mov x3, #PT_DEV_L3
- orr x2, x2, x3 /* x2 := 4K dev map including UART */
- str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+ /* ... map of paddr(start) in boot_pgtable */
+ lsr x1, x19, #39 /* Offset of base paddr in boot_pgtable */
+ cbz x1, 1f /* It's in slot 0, map in boot_first
+ * or boot_second later on */
- /* Build the baseline idle pagetable's first-level entries */
- ldr x1, =xen_second
- add x1, x1, x20 /* x1 := paddr (xen_second) */
- mov x3, #PT_PT /* x2 := table map of xen_second */
- orr x2, x1, x3 /* (+ rights for linear PT) */
+ lsl x2, x1, #39 /* Base address for 512GB mapping */
+ mov x3, #PT_MEM /* x2 := Section mapping */
+ orr x2, x2, x3
+ lsl x1, x1, #3 /* x1 := Slot offset */
+ str x2, [x4, x1] /* Mapping of paddr(start)*/
+
+1: /* Setup boot_first: */
+ ldr x4, =boot_first /* Next level into boot_first */
+ add x4, x4, x20 /* x4 := paddr(boot_first) */
+
+ /* ... map boot_second in boot_first[0] */
+ ldr x1, =boot_second
+ add x1, x1, x20 /* x1 := paddr(boot_second) */
+ mov x3, #PT_PT /* x2 := table map of boot_first */
+ orr x2, x1, x3 /* + rights for linear PT */
str x2, [x4, #0] /* Map it in slot 0 */
- add x2, x2, #0x1000
- str x2, [x4, #8] /* Map 2nd page in slot 1 */
- add x2, x2, #0x1000
- str x2, [x4, #16] /* Map 3rd page in slot 2 */
- add x2, x2, #0x1000
- str x2, [x4, #24] /* Map 4th page in slot 3 */
-
- /* Now set up the second-level entries */
- mov x3, #PT_MEM
- orr x2, x19, x3 /* x2 := 2MB normal map of Xen */
- orr x4, xzr, x19, lsr #18
- str x2, [x1, x4] /* Map Xen there */
- ldr x4, =start
- lsr x4, x4, #18 /* Slot for vaddr(start) */
- str x2, [x1, x4] /* Map Xen there too */
-
- /* xen_fixmap pagetable */
- ldr x2, =xen_fixmap
- add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
- mov x3, #PT_PT
- orr x2, x2, x3 /* x2 := table map of xen_fixmap */
- add x4, x4, #8
- str x2, [x1, x4] /* Map it in the fixmap's slot */
- lsr x2, x21, #21
- lsl x2, x2, #21 /* 2MB-aligned paddr of DTB */
- mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
+ /* ... map of paddr(start) in boot_first */
+ lsr x2, x19, #30 /* x2 := Offset of base paddr in boot_first */
+ and x1, x2, 0x1ff /* x1 := Slot to use */
+ cbz x1, 1f /* It's in slot 0, map in boot_second */
+
+ lsl x2, x2, #30 /* Base address for 1GB mapping */
+ mov x3, #PT_MEM /* x2 := Section map */
orr x2, x2, x3
- add x4, x4, #8
- str x2, [x1, x4] /* Map it in the early boot slot */
+ lsl x1, x1, #3 /* x1 := Slot offset */
+ str x2, [x4, x1] /* Create mapping of paddr(start)*/
+
+1: /* Setup boot_second: */
+ ldr x4, =boot_second
+ add x4, x4, x20 /* x4 := paddr (boot_second) */
+
+ lsr x2, x19, #20 /* Base address for 2MB mapping */
+ lsl x2, x2, #20
+ mov x3, #PT_MEM /* x2 := Section map */
+ orr x2, x2, x3
+
+ /* ... map of vaddr(start) in boot_second */
+ ldr x1, =start
+ lsr x1, x1, #18 /* Slot for vaddr(start) */
+ str x2, [x4, x1] /* Map vaddr(start) */
+
+ /* ... map of paddr(start) in boot_second */
+ lsr x1, x19, #30 /* Base paddr */
+ cbnz x1, 1f /* If paddr(start) is not in slot 0
+ * then the mapping was done in
+ * boot_pgtable or boot_first above */
+
+ lsr x1, x19, #18 /* Slot for paddr(start) */
+ str x2, [x4, x1] /* Map Xen there */
+1:
+
+ /* Defer fixmap and dtb mapping until after paging enabled, to
+ * avoid them clashing with the 1:1 mapping. */
+
+ /* boot pagetable setup complete */
-pt_ready:
PRINT("- Turning on paging -\r\n")
ldr x1, =paging /* Explicit vaddr, not RIP-relative */
@@ -279,17 +339,60 @@ pt_ready:
br x1 /* Get a proper vaddr into PC */
paging:
+ /* Now we can install the fixmap and dtb mappings, since we
+ * don't need the 1:1 map any more */
+ dsb sy
+#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
+ /* Non-boot CPUs don't need to rebuild the fixmap itself, just
+ * the mapping from boot_second to xen_fixmap */
+ cbnz x22, 1f
+
+ /* Add UART to the fixmap table */
+ ldr x1, =xen_fixmap
+ add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
+ lsr x2, x23, #12
+ lsl x2, x2, #12 /* 4K aligned paddr of UART */
+ mov x3, #PT_DEV_L3
+ orr x2, x2, x3 /* x2 := 4K dev map including UART */
+ str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+1:
+
+ /* Map fixmap into boot_second */
+ ldr x4, =boot_second /* x4 := vaddr (boot_second) */
+ ldr x2, =xen_fixmap
+ add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
+ mov x3, #PT_PT
+ orr x2, x2, x3 /* x2 := table map of xen_fixmap */
+ ldr x1, =FIXMAP_ADDR(0)
+ lsr x1, x1, #18 /* x1 := Slot for FIXMAP(0) */
+ str x2, [x4, x1] /* Map it in the fixmap's slot */
+
/* Use a virtual address to access the UART. */
ldr x23, =FIXMAP_ADDR(FIXMAP_CONSOLE)
+#endif
+
+ /* Map the DTB in the boot misc slot */
+ cbnz x22, 1f /* Only on boot CPU */
+
+ lsr x2, x21, #21
+ lsl x2, x2, #21 /* x2 := 2MB-aligned paddr of DTB */
+ mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
+ orr x2, x2, x3
+ ldr x1, =BOOT_MISC_VIRT_START
+ lsr x1, x1, #18 /* x4 := Slot for BOOT_MISC_VIRT_START */
+ str x2, [x4, x1] /* Map it in the early boot slot */
+ dsb sy
+1:
PRINT("- Ready -\r\n")
/* The boot CPU should go straight into C now */
cbz x22, launch
- /* Non-boot CPUs need to move on to the relocated pagetables */
- ldr x4, =boot_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
- add x4, x4, x20 /* PA of it */
+ /* Non-boot CPUs need to move on to the proper pagetables, which were
+ * setup in init_secondary_pagetables. */
+
+ ldr x4, =init_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
ldr x4, [x4] /* Actual value */
dsb sy
msr TTBR0_EL2, x4
@@ -299,28 +402,6 @@ paging:
dsb sy /* Ensure completion of TLB flush */
isb
- /* Non-boot CPUs report that they've got this far */
- ldr x0, =ready_cpus
-1: ldaxr x1, [x0] /* { read # of ready CPUs } */
- add x1, x1, #1 /* Atomically { ++ } */
- stlxr w2, x1, [x0] /* { writeback } */
- cbnz w2, 1b
- dsb sy
- dc cvac, x0 /* Flush D-Cache */
- dsb sy
-
- /* Here, the non-boot CPUs must wait again -- they're now running on
- * the boot CPU's pagetables so it's safe for the boot CPU to
- * overwrite the non-relocated copy of Xen. Once it's done that,
- * and brought up the memory allocator, non-boot CPUs can get their
- * own stacks and enter C. */
-1: wfe
- dsb sy
- ldr x0, =smp_up_cpu
- ldr x1, [x0] /* Which CPU is being booted? */
- cmp x1, x22 /* Is it us? */
- b.ne 1b
-
launch:
ldr x0, =init_data
add x0, x0, #INITINFO_stack /* Find the boot-time stack */
@@ -331,7 +412,7 @@ launch:
mov x0, x20 /* Marshal args: - phys_offset */
mov x1, x21 /* - FDT */
- mov x2, x22 /* - CPU ID */
+ mov x2, x24 /* - CPU ID */
cbz x22, start_xen /* and disappear into the land of C */
b start_secondary /* (to the appropriate entry point) */
@@ -341,13 +422,80 @@ fail: PRINT("- Boot failed -\r\n")
1: wfe
b 1b
-#ifdef EARLY_PRINTK
+/* Copy Xen to new location and switch TTBR
+ * x0 ttbr
+ * x1 source address
+ * x2 destination address
+ * x3 length
+ *
+ * Source and destination must be word aligned, length is rounded up
+ * to a 16 byte boundary.
+ *
+ * MUST BE VERY CAREFUL when saving things to RAM over the copy */
+ENTRY(relocate_xen)
+ /* Copy 16 bytes at a time using:
+ * x9: counter
+ * x10: data
+ * x11: data
+ * x12: source
+ * x13: destination
+ */
+ mov x9, x3
+ mov x12, x1
+ mov x13, x2
+1: ldp x10, x11, [x12], #16
+ stp x10, x11, [x13], #16
+
+ subs x9, x9, #16
+ bgt 1b
+
+ /* Flush destination from dcache using:
+ * x9: counter
+ * x10: step
+ * x11: vaddr
+ */
+ dsb sy /* So the CPU issues all writes to the range */
+
+ mov x9, x3
+ ldr x10, =cacheline_bytes /* x10 := step */
+ ldr x10, [x10]
+ mov x11, x2
+
+1: dc cvac, x11
+
+ add x11, x11, x10
+ subs x9, x9, x10
+ bgt 1b
+
+ dsb sy /* Ensure the flushes happen before
+ * continuing */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ tlbi alle2 /* Flush hypervisor TLB */
+ ic iallu /* Flush I-cache */
+ dsb sy /* Ensure completion of TLB flush */
+ isb
+
+ msr TTBR0_EL2, x0
+
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ tlbi alle2 /* Flush hypervisor TLB */
+ ic iallu /* Flush I-cache */
+ dsb sy /* Ensure completion of TLB flush */
+ isb
+
+ ret
+
+#ifdef EARLY_PRINTK
/* Bring up the UART.
* x23: Early UART base address
* Clobbers x0-x1 */
init_uart:
+#ifdef EARLY_PRINTK_INIT_UART
early_uart_init x23, 0
+#endif
adr x0, 1f
b puts
1: .asciz "- UART enabled -\r\n"
diff --git a/xen/arch/arm/arm64/mode_switch.S b/xen/arch/arm/arm64/mode_switch.S
deleted file mode 100644
index ea64f22..0000000
--- a/xen/arch/arm/arm64/mode_switch.S
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * xen/arch/arm/arm64/mode_switch.S
- *
- * Start-of day code to take a CPU from EL3 to EL2. Largely taken from
- * bootwrapper.
- *
- * Ian Campbell <ian.campbell@citrix.com>
- * Copyright (c) 2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <asm/config.h>
-#include <asm/page.h>
-#include <asm/asm_defns.h>
-#include <asm/platforms/vexpress.h>
-
-/* Get up a CPU into EL2. Clobbers x0-x3.
- *
- * Expects x22 == CPU number
- * Expects x30 == EL2 entry point
- *
- * This code is specific to the VE model, and not intended to be used
- * on production systems. As such it's a bit hackier than the main
- * boot code in head.S. In future it will be replaced by better
- * integration with the bootloader/firmware so that Xen always starts
- * at EL2.
- */
-GLOBAL(enter_el2_mode)
- mov x0, #0x30 // RES1
- orr x0, x0, #(1 << 0) // Non-secure EL1
- orr x0, x0, #(1 << 8) // HVC enable
- orr x0, x0, #(1 << 10) // 64-bit EL2
- msr scr_el3, x0
-
- msr cptr_el3, xzr // Disable copro. traps to EL3
-
- ldr x0, =0x01800000 // 24Mhz
- msr cntfrq_el0, x0
-
- /*
- * Check for the primary CPU to avoid a race on the distributor
- * registers.
- */
- cbnz x22, 1f
-
- ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET) // GICD_CTLR
- mov w0, #3 // EnableGrp0 | EnableGrp1
- str w0, [x1]
-
-1: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET+0x80) // GICD_IGROUPR
- mov w0, #~0 // Grp1 interrupts
- str w0, [x1], #4
- b.ne 2f // Only local interrupts for secondary CPUs
- str w0, [x1], #4
- str w0, [x1], #4
-
-2: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_CR_OFFSET) // GICC_CTLR
- ldr w0, [x1]
- mov w0, #3 // EnableGrp0 | EnableGrp1
- str w0, [x1]
-
- mov w0, #1 << 7 // allow NS access to GICC_PMR
- str w0, [x1, #4] // GICC_PMR
-
- msr sctlr_el2, xzr
-
- /*
- * Prepare the switch to the EL2_SP1 mode from EL3
- */
- msr elr_el3, x30 // Return to desired function
- mov x1, #0x3c9 // EL2_SP1 | D | A | I | F
- msr spsr_el3, x1
- eret
-
-/*
- * Local variables:
- * mode: ASM
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 3d7b2f5..701bc2e 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -43,40 +43,70 @@
struct domain *dom_xen, *dom_io, *dom_cow;
-/* Static start-of-day pagetables that we use before the
- * allocators are up. These go on to become the boot CPU's real pagetables.
+/* Static start-of-day pagetables that we use before the allocators
+ * are up. These are used by all CPUs during bringup before switching
+ * to the CPUs own pagetables.
+ *
+ * These pagetables have a very simple structure. They include:
+ * - a 2MB mapping of xen at XEN_VIRT_START, boot_first and
+ * boot_second are used to populate the trie down to that mapping.
+ * - a 1:1 mapping of xen at its current physical address. This uses a
+ * section mapping at whichever of boot_{pgtable,first,second}
+ * covers that physical address.
+ *
+ * For the boot CPU these mappings point to the address where Xen was
+ * loaded by the bootloader. For secondary CPUs they point to the
+ * relocated copy of Xen for the benefit of secondary CPUs.
+ *
+ * In addition to the above for the boot CPU the device-tree is
+ * initially mapped in the boot misc slot. This mapping is not present
+ * for secondary CPUs.
+ *
+ * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped
+ * by the CPU once it has moved off the 1:1 mapping.
*/
lpae_t boot_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
#ifdef CONFIG_ARM_64
lpae_t boot_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-/* The first page of the first level mapping of the xenheap. The
- * subsequent xenheap first level pages are dynamically allocated, but
- * we need this one to bootstrap ourselves. */
-lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-/* The zeroeth level slot which uses xenheap_first_first. Used because
- * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
- * valid for a non-xenheap mapping. */
-static __initdata int xenheap_first_first_slot = -1;
#endif
+lpae_t boot_second[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+
+/* Main runtime page tables */
/*
- * xen_pgtable and xen_dommap are per-PCPU and are allocated before
- * bringing up each CPU. On 64-bit a first level table is also allocated.
+ * For arm32 xen_pgtable and xen_dommap are per-PCPU and are allocated before
+ * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs.
*
- * xen_second, xen_fixmap and xen_xenmap are shared between all PCPUs.
+ * xen_second, xen_fixmap and xen_xenmap are always shared between all
+ * PCPUs.
*/
#ifdef CONFIG_ARM_64
-#define THIS_CPU_PGTABLE boot_pgtable
+lpae_t xen_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+lpae_t xen_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+#define THIS_CPU_PGTABLE xen_pgtable
#else
/* Per-CPU pagetable pages */
/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */
static DEFINE_PER_CPU(lpae_t *, xen_pgtable);
#define THIS_CPU_PGTABLE this_cpu(xen_pgtable)
/* xen_dommap == pages used by map_domain_page, these pages contain
- * the second level pagetables which mapp the domheap region
+ * the second level pagetables which map the domheap region
* DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */
static DEFINE_PER_CPU(lpae_t *, xen_dommap);
+/* Root of the trie for cpu0 */
+lpae_t cpu0_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+#endif
+
+#ifdef CONFIG_ARM_64
+/* The first page of the first level mapping of the xenheap. The
+ * subsequent xenheap first level pages are dynamically allocated, but
+ * we need this one to bootstrap ourselves. */
+lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+/* The zeroeth level slot which uses xenheap_first_first. Used because
+ * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
+ * valid for a non-xenheap mapping. */
+static __initdata int xenheap_first_first_slot = -1;
#endif
/* Common pagetable leaves */
@@ -104,9 +134,8 @@ lpae_t xen_fixmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
* as appropriate. */
static lpae_t xen_xenmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-
/* Non-boot CPUs use this to find the correct pagetables. */
-uint64_t boot_ttbr;
+uint64_t init_ttbr;
static paddr_t phys_offset;
@@ -131,6 +160,12 @@ static inline void check_memory_layout_alignment_constraints(void) {
BUILD_BUG_ON(BOOT_MISC_VIRT_START & ~SECOND_MASK);
/* 1GB aligned regions */
BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK);
+ /* Page table structure constraints */
+#ifdef CONFIG_ARM_64
+ BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
+#endif
+ BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
+ BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= LPAE_ENTRIES);
#ifdef CONFIG_DOMAIN_PAGE
BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
#endif
@@ -361,16 +396,6 @@ void __cpuinit setup_virt_paging(void)
WRITE_SYSREG32(0x80002558, VTCR_EL2); isb();
}
-/* This needs to be a macro to stop the compiler spilling to the stack
- * which will change when we change pagetables */
-#define WRITE_TTBR(ttbr) \
- flush_xen_text_tlb(); \
- WRITE_SYSREG64(ttbr, TTBR0_EL2); \
- dsb(); /* ensure memory accesses do not cross over the TTBR0 write */ \
- /* flush_xen_text_tlb contains an initial isb which ensures the \
- * write to TTBR0 has completed. */ \
- flush_xen_text_tlb()
-
static inline lpae_t pte_of_xenaddr(vaddr_t va)
{
paddr_t ma = va + phys_offset;
@@ -378,69 +403,73 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va)
return mfn_to_xen_entry(mfn);
}
+extern void relocate_xen(uint64_t ttbr, void *src, void *dst, size_t len);
+
/* Boot-time pagetable setup.
* Changes here may need matching changes in head.S */
void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
{
+ uint64_t ttbr;
unsigned long dest_va;
lpae_t pte, *p;
int i;
- /* Map the destination in the boot misc area. */
- dest_va = BOOT_MISC_VIRT_START;
- pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
- write_pte(xen_second + second_table_offset(dest_va), pte);
- flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
-
/* Calculate virt-to-phys offset for the new location */
phys_offset = xen_paddr - (unsigned long) _start;
- /* Copy */
- memcpy((void *) dest_va, _start, _end - _start);
-
- /* Beware! Any state we modify between now and the PT switch may be
- * discarded when we switch over to the copy. */
-
- /* Update the copy of boot_pgtable to use the new paddrs */
- p = (void *) boot_pgtable + dest_va - (unsigned long) _start;
#ifdef CONFIG_ARM_64
- p[0].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
- p = (void *) boot_first + dest_va - (unsigned long) _start;
+ p = (void *) xen_pgtable;
+ p[0] = pte_of_xenaddr((uintptr_t)xen_first);
+ p[0].pt.table = 1;
+ p[0].pt.xn = 0;
+ p = (void *) xen_first;
+#else
+ p = (void *) cpu0_pgtable;
#endif
- for ( i = 0; i < 4; i++)
- p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
- p = (void *) xen_second + dest_va - (unsigned long) _start;
- if ( boot_phys_offset != 0 )
+ /* Initialise first level entries, to point to second level entries */
+ for ( i = 0; i < 4; i++)
{
- /* Remove the old identity mapping of the boot paddr */
- vaddr_t va = (vaddr_t)_start + boot_phys_offset;
- p[second_linear_offset(va)].bits = 0;
+ p[i] = pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
+ p[i].pt.table = 1;
+ p[i].pt.xn = 0;
}
- for ( i = 0; i < 4 * LPAE_ENTRIES; i++)
- if ( p[i].pt.valid )
- p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
-
- /* Change pagetables to the copy in the relocated Xen */
- boot_ttbr = (uintptr_t) boot_pgtable + phys_offset;
- flush_xen_dcache(boot_ttbr);
- flush_xen_dcache_va_range((void*)dest_va, _end - _start);
- WRITE_TTBR(boot_ttbr);
+ /* Initialise xen second level entries ... */
+ /* ... Xen's text etc */
- /* Undo the temporary map */
- pte.bits = 0;
- write_pte(xen_second + second_table_offset(dest_va), pte);
- flush_xen_text_tlb();
+ pte = mfn_to_xen_entry(xen_paddr>>PAGE_SHIFT);
+ pte.pt.xn = 0;/* Contains our text mapping! */
+ xen_second[second_table_offset(XEN_VIRT_START)] = pte;
- /* Link in the fixmap pagetable */
+ /* ... Fixmap */
pte = pte_of_xenaddr((vaddr_t)xen_fixmap);
pte.pt.table = 1;
- write_pte(xen_second + second_table_offset(FIXMAP_ADDR(0)), pte);
- /*
- * No flush required here. Individual flushes are done in
- * set_fixmap as entries are used.
- */
+ xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte;
+
+ /* Map the destination in the boot misc area. */
+ dest_va = BOOT_MISC_VIRT_START;
+ pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
+ write_pte(boot_second + second_table_offset(dest_va), pte);
+ flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
+#ifdef CONFIG_ARM_64
+ ttbr = (uintptr_t) xen_pgtable + phys_offset;
+#else
+ ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
+#endif
+
+ relocate_xen(ttbr, _start, (void*)dest_va, _end - _start);
+
+ /* Clear the copy of the boot pagetables. Each secondary CPU
+ * rebuilds these itself (see head.S) */
+ memset(boot_pgtable, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_pgtable);
+#ifdef CONFIG_ARM_64
+ memset(boot_pgtable, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_first);
+#endif
+ memset(boot_second, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_second);
/* Break up the Xen mapping into 4k pages and protect them separately. */
for ( i = 0; i < LPAE_ENTRIES; i++ )
@@ -461,6 +490,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
write_pte(xen_xenmap + i, pte);
/* No flush required here as page table is not hooked in yet. */
}
+
pte = pte_of_xenaddr((vaddr_t)xen_xenmap);
pte.pt.table = 1;
write_pte(xen_second + second_linear_offset(XEN_VIRT_START), pte);
@@ -472,7 +502,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
flush_xen_text_tlb();
#ifdef CONFIG_ARM_32
- per_cpu(xen_pgtable, 0) = boot_pgtable;
+ per_cpu(xen_pgtable, 0) = cpu0_pgtable;
per_cpu(xen_dommap, 0) = xen_second +
second_linear_offset(DOMHEAP_VIRT_START);
@@ -483,10 +513,14 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
DOMHEAP_SECOND_PAGES*PAGE_SIZE);
#endif
}
+
#ifdef CONFIG_ARM_64
int init_secondary_pagetables(int cpu)
{
- /* All CPUs share a single page table on 64 bit */
+ /* Set init_ttbr for this CPU coming up. All CPus share a single setof
+ * pagetables, but rewrite it each time for consistency with 32 bit. */
+ init_ttbr = (uintptr_t) xen_pgtable + phys_offset;
+ flush_xen_dcache(init_ttbr);
return 0;
}
#else
@@ -507,7 +541,7 @@ int init_secondary_pagetables(int cpu)
}
/* Initialise root pagetable from root of boot tables */
- memcpy(first, boot_pgtable, PAGE_SIZE);
+ memcpy(first, cpu0_pgtable, PAGE_SIZE);
/* Ensure the domheap has no stray mappings */
memset(domheap, 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE);
@@ -527,6 +561,10 @@ int init_secondary_pagetables(int cpu)
per_cpu(xen_pgtable, cpu) = first;
per_cpu(xen_dommap, cpu) = domheap;
+ /* Set init_ttbr for this CPU coming up */
+ init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
+ flush_xen_dcache(init_ttbr);
+
return 0;
}
#endif
@@ -534,12 +572,6 @@ int init_secondary_pagetables(int cpu)
/* MMU setup for secondary CPUS (which already have paging enabled) */
void __cpuinit mmu_init_secondary_cpu(void)
{
- uint64_t ttbr;
-
- /* Change to this CPU's pagetables */
- ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
- WRITE_TTBR(ttbr);
-
/* From now on, no mapping may be both writable and executable. */
WRITE_SYSREG32(READ_SYSREG32(SCTLR_EL2) | SCTLR_WXN, SCTLR_EL2);
flush_xen_text_tlb();
@@ -612,7 +644,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
while ( base_mfn < end_mfn )
{
int slot = zeroeth_table_offset(vaddr);
- lpae_t *p = &boot_pgtable[slot];
+ lpae_t *p = &xen_pgtable[slot];
if ( p->pt.valid )
{
@@ -679,7 +711,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
{
pte = mfn_to_xen_entry(second_base + i);
pte.pt.table = 1;
- write_pte(&boot_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
+ write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
}
create_32mb_mappings(second, 0, base_mfn, frametable_size >> PAGE_SHIFT);
#else
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 07338e1..a943dc8 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -518,7 +518,7 @@ void __init setup_cache(void)
* MPIDR values related to logical cpus
* Code base on Linux arch/arm/kernel/devtree.c
*/
-static void __init init_cpus_maps(void)
+static void __init smp_init_cpus(void)
{
register_t mpidr;
struct dt_device_node *cpus = dt_find_node_by_path("/cpus");
@@ -530,6 +530,14 @@ static void __init init_cpus_maps(void)
[0 ... NR_CPUS - 1] = MPIDR_INVALID
};
bool_t bootcpu_valid = 0;
+ int rc;
+
+ if ( (rc = arch_smp_init()) < 0 )
+ {
+ printk(XENLOG_WARNING "SMP init failed (%d)\n"
+ "Using only 1 CPU\n", rc);
+ return;
+ }
mpidr = boot_cpu_data.mpidr.bits & MPIDR_HWID_MASK;
@@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
}
}
+ if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
+ {
+ printk("cpu init failed (hwid %x): %d\n", hwid, rc);
+ continue;
+ }
+
/*
* Build a stashed array of MPIDR values. Numbering scheme requires
* that if detected the boot CPU must be assigned logical id 0. Other
@@ -599,7 +613,8 @@ static void __init init_cpus_maps(void)
if ( cpuidx > NR_CPUS )
{
- printk(XENLOG_WARNING "DT /cpu %u node greater than max cores %u, capping them\n",
+ printk(XENLOG_WARNING
+ "DT /cpu %u node greater than max cores %u, capping them\n",
cpuidx, NR_CPUS);
cpuidx = NR_CPUS;
break;
@@ -657,15 +672,14 @@ void __init start_xen(unsigned long boot_phys_offset,
processor_id();
- init_cpus_maps();
- cpus = smp_get_max_cpus();
-
platform_init();
+ smp_init_cpus();
+ cpus = smp_get_max_cpus();
+
init_xen_time();
gic_init();
- make_cpus_ready(cpus, boot_phys_offset);
set_current((struct vcpu *)0xfffff000); /* debug sanity */
idle_vcpu[0] = current;
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index 234748e..7b4ad8a 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -56,12 +56,10 @@ struct init_info __initdata init_data =
};
/* Shared state for coordinating CPU bringup */
-unsigned long smp_up_cpu = 0;
+unsigned long smp_up_cpu = ~0UL;
+/* Shared state for coordinating CPU teardown */
static bool_t cpu_is_dead = 0;
-/* Number of non-boot CPUs ready to enter C */
-unsigned long __initdata ready_cpus = 0;
-
/* ID of the PCPU we're running on */
DEFINE_PER_CPU(unsigned int, cpu_id);
/* XXX these seem awfully x86ish... */
@@ -103,7 +101,6 @@ smp_get_max_cpus (void)
return max_cpus;
}
-
void __init
smp_prepare_cpus (unsigned int max_cpus)
{
@@ -112,32 +109,6 @@ smp_prepare_cpus (unsigned int max_cpus)
setup_cpu_sibling_map(0);
}
-void __init
-make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset)
-{
- unsigned long *gate;
- paddr_t gate_pa;
- int i;
-
- printk("Waiting for %i other CPUs to be ready\n", max_cpus - 1);
- /* We use the unrelocated copy of smp_up_cpu as that's the one the
- * others can see. */
- gate_pa = ((paddr_t) (unsigned long) &smp_up_cpu) + boot_phys_offset;
- gate = map_domain_page(gate_pa >> PAGE_SHIFT) + (gate_pa & ~PAGE_MASK);
- for ( i = 1; i < max_cpus; i++ )
- {
- /* Tell the next CPU to get ready */
- *gate = cpu_logical_map(i);
- flush_xen_dcache(*gate);
- isb();
- sev();
- /* And wait for it to respond */
- while ( ready_cpus < i )
- smp_rmb();
- }
- unmap_domain_page(gate);
-}
-
/* Boot the current CPU */
void __cpuinit start_secondary(unsigned long boot_phys_offset,
unsigned long fdt_paddr,
@@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
wmb();
/* Now report this CPU is up */
+ smp_up_cpu = ~0UL;
cpumask_set_cpu(cpuid, &cpu_online_map);
wmb();
@@ -226,6 +198,8 @@ int __cpu_up(unsigned int cpu)
{
int rc;
+ printk("Bringing up CPU%d\n", cpu);
+
rc = init_secondary_pagetables(cpu);
if ( rc < 0 )
return rc;
@@ -236,14 +210,22 @@ int __cpu_up(unsigned int cpu)
/* Tell the remote CPU what is it's logical CPU ID */
init_data.cpuid = cpu;
- /* Unblock the CPU. It should be waiting in the loop in head.S
- * for an event to arrive when smp_up_cpu matches its cpuid. */
+ /* Open the gate for this CPU */
smp_up_cpu = cpu_logical_map(cpu);
- /* we need to make sure that the change to smp_up_cpu is visible to
- * secondary cpus with D-cache off */
flush_xen_dcache(smp_up_cpu);
- isb();
- sev();
+
+ rc = arch_cpu_up(cpu);
+
+ if ( rc < 0 )
+ {
+ printk("Failed to bring up CPU%d\n", cpu);
+ return rc;
+ }
+
+ /* We don't know the GIC ID of the CPU until it has woken up, so just signal
+ * everyone and rely on our own smp_up_cpu gate to ensure only the one we
+ * want gets through. */
+ send_SGI_allbutself(GIC_SGI_EVENT_CHECK);
while ( !cpu_online(cpu) )
{
@@ -272,7 +254,6 @@ void __cpu_die(unsigned int cpu)
mb();
}
-
/*
* Local variables:
* mode: C
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index 173db1b..188b385 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -147,7 +147,8 @@ extern unsigned long total_pages;
/* Boot-time pagetable setup */
extern void setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr);
-/* Allocate and initialise pagetables for a secondary CPU */
+/* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the
+ * new page table */
extern int __cpuinit init_secondary_pagetables(int cpu);
/* Switch secondary CPUS to its own pagetables and finalise MMU setup */
extern void __cpuinit mmu_init_secondary_cpu(void);
diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
index ee5bdfa..af30608 100644
--- a/xen/include/asm-arm/platforms/exynos5.h
+++ b/xen/include/asm-arm/platforms/exynos5.h
@@ -14,20 +14,6 @@
#define S5P_PA_SYSRAM 0x02020000
-/* Constants below is only used in assembly because the DTS is not yet parsed */
-#ifdef __ASSEMBLY__
-
-/* GIC Base Address */
-#define EXYNOS5_GIC_BASE_ADDRESS 0x10480000
-
-/* Timer's frequency */
-#define EXYNOS5_TIMER_FREQUENCY (24 * 1000 * 1000) /* 24 MHz */
-
-/* Arndale machine ID */
-#define MACH_TYPE_SMDK5250 3774
-
-#endif /* __ASSEMBLY__ */
-
#endif /* __ASM_ARM_PLATFORMS_EXYNOS5_H */
/*
* Local variables:
diff --git a/xen/include/asm-arm/platforms/vexpress.h b/xen/include/asm-arm/platforms/vexpress.h
index 982a293..5cf3aba 100644
--- a/xen/include/asm-arm/platforms/vexpress.h
+++ b/xen/include/asm-arm/platforms/vexpress.h
@@ -32,17 +32,6 @@
int vexpress_syscfg(int write, int function, int device, uint32_t *data);
#endif
-/* Constants below is only used in assembly because the DTS is not yet parsed */
-#ifdef __ASSEMBLY__
-
-/* GIC base address */
-#define V2M_GIC_BASE_ADDRESS 0x2c000000
-
-/* Timer's frequency */
-#define V2M_TIMER_FREQUENCY 0x5f5e100 /* 100 Mhz */
-
-#endif /* __ASSEMBLY__ */
-
#endif /* __ASM_ARM_PLATFORMS_VEXPRESS_H */
/*
* Local variables:
diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h
index 1added5..83add6c 100644
--- a/xen/include/asm-arm/smp.h
+++ b/xen/include/asm-arm/smp.h
@@ -17,12 +17,6 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
extern void stop_cpu(void);
-/* Bring the non-boot CPUs up to paging and ready to enter C.
- * Must be called after Xen is relocated but before the original copy of
- * .text gets overwritten. */
-extern void
-make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset);
-
extern int arch_smp_init(void);
extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
extern int arch_cpu_up(int cpu);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 09/11] xen: arm: use symbolic names for MPIDR bits.
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (7 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 10/11] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-27 10:20 ` [PATCH v3 11/11] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
arm32 already uses MPIDR_HWID_MASK, use it on arm64 too. Add MPIDR_{SMP,UP}
(and bitwise equivalents) and use them.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
---
v4: Use U not UL, otherwise MPIDR_INVALID can be a 64-bit number, but the
register is 32-bit so assigning it to a u32 etc is valid. e.g tmp_map in
init_cpus_map. Avoids -Werror=overflow issues.
v3: Needs to be unsigned, 1<<31 is undefined on arm32 otherwise
---
xen/arch/arm/arm32/head.S | 4 ++--
xen/arch/arm/arm64/head.S | 6 +++---
xen/include/asm-arm/processor.h | 10 ++++++----
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index 946394c..e5cb266 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -127,9 +127,9 @@ common_start:
* find that multiprocessor extensions are
* present and the system is SMP */
mrc CP32(r1, MPIDR)
- tst r1, #(1<<31) /* Multiprocessor extension supported? */
+ tst r1, #MPIDR_SMP /* Multiprocessor extension supported? */
beq 1f
- tst r1, #(1<<30) /* Uniprocessor system? */
+ tst r1, #MPIDR_UP /* Uniprocessor system? */
bne 1f
bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
1:
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index b327770..3dd71af 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -153,10 +153,10 @@ common_start:
* find that multiprocessor extensions are
* present and the system is SMP */
mrs x0, mpidr_el1
- tbz x0, 31, 1f /* Multiprocessor extension not supported? */
- tbnz x0, 30, 1f /* Uniprocessor system? */
+ tbz x0, _MPIDR_SMP, 1f /* Multiprocessor extension not supported? */
+ tbnz x0, _MPIDR_UP, 1f /* Uniprocessor system? */
- mov x13, #(0xff << 24)
+ mov x13, #(~MPIDR_HWID_MASK)
bic x24, x0, x13 /* Mask out flags to get CPU ID */
1:
diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h
index 0646422..5294421 100644
--- a/xen/include/asm-arm/processor.h
+++ b/xen/include/asm-arm/processor.h
@@ -8,11 +8,13 @@
#define MIDR_MASK 0xff0ffff0
/* MPIDR Multiprocessor Affinity Register */
-#define MPIDR_UP (1 << 30)
-#define MPIDR_SMP (1 << 31)
+#define _MPIDR_UP (30)
+#define MPIDR_UP (_AC(1,U) << _MPIDR_UP)
+#define _MPIDR_SMP (31)
+#define MPIDR_SMP (_AC(1,U) << _MPIDR_SMP)
#define MPIDR_AFF0_SHIFT (0)
-#define MPIDR_AFF0_MASK (0xff << MPIDR_AFF0_SHIFT)
-#define MPIDR_HWID_MASK 0xffffff
+#define MPIDR_AFF0_MASK (_AC(0xff,U) << MPIDR_AFF0_SHIFT)
+#define MPIDR_HWID_MASK _AC(0xffffff,U)
#define MPIDR_INVALID (~MPIDR_HWID_MASK)
/* TTBCR Translation Table Base Control Register */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 10/11] xen: arm: configure TCR_EL2 for 40 bit physical address space
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (8 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 09/11] xen: arm: use symbolic names for MPIDR bits Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 11/11] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Tim Deegan <tim@xen.org>
---
xen/arch/arm/arm64/head.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index 3dd71af..40a0ebe 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -224,12 +224,12 @@ skip_bss:
msr mair_el2, x0
/* Set up the HTCR:
- * PASize -- 4G
+ * PASize -- 40 bits / 1TB
* Top byte is used
* PT walks use Outer-Shareable accesses,
* PT walks are write-back, write-allocate in both cache levels,
* Full 64-bit address space goes through this table. */
- ldr x0, =0x80802500
+ ldr x0, =0x80822500
msr tcr_el2, x0
/* Set up the SCTLR_EL2:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 11/11] xen: arm: split cpu0's domheap mapping PTs out from xen_second
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
` (9 preceding siblings ...)
2013-09-27 10:20 ` [PATCH v3 10/11] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
@ 2013-09-27 10:20 ` Ian Campbell
10 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 10:20 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Now that bringup has been rewritten we don't need these 4 contiguous pages for
the 1:1 map. So split them out and only allocate them for 32 bit
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
---
xen/arch/arm/mm.c | 35 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 701bc2e..7e606be 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -94,8 +94,11 @@ static DEFINE_PER_CPU(lpae_t *, xen_pgtable);
* the second level pagetables which map the domheap region
* DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */
static DEFINE_PER_CPU(lpae_t *, xen_dommap);
-/* Root of the trie for cpu0 */
+/* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */
lpae_t cpu0_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+/* cpu0's domheap page tables */
+lpae_t cpu0_dommap[LPAE_ENTRIES*DOMHEAP_SECOND_PAGES]
+ __attribute__((__aligned__(4096*DOMHEAP_SECOND_PAGES)));
#endif
#ifdef CONFIG_ARM_64
@@ -115,19 +118,8 @@ static __initdata int xenheap_first_first_slot = -1;
* The second-level table is 2 contiguous pages long, and covers all
* addresses from 0 to 0x7fffffff. Offsets into it are calculated
* with second_linear_offset(), not second_table_offset().
- *
- * On 32bit addresses 0x80000000 to 0xffffffff are covered by the
- * per-cpu xen_domheap mappings described above. We allocate 4 pages
- * here for use in the boot page tables and the second two pages
- * become the boot CPUs xen_dommap pages.
- *
- * On 64bit addresses 0x80000000 to 0xffffffff are unused. However we
- * allocate 4 pages here for use while relocating Xen, which currently
- * expects a second level page to exist for all addresses in the first
- * 4GB. We need to keep these extra mappings in place for seconary CPU
- * bring up too. For now we just leave them forever.
*/
-lpae_t xen_second[LPAE_ENTRIES*4] __attribute__((__aligned__(4096*4)));
+lpae_t xen_second[LPAE_ENTRIES*2] __attribute__((__aligned__(4096*2)));
/* First level page table used for fixmap */
lpae_t xen_fixmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
/* First level page table used to map Xen itself with the XN bit set
@@ -428,13 +420,22 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
#endif
/* Initialise first level entries, to point to second level entries */
- for ( i = 0; i < 4; i++)
+ for ( i = 0; i < 2; i++)
{
p[i] = pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
p[i].pt.table = 1;
p[i].pt.xn = 0;
}
+#ifdef CONFIG_ARM_32
+ for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ )
+ {
+ p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)]
+ = pte_of_xenaddr((uintptr_t)(cpu0_dommap+i*LPAE_ENTRIES));
+ p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)].pt.table = 1;
+ }
+#endif
+
/* Initialise xen second level entries ... */
/* ... Xen's text etc */
@@ -503,11 +504,9 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
#ifdef CONFIG_ARM_32
per_cpu(xen_pgtable, 0) = cpu0_pgtable;
- per_cpu(xen_dommap, 0) = xen_second +
- second_linear_offset(DOMHEAP_VIRT_START);
+ per_cpu(xen_dommap, 0) = cpu0_dommap;
- /* Some of these slots may have been used during start of day and/or
- * relocation. Make sure they are clear now. */
+ /* Make sure it is clear */
memset(this_cpu(xen_dommap), 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE);
flush_xen_dcache_va_range(this_cpu(xen_dommap),
DOMHEAP_SECOND_PAGES*PAGE_SIZE);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch
2013-09-27 10:20 ` [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch Ian Campbell
@ 2013-09-27 12:19 ` Julien Grall
0 siblings, 0 replies; 28+ messages in thread
From: Julien Grall @ 2013-09-27 12:19 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 11:20 AM, Ian Campbell wrote:
> midway, omap5 and exynos are all 32-bit only platforms. This avoids needing
> CONFIG_ARM_32 ifdefs around the SMP callbacks on such platforms.
>
> Vexpress is both.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/platforms/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/platforms/Makefile b/xen/arch/arm/platforms/Makefile
> index 4aa82e8..7535801 100644
> --- a/xen/arch/arm/platforms/Makefile
> +++ b/xen/arch/arm/platforms/Makefile
> @@ -1,4 +1,4 @@
> obj-y += vexpress.o
> -obj-y += exynos5.o
> -obj-y += midway.o
> -obj-y += omap5.o
> +obj-$(CONFIG_ARM_32) += exynos5.o
> +obj-$(CONFIG_ARM_32) += midway.o
> +obj-$(CONFIG_ARM_32) += omap5.o
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework
2013-09-27 10:20 ` [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
@ 2013-09-27 12:23 ` Julien Grall
2013-09-27 12:35 ` Ian Campbell
0 siblings, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 12:23 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 11:20 AM, Ian Campbell wrote:
> Includes an implementation for vexpress using the sysflags interface and
> support for the ARMv8 "spin-table" method.
>
> Unused until the next patch, split out to simplify review.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Acked-by: Tim Deegan <tim@xen.org>
> Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/arm32/Makefile | 1 +
> xen/arch/arm/arm32/head.S | 2 +-
> xen/arch/arm/arm32/smpboot.c | 29 ++++++++++++
> xen/arch/arm/arm64/Makefile | 1 +
> xen/arch/arm/arm64/head.S | 1 +
> xen/arch/arm/arm64/smpboot.c | 89 +++++++++++++++++++++++++++++++++++++
> xen/arch/arm/platform.c | 18 ++++++++
> xen/arch/arm/platforms/vexpress.c | 38 ++++++++++++++++
> xen/include/asm-arm/platform.h | 9 ++++
> xen/include/asm-arm/smp.h | 9 ++++
> 10 files changed, 196 insertions(+), 1 deletion(-)
> create mode 100644 xen/arch/arm/arm32/smpboot.c
> create mode 100644 xen/arch/arm/arm64/smpboot.c
>
> diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
> index 18522dc..463b1f5 100644
> --- a/xen/arch/arm/arm32/Makefile
> +++ b/xen/arch/arm/arm32/Makefile
> @@ -7,5 +7,6 @@ obj-y += proc-v7.o
> obj-y += traps.o
> obj-y += domain.o
> obj-y += vfp.o
> +obj-y += smpboot.o
>
> obj-$(EARLY_PRINTK) += debug.o
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index fce18a2..8cb31a2 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -59,7 +59,7 @@
> * or the initial pagetable code below will need adjustment. */
> .global start
> start:
> -
> +GLOBAL(init_secondary) /* currently unused */
> /* zImage magic header, see:
> * http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
> */
> diff --git a/xen/arch/arm/arm32/smpboot.c b/xen/arch/arm/arm32/smpboot.c
> new file mode 100644
> index 0000000..88fe8fb
> --- /dev/null
> +++ b/xen/arch/arm/arm32/smpboot.c
> @@ -0,0 +1,29 @@
> +#include <xen/device_tree.h>
> +#include <xen/init.h>
> +#include <xen/smp.h>
> +#include <asm/platform.h>
> +
> +int __init arch_smp_init(void)
> +{
> + return platform_smp_init();
> +}
> +
> +int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
> +{
> + /* TODO handle PSCI init */
> + return 0;
> +}
> +
> +int __init arch_cpu_up(int cpu)
> +{
> + return platform_cpu_up(cpu);
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
> index e06a0a9..30fb480 100644
> --- a/xen/arch/arm/arm64/Makefile
> +++ b/xen/arch/arm/arm64/Makefile
> @@ -6,5 +6,6 @@ obj-y += mode_switch.o
> obj-y += traps.o
> obj-y += domain.o
> obj-y += vfp.o
> +obj-y += smpboot.o
>
> obj-$(EARLY_PRINTK) += debug.o
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 4495f72..7cecac3 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -65,6 +65,7 @@
>
> .global start
> start:
> +GLOBAL(init_secondary) /* currently unused */
> /*
> * DO NOT MODIFY. Image header expected by Linux boot-loaders.
> */
> diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c
> new file mode 100644
> index 0000000..8239590
> --- /dev/null
> +++ b/xen/arch/arm/arm64/smpboot.c
> @@ -0,0 +1,89 @@
> +#include <xen/cpu.h>
> +#include <xen/lib.h>
> +#include <xen/init.h>
> +#include <xen/errno.h>
> +#include <xen/mm.h>
> +#include <xen/smp.h>
> +
> +struct smp_enable_ops {
> + int (*prepare_cpu)(int);
> +};
> +
> +static paddr_t cpu_release_addr[NR_CPUS];
> +static struct smp_enable_ops smp_enable_ops[NR_CPUS];
> +
> +static int __init smp_spin_table_cpu_up(int cpu)
> +{
> + paddr_t *release;
> +
> + if (!cpu_release_addr[cpu])
> + {
> + printk("CPU%d: No release addr\n", cpu);
> + return -ENODEV;
> + }
> +
> + release = __va(cpu_release_addr[cpu]);
> +
> + release[0] = __pa(init_secondary);
> + flush_xen_data_tlb_range_va((vaddr_t)release, sizeof(*release));
> +
> + sev();
> + return 0;
> +}
> +
> +static void __init smp_spin_table_init(int cpu, struct dt_device_node *dn)
> +{
> + if ( !dt_property_read_u64(dn, "cpu-release-addr", &cpu_release_addr[cpu]) )
> + {
> + printk("CPU%d has no cpu-release-addr\n", cpu);
> + return;
> + }
> +
> + smp_enable_ops[cpu].prepare_cpu = smp_spin_table_cpu_up;
> +}
> +
> +int __init arch_smp_init(void)
> +{
> + /* Nothing */
> + return 0;
> +}
> +
> +int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
> +{
> + const char *enable_method;
> +
> + enable_method = dt_get_property(dn, "enable-method", NULL);
> + if (!enable_method)
> + {
> + printk("CPU%d has no enable method\n", cpu);
> + return -EINVAL;
> + }
> +
> + if ( !strcmp(enable_method, "spin-table") )
> + smp_spin_table_init(cpu, dn);
> + /* TODO: method "psci" */
> + else
> + {
> + printk("CPU%d has unknown enable method \"%s\"\n", cpu, enable_method);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +int __init arch_cpu_up(int cpu)
> +{
> + if ( !smp_enable_ops[cpu].prepare_cpu )
> + return -ENODEV;
> +
> + return smp_enable_ops[cpu].prepare_cpu(cpu);
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
> index db79368..db135f8 100644
> --- a/xen/arch/arm/platform.c
> +++ b/xen/arch/arm/platform.c
> @@ -105,6 +105,24 @@ int __init platform_specific_mapping(struct domain *d)
> return res;
> }
>
> +#ifdef CONFIG_ARM_32
> +int __init platform_cpu_up(int cpu)
> +{
> + if ( platform && platform->cpu_up )
> + return platform->cpu_up(cpu);
> +
> + return -EAGAIN;
> +}
> +
> +int __init platform_smp_init(void)
> +{
> + if ( platform && platform->smp_init )
> + return platform->smp_init();
> +
> + return 0;
> +}
> +#endif
> +
> void platform_reset(void)
> {
> if ( platform && platform->reset )
> diff --git a/xen/arch/arm/platforms/vexpress.c b/xen/arch/arm/platforms/vexpress.c
> index 22c0c13..be0516f 100644
> --- a/xen/arch/arm/platforms/vexpress.c
> +++ b/xen/arch/arm/platforms/vexpress.c
> @@ -22,6 +22,7 @@
> #include <xen/mm.h>
> #include <xen/vmap.h>
> #include <asm/io.h>
> +#include <asm/gic.h>
>
> #define DCC_SHIFT 26
> #define FUNCTION_SHIFT 20
> @@ -120,6 +121,39 @@ static void vexpress_reset(void)
> iounmap(sp810);
> }
>
> +#ifdef CONFIG_ARM_32
> +
> +static int vexpress_smp_init(void)
platform_smp_init is in init section. vexpress_smp should also be here.
> +{
> + void __iomem *sysflags;
> +
> + sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
> + if ( !sysflags )
> + {
> + dprintk(XENLOG_ERR, "Unable to map vexpress MMIO\n");
> + return -EFAULT;
> + }
> +
> + printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
> + __pa(init_secondary), init_secondary);
> + writel(~0, sysflags + V2M_SYS_FLAGSCLR);
> + writel(__pa(init_secondary), sysflags + V2M_SYS_FLAGSSET);
> +
> + iounmap(sysflags);
> +
> + return 0;
> +}
> +
> +static int vexpress_cpu_up(int cpu)
same here.
> +{
> + /* Nothing to do here, the generic sev() will suffice to kick CPUs
> + * out of either the firmware or our own smp_up_cpu gate,
> + * depending on where they have ended up. */
> +
> + return 0;
> +}
> +#endif
> +
> static const char * const vexpress_dt_compat[] __initdata =
> {
> "arm,vexpress",
> @@ -144,6 +178,10 @@ static const struct dt_device_match vexpress_blacklist_dev[] __initconst =
>
> PLATFORM_START(vexpress, "VERSATILE EXPRESS")
> .compatible = vexpress_dt_compat,
> +#ifdef CONFIG_ARM_32
> + .smp_init = vexpress_smp_init,
> + .cpu_up = vexpress_cpu_up,
> +#endif
> .reset = vexpress_reset,
> .blacklist_dev = vexpress_blacklist_dev,
> PLATFORM_END
> diff --git a/xen/include/asm-arm/platform.h b/xen/include/asm-arm/platform.h
> index a19dbf7..dbd2a15 100644
> --- a/xen/include/asm-arm/platform.h
> +++ b/xen/include/asm-arm/platform.h
> @@ -15,6 +15,11 @@ struct platform_desc {
> /* Platform initialization */
> int (*init)(void);
> int (*init_time)(void);
> +#ifdef CONFIG_ARM_32
> + /* SMP */
> + int (*smp_init)(void);
> + int (*cpu_up)(int cpu);
> +#endif
> /* Specific mapping for dom0 */
> int (*specific_mapping)(struct domain *d);
> /* Platform reset */
> @@ -43,6 +48,10 @@ struct platform_desc {
> int __init platform_init(void);
> int __init platform_init_time(void);
> int __init platform_specific_mapping(struct domain *d);
> +#ifdef CONFIG_ARM_32
> +int platform_smp_init(void);
> +int platform_cpu_up(int cpu);
> +#endif
> void platform_reset(void);
> void platform_poweroff(void);
> bool_t platform_has_quirk(uint32_t quirk);
> diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h
> index 1c2746b..1added5 100644
> --- a/xen/include/asm-arm/smp.h
> +++ b/xen/include/asm-arm/smp.h
> @@ -4,6 +4,7 @@
> #ifndef __ASSEMBLY__
> #include <xen/config.h>
> #include <xen/cpumask.h>
> +#include <xen/device_tree.h>
> #include <asm/current.h>
> #endif
>
> @@ -22,9 +23,17 @@ extern void stop_cpu(void);
> extern void
> make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset);
>
> +extern int arch_smp_init(void);
> +extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
> +extern int arch_cpu_up(int cpu);
> +
> +/* Secondary CPU entry point */
> +extern void init_secondary(void);
> +
> extern void smp_clear_cpu_maps (void);
> extern int smp_get_max_cpus (void);
> #endif
> +
> /*
> * Local variables:
> * mode: C
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 10:20 ` [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
@ 2013-09-27 12:30 ` Julien Grall
2013-09-27 12:37 ` Ian Campbell
2013-09-27 13:30 ` Julien Grall
1 sibling, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 12:30 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 11:20 AM, Ian Campbell wrote:
> This is unfortunately a rather large monolithic patch.
>
> Rather than bringing up all CPUs in lockstep as we setup paging and relocate
> Xen instead create a simplified set of dedicated boot time pagetables.
>
> This allows secondary CPUs to remain powered down or in the firmware until we
> actually want to enable them. The bringup is now done later on in C and can be
> driven by DT etc. I have included code for the vexpress platform, but other
> platforms will need to be added.
>
> The mechanism for deciding how to bring up a CPU differs between arm32 and
> arm64. On arm32 it is essentially a per-platform property, with the exception
> of PSCI which can be implemented globally (but isn't here). On arm64 there is a
> per-cpu property in the device tree.
>
> Secondary CPUs are brought up directly into the relocated Xen image, instead of
> relying on being able to launch on the unrelocated Xen and hoping that it
> hasn't been clobbered.
>
> As part of this change drop support for switching from secure mode to NS HYP as
> well as the early CPU kick. Xen now requires that it is launched in NS HYP
> mode and that firmware configure things such that secondary CPUs can be woken
> up by a primarly CPU in HYP mode. This may require fixes to bootloaders or the
> use of a boot wrapper.
>
> The changes done here (re)exposed an issue with relocating Xen and the compiler
> spilling values to the stack between the copy and the actual switch to the
> relocaed copy of Xen in setup_pagetables. Therefore switch to doing the copy
> and switch in a single asm function where we can control precisely what gets
> spilled to the stack etc.
>
> Since we now have a separate set of boot pagetables it is much easier to build
> the real Xen pagetables inplace before relocating rather than the more complex
> approach of rewriting the pagetables in the relocated copy before switching.
>
> This will also enable Xen to be loaded above the 4GB boundary on 64-bit.
There is a conflict with this patch and your recently pushed patch
series "xen: arm: memory mangement fixes / improvements".
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> v3: add a dsb before the smp_up_cpu wait loop.
> move arch_smp_init() and arch_cpu_init() int init_cpus_maps() which I
> rename to smp_init_cpus().
> v2: Lots of review feedback from Julien and Tim
> Reintroduce a smp_up_cpu gate. We cannot reliably wake a single CPU so we
> add our own gate. However it is purely in the relocated image.
> ---
> xen/arch/arm/arm32/Makefile | 1 -
> xen/arch/arm/arm32/head.S | 391 ++++++++++++++++++-----------
> xen/arch/arm/arm32/mode_switch.S | 158 ------------
> xen/arch/arm/arm64/Makefile | 1 -
> xen/arch/arm/arm64/head.S | 396 ++++++++++++++++++++----------
> xen/arch/arm/arm64/mode_switch.S | 89 -------
> xen/arch/arm/mm.c | 192 +++++++++------
> xen/arch/arm/setup.c | 26 +-
> xen/arch/arm/smpboot.c | 57 ++---
> xen/include/asm-arm/mm.h | 3 +-
> xen/include/asm-arm/platforms/exynos5.h | 14 --
> xen/include/asm-arm/platforms/vexpress.h | 11 -
> xen/include/asm-arm/smp.h | 6 -
> 13 files changed, 672 insertions(+), 673 deletions(-)
> delete mode 100644 xen/arch/arm/arm32/mode_switch.S
> delete mode 100644 xen/arch/arm/arm64/mode_switch.S
>
> diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
> index 463b1f5..aacdcb9 100644
> --- a/xen/arch/arm/arm32/Makefile
> +++ b/xen/arch/arm/arm32/Makefile
> @@ -1,7 +1,6 @@
> subdir-y += lib
>
> obj-y += entry.o
> -obj-y += mode_switch.o
> obj-y += proc-v7.o
>
> obj-y += traps.o
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index 8cb31a2..946394c 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -37,6 +37,25 @@
> #include EARLY_PRINTK_INC
> #endif
>
> +/*
> + * Common register usage in this file:
> + * r0 -
> + * r1 -
> + * r2 -
> + * r3 -
> + * r4 -
> + * r5 -
> + * r6 -
> + * r7 - CPUID
> + * r8 - DTB address (boot CPU only)
> + * r9 - paddr(start)
> + * r10 - phys offset
> + * r11 - UART address
> + * r12 - is_secondary_cpu
> + * r13 - SP
> + * r14 - LR
> + * r15 - PC
> + */
> /* Macro to print a string to the UART, if there is one.
> * Clobbers r0-r3. */
> #ifdef EARLY_PRINTK
> @@ -59,7 +78,6 @@
> * or the initial pagetable code below will need adjustment. */
> .global start
> start:
> -GLOBAL(init_secondary) /* currently unused */
> /* zImage magic header, see:
> * http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
> */
> @@ -77,7 +95,6 @@ past_zImage:
> cpsid aif /* Disable all interrupts */
>
> /* Save the bootloader arguments in less-clobberable registers */
> - mov r5, r1 /* r5: ARM-linux machine type */
> mov r8, r2 /* r8 := DTB base address */
>
> /* Find out where we are */
> @@ -91,53 +108,55 @@ past_zImage:
> add r8, r10 /* r8 := paddr(DTB) */
> #endif
>
> - /* Are we the boot CPU? */
> - mov r12, #0 /* r12 := CPU ID */
> - mrc CP32(r0, MPIDR)
> - tst r0, #(1<<31) /* Multiprocessor extension supported? */
> - beq boot_cpu
> - tst r0, #(1<<30) /* Uniprocessor system? */
> - bne boot_cpu
> - bics r12, r0, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
> - beq boot_cpu /* If we're CPU 0, boot now */
> -
> - /* Non-boot CPUs wait here to be woken up one at a time. */
> -1: dsb
> - ldr r0, =smp_up_cpu /* VA of gate */
> - add r0, r0, r10 /* PA of gate */
> - ldr r1, [r0] /* Which CPU is being booted? */
> - teq r1, r12 /* Is it us? */
> - wfene
> - bne 1b
> + mov r12, #0 /* r12 := is_secondary_cpu */
> +
> + b common_start
> +
> +GLOBAL(init_secondary)
> + cpsid aif /* Disable all interrupts */
> +
> + /* Find out where we are */
> + ldr r0, =start
> + adr r9, start /* r9 := paddr (start) */
> + sub r10, r9, r0 /* r10 := phys-offset */
> +
> + mov r12, #1 /* r12 := is_secondary_cpu */
> +
> +common_start:
> + mov r7, #0 /* r7 := CPU ID. Initialy zero until we
> + * find that multiprocessor extensions are
> + * present and the system is SMP */
> + mrc CP32(r1, MPIDR)
> + tst r1, #(1<<31) /* Multiprocessor extension supported? */
> + beq 1f
> + tst r1, #(1<<30) /* Uniprocessor system? */
> + bne 1f
> + bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
> +1:
> +
> + /* Non-boot CPUs wait here until __cpu_up is ready for them */
> + teq r12, #0
> + beq 1f
> +
> + ldr r0, =smp_up_cpu
> + add r0, r0, r10 /* Apply physical offset */
> + dsb
> +2: ldr r1, [r0]
> + cmp r1, r7
> + beq 1f
> + wfe
> + b 2b
> +1:
>
> -boot_cpu:
> #ifdef EARLY_PRINTK
> ldr r11, =EARLY_UART_BASE_ADDRESS /* r11 := UART base address */
> - teq r12, #0 /* CPU 0 sets up the UART too */
> + teq r12, #0 /* Boot CPU sets up the UART too */
> bleq init_uart
> PRINT("- CPU ")
> - mov r0, r12
> + mov r0, r7
> bl putn
> PRINT(" booting -\r\n")
> #endif
> - /* Secondary CPUs doesn't have machine ID
> - * - Store machine ID on boot CPU
> - * - Load machine ID on secondary CPUs
> - * Machine ID is needed in kick_cpus and enter_hyp_mode */
> - ldr r0, =machine_id /* VA of machine_id */
> - add r0, r0, r10 /* PA of machine_id */
> - teq r12, #0
> - streq r5, [r0] /* On boot CPU save machine ID */
> - ldrne r5, [r0] /* If non boot cpu r5 := machine ID */
> -
> - /* Wake up secondary cpus */
> - teq r12, #0
> - bleq kick_cpus
> -
> - PRINT("- Machine ID ")
> - mov r0, r5
> - bl putn
> - PRINT(" -\r\n")
>
> /* Check that this CPU has Hyp mode */
> mrc CP32(r0, ID_PFR1)
> @@ -147,28 +166,19 @@ boot_cpu:
> PRINT("- CPU doesn't support the virtualization extensions -\r\n")
> b fail
> 1:
> - /* Check if we're already in it */
> +
> + /* Check that we're already in Hyp mode */
> mrs r0, cpsr
> and r0, r0, #0x1f /* Mode is in the low 5 bits of CPSR */
> teq r0, #0x1a /* Hyp Mode? */
> - bne 1f
> - PRINT("- Started in Hyp mode -\r\n")
> - b hyp
> -1:
> - /* Otherwise, it must have been Secure Supervisor mode */
> - mrc CP32(r0, SCR)
> - tst r0, #0x1 /* Not-Secure bit set? */
> - beq 1f
> - PRINT("- CPU is not in Hyp mode or Secure state -\r\n")
> + beq hyp
> +
> + /* OK, we're boned. */
> + PRINT("- Xen must be entered in NS Hyp mode -\r\n" \
> + "- Please update the bootloader -\r\n")
> b fail
> -1:
> - /* OK, we're in Secure state. */
> - PRINT("- Started in Secure state -\r\n- Entering Hyp mode -\r\n")
> - ldr r0, =enter_hyp_mode /* VA of function */
> - adr lr, hyp /* Set return address for call */
> - add pc, r0, r10 /* Call PA of function */
>
> -hyp:
> +hyp: PRINT("- Xen starting in Hyp mode -\r\n")
>
> /* Zero BSS On the boot CPU to avoid nasty surprises */
> teq r12, #0
> @@ -208,8 +218,8 @@ skip_bss:
> bl putn
> PRINT(" -\r\n")
> b fail
> -
> 2:
> +
> /* Jump to cpu_init */
> ldr r1, [r1, #PROCINFO_cpu_init] /* r1 := vaddr(init func) */
> adr lr, cpu_init_done /* Save return address */
> @@ -242,68 +252,69 @@ cpu_init_done:
> ldr r0, =(HSCTLR_BASE|SCTLR_A)
> mcr CP32(r0, HSCTLR)
>
> + /* Rebuild the boot pagetable's first-level entries. The structure
> + * is described in mm.c.
> + *
> + * After the CPU enables paging it will add the fixmap mapping
> + * to these page tables, however this may clash with the 1:1
> + * mapping. So each CPU must rebuild the page tables here with
> + * the 1:1 in place. */
> +
> /* Write Xen's PT's paddr into the HTTBR */
> ldr r4, =boot_pgtable
> - add r4, r4, r10 /* r4 := paddr (xen_pagetable) */
> - mov r5, #0 /* r4:r5 is paddr (xen_pagetable) */
> + add r4, r4, r10 /* r4 := paddr (boot_pagetable) */
> + mov r5, #0 /* r4:r5 is paddr (boot_pagetable) */
> mcrr CP64(r4, r5, HTTBR)
>
> - /* Non-boot CPUs don't need to rebuild the pagetable */
> - teq r12, #0
> - bne pt_ready
> -
> - /* console fixmap */
> -#if defined(EARLY_PRINTK)
> - ldr r1, =xen_fixmap
> - add r1, r1, r10 /* r1 := paddr (xen_fixmap) */
> - mov r3, #0
> - lsr r2, r11, #12
> - lsl r2, r2, #12 /* 4K aligned paddr of UART */
> - orr r2, r2, #PT_UPPER(DEV_L3)
> - orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
> - strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
> -#endif
> -
> - /* Build the baseline idle pagetable's first-level entries */
> - ldr r1, =xen_second
> - add r1, r1, r10 /* r1 := paddr (xen_second) */
> + /* Setup boot_pgtable: */
> + ldr r1, =boot_second
> + add r1, r1, r10 /* r1 := paddr (boot_second) */
> mov r3, #0x0
> - orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of xen_second */
> +
> + /* ... map boot_second in boot_pgtable[0] */
> + orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of boot_second */
> orr r2, r2, #PT_LOWER(PT) /* (+ rights for linear PT) */
> strd r2, r3, [r4, #0] /* Map it in slot 0 */
> - add r2, r2, #0x1000
> - strd r2, r3, [r4, #8] /* Map 2nd page in slot 1 */
> - add r2, r2, #0x1000
> - strd r2, r3, [r4, #16] /* Map 3rd page in slot 2 */
> - add r2, r2, #0x1000
> - strd r2, r3, [r4, #24] /* Map 4th page in slot 3 */
> -
> - /* Now set up the second-level entries */
> - orr r2, r9, #PT_UPPER(MEM)
> - orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB normal map of Xen */
> - mov r4, r9, lsr #18 /* Slot for paddr(start) */
> - strd r2, r3, [r1, r4] /* Map Xen there */
> - ldr r4, =start
> - lsr r4, #18 /* Slot for vaddr(start) */
> - strd r2, r3, [r1, r4] /* Map Xen there too */
> -
> - /* xen_fixmap pagetable */
> - ldr r2, =xen_fixmap
> - add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
> - orr r2, r2, #PT_UPPER(PT)
> - orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
> - add r4, r4, #8
> - strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
>
> - mov r3, #0x0
> - lsr r2, r8, #21
> - lsl r2, r2, #21 /* 2MB-aligned paddr of DTB */
> - orr r2, r2, #PT_UPPER(MEM)
> - orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
> - add r4, r4, #8
> - strd r2, r3, [r1, r4] /* Map it in the early boot slot */
> + /* ... map of paddr(start) in boot_pgtable */
> + lsrs r1, r9, #30 /* Offset of base paddr in boot_pgtable */
> + beq 1f /* If it is in slot 0 then map in boot_second
> + * later on */
> + lsl r2, r1, #30 /* Base address for 1GB mapping */
> + orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
> + orr r2, r2, #PT_LOWER(MEM)
> + lsl r1, r1, #3 /* r1 := Slot offset */
> + strd r2, r3, [r4, r1] /* Mapping of paddr(start) */
> +
> +1: /* Setup boot_second: */
> + ldr r4, =boot_second
> + add r4, r4, r10 /* r1 := paddr (boot_second) */
> +
> + lsr r2, r9, #20 /* Base address for 2MB mapping */
> + lsl r2, r2, #20
> + orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
> + orr r2, r2, #PT_LOWER(MEM)
> +
> + /* ... map of vaddr(start) in boot_second */
> + ldr r1, =start
> + lsr r1, #18 /* Slot for vaddr(start) */
> + strd r2, r3, [r4, r1] /* Map vaddr(start) */
> +
> + /* ... map of paddr(start) in boot_second */
> + lsrs r1, r9, #30 /* Base paddr */
> + bne 1f /* If paddr(start) is not in slot 0
> + * then the mapping was done in
> + * boot_pgtable above */
> +
> + mov r1, r9, lsr #18 /* Slot for paddr(start) */
> + strd r2, r3, [r4, r1] /* Map Xen there */
> +1:
> +
> + /* Defer fixmap and dtb mapping until after paging enabled, to
> + * avoid them clashing with the 1:1 mapping. */
> +
> + /* boot pagetable setup complete */
>
> -pt_ready:
> PRINT("- Turning on paging -\r\n")
>
> ldr r1, =paging /* Explicit vaddr, not RIP-relative */
> @@ -315,11 +326,53 @@ pt_ready:
> mov pc, r1 /* Get a proper vaddr into PC */
> paging:
>
> + /* Now we can install the fixmap and dtb mappings, since we
> + * don't need the 1:1 map any more */
> + dsb
> +#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
> + /* Non-boot CPUs don't need to rebuild the fixmap itself, just
> + * the mapping from boot_second to xen_fixmap */
> + teq r12, #0
> + bne 1f
> +
> + /* Add UART to the fixmap table */
> + ldr r1, =xen_fixmap /* r1 := vaddr (xen_fixmap) */
> + mov r3, #0
> + lsr r2, r11, #12
> + lsl r2, r2, #12 /* 4K aligned paddr of UART */
> + orr r2, r2, #PT_UPPER(DEV_L3)
> + orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
> + strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
> +1:
> +
> + /* Map fixmap into boot_second */
> + ldr r1, =boot_second /* r1 := vaddr (xen_fixmap) */
> + ldr r2, =xen_fixmap
> + add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
> + orr r2, r2, #PT_UPPER(PT)
> + orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
> + ldr r4, =FIXMAP_ADDR(0)
> + mov r4, r4, lsr #18 /* r4 := Slot for FIXMAP(0) */
> + strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
>
> -#ifdef EARLY_PRINTK
> /* Use a virtual address to access the UART. */
> ldr r11, =FIXMAP_ADDR(FIXMAP_CONSOLE)
> #endif
> + /* Map the DTB in the boot misc slot */
> + teq r12, #0 /* Only on boot CPU */
> + bne 1f
> +
> + ldr r1, =boot_second
> + mov r3, #0x0
> + lsr r2, r8, #21
> + lsl r2, r2, #21 /* r2: 2MB-aligned paddr of DTB */
> + orr r2, r2, #PT_UPPER(MEM)
> + orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
> + ldr r4, =BOOT_MISC_VIRT_START
> + mov r4, r4, lsr #18 /* Slot for BOOT_MISC_VIRT_START */
> + strd r2, r3, [r1, r4] /* Map it in the early boot slot */
> + dsb
> +1:
>
> PRINT("- Ready -\r\n")
>
> @@ -327,10 +380,10 @@ paging:
> teq r12, #0
> beq launch
>
> - /* Non-boot CPUs need to move on to the relocated pagetables */
> - mov r0, #0
> - ldr r4, =boot_ttbr /* VA of HTTBR value stashed by CPU 0 */
> - add r4, r4, r10 /* PA of it */
> + /* Non-boot CPUs need to move on to the proper pagetables, which were
> + * setup in init_secondary_pagetables. */
> +
> + ldr r4, =init_ttbr /* VA of HTTBR value stashed by CPU 0 */
> ldrd r4, r5, [r4] /* Actual value */
> dsb
> mcrr CP64(r4, r5, HTTBR)
> @@ -342,29 +395,6 @@ paging:
> dsb /* Ensure completion of TLB+BP flush */
> isb
>
> - /* Non-boot CPUs report that they've got this far */
> - ldr r0, =ready_cpus
> -1: ldrex r1, [r0] /* { read # of ready CPUs } */
> - add r1, r1, #1 /* Atomically { ++ } */
> - strex r2, r1, [r0] /* { writeback } */
> - teq r2, #0
> - bne 1b
> - dsb
> - mcr CP32(r0, DCCMVAC) /* flush D-Cache */
> - dsb
> -
> - /* Here, the non-boot CPUs must wait again -- they're now running on
> - * the boot CPU's pagetables so it's safe for the boot CPU to
> - * overwrite the non-relocated copy of Xen. Once it's done that,
> - * and brought up the memory allocator, non-boot CPUs can get their
> - * own stacks and enter C. */
> -1: wfe
> - dsb
> - ldr r0, =smp_up_cpu
> - ldr r1, [r0] /* Which CPU is being booted? */
> - teq r1, r12 /* Is it us? */
> - bne 1b
> -
> launch:
> ldr r0, =init_data
> add r0, #INITINFO_stack /* Find the boot-time stack */
> @@ -373,7 +403,7 @@ launch:
> sub sp, #CPUINFO_sizeof /* Make room for CPU save record */
> mov r0, r10 /* Marshal args: - phys_offset */
> mov r1, r8 /* - DTB address */
> - movs r2, r12 /* - CPU ID */
> + movs r2, r7 /* - CPU ID */
> beq start_xen /* and disappear into the land of C */
> b start_secondary /* (to the appropriate entry point) */
>
> @@ -383,6 +413,82 @@ fail: PRINT("- Boot failed -\r\n")
> 1: wfe
> b 1b
>
> +/* Copy Xen to new location and switch TTBR
> + * r1:r0 ttbr
> + * r2 source address
> + * r3 destination address
> + * [sp]=>r4 length
> + *
> + * Source and destination must be word aligned, length is rounded up
> + * to a 16 byte boundary.
> + *
> + * MUST BE VERY CAREFUL when saving things to RAM over the copy */
> +ENTRY(relocate_xen)
> + push {r4,r5,r6,r7,r8,r9,r10,r11}
> +
> + ldr r4, [sp, #8*4] /* Get 4th argument from stack */
> +
> + /* Copy 16 bytes at a time using:
> + * r5: counter
> + * r6: data
> + * r7: data
> + * r8: data
> + * r9: data
> + * r10: source
> + * r11: destination
> + */
> + mov r5, r4
> + mov r10, r2
> + mov r11, r3
> +1: ldmia r10!, {r6, r7, r8, r9}
> + stmia r11!, {r6, r7, r8, r9}
> +
> + subs r5, r5, #16
> + bgt 1b
> +
> + /* Flush destination from dcache using:
> + * r5: counter
> + * r6: step
> + * r7: vaddr
> + */
> + dsb /* So the CPU issues all writes to the range */
> +
> + mov r5, r4
> + ldr r6, =cacheline_bytes /* r6 := step */
> + ldr r6, [r6]
> + mov r7, r3
> +
> +1: mcr CP32(r7, DCCMVAC)
> +
> + add r7, r7, r6
> + subs r5, r5, r6
> + bgt 1b
> +
> + dsb /* Ensure the flushes happen before
> + * continuing */
> + isb /* Ensure synchronization with previous
> + * changes to text */
> + mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
> + mcr CP32(r0, ICIALLU) /* Flush I-cache */
> + mcr CP32(r0, BPIALL) /* Flush branch predictor */
> + dsb /* Ensure completion of TLB+BP flush */
> + isb
> +
> + mcrr CP64(r0, r1, HTTBR)
> +
> + dsb /* ensure memory accesses do not cross
> + * over the TTBR0 write */
> + isb /* Ensure synchronization with previous
> + * changes to text */
> + mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
> + mcr CP32(r0, ICIALLU) /* Flush I-cache */
> + mcr CP32(r0, BPIALL) /* Flush branch predictor */
> + dsb /* Ensure completion of TLB+BP flush */
> + isb
> +
> + pop {r4, r5,r6,r7,r8,r9,r10,r11}
> +
> + mov pc, lr
>
> #ifdef EARLY_PRINTK
> /* Bring up the UART.
> @@ -439,9 +545,6 @@ putn: mov pc, lr
>
> #endif /* !EARLY_PRINTK */
>
> -/* Place holder for machine ID */
> -machine_id: .word 0x0
> -
> /*
> * Local variables:
> * mode: ASM
> diff --git a/xen/arch/arm/arm32/mode_switch.S b/xen/arch/arm/arm32/mode_switch.S
> deleted file mode 100644
> index 2cd5888..0000000
> --- a/xen/arch/arm/arm32/mode_switch.S
> +++ /dev/null
> @@ -1,158 +0,0 @@
> -/*
> - * xen/arch/arm/mode_switch.S
> - *
> - * Start-of day code to take a CPU from Secure mode to Hyp mode.
> - *
> - * Tim Deegan <tim@xen.org>
> - * Copyright (c) 2011-2012 Citrix Systems.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> -
> -#include <asm/config.h>
> -#include <asm/page.h>
> -#include <asm/platforms/vexpress.h>
> -#include <asm/platforms/exynos5.h>
> -#include <asm/asm_defns.h>
> -#include <asm/gic.h>
> -
> -/* Wake up secondary cpus
> - * This code relies on Machine ID and only works for Vexpress and the Arndale
> - * TODO: Move this code either later (via platform specific desc) or in a bootwrapper
> - * r5: Machine ID
> - * Clobber r0 r2 */
> -GLOBAL(kick_cpus)
> - ldr r0, =MACH_TYPE_SMDK5250
> - teq r5, r0 /* Are we running on the arndale? */
> - beq kick_cpus_arndale
> - /* otherwise versatile express */
> - /* write start paddr to v2m sysreg FLAGSSET register */
> - ldr r0, =(V2M_SYS_MMIO_BASE) /* base V2M sysreg MMIO address */
> - dsb
> - mov r2, #0xffffffff
> - str r2, [r0, #(V2M_SYS_FLAGSCLR)]
> - dsb
> - ldr r2, =start
> - add r2, r2, r10
> - str r2, [r0, #(V2M_SYS_FLAGSSET)]
> - dsb
> - ldr r2, =V2M_GIC_BASE_ADDRESS /* r2 := VE gic base address */
> - b kick_cpus_sgi
> -kick_cpus_arndale:
> - /* write start paddr to CPU 1 sysreg register */
> - ldr r0, =(S5P_PA_SYSRAM)
> - ldr r2, =start
> - add r2, r2, r10
> - str r2, [r0]
> - dsb
> - ldr r2, =EXYNOS5_GIC_BASE_ADDRESS /* r2 := Exynos5 gic base address */
> -kick_cpus_sgi:
> - /* send an interrupt */
> - ldr r0, =GIC_DR_OFFSET /* GIC distributor offset */
> - add r0, r2 /* r0 := r0 + gic base address */
> - mov r2, #0x1
> - str r2, [r0, #(GICD_CTLR * 4)] /* enable distributor */
> - mov r2, #0xfe0000
> - str r2, [r0, #(GICD_SGIR * 4)] /* send IPI to everybody, SGI0 = Event check */
> - dsb
> - str r2, [r0, #(GICD_CTLR * 4)] /* disable distributor */
> - mov pc, lr
> -
> -
> -/* Get up a CPU into Hyp mode. Clobbers r0-r3.
> - *
> - * r5: Machine ID
> - * r12: CPU number
> - *
> - * This code is specific to the VE model/Arndale, and not intended to be used
> - * on production systems. As such it's a bit hackier than the main
> - * boot code in head.S. In future it will be replaced by better
> - * integration with the bootloader/firmware so that Xen always starts
> - * in Hyp mode.
> - * Clobber r0 - r4 */
> -GLOBAL(enter_hyp_mode)
> - mov r3, lr /* Put return address in non-banked reg */
> - cpsid aif, #0x16 /* Enter Monitor mode */
> - mrc CP32(r0, SCR)
> - orr r0, r0, #0x100 /* Set HCE */
> - orr r0, r0, #0xb1 /* Set SCD, AW, FW and NS */
> - bic r0, r0, #0xe /* Clear EA, FIQ and IRQ */
> - mcr CP32(r0, SCR)
> -
> - ldr r2, =MACH_TYPE_SMDK5250 /* r4 := Arndale machine ID */
> - /* By default load Arndale defaults values */
> - ldr r0, =EXYNOS5_TIMER_FREQUENCY /* r0 := timer's frequency */
> - ldr r1, =EXYNOS5_GIC_BASE_ADDRESS /* r1 := GIC base address */
> - /* If it's not the Arndale machine ID, load VE values */
> - teq r5, r2
> - ldrne r0, =V2M_TIMER_FREQUENCY
> - ldrne r1, =V2M_GIC_BASE_ADDRESS
> -
> - /* Ugly: the system timer's frequency register is only
> - * programmable in Secure state. Since we don't know where its
> - * memory-mapped control registers live, we can't find out the
> - * right frequency. */
> - mcr CP32(r0, CNTFRQ)
> -
> - mrc CP32(r0,NSACR)
> - ldr r4, =0x3fff /* Allow access to all co-processors in NS mode */
> - orr r0, r0, r4
> - orr r0, r0, #(1<<18) /* CA7/CA15: Allow access to ACTLR.SMP in NS mode */
> - mcr CP32(r0, NSACR)
> -
> - add r0, r1, #GIC_DR_OFFSET
> - /* Disable the GIC distributor, on the boot CPU only */
> - mov r4, #0
> - teq r12, #0 /* Is this the boot CPU? */
> - streq r4, [r0]
> - /* Continuing ugliness: Set up the GIC so NS state owns interrupts,
> - * The first 32 interrupts (SGIs & PPIs) must be configured on all
> - * CPUs while the remainder are SPIs and only need to be done one, on
> - * the boot CPU. */
> - add r0, r0, #0x80 /* GICD_IGROUP0 */
> - mov r2, #0xffffffff /* All interrupts to group 1 */
> - str r2, [r0] /* Interrupts 0-31 (SGI & PPI) */
> - teq r12, #0 /* Boot CPU? */
> - bne skip_spis /* Don't route SPIs on secondary CPUs */
> -
> - add r4, r1, #GIC_DR_OFFSET
> - ldr r4, [r4, #4] /* r4 := Interrupt Controller Type Reg */
> - and r4, r4, #GICD_TYPE_LINES /* r4 := number of SPIs */
> -1: teq r4, #0
> - beq skip_spis
> - add r0, r0, #4 /* Go to the new group */
> - str r2, [r0] /* Update the group */
> - sub r4, r4, #1
> - b 1b
> -skip_spis:
> - /* Disable the GIC CPU interface on all processors */
> - add r0, r1, #GIC_CR_OFFSET
> - mov r1, #0
> - str r1, [r0]
> - /* Must drop priority mask below 0x80 before entering NS state */
> - ldr r1, =0xff
> - str r1, [r0, #0x4] /* -> GICC_PMR */
> - /* Reset a few config registers */
> - mov r0, #0
> - mcr CP32(r0, FCSEIDR)
> - mcr CP32(r0, CONTEXTIDR)
> -
> - mrs r0, cpsr /* Copy the CPSR */
> - add r0, r0, #0x4 /* 0x16 (Monitor) -> 0x1a (Hyp) */
> - msr spsr_cxsf, r0 /* into the SPSR */
> - movs pc, r3 /* Exception-return into Hyp mode */
> -
> -/*
> - * Local variables:
> - * mode: ASM
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
> index 30fb480..5d28bad 100644
> --- a/xen/arch/arm/arm64/Makefile
> +++ b/xen/arch/arm/arm64/Makefile
> @@ -1,7 +1,6 @@
> subdir-y += lib
>
> obj-y += entry.o
> -obj-y += mode_switch.o
>
> obj-y += traps.o
> obj-y += domain.o
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 7cecac3..b327770 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -33,6 +33,41 @@
> #include EARLY_PRINTK_INC
> #endif
>
> +/*
> + * Common register usage in this file:
> + * x0 -
> + * x1 -
> + * x2 -
> + * x3 -
> + * x4 -
> + * x5 -
> + * x6 -
> + * x7 -
> + * x8 -
> + * x9 -
> + * x10 -
> + * x11 -
> + * x12 -
> + * x13 -
> + * x14 -
> + * x15 -
> + * x16 -
> + * x17 -
> + * x18 -
> + * x19 - paddr(start)
> + * x20 - phys offset
> + * x21 - DTB address (boot cpu only)
> + * x22 - is_secondary_cpu
> + * x23 - UART address
> + * x24 - cpuid
> + * x25 -
> + * x26 -
> + * x27 -
> + * x28 -
> + * x29 -
> + * x30 - lr
> + */
> +
> /* Macro to print a string to the UART, if there is one.
> * Clobbers x0-x3. */
> #ifdef EARLY_PRINTK
> @@ -65,7 +100,6 @@
>
> .global start
> start:
> -GLOBAL(init_secondary) /* currently unused */
> /*
> * DO NOT MODIFY. Image header expected by Linux boot-loaders.
> */
> @@ -100,69 +134,73 @@ real_start:
> add x21, x21, x20 /* x21 := paddr(DTB) */
> #endif
>
> - /* Are we the boot CPU? */
> - mov x22, #0 /* x22 := CPU ID */
> + mov x22, #0 /* x22 := is_secondary_cpu */
> +
> + b common_start
> +
> +GLOBAL(init_secondary)
> + msr DAIFSet, 0xf /* Disable all interrupts */
> +
> + /* Find out where we are */
> + ldr x0, =start
> + adr x19, start /* x19 := paddr (start) */
> + sub x20, x19, x0 /* x20 := phys-offset */
> +
> + mov x22, #1 /* x22 := is_secondary_cpu */
> +
> +common_start:
> + mov x24, #0 /* x24 := CPU ID. Initialy zero until we
> + * find that multiprocessor extensions are
> + * present and the system is SMP */
> mrs x0, mpidr_el1
> - tbz x0, 31, boot_cpu /* Multiprocessor extension supported? */
> - tbnz x0, 30, boot_cpu /* Uniprocessor system? */
> + tbz x0, 31, 1f /* Multiprocessor extension not supported? */
> + tbnz x0, 30, 1f /* Uniprocessor system? */
>
> mov x13, #(0xff << 24)
> - bics x22, x0, x13 /* Mask out flags to get CPU ID */
> - b.eq boot_cpu /* If we're CPU 0, boot now */
> -
> - /* Non-boot CPUs wait here to be woken up one at a time. */
> -1: dsb sy
> - ldr x0, =smp_up_cpu /* VA of gate */
> - add x0, x0, x20 /* PA of gate */
> - ldr x1, [x0] /* Which CPU is being booted? */
> - cmp x1, x22 /* Is it us? */
> - b.eq 2f
> + bic x24, x0, x13 /* Mask out flags to get CPU ID */
> +1:
> +
> + /* Non-boot CPUs wait here until __cpu_up is ready for them */
> + cbz x22, 1f
> +
> + ldr x0, =smp_up_cpu
> + add x0, x0, x20 /* Apply physical offset */
> + dsb sy
> +2: ldr x1, [x0]
> + cmp x1, x24
> + beq 1f
> wfe
> - b 1b
> -2:
> + b 2b
> +1:
>
> -boot_cpu:
> #ifdef EARLY_PRINTK
> ldr x23, =EARLY_UART_BASE_ADDRESS /* x23 := UART base address */
> cbnz x22, 1f
> -#ifdef EARLY_PRINTK_INIT_UART
> - bl init_uart /* CPU 0 sets up the UART too */
> -#endif
> + bl init_uart /* Boot CPU sets up the UART too */
> 1: PRINT("- CPU ")
> - mov x0, x22
> + mov x0, x24
> bl putn
> PRINT(" booting -\r\n")
> #endif
>
> PRINT("- Current EL ")
> - mrs x0, CurrentEL
> + mrs x4, CurrentEL
> + mov x0, x4
> bl putn
> PRINT(" -\r\n")
>
> - /* Are we in EL3 */
> - mrs x0, CurrentEL
> - cmp x0, #PSR_MODE_EL3t
> - ccmp x0, #PSR_MODE_EL3h, #0x4, ne
> - b.eq 1f /* Yes */
> -
> /* Are we in EL2 */
> - cmp x0, #PSR_MODE_EL2t
> - ccmp x0, #PSR_MODE_EL2h, #0x4, ne
> - b.eq 2f /* Yes */
> + cmp x4, #PSR_MODE_EL2t
> + ccmp x4, #PSR_MODE_EL2h, #0x4, ne
> + b.eq el2 /* Yes */
>
> - /* Otherwise, it must have been EL0 or EL1 */
> - PRINT("- CPU is not in EL3 or EL2 -\r\n")
> - b fail
> + /* OK, we're boned. */
> + PRINT("- Xen must be entered in NS EL2 mode -\r\n" \
> + "- Please update the bootloader -\r\n")
> + b fail
>
> -1: PRINT("- Started in EL3 -\r\n- Entering EL2 -\r\n")
> - ldr x1, =enter_el2_mode /* VA of function */
> - add x1, x1, x20 /* PA of function */
> - adr x30, el2 /* Set return address for call */
> - br x1 /* Call function */
> +el2: PRINT("- Xen starting at EL2 -\r\n")
>
> -2: PRINT("- Started in EL2 mode -\r\n")
> -
> -el2:
> /* Zero BSS On the boot CPU to avoid nasty surprises */
> cbnz x22, skip_bss
>
> @@ -177,9 +215,10 @@ el2:
> b.lo 1b
>
> skip_bss:
> -
> PRINT("- Setting up control registers -\r\n")
>
> + /* XXXX call PROCINFO_cpu_init here */
> +
> /* Set up memory attribute type tables */
> ldr x0, =MAIRVAL
> msr mair_el2, x0
> @@ -193,7 +232,7 @@ skip_bss:
> ldr x0, =0x80802500
> msr tcr_el2, x0
>
> - /* Set up the HSCTLR:
> + /* Set up the SCTLR_EL2:
> * Exceptions in LE ARM,
> * Low-latency IRQs disabled,
> * Write-implies-XN disabled (for now),
> @@ -204,69 +243,90 @@ skip_bss:
> ldr x0, =(HSCTLR_BASE|SCTLR_A)
> msr SCTLR_EL2, x0
>
> - /* Write Xen's PT's paddr into the HTTBR */
> + /* Rebuild the boot pagetable's first-level entries. The structure
> + * is described in mm.c.
> + *
> + * After the CPU enables paging it will add the fixmap mapping
> + * to these page tables, however this may clash with the 1:1
> + * mapping. So each CPU must rebuild the page tables here with
> + * the 1:1 in place. */
> +
> + /* Write Xen's PT's paddr into TTBR0_EL2 */
> ldr x4, =boot_pgtable
> - add x4, x4, x20 /* x4 := paddr (xen_pagetable) */
> + add x4, x4, x20 /* x4 := paddr (boot_pagetable) */
> msr TTBR0_EL2, x4
>
> - /* Non-boot CPUs don't need to rebuild the pagetable */
> - cbnz x22, pt_ready
> -
> + /* Setup boot_pgtable: */
> ldr x1, =boot_first
> - add x1, x1, x20 /* x1 := paddr (xen_first) */
> - mov x3, #PT_PT /* x2 := table map of xen_first */
> - orr x2, x1, x3 /* (+ rights for linear PT) */
> - str x2, [x4, #0] /* Map it in slot 0 */
> + add x1, x1, x20 /* x1 := paddr (boot_first) */
>
> - mov x4, x1 /* Next level into xen_first */
> + /* ... map boot_first in boot_pgtable[0] */
> + mov x3, #PT_PT /* x2 := table map of boot_first */
> + orr x2, x1, x3 /* + rights for linear PT */
> + str x2, [x4, #0] /* Map it in slot 0 */
>
> - /* console fixmap */
> - ldr x1, =xen_fixmap
> - add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
> - lsr x2, x23, #12
> - lsl x2, x2, #12 /* 4K aligned paddr of UART */
> - mov x3, #PT_DEV_L3
> - orr x2, x2, x3 /* x2 := 4K dev map including UART */
> - str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
> + /* ... map of paddr(start) in boot_pgtable */
> + lsr x1, x19, #39 /* Offset of base paddr in boot_pgtable */
> + cbz x1, 1f /* It's in slot 0, map in boot_first
> + * or boot_second later on */
>
> - /* Build the baseline idle pagetable's first-level entries */
> - ldr x1, =xen_second
> - add x1, x1, x20 /* x1 := paddr (xen_second) */
> - mov x3, #PT_PT /* x2 := table map of xen_second */
> - orr x2, x1, x3 /* (+ rights for linear PT) */
> + lsl x2, x1, #39 /* Base address for 512GB mapping */
> + mov x3, #PT_MEM /* x2 := Section mapping */
> + orr x2, x2, x3
> + lsl x1, x1, #3 /* x1 := Slot offset */
> + str x2, [x4, x1] /* Mapping of paddr(start)*/
> +
> +1: /* Setup boot_first: */
> + ldr x4, =boot_first /* Next level into boot_first */
> + add x4, x4, x20 /* x4 := paddr(boot_first) */
> +
> + /* ... map boot_second in boot_first[0] */
> + ldr x1, =boot_second
> + add x1, x1, x20 /* x1 := paddr(boot_second) */
> + mov x3, #PT_PT /* x2 := table map of boot_first */
> + orr x2, x1, x3 /* + rights for linear PT */
> str x2, [x4, #0] /* Map it in slot 0 */
> - add x2, x2, #0x1000
> - str x2, [x4, #8] /* Map 2nd page in slot 1 */
> - add x2, x2, #0x1000
> - str x2, [x4, #16] /* Map 3rd page in slot 2 */
> - add x2, x2, #0x1000
> - str x2, [x4, #24] /* Map 4th page in slot 3 */
> -
> - /* Now set up the second-level entries */
> - mov x3, #PT_MEM
> - orr x2, x19, x3 /* x2 := 2MB normal map of Xen */
> - orr x4, xzr, x19, lsr #18
> - str x2, [x1, x4] /* Map Xen there */
> - ldr x4, =start
> - lsr x4, x4, #18 /* Slot for vaddr(start) */
> - str x2, [x1, x4] /* Map Xen there too */
> -
> - /* xen_fixmap pagetable */
> - ldr x2, =xen_fixmap
> - add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
> - mov x3, #PT_PT
> - orr x2, x2, x3 /* x2 := table map of xen_fixmap */
> - add x4, x4, #8
> - str x2, [x1, x4] /* Map it in the fixmap's slot */
>
> - lsr x2, x21, #21
> - lsl x2, x2, #21 /* 2MB-aligned paddr of DTB */
> - mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
> + /* ... map of paddr(start) in boot_first */
> + lsr x2, x19, #30 /* x2 := Offset of base paddr in boot_first */
> + and x1, x2, 0x1ff /* x1 := Slot to use */
> + cbz x1, 1f /* It's in slot 0, map in boot_second */
> +
> + lsl x2, x2, #30 /* Base address for 1GB mapping */
> + mov x3, #PT_MEM /* x2 := Section map */
> orr x2, x2, x3
> - add x4, x4, #8
> - str x2, [x1, x4] /* Map it in the early boot slot */
> + lsl x1, x1, #3 /* x1 := Slot offset */
> + str x2, [x4, x1] /* Create mapping of paddr(start)*/
> +
> +1: /* Setup boot_second: */
> + ldr x4, =boot_second
> + add x4, x4, x20 /* x4 := paddr (boot_second) */
> +
> + lsr x2, x19, #20 /* Base address for 2MB mapping */
> + lsl x2, x2, #20
> + mov x3, #PT_MEM /* x2 := Section map */
> + orr x2, x2, x3
> +
> + /* ... map of vaddr(start) in boot_second */
> + ldr x1, =start
> + lsr x1, x1, #18 /* Slot for vaddr(start) */
> + str x2, [x4, x1] /* Map vaddr(start) */
> +
> + /* ... map of paddr(start) in boot_second */
> + lsr x1, x19, #30 /* Base paddr */
> + cbnz x1, 1f /* If paddr(start) is not in slot 0
> + * then the mapping was done in
> + * boot_pgtable or boot_first above */
> +
> + lsr x1, x19, #18 /* Slot for paddr(start) */
> + str x2, [x4, x1] /* Map Xen there */
> +1:
> +
> + /* Defer fixmap and dtb mapping until after paging enabled, to
> + * avoid them clashing with the 1:1 mapping. */
> +
> + /* boot pagetable setup complete */
>
> -pt_ready:
> PRINT("- Turning on paging -\r\n")
>
> ldr x1, =paging /* Explicit vaddr, not RIP-relative */
> @@ -279,17 +339,60 @@ pt_ready:
> br x1 /* Get a proper vaddr into PC */
> paging:
>
> + /* Now we can install the fixmap and dtb mappings, since we
> + * don't need the 1:1 map any more */
> + dsb sy
> +#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
> + /* Non-boot CPUs don't need to rebuild the fixmap itself, just
> + * the mapping from boot_second to xen_fixmap */
> + cbnz x22, 1f
> +
> + /* Add UART to the fixmap table */
> + ldr x1, =xen_fixmap
> + add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
> + lsr x2, x23, #12
> + lsl x2, x2, #12 /* 4K aligned paddr of UART */
> + mov x3, #PT_DEV_L3
> + orr x2, x2, x3 /* x2 := 4K dev map including UART */
> + str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
> +1:
> +
> + /* Map fixmap into boot_second */
> + ldr x4, =boot_second /* x4 := vaddr (boot_second) */
> + ldr x2, =xen_fixmap
> + add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
> + mov x3, #PT_PT
> + orr x2, x2, x3 /* x2 := table map of xen_fixmap */
> + ldr x1, =FIXMAP_ADDR(0)
> + lsr x1, x1, #18 /* x1 := Slot for FIXMAP(0) */
> + str x2, [x4, x1] /* Map it in the fixmap's slot */
> +
> /* Use a virtual address to access the UART. */
> ldr x23, =FIXMAP_ADDR(FIXMAP_CONSOLE)
> +#endif
> +
> + /* Map the DTB in the boot misc slot */
> + cbnz x22, 1f /* Only on boot CPU */
> +
> + lsr x2, x21, #21
> + lsl x2, x2, #21 /* x2 := 2MB-aligned paddr of DTB */
> + mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
> + orr x2, x2, x3
> + ldr x1, =BOOT_MISC_VIRT_START
> + lsr x1, x1, #18 /* x4 := Slot for BOOT_MISC_VIRT_START */
> + str x2, [x4, x1] /* Map it in the early boot slot */
> + dsb sy
> +1:
>
> PRINT("- Ready -\r\n")
>
> /* The boot CPU should go straight into C now */
> cbz x22, launch
>
> - /* Non-boot CPUs need to move on to the relocated pagetables */
> - ldr x4, =boot_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
> - add x4, x4, x20 /* PA of it */
> + /* Non-boot CPUs need to move on to the proper pagetables, which were
> + * setup in init_secondary_pagetables. */
> +
> + ldr x4, =init_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
> ldr x4, [x4] /* Actual value */
> dsb sy
> msr TTBR0_EL2, x4
> @@ -299,28 +402,6 @@ paging:
> dsb sy /* Ensure completion of TLB flush */
> isb
>
> - /* Non-boot CPUs report that they've got this far */
> - ldr x0, =ready_cpus
> -1: ldaxr x1, [x0] /* { read # of ready CPUs } */
> - add x1, x1, #1 /* Atomically { ++ } */
> - stlxr w2, x1, [x0] /* { writeback } */
> - cbnz w2, 1b
> - dsb sy
> - dc cvac, x0 /* Flush D-Cache */
> - dsb sy
> -
> - /* Here, the non-boot CPUs must wait again -- they're now running on
> - * the boot CPU's pagetables so it's safe for the boot CPU to
> - * overwrite the non-relocated copy of Xen. Once it's done that,
> - * and brought up the memory allocator, non-boot CPUs can get their
> - * own stacks and enter C. */
> -1: wfe
> - dsb sy
> - ldr x0, =smp_up_cpu
> - ldr x1, [x0] /* Which CPU is being booted? */
> - cmp x1, x22 /* Is it us? */
> - b.ne 1b
> -
> launch:
> ldr x0, =init_data
> add x0, x0, #INITINFO_stack /* Find the boot-time stack */
> @@ -331,7 +412,7 @@ launch:
>
> mov x0, x20 /* Marshal args: - phys_offset */
> mov x1, x21 /* - FDT */
> - mov x2, x22 /* - CPU ID */
> + mov x2, x24 /* - CPU ID */
> cbz x22, start_xen /* and disappear into the land of C */
> b start_secondary /* (to the appropriate entry point) */
>
> @@ -341,13 +422,80 @@ fail: PRINT("- Boot failed -\r\n")
> 1: wfe
> b 1b
>
> -#ifdef EARLY_PRINTK
> +/* Copy Xen to new location and switch TTBR
> + * x0 ttbr
> + * x1 source address
> + * x2 destination address
> + * x3 length
> + *
> + * Source and destination must be word aligned, length is rounded up
> + * to a 16 byte boundary.
> + *
> + * MUST BE VERY CAREFUL when saving things to RAM over the copy */
> +ENTRY(relocate_xen)
> + /* Copy 16 bytes at a time using:
> + * x9: counter
> + * x10: data
> + * x11: data
> + * x12: source
> + * x13: destination
> + */
> + mov x9, x3
> + mov x12, x1
> + mov x13, x2
>
> +1: ldp x10, x11, [x12], #16
> + stp x10, x11, [x13], #16
> +
> + subs x9, x9, #16
> + bgt 1b
> +
> + /* Flush destination from dcache using:
> + * x9: counter
> + * x10: step
> + * x11: vaddr
> + */
> + dsb sy /* So the CPU issues all writes to the range */
> +
> + mov x9, x3
> + ldr x10, =cacheline_bytes /* x10 := step */
> + ldr x10, [x10]
> + mov x11, x2
> +
> +1: dc cvac, x11
> +
> + add x11, x11, x10
> + subs x9, x9, x10
> + bgt 1b
> +
> + dsb sy /* Ensure the flushes happen before
> + * continuing */
> + isb /* Ensure synchronization with previous
> + * changes to text */
> + tlbi alle2 /* Flush hypervisor TLB */
> + ic iallu /* Flush I-cache */
> + dsb sy /* Ensure completion of TLB flush */
> + isb
> +
> + msr TTBR0_EL2, x0
> +
> + isb /* Ensure synchronization with previous
> + * changes to text */
> + tlbi alle2 /* Flush hypervisor TLB */
> + ic iallu /* Flush I-cache */
> + dsb sy /* Ensure completion of TLB flush */
> + isb
> +
> + ret
> +
> +#ifdef EARLY_PRINTK
> /* Bring up the UART.
> * x23: Early UART base address
> * Clobbers x0-x1 */
> init_uart:
> +#ifdef EARLY_PRINTK_INIT_UART
> early_uart_init x23, 0
> +#endif
> adr x0, 1f
> b puts
> 1: .asciz "- UART enabled -\r\n"
> diff --git a/xen/arch/arm/arm64/mode_switch.S b/xen/arch/arm/arm64/mode_switch.S
> deleted file mode 100644
> index ea64f22..0000000
> --- a/xen/arch/arm/arm64/mode_switch.S
> +++ /dev/null
> @@ -1,89 +0,0 @@
> -/*
> - * xen/arch/arm/arm64/mode_switch.S
> - *
> - * Start-of day code to take a CPU from EL3 to EL2. Largely taken from
> - * bootwrapper.
> - *
> - * Ian Campbell <ian.campbell@citrix.com>
> - * Copyright (c) 2012 Citrix Systems.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> -
> -#include <asm/config.h>
> -#include <asm/page.h>
> -#include <asm/asm_defns.h>
> -#include <asm/platforms/vexpress.h>
> -
> -/* Get up a CPU into EL2. Clobbers x0-x3.
> - *
> - * Expects x22 == CPU number
> - * Expects x30 == EL2 entry point
> - *
> - * This code is specific to the VE model, and not intended to be used
> - * on production systems. As such it's a bit hackier than the main
> - * boot code in head.S. In future it will be replaced by better
> - * integration with the bootloader/firmware so that Xen always starts
> - * at EL2.
> - */
> -GLOBAL(enter_el2_mode)
> - mov x0, #0x30 // RES1
> - orr x0, x0, #(1 << 0) // Non-secure EL1
> - orr x0, x0, #(1 << 8) // HVC enable
> - orr x0, x0, #(1 << 10) // 64-bit EL2
> - msr scr_el3, x0
> -
> - msr cptr_el3, xzr // Disable copro. traps to EL3
> -
> - ldr x0, =0x01800000 // 24Mhz
> - msr cntfrq_el0, x0
> -
> - /*
> - * Check for the primary CPU to avoid a race on the distributor
> - * registers.
> - */
> - cbnz x22, 1f
> -
> - ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET) // GICD_CTLR
> - mov w0, #3 // EnableGrp0 | EnableGrp1
> - str w0, [x1]
> -
> -1: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET+0x80) // GICD_IGROUPR
> - mov w0, #~0 // Grp1 interrupts
> - str w0, [x1], #4
> - b.ne 2f // Only local interrupts for secondary CPUs
> - str w0, [x1], #4
> - str w0, [x1], #4
> -
> -2: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_CR_OFFSET) // GICC_CTLR
> - ldr w0, [x1]
> - mov w0, #3 // EnableGrp0 | EnableGrp1
> - str w0, [x1]
> -
> - mov w0, #1 << 7 // allow NS access to GICC_PMR
> - str w0, [x1, #4] // GICC_PMR
> -
> - msr sctlr_el2, xzr
> -
> - /*
> - * Prepare the switch to the EL2_SP1 mode from EL3
> - */
> - msr elr_el3, x30 // Return to desired function
> - mov x1, #0x3c9 // EL2_SP1 | D | A | I | F
> - msr spsr_el3, x1
> - eret
> -
> -/*
> - * Local variables:
> - * mode: ASM
> - * indent-tabs-mode: nil
> - * End:
> - */
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 3d7b2f5..701bc2e 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -43,40 +43,70 @@
>
> struct domain *dom_xen, *dom_io, *dom_cow;
>
> -/* Static start-of-day pagetables that we use before the
> - * allocators are up. These go on to become the boot CPU's real pagetables.
> +/* Static start-of-day pagetables that we use before the allocators
> + * are up. These are used by all CPUs during bringup before switching
> + * to the CPUs own pagetables.
> + *
> + * These pagetables have a very simple structure. They include:
> + * - a 2MB mapping of xen at XEN_VIRT_START, boot_first and
> + * boot_second are used to populate the trie down to that mapping.
> + * - a 1:1 mapping of xen at its current physical address. This uses a
> + * section mapping at whichever of boot_{pgtable,first,second}
> + * covers that physical address.
> + *
> + * For the boot CPU these mappings point to the address where Xen was
> + * loaded by the bootloader. For secondary CPUs they point to the
> + * relocated copy of Xen for the benefit of secondary CPUs.
> + *
> + * In addition to the above for the boot CPU the device-tree is
> + * initially mapped in the boot misc slot. This mapping is not present
> + * for secondary CPUs.
> + *
> + * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped
> + * by the CPU once it has moved off the 1:1 mapping.
> */
> lpae_t boot_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> #ifdef CONFIG_ARM_64
> lpae_t boot_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> -/* The first page of the first level mapping of the xenheap. The
> - * subsequent xenheap first level pages are dynamically allocated, but
> - * we need this one to bootstrap ourselves. */
> -lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> -/* The zeroeth level slot which uses xenheap_first_first. Used because
> - * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
> - * valid for a non-xenheap mapping. */
> -static __initdata int xenheap_first_first_slot = -1;
> #endif
> +lpae_t boot_second[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> +
> +/* Main runtime page tables */
>
> /*
> - * xen_pgtable and xen_dommap are per-PCPU and are allocated before
> - * bringing up each CPU. On 64-bit a first level table is also allocated.
> + * For arm32 xen_pgtable and xen_dommap are per-PCPU and are allocated before
> + * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs.
> *
> - * xen_second, xen_fixmap and xen_xenmap are shared between all PCPUs.
> + * xen_second, xen_fixmap and xen_xenmap are always shared between all
> + * PCPUs.
> */
>
> #ifdef CONFIG_ARM_64
> -#define THIS_CPU_PGTABLE boot_pgtable
> +lpae_t xen_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> +lpae_t xen_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> +#define THIS_CPU_PGTABLE xen_pgtable
> #else
> /* Per-CPU pagetable pages */
> /* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */
> static DEFINE_PER_CPU(lpae_t *, xen_pgtable);
> #define THIS_CPU_PGTABLE this_cpu(xen_pgtable)
> /* xen_dommap == pages used by map_domain_page, these pages contain
> - * the second level pagetables which mapp the domheap region
> + * the second level pagetables which map the domheap region
> * DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */
> static DEFINE_PER_CPU(lpae_t *, xen_dommap);
> +/* Root of the trie for cpu0 */
> +lpae_t cpu0_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> +#endif
> +
> +#ifdef CONFIG_ARM_64
> +/* The first page of the first level mapping of the xenheap. The
> + * subsequent xenheap first level pages are dynamically allocated, but
> + * we need this one to bootstrap ourselves. */
> +lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> +/* The zeroeth level slot which uses xenheap_first_first. Used because
> + * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
> + * valid for a non-xenheap mapping. */
> +static __initdata int xenheap_first_first_slot = -1;
> #endif
>
> /* Common pagetable leaves */
> @@ -104,9 +134,8 @@ lpae_t xen_fixmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
> * as appropriate. */
> static lpae_t xen_xenmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
>
> -
> /* Non-boot CPUs use this to find the correct pagetables. */
> -uint64_t boot_ttbr;
> +uint64_t init_ttbr;
>
> static paddr_t phys_offset;
>
> @@ -131,6 +160,12 @@ static inline void check_memory_layout_alignment_constraints(void) {
> BUILD_BUG_ON(BOOT_MISC_VIRT_START & ~SECOND_MASK);
> /* 1GB aligned regions */
> BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK);
> + /* Page table structure constraints */
> +#ifdef CONFIG_ARM_64
> + BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
> +#endif
> + BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
> + BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= LPAE_ENTRIES);
> #ifdef CONFIG_DOMAIN_PAGE
> BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
> #endif
> @@ -361,16 +396,6 @@ void __cpuinit setup_virt_paging(void)
> WRITE_SYSREG32(0x80002558, VTCR_EL2); isb();
> }
>
> -/* This needs to be a macro to stop the compiler spilling to the stack
> - * which will change when we change pagetables */
> -#define WRITE_TTBR(ttbr) \
> - flush_xen_text_tlb(); \
> - WRITE_SYSREG64(ttbr, TTBR0_EL2); \
> - dsb(); /* ensure memory accesses do not cross over the TTBR0 write */ \
> - /* flush_xen_text_tlb contains an initial isb which ensures the \
> - * write to TTBR0 has completed. */ \
> - flush_xen_text_tlb()
> -
> static inline lpae_t pte_of_xenaddr(vaddr_t va)
> {
> paddr_t ma = va + phys_offset;
> @@ -378,69 +403,73 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va)
> return mfn_to_xen_entry(mfn);
> }
>
> +extern void relocate_xen(uint64_t ttbr, void *src, void *dst, size_t len);
> +
> /* Boot-time pagetable setup.
> * Changes here may need matching changes in head.S */
> void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
> {
> + uint64_t ttbr;
> unsigned long dest_va;
> lpae_t pte, *p;
> int i;
>
> - /* Map the destination in the boot misc area. */
> - dest_va = BOOT_MISC_VIRT_START;
> - pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
> - write_pte(xen_second + second_table_offset(dest_va), pte);
> - flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
> -
> /* Calculate virt-to-phys offset for the new location */
> phys_offset = xen_paddr - (unsigned long) _start;
>
> - /* Copy */
> - memcpy((void *) dest_va, _start, _end - _start);
> -
> - /* Beware! Any state we modify between now and the PT switch may be
> - * discarded when we switch over to the copy. */
> -
> - /* Update the copy of boot_pgtable to use the new paddrs */
> - p = (void *) boot_pgtable + dest_va - (unsigned long) _start;
> #ifdef CONFIG_ARM_64
> - p[0].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
> - p = (void *) boot_first + dest_va - (unsigned long) _start;
> + p = (void *) xen_pgtable;
> + p[0] = pte_of_xenaddr((uintptr_t)xen_first);
> + p[0].pt.table = 1;
> + p[0].pt.xn = 0;
> + p = (void *) xen_first;
> +#else
> + p = (void *) cpu0_pgtable;
> #endif
> - for ( i = 0; i < 4; i++)
> - p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
>
> - p = (void *) xen_second + dest_va - (unsigned long) _start;
> - if ( boot_phys_offset != 0 )
> + /* Initialise first level entries, to point to second level entries */
> + for ( i = 0; i < 4; i++)
> {
> - /* Remove the old identity mapping of the boot paddr */
> - vaddr_t va = (vaddr_t)_start + boot_phys_offset;
> - p[second_linear_offset(va)].bits = 0;
> + p[i] = pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
> + p[i].pt.table = 1;
> + p[i].pt.xn = 0;
> }
> - for ( i = 0; i < 4 * LPAE_ENTRIES; i++)
> - if ( p[i].pt.valid )
> - p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
> -
> - /* Change pagetables to the copy in the relocated Xen */
> - boot_ttbr = (uintptr_t) boot_pgtable + phys_offset;
> - flush_xen_dcache(boot_ttbr);
> - flush_xen_dcache_va_range((void*)dest_va, _end - _start);
>
> - WRITE_TTBR(boot_ttbr);
> + /* Initialise xen second level entries ... */
> + /* ... Xen's text etc */
>
> - /* Undo the temporary map */
> - pte.bits = 0;
> - write_pte(xen_second + second_table_offset(dest_va), pte);
> - flush_xen_text_tlb();
> + pte = mfn_to_xen_entry(xen_paddr>>PAGE_SHIFT);
> + pte.pt.xn = 0;/* Contains our text mapping! */
> + xen_second[second_table_offset(XEN_VIRT_START)] = pte;
>
> - /* Link in the fixmap pagetable */
> + /* ... Fixmap */
> pte = pte_of_xenaddr((vaddr_t)xen_fixmap);
> pte.pt.table = 1;
> - write_pte(xen_second + second_table_offset(FIXMAP_ADDR(0)), pte);
> - /*
> - * No flush required here. Individual flushes are done in
> - * set_fixmap as entries are used.
> - */
> + xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte;
> +
> + /* Map the destination in the boot misc area. */
> + dest_va = BOOT_MISC_VIRT_START;
> + pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
> + write_pte(boot_second + second_table_offset(dest_va), pte);
> + flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
> +#ifdef CONFIG_ARM_64
> + ttbr = (uintptr_t) xen_pgtable + phys_offset;
> +#else
> + ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
> +#endif
> +
> + relocate_xen(ttbr, _start, (void*)dest_va, _end - _start);
> +
> + /* Clear the copy of the boot pagetables. Each secondary CPU
> + * rebuilds these itself (see head.S) */
> + memset(boot_pgtable, 0x0, PAGE_SIZE);
> + flush_xen_dcache(boot_pgtable);
> +#ifdef CONFIG_ARM_64
> + memset(boot_pgtable, 0x0, PAGE_SIZE);
> + flush_xen_dcache(boot_first);
> +#endif
> + memset(boot_second, 0x0, PAGE_SIZE);
> + flush_xen_dcache(boot_second);
>
> /* Break up the Xen mapping into 4k pages and protect them separately. */
> for ( i = 0; i < LPAE_ENTRIES; i++ )
> @@ -461,6 +490,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
> write_pte(xen_xenmap + i, pte);
> /* No flush required here as page table is not hooked in yet. */
> }
> +
> pte = pte_of_xenaddr((vaddr_t)xen_xenmap);
> pte.pt.table = 1;
> write_pte(xen_second + second_linear_offset(XEN_VIRT_START), pte);
> @@ -472,7 +502,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
> flush_xen_text_tlb();
>
> #ifdef CONFIG_ARM_32
> - per_cpu(xen_pgtable, 0) = boot_pgtable;
> + per_cpu(xen_pgtable, 0) = cpu0_pgtable;
> per_cpu(xen_dommap, 0) = xen_second +
> second_linear_offset(DOMHEAP_VIRT_START);
>
> @@ -483,10 +513,14 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
> DOMHEAP_SECOND_PAGES*PAGE_SIZE);
> #endif
> }
> +
> #ifdef CONFIG_ARM_64
> int init_secondary_pagetables(int cpu)
> {
> - /* All CPUs share a single page table on 64 bit */
> + /* Set init_ttbr for this CPU coming up. All CPus share a single setof
> + * pagetables, but rewrite it each time for consistency with 32 bit. */
> + init_ttbr = (uintptr_t) xen_pgtable + phys_offset;
> + flush_xen_dcache(init_ttbr);
> return 0;
> }
> #else
> @@ -507,7 +541,7 @@ int init_secondary_pagetables(int cpu)
> }
>
> /* Initialise root pagetable from root of boot tables */
> - memcpy(first, boot_pgtable, PAGE_SIZE);
> + memcpy(first, cpu0_pgtable, PAGE_SIZE);
>
> /* Ensure the domheap has no stray mappings */
> memset(domheap, 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE);
> @@ -527,6 +561,10 @@ int init_secondary_pagetables(int cpu)
> per_cpu(xen_pgtable, cpu) = first;
> per_cpu(xen_dommap, cpu) = domheap;
>
> + /* Set init_ttbr for this CPU coming up */
> + init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> + flush_xen_dcache(init_ttbr);
> +
> return 0;
> }
> #endif
> @@ -534,12 +572,6 @@ int init_secondary_pagetables(int cpu)
> /* MMU setup for secondary CPUS (which already have paging enabled) */
> void __cpuinit mmu_init_secondary_cpu(void)
> {
> - uint64_t ttbr;
> -
> - /* Change to this CPU's pagetables */
> - ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
> - WRITE_TTBR(ttbr);
> -
> /* From now on, no mapping may be both writable and executable. */
> WRITE_SYSREG32(READ_SYSREG32(SCTLR_EL2) | SCTLR_WXN, SCTLR_EL2);
> flush_xen_text_tlb();
> @@ -612,7 +644,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
> while ( base_mfn < end_mfn )
> {
> int slot = zeroeth_table_offset(vaddr);
> - lpae_t *p = &boot_pgtable[slot];
> + lpae_t *p = &xen_pgtable[slot];
>
> if ( p->pt.valid )
> {
> @@ -679,7 +711,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
> {
> pte = mfn_to_xen_entry(second_base + i);
> pte.pt.table = 1;
> - write_pte(&boot_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
> + write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
> }
> create_32mb_mappings(second, 0, base_mfn, frametable_size >> PAGE_SHIFT);
> #else
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 07338e1..a943dc8 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -518,7 +518,7 @@ void __init setup_cache(void)
> * MPIDR values related to logical cpus
> * Code base on Linux arch/arm/kernel/devtree.c
> */
> -static void __init init_cpus_maps(void)
> +static void __init smp_init_cpus(void)
> {
> register_t mpidr;
> struct dt_device_node *cpus = dt_find_node_by_path("/cpus");
> @@ -530,6 +530,14 @@ static void __init init_cpus_maps(void)
> [0 ... NR_CPUS - 1] = MPIDR_INVALID
> };
> bool_t bootcpu_valid = 0;
> + int rc;
> +
> + if ( (rc = arch_smp_init()) < 0 )
> + {
> + printk(XENLOG_WARNING "SMP init failed (%d)\n"
> + "Using only 1 CPU\n", rc);
> + return;
> + }
>
> mpidr = boot_cpu_data.mpidr.bits & MPIDR_HWID_MASK;
>
> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> }
> }
>
> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> + {
> + printk("cpu init failed (hwid %x): %d\n", hwid, rc);
> + continue;
> + }
> +
> /*
> * Build a stashed array of MPIDR values. Numbering scheme requires
> * that if detected the boot CPU must be assigned logical id 0. Other
> @@ -599,7 +613,8 @@ static void __init init_cpus_maps(void)
>
> if ( cpuidx > NR_CPUS )
> {
> - printk(XENLOG_WARNING "DT /cpu %u node greater than max cores %u, capping them\n",
> + printk(XENLOG_WARNING
> + "DT /cpu %u node greater than max cores %u, capping them\n",
> cpuidx, NR_CPUS);
> cpuidx = NR_CPUS;
> break;
> @@ -657,15 +672,14 @@ void __init start_xen(unsigned long boot_phys_offset,
>
> processor_id();
>
> - init_cpus_maps();
> - cpus = smp_get_max_cpus();
> -
> platform_init();
>
> + smp_init_cpus();
> + cpus = smp_get_max_cpus();
> +
> init_xen_time();
>
> gic_init();
> - make_cpus_ready(cpus, boot_phys_offset);
>
> set_current((struct vcpu *)0xfffff000); /* debug sanity */
> idle_vcpu[0] = current;
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 234748e..7b4ad8a 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -56,12 +56,10 @@ struct init_info __initdata init_data =
> };
>
> /* Shared state for coordinating CPU bringup */
> -unsigned long smp_up_cpu = 0;
> +unsigned long smp_up_cpu = ~0UL;
> +/* Shared state for coordinating CPU teardown */
> static bool_t cpu_is_dead = 0;
>
> -/* Number of non-boot CPUs ready to enter C */
> -unsigned long __initdata ready_cpus = 0;
> -
> /* ID of the PCPU we're running on */
> DEFINE_PER_CPU(unsigned int, cpu_id);
> /* XXX these seem awfully x86ish... */
> @@ -103,7 +101,6 @@ smp_get_max_cpus (void)
> return max_cpus;
> }
>
> -
> void __init
> smp_prepare_cpus (unsigned int max_cpus)
> {
> @@ -112,32 +109,6 @@ smp_prepare_cpus (unsigned int max_cpus)
> setup_cpu_sibling_map(0);
> }
>
> -void __init
> -make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset)
> -{
> - unsigned long *gate;
> - paddr_t gate_pa;
> - int i;
> -
> - printk("Waiting for %i other CPUs to be ready\n", max_cpus - 1);
> - /* We use the unrelocated copy of smp_up_cpu as that's the one the
> - * others can see. */
> - gate_pa = ((paddr_t) (unsigned long) &smp_up_cpu) + boot_phys_offset;
> - gate = map_domain_page(gate_pa >> PAGE_SHIFT) + (gate_pa & ~PAGE_MASK);
> - for ( i = 1; i < max_cpus; i++ )
> - {
> - /* Tell the next CPU to get ready */
> - *gate = cpu_logical_map(i);
> - flush_xen_dcache(*gate);
> - isb();
> - sev();
> - /* And wait for it to respond */
> - while ( ready_cpus < i )
> - smp_rmb();
> - }
> - unmap_domain_page(gate);
> -}
> -
> /* Boot the current CPU */
> void __cpuinit start_secondary(unsigned long boot_phys_offset,
> unsigned long fdt_paddr,
> @@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
> wmb();
>
> /* Now report this CPU is up */
> + smp_up_cpu = ~0UL;
> cpumask_set_cpu(cpuid, &cpu_online_map);
> wmb();
>
> @@ -226,6 +198,8 @@ int __cpu_up(unsigned int cpu)
> {
> int rc;
>
> + printk("Bringing up CPU%d\n", cpu);
> +
> rc = init_secondary_pagetables(cpu);
> if ( rc < 0 )
> return rc;
> @@ -236,14 +210,22 @@ int __cpu_up(unsigned int cpu)
> /* Tell the remote CPU what is it's logical CPU ID */
> init_data.cpuid = cpu;
>
> - /* Unblock the CPU. It should be waiting in the loop in head.S
> - * for an event to arrive when smp_up_cpu matches its cpuid. */
> + /* Open the gate for this CPU */
> smp_up_cpu = cpu_logical_map(cpu);
> - /* we need to make sure that the change to smp_up_cpu is visible to
> - * secondary cpus with D-cache off */
> flush_xen_dcache(smp_up_cpu);
> - isb();
> - sev();
> +
> + rc = arch_cpu_up(cpu);
> +
> + if ( rc < 0 )
> + {
> + printk("Failed to bring up CPU%d\n", cpu);
> + return rc;
> + }
> +
> + /* We don't know the GIC ID of the CPU until it has woken up, so just signal
> + * everyone and rely on our own smp_up_cpu gate to ensure only the one we
> + * want gets through. */
> + send_SGI_allbutself(GIC_SGI_EVENT_CHECK);
>
> while ( !cpu_online(cpu) )
> {
> @@ -272,7 +254,6 @@ void __cpu_die(unsigned int cpu)
> mb();
> }
>
> -
> /*
> * Local variables:
> * mode: C
> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index 173db1b..188b385 100644
> --- a/xen/include/asm-arm/mm.h
> +++ b/xen/include/asm-arm/mm.h
> @@ -147,7 +147,8 @@ extern unsigned long total_pages;
>
> /* Boot-time pagetable setup */
> extern void setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr);
> -/* Allocate and initialise pagetables for a secondary CPU */
> +/* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the
> + * new page table */
> extern int __cpuinit init_secondary_pagetables(int cpu);
> /* Switch secondary CPUS to its own pagetables and finalise MMU setup */
> extern void __cpuinit mmu_init_secondary_cpu(void);
> diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
> index ee5bdfa..af30608 100644
> --- a/xen/include/asm-arm/platforms/exynos5.h
> +++ b/xen/include/asm-arm/platforms/exynos5.h
> @@ -14,20 +14,6 @@
>
> #define S5P_PA_SYSRAM 0x02020000
>
> -/* Constants below is only used in assembly because the DTS is not yet parsed */
> -#ifdef __ASSEMBLY__
> -
> -/* GIC Base Address */
> -#define EXYNOS5_GIC_BASE_ADDRESS 0x10480000
> -
> -/* Timer's frequency */
> -#define EXYNOS5_TIMER_FREQUENCY (24 * 1000 * 1000) /* 24 MHz */
> -
> -/* Arndale machine ID */
> -#define MACH_TYPE_SMDK5250 3774
> -
> -#endif /* __ASSEMBLY__ */
> -
> #endif /* __ASM_ARM_PLATFORMS_EXYNOS5_H */
> /*
> * Local variables:
> diff --git a/xen/include/asm-arm/platforms/vexpress.h b/xen/include/asm-arm/platforms/vexpress.h
> index 982a293..5cf3aba 100644
> --- a/xen/include/asm-arm/platforms/vexpress.h
> +++ b/xen/include/asm-arm/platforms/vexpress.h
> @@ -32,17 +32,6 @@
> int vexpress_syscfg(int write, int function, int device, uint32_t *data);
> #endif
>
> -/* Constants below is only used in assembly because the DTS is not yet parsed */
> -#ifdef __ASSEMBLY__
> -
> -/* GIC base address */
> -#define V2M_GIC_BASE_ADDRESS 0x2c000000
> -
> -/* Timer's frequency */
> -#define V2M_TIMER_FREQUENCY 0x5f5e100 /* 100 Mhz */
> -
> -#endif /* __ASSEMBLY__ */
> -
> #endif /* __ASM_ARM_PLATFORMS_VEXPRESS_H */
> /*
> * Local variables:
> diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h
> index 1added5..83add6c 100644
> --- a/xen/include/asm-arm/smp.h
> +++ b/xen/include/asm-arm/smp.h
> @@ -17,12 +17,6 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
>
> extern void stop_cpu(void);
>
> -/* Bring the non-boot CPUs up to paging and ready to enter C.
> - * Must be called after Xen is relocated but before the original copy of
> - * .text gets overwritten. */
> -extern void
> -make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset);
> -
> extern int arch_smp_init(void);
> extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
> extern int arch_cpu_up(int cpu);
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework
2013-09-27 12:23 ` Julien Grall
@ 2013-09-27 12:35 ` Ian Campbell
0 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 12:35 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 13:23 +0100, Julien Grall wrote:
> > +#ifdef CONFIG_ARM_32
> > +
> > +static int vexpress_smp_init(void)
>
> platform_smp_init is in init section. vexpress_smp should also be here.
True. The same is no doubt true of the exynos patch. Will fix them all.
Ian.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 12:30 ` Julien Grall
@ 2013-09-27 12:37 ` Ian Campbell
0 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 12:37 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 13:30 +0100, Julien Grall wrote:
> On 09/27/2013 11:20 AM, Ian Campbell wrote:
> > This is unfortunately a rather large monolithic patch.
> >
> > Rather than bringing up all CPUs in lockstep as we setup paging and relocate
> > Xen instead create a simplified set of dedicated boot time pagetables.
> >
> > This allows secondary CPUs to remain powered down or in the firmware until we
> > actually want to enable them. The bringup is now done later on in C and can be
> > driven by DT etc. I have included code for the vexpress platform, but other
> > platforms will need to be added.
> >
> > The mechanism for deciding how to bring up a CPU differs between arm32 and
> > arm64. On arm32 it is essentially a per-platform property, with the exception
> > of PSCI which can be implemented globally (but isn't here). On arm64 there is a
> > per-cpu property in the device tree.
> >
> > Secondary CPUs are brought up directly into the relocated Xen image, instead of
> > relying on being able to launch on the unrelocated Xen and hoping that it
> > hasn't been clobbered.
> >
> > As part of this change drop support for switching from secure mode to NS HYP as
> > well as the early CPU kick. Xen now requires that it is launched in NS HYP
> > mode and that firmware configure things such that secondary CPUs can be woken
> > up by a primarly CPU in HYP mode. This may require fixes to bootloaders or the
> > use of a boot wrapper.
> >
> > The changes done here (re)exposed an issue with relocating Xen and the compiler
> > spilling values to the stack between the copy and the actual switch to the
> > relocaed copy of Xen in setup_pagetables. Therefore switch to doing the copy
> > and switch in a single asm function where we can control precisely what gets
> > spilled to the stack etc.
> >
> > Since we now have a separate set of boot pagetables it is much easier to build
> > the real Xen pagetables inplace before relocating rather than the more complex
> > approach of rewriting the pagetables in the relocated copy before switching.
> >
> > This will also enable Xen to be loaded above the 4GB boundary on 64-bit.
>
> There is a conflict with this patch and your recently pushed patch
> series "xen: arm: memory mangement fixes / improvements".
Thanks, I thought I'd rebased after pushing that but obviously not.
I'll rebase, if it's not too much surgery I won't both reposting.
Ian.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 10:20 ` [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-27 12:30 ` Julien Grall
@ 2013-09-27 13:30 ` Julien Grall
2013-09-27 14:10 ` Ian Campbell
1 sibling, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 13:30 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 11:20 AM, Ian Campbell wrote:
[..]
> -static void __init init_cpus_maps(void)
> +static void __init smp_init_cpus(void)
> {
> register_t mpidr;
> struct dt_device_node *cpus = dt_find_node_by_path("/cpus");
> @@ -530,6 +530,14 @@ static void __init init_cpus_maps(void)
> [0 ... NR_CPUS - 1] = MPIDR_INVALID
> };
> bool_t bootcpu_valid = 0;
> + int rc;
> +
> + if ( (rc = arch_smp_init()) < 0 )
> + {
> + printk(XENLOG_WARNING "SMP init failed (%d)\n"
> + "Using only 1 CPU\n", rc);
> + return;
> + }
>
> mpidr = boot_cpu_data.mpidr.bits & MPIDR_HWID_MASK;
>
> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> }
> }
>
> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
As I understand your patch #6, arch_cpu_init take a logical cpu id (on
ARM64 it's used as an index in an array).
So you should used j here.
Also, do we really need to call arch_cpu_init on the boot CPU?
> + {
> + printk("cpu init failed (hwid %x): %d\n", hwid, rc);
> + continue;
> + }
> +
> /*
> * Build a stashed array of MPIDR values. Numbering scheme requires
> * that if detected the boot CPU must be assigned logical id 0. Other
> @@ -599,7 +613,8 @@ static void __init init_cpus_maps(void)
>
> if ( cpuidx > NR_CPUS )
> {
> - printk(XENLOG_WARNING "DT /cpu %u node greater than max cores %u, capping them\n",
> + printk(XENLOG_WARNING
> + "DT /cpu %u node greater than max cores %u, capping them\n",
> cpuidx, NR_CPUS);
> cpuidx = NR_CPUS;
> break;
> @@ -657,15 +672,14 @@ void __init start_xen(unsigned long boot_phys_offset,
>
> processor_id();
>
> - init_cpus_maps();
> - cpus = smp_get_max_cpus();
> -
> platform_init();
>
> + smp_init_cpus();
> + cpus = smp_get_max_cpus();
> +
> init_xen_time();
>
> gic_init();
> - make_cpus_ready(cpus, boot_phys_offset);
>
> set_current((struct vcpu *)0xfffff000); /* debug sanity */
> idle_vcpu[0] = current;
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 234748e..7b4ad8a 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -56,12 +56,10 @@ struct init_info __initdata init_data =
> };
>
> /* Shared state for coordinating CPU bringup */
> -unsigned long smp_up_cpu = 0;
> +unsigned long smp_up_cpu = ~0UL;
MPIDR_INVALID?
[..]
> /* Boot the current CPU */
> void __cpuinit start_secondary(unsigned long boot_phys_offset,
> unsigned long fdt_paddr,
> @@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
> wmb();
>
> /* Now report this CPU is up */
> + smp_up_cpu = ~0UL;
smp_up_cpu = MPIDR_INVALID?
Also, perhaps a dsb is needed here to ensure to update smp_up_cpu before
cpumask_set_cpu is updated.
> cpumask_set_cpu(cpuid, &cpu_online_map);
> wmb();
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 13:30 ` Julien Grall
@ 2013-09-27 14:10 ` Ian Campbell
2013-09-27 14:21 ` Julien Grall
2013-09-27 14:21 ` Ian Campbell
0 siblings, 2 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 14:10 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
> > @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> > }
> > }
> >
> > + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
>
> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> ARM64 it's used as an index in an array).
Yes, I thought I wanted to pass the hwid here, but it looks like I've
got my wires crossed.
> So you should used j here.
You mean cpuidx I think, after having moved the call after the cpuidx++
I wanted to handle the case where the function failed by having
possible_map not contain failed cpus. I think I'll handle this by making
tmp_map[i] == INVALID_MIDR in that case and checking that in the loop
which sets bits in cpu_possible_map.
> Also, do we really need to call arch_cpu_init on the boot CPU?
Good question. I suppose not. On the other hand it gives the platform
the option of doing per-cpu init not related to bring up. I think I'll
keep this hook in place.
> > };
> >
> > /* Shared state for coordinating CPU bringup */
> > -unsigned long smp_up_cpu = 0;
> > +unsigned long smp_up_cpu = ~0UL;
>
> MPIDR_INVALID?
yes, for all of those.
> > @@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
> > wmb();
> >
> > /* Now report this CPU is up */
> > + smp_up_cpu = ~0UL;
>
> smp_up_cpu = MPIDR_INVALID?
>
> Also, perhaps a dsb is needed here to ensure to update smp_up_cpu before
> cpumask_set_cpu is updated.
Does anything rely on the order of these two writes? There is a wmb
right after the writes so they will become visible together. I think
it's probably OK to see one slightly before the other in either order.
>
> > cpumask_set_cpu(cpuid, &cpu_online_map);
> > wmb();
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:10 ` Ian Campbell
@ 2013-09-27 14:21 ` Julien Grall
2013-09-27 14:23 ` Ian Campbell
2013-09-27 14:21 ` Ian Campbell
1 sibling, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 14:21 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 03:10 PM, Ian Campbell wrote:
> On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
>
>>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
>>> }
>>> }
>>>
>>> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
>>
>> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
>> ARM64 it's used as an index in an array).
>
> Yes, I thought I wanted to pass the hwid here, but it looks like I've
> got my wires crossed.
>
>> So you should used j here.
>
> You mean cpuidx I think, after having moved the call after the cpuidx++
In fact I mean i. Because i = 0 (if it's the boot CPU) or cpuidx++ for
non-boot CPU.
>
> I wanted to handle the case where the function failed by having
> possible_map not contain failed cpus. I think I'll handle this by making
> tmp_map[i] == INVALID_MIDR in that case and checking that in the loop
> which sets bits in cpu_possible_map.
Sounds a good place.
>> Also, do we really need to call arch_cpu_init on the boot CPU?
>
> Good question. I suppose not. On the other hand it gives the platform
> the option of doing per-cpu init not related to bring up. I think I'll
> keep this hook in place.
Ok.
>>> };
>>>
>>> /* Shared state for coordinating CPU bringup */
>>> -unsigned long smp_up_cpu = 0;
>>> +unsigned long smp_up_cpu = ~0UL;
>>
>> MPIDR_INVALID?
>
> yes, for all of those.
>
>>> @@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
>>> wmb();
>>>
>>> /* Now report this CPU is up */
>>> + smp_up_cpu = ~0UL;
>>
>> smp_up_cpu = MPIDR_INVALID?
>>
>> Also, perhaps a dsb is needed here to ensure to update smp_up_cpu before
>> cpumask_set_cpu is updated.
>
> Does anything rely on the order of these two writes? There is a wmb
> right after the writes so they will become visible together. I think
> it's probably OK to see one slightly before the other in either order.
I though smp_up_cpu was updated just after the loop
while( !cpu_online(cpu) ) but not. So it's fine for me.
>>
>>> cpumask_set_cpu(cpuid, &cpu_online_map);
>>> wmb();
>>
>
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:10 ` Ian Campbell
2013-09-27 14:21 ` Julien Grall
@ 2013-09-27 14:21 ` Ian Campbell
2013-09-27 14:31 ` Julien Grall
1 sibling, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 14:21 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini
On Fri, 2013-09-27 at 15:10 +0100, Ian Campbell wrote:
> On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
>
> > > @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> > > }
> > > }
> > >
> > > + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> >
> > As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> > ARM64 it's used as an index in an array).
>
> Yes, I thought I wanted to pass the hwid here, but it looks like I've
> got my wires crossed.
>
> > So you should used j here.
>
> You mean cpuidx I think, after having moved the call after the cpuidx++
>
> I wanted to handle the case where the function failed by having
> possible_map not contain failed cpus. I think I'll handle this by making
> tmp_map[i] == INVALID_MIDR in that case and checking that in the loop
> which sets bits in cpu_possible_map.
Incrementally this looks like:
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index 5923cfc..b836be4 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -165,12 +165,6 @@ void __init smp_init_cpus(void)
}
}
- if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
- {
- printk("cpu init failed (hwid %x): %d\n", hwid, rc);
- continue;
- }
-
/*
* Build a stashed array of MPIDR values. Numbering scheme requires
* that if detected the boot CPU must be assigned logical id 0. Other
@@ -196,7 +190,13 @@ void __init smp_init_cpus(void)
break;
}
- tmp_map[i] = hwid;
+ if ( (rc = arch_cpu_init(i, cpu)) < 0 )
+ {
+ printk("cpu%d init failed (hwid %x): %d\n", i, hwid, rc);
+ tmp_map[i] = MPIDR_INVALID;
+ }
+ else
+ tmp_map[i] = hwid;
}
if ( !bootcpu_valid )
@@ -208,6 +208,8 @@ void __init smp_init_cpus(void)
for ( i = 0; i < cpuidx; i++ )
{
+ if ( tmp_map[i] == MPIDR_INVALID )
+ continue;
cpumask_set_cpu(i, &cpu_possible_map);
cpu_logical_map(i) = tmp_map[i];
}
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:21 ` Julien Grall
@ 2013-09-27 14:23 ` Ian Campbell
2013-09-27 14:26 ` Ian Campbell
0 siblings, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 14:23 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 15:21 +0100, Julien Grall wrote:
> On 09/27/2013 03:10 PM, Ian Campbell wrote:
> > On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
> >
> >>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> >>> }
> >>> }
> >>>
> >>> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> >>
> >> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> >> ARM64 it's used as an index in an array).
> >
> > Yes, I thought I wanted to pass the hwid here, but it looks like I've
> > got my wires crossed.
> >
> >> So you should used j here.
> >
> > You mean cpuidx I think, after having moved the call after the cpuidx++
>
> In fact I mean i. Because i = 0 (if it's the boot CPU) or cpuidx++ for
> non-boot CPU.
Right. Ignore the incremental patch I posted, the real one will have the
obvious change made ;-)
Ian
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:23 ` Ian Campbell
@ 2013-09-27 14:26 ` Ian Campbell
0 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 14:26 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini
On Fri, 2013-09-27 at 15:23 +0100, Ian Campbell wrote:
> On Fri, 2013-09-27 at 15:21 +0100, Julien Grall wrote:
> > On 09/27/2013 03:10 PM, Ian Campbell wrote:
> > > On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
> > >
> > >>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> > >>> }
> > >>> }
> > >>>
> > >>> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> > >>
> > >> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> > >> ARM64 it's used as an index in an array).
> > >
> > > Yes, I thought I wanted to pass the hwid here, but it looks like I've
> > > got my wires crossed.
> > >
> > >> So you should used j here.
> > >
> > > You mean cpuidx I think, after having moved the call after the cpuidx++
> >
> > In fact I mean i. Because i = 0 (if it's the boot CPU) or cpuidx++ for
> > non-boot CPU.
>
> Right. Ignore the incremental patch I posted, the real one will have the
> obvious change made ;-)
Actually, looks like I thought cpuidx and wrote i, so the incremental
patch is fine ;-)
Ian.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:21 ` Ian Campbell
@ 2013-09-27 14:31 ` Julien Grall
2013-09-27 14:38 ` Ian Campbell
0 siblings, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 14:31 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, tim, stefano.stabellini
On 09/27/2013 03:21 PM, Ian Campbell wrote:
> On Fri, 2013-09-27 at 15:10 +0100, Ian Campbell wrote:
>> On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
>>
>>>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
>>>> }
>>>> }
>>>>
>>>> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
>>>
>>> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
>>> ARM64 it's used as an index in an array).
>>
>> Yes, I thought I wanted to pass the hwid here, but it looks like I've
>> got my wires crossed.
>>
>>> So you should used j here.
>>
>> You mean cpuidx I think, after having moved the call after the cpuidx++
>>
>> I wanted to handle the case where the function failed by having
>> possible_map not contain failed cpus. I think I'll handle this by making
>> tmp_map[i] == INVALID_MIDR in that case and checking that in the loop
>> which sets bits in cpu_possible_map.
>
> Incrementally this looks like:
It looks good to me.
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 5923cfc..b836be4 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -165,12 +165,6 @@ void __init smp_init_cpus(void)
> }
> }
>
> - if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> - {
> - printk("cpu init failed (hwid %x): %d\n", hwid, rc);
> - continue;
> - }
> -
> /*
> * Build a stashed array of MPIDR values. Numbering scheme requires
> * that if detected the boot CPU must be assigned logical id 0. Other
> @@ -196,7 +190,13 @@ void __init smp_init_cpus(void)
> break;
> }
>
> - tmp_map[i] = hwid;
> + if ( (rc = arch_cpu_init(i, cpu)) < 0 )
> + {
> + printk("cpu%d init failed (hwid %x): %d\n", i, hwid, rc);
> + tmp_map[i] = MPIDR_INVALID;
> + }
> + else
> + tmp_map[i] = hwid;
> }
>
> if ( !bootcpu_valid )
> @@ -208,6 +208,8 @@ void __init smp_init_cpus(void)
>
> for ( i = 0; i < cpuidx; i++ )
> {
> + if ( tmp_map[i] == MPIDR_INVALID )
> + continue;
> cpumask_set_cpu(i, &cpu_possible_map);
> cpu_logical_map(i) = tmp_map[i];
> }
>
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:31 ` Julien Grall
@ 2013-09-27 14:38 ` Ian Campbell
2013-09-27 15:17 ` Ian Campbell
0 siblings, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 14:38 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, tim, stefano.stabellini
On Fri, 2013-09-27 at 15:31 +0100, Julien Grall wrote:
> On 09/27/2013 03:21 PM, Ian Campbell wrote:
> > On Fri, 2013-09-27 at 15:10 +0100, Ian Campbell wrote:
> >> On Fri, 2013-09-27 at 14:30 +0100, Julien Grall wrote:
> >>
> >>>> @@ -581,6 +589,12 @@ static void __init init_cpus_maps(void)
> >>>> }
> >>>> }
> >>>>
> >>>> + if ( (rc = arch_cpu_init(hwid, cpu)) < 0 )
> >>>
> >>> As I understand your patch #6, arch_cpu_init take a logical cpu id (on
> >>> ARM64 it's used as an index in an array).
> >>
> >> Yes, I thought I wanted to pass the hwid here, but it looks like I've
> >> got my wires crossed.
> >>
> >>> So you should used j here.
> >>
> >> You mean cpuidx I think, after having moved the call after the cpuidx++
> >>
> >> I wanted to handle the case where the function failed by having
> >> possible_map not contain failed cpus. I think I'll handle this by making
> >> tmp_map[i] == INVALID_MIDR in that case and checking that in the loop
> >> which sets bits in cpu_possible_map.
> >
> > Incrementally this looks like:
>
> It looks good to me.
Thanks, I won't resend the whole the series, the full version of that
patch is below. There is a corresponding knock on to "xen: arm: move
smp_init_cpus to smpboot.c" but I won't bother reposting that...
8<-----------------
>From ff0b78bd2bd57a892736c87a9bcc77ea00130af9 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Thu, 29 Aug 2013 16:25:00 +0100
Subject: [PATCH] xen: arm: rewrite start of day page table and cpu bring up
This is unfortunately a rather large monolithic patch.
Rather than bringing up all CPUs in lockstep as we setup paging and relocate
Xen instead create a simplified set of dedicated boot time pagetables.
This allows secondary CPUs to remain powered down or in the firmware until we
actually want to enable them. The bringup is now done later on in C and can be
driven by DT etc. I have included code for the vexpress platform, but other
platforms will need to be added.
The mechanism for deciding how to bring up a CPU differs between arm32 and
arm64. On arm32 it is essentially a per-platform property, with the exception
of PSCI which can be implemented globally (but isn't here). On arm64 there is a
per-cpu property in the device tree.
Secondary CPUs are brought up directly into the relocated Xen image, instead of
relying on being able to launch on the unrelocated Xen and hoping that it
hasn't been clobbered.
As part of this change drop support for switching from secure mode to NS HYP as
well as the early CPU kick. Xen now requires that it is launched in NS HYP
mode and that firmware configure things such that secondary CPUs can be woken
up by a primarly CPU in HYP mode. This may require fixes to bootloaders or the
use of a boot wrapper.
The changes done here (re)exposed an issue with relocating Xen and the compiler
spilling values to the stack between the copy and the actual switch to the
relocaed copy of Xen in setup_pagetables. Therefore switch to doing the copy
and switch in a single asm function where we can control precisely what gets
spilled to the stack etc.
Since we now have a separate set of boot pagetables it is much easier to build
the real Xen pagetables inplace before relocating rather than the more complex
approach of rewriting the pagetables in the relocated copy before switching.
This will also enable Xen to be loaded above the 4GB boundary on 64-bit.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
---
v5: use MPIDR_INVALID
Pass logical ID not hwid to arch_cpu_init
v4: rebase due to fixups. Need to preserved DTB mapping since "xen/arm:
Support dtb /memreserve/ regions".
v3: add a dsb before the smp_up_cpu wait loop.
move arch_smp_init() and arch_cpu_init() int init_cpus_maps() which I
rename to smp_init_cpus().
v2: Lots of review feedback from Julien and Tim
Reintroduce a smp_up_cpu gate. We cannot reliably wake a single CPU so we
add our own gate. However it is purely in the relocated image.
---
xen/arch/arm/arm32/Makefile | 1 -
xen/arch/arm/arm32/head.S | 391 ++++++++++++++++++-----------
xen/arch/arm/arm32/mode_switch.S | 158 ------------
xen/arch/arm/arm64/Makefile | 1 -
xen/arch/arm/arm64/head.S | 396 ++++++++++++++++++++----------
xen/arch/arm/arm64/mode_switch.S | 89 -------
xen/arch/arm/mm.c | 197 +++++++++------
xen/arch/arm/setup.c | 30 ++-
xen/arch/arm/smpboot.c | 57 ++---
xen/include/asm-arm/mm.h | 3 +-
xen/include/asm-arm/platforms/exynos5.h | 14 --
xen/include/asm-arm/platforms/vexpress.h | 11 -
xen/include/asm-arm/smp.h | 6 -
13 files changed, 679 insertions(+), 675 deletions(-)
delete mode 100644 xen/arch/arm/arm32/mode_switch.S
delete mode 100644 xen/arch/arm/arm64/mode_switch.S
diff --git a/xen/arch/arm/arm32/Makefile b/xen/arch/arm/arm32/Makefile
index 463b1f5..aacdcb9 100644
--- a/xen/arch/arm/arm32/Makefile
+++ b/xen/arch/arm/arm32/Makefile
@@ -1,7 +1,6 @@
subdir-y += lib
obj-y += entry.o
-obj-y += mode_switch.o
obj-y += proc-v7.o
obj-y += traps.o
diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
index bbcb3a0..510ccff 100644
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -37,6 +37,25 @@
#include EARLY_PRINTK_INC
#endif
+/*
+ * Common register usage in this file:
+ * r0 -
+ * r1 -
+ * r2 -
+ * r3 -
+ * r4 -
+ * r5 -
+ * r6 -
+ * r7 - CPUID
+ * r8 - DTB address (boot CPU only)
+ * r9 - paddr(start)
+ * r10 - phys offset
+ * r11 - UART address
+ * r12 - is_secondary_cpu
+ * r13 - SP
+ * r14 - LR
+ * r15 - PC
+ */
/* Macro to print a string to the UART, if there is one.
* Clobbers r0-r3. */
#ifdef EARLY_PRINTK
@@ -59,7 +78,6 @@
* or the initial pagetable code below will need adjustment. */
.global start
start:
-GLOBAL(init_secondary) /* currently unused */
/* zImage magic header, see:
* http://www.simtec.co.uk/products/SWLINUX/files/booting_article.html#d0e309
*/
@@ -77,7 +95,6 @@ past_zImage:
cpsid aif /* Disable all interrupts */
/* Save the bootloader arguments in less-clobberable registers */
- mov r5, r1 /* r5: ARM-linux machine type */
mov r8, r2 /* r8 := DTB base address */
/* Find out where we are */
@@ -91,53 +108,55 @@ past_zImage:
add r8, r10 /* r8 := paddr(DTB) */
#endif
- /* Are we the boot CPU? */
- mov r12, #0 /* r12 := CPU ID */
- mrc CP32(r0, MPIDR)
- tst r0, #(1<<31) /* Multiprocessor extension supported? */
- beq boot_cpu
- tst r0, #(1<<30) /* Uniprocessor system? */
- bne boot_cpu
- bics r12, r0, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
- beq boot_cpu /* If we're CPU 0, boot now */
-
- /* Non-boot CPUs wait here to be woken up one at a time. */
-1: dsb
- ldr r0, =smp_up_cpu /* VA of gate */
- add r0, r0, r10 /* PA of gate */
- ldr r1, [r0] /* Which CPU is being booted? */
- teq r1, r12 /* Is it us? */
- wfene
- bne 1b
+ mov r12, #0 /* r12 := is_secondary_cpu */
+
+ b common_start
+
+GLOBAL(init_secondary)
+ cpsid aif /* Disable all interrupts */
+
+ /* Find out where we are */
+ ldr r0, =start
+ adr r9, start /* r9 := paddr (start) */
+ sub r10, r9, r0 /* r10 := phys-offset */
+
+ mov r12, #1 /* r12 := is_secondary_cpu */
+
+common_start:
+ mov r7, #0 /* r7 := CPU ID. Initialy zero until we
+ * find that multiprocessor extensions are
+ * present and the system is SMP */
+ mrc CP32(r1, MPIDR)
+ tst r1, #(1<<31) /* Multiprocessor extension supported? */
+ beq 1f
+ tst r1, #(1<<30) /* Uniprocessor system? */
+ bne 1f
+ bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */
+1:
+
+ /* Non-boot CPUs wait here until __cpu_up is ready for them */
+ teq r12, #0
+ beq 1f
+
+ ldr r0, =smp_up_cpu
+ add r0, r0, r10 /* Apply physical offset */
+ dsb
+2: ldr r1, [r0]
+ cmp r1, r7
+ beq 1f
+ wfe
+ b 2b
+1:
-boot_cpu:
#ifdef EARLY_PRINTK
ldr r11, =EARLY_UART_BASE_ADDRESS /* r11 := UART base address */
- teq r12, #0 /* CPU 0 sets up the UART too */
+ teq r12, #0 /* Boot CPU sets up the UART too */
bleq init_uart
PRINT("- CPU ")
- mov r0, r12
+ mov r0, r7
bl putn
PRINT(" booting -\r\n")
#endif
- /* Secondary CPUs doesn't have machine ID
- * - Store machine ID on boot CPU
- * - Load machine ID on secondary CPUs
- * Machine ID is needed in kick_cpus and enter_hyp_mode */
- ldr r0, =machine_id /* VA of machine_id */
- add r0, r0, r10 /* PA of machine_id */
- teq r12, #0
- streq r5, [r0] /* On boot CPU save machine ID */
- ldrne r5, [r0] /* If non boot cpu r5 := machine ID */
-
- /* Wake up secondary cpus */
- teq r12, #0
- bleq kick_cpus
-
- PRINT("- Machine ID ")
- mov r0, r5
- bl putn
- PRINT(" -\r\n")
/* Check that this CPU has Hyp mode */
mrc CP32(r0, ID_PFR1)
@@ -147,28 +166,19 @@ boot_cpu:
PRINT("- CPU doesn't support the virtualization extensions -\r\n")
b fail
1:
- /* Check if we're already in it */
+
+ /* Check that we're already in Hyp mode */
mrs r0, cpsr
and r0, r0, #0x1f /* Mode is in the low 5 bits of CPSR */
teq r0, #0x1a /* Hyp Mode? */
- bne 1f
- PRINT("- Started in Hyp mode -\r\n")
- b hyp
-1:
- /* Otherwise, it must have been Secure Supervisor mode */
- mrc CP32(r0, SCR)
- tst r0, #0x1 /* Not-Secure bit set? */
- beq 1f
- PRINT("- CPU is not in Hyp mode or Secure state -\r\n")
+ beq hyp
+
+ /* OK, we're boned. */
+ PRINT("- Xen must be entered in NS Hyp mode -\r\n" \
+ "- Please update the bootloader -\r\n")
b fail
-1:
- /* OK, we're in Secure state. */
- PRINT("- Started in Secure state -\r\n- Entering Hyp mode -\r\n")
- ldr r0, =enter_hyp_mode /* VA of function */
- adr lr, hyp /* Set return address for call */
- add pc, r0, r10 /* Call PA of function */
-hyp:
+hyp: PRINT("- Xen starting in Hyp mode -\r\n")
/* Zero BSS On the boot CPU to avoid nasty surprises */
teq r12, #0
@@ -208,8 +218,8 @@ skip_bss:
bl putn
PRINT(" -\r\n")
b fail
-
2:
+
/* Jump to cpu_init */
ldr r1, [r1, #PROCINFO_cpu_init] /* r1 := vaddr(init func) */
adr lr, cpu_init_done /* Save return address */
@@ -242,68 +252,69 @@ cpu_init_done:
ldr r0, =(HSCTLR_BASE|SCTLR_A)
mcr CP32(r0, HSCTLR)
+ /* Rebuild the boot pagetable's first-level entries. The structure
+ * is described in mm.c.
+ *
+ * After the CPU enables paging it will add the fixmap mapping
+ * to these page tables, however this may clash with the 1:1
+ * mapping. So each CPU must rebuild the page tables here with
+ * the 1:1 in place. */
+
/* Write Xen's PT's paddr into the HTTBR */
ldr r4, =boot_pgtable
- add r4, r4, r10 /* r4 := paddr (xen_pagetable) */
- mov r5, #0 /* r4:r5 is paddr (xen_pagetable) */
+ add r4, r4, r10 /* r4 := paddr (boot_pagetable) */
+ mov r5, #0 /* r4:r5 is paddr (boot_pagetable) */
mcrr CP64(r4, r5, HTTBR)
- /* Non-boot CPUs don't need to rebuild the pagetable */
- teq r12, #0
- bne pt_ready
-
- /* console fixmap */
-#if defined(EARLY_PRINTK)
- ldr r1, =xen_fixmap
- add r1, r1, r10 /* r1 := paddr (xen_fixmap) */
- mov r3, #0
- lsr r2, r11, #12
- lsl r2, r2, #12 /* 4K aligned paddr of UART */
- orr r2, r2, #PT_UPPER(DEV_L3)
- orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
- strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
-#endif
-
- /* Build the baseline idle pagetable's first-level entries */
- ldr r1, =xen_second
- add r1, r1, r10 /* r1 := paddr (xen_second) */
+ /* Setup boot_pgtable: */
+ ldr r1, =boot_second
+ add r1, r1, r10 /* r1 := paddr (boot_second) */
mov r3, #0x0
- orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of xen_second */
+
+ /* ... map boot_second in boot_pgtable[0] */
+ orr r2, r1, #PT_UPPER(PT) /* r2:r3 := table map of boot_second */
orr r2, r2, #PT_LOWER(PT) /* (+ rights for linear PT) */
strd r2, r3, [r4, #0] /* Map it in slot 0 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #8] /* Map 2nd page in slot 1 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #16] /* Map 3rd page in slot 2 */
- add r2, r2, #0x1000
- strd r2, r3, [r4, #24] /* Map 4th page in slot 3 */
-
- /* Now set up the second-level entries */
- orr r2, r9, #PT_UPPER(MEM)
- orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB normal map of Xen */
- mov r4, r9, lsr #18 /* Slot for paddr(start) */
- strd r2, r3, [r1, r4] /* Map Xen there */
- ldr r4, =start
- lsr r4, #18 /* Slot for vaddr(start) */
- strd r2, r3, [r1, r4] /* Map Xen there too */
-
- /* xen_fixmap pagetable */
- ldr r2, =xen_fixmap
- add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
- orr r2, r2, #PT_UPPER(PT)
- orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
- add r4, r4, #8
- strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
- mov r3, #0x0
- lsr r2, r8, #21
- lsl r2, r2, #21 /* 2MB-aligned paddr of DTB */
- orr r2, r2, #PT_UPPER(MEM)
- orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
- add r4, r4, #8
- strd r2, r3, [r1, r4] /* Map it in the early fdt slot */
+ /* ... map of paddr(start) in boot_pgtable */
+ lsrs r1, r9, #30 /* Offset of base paddr in boot_pgtable */
+ beq 1f /* If it is in slot 0 then map in boot_second
+ * later on */
+ lsl r2, r1, #30 /* Base address for 1GB mapping */
+ orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
+ orr r2, r2, #PT_LOWER(MEM)
+ lsl r1, r1, #3 /* r1 := Slot offset */
+ strd r2, r3, [r4, r1] /* Mapping of paddr(start) */
+
+1: /* Setup boot_second: */
+ ldr r4, =boot_second
+ add r4, r4, r10 /* r1 := paddr (boot_second) */
+
+ lsr r2, r9, #20 /* Base address for 2MB mapping */
+ lsl r2, r2, #20
+ orr r2, r2, #PT_UPPER(MEM) /* r2:r3 := section map */
+ orr r2, r2, #PT_LOWER(MEM)
+
+ /* ... map of vaddr(start) in boot_second */
+ ldr r1, =start
+ lsr r1, #18 /* Slot for vaddr(start) */
+ strd r2, r3, [r4, r1] /* Map vaddr(start) */
+
+ /* ... map of paddr(start) in boot_second */
+ lsrs r1, r9, #30 /* Base paddr */
+ bne 1f /* If paddr(start) is not in slot 0
+ * then the mapping was done in
+ * boot_pgtable above */
+
+ mov r1, r9, lsr #18 /* Slot for paddr(start) */
+ strd r2, r3, [r4, r1] /* Map Xen there */
+1:
+
+ /* Defer fixmap and dtb mapping until after paging enabled, to
+ * avoid them clashing with the 1:1 mapping. */
+
+ /* boot pagetable setup complete */
-pt_ready:
PRINT("- Turning on paging -\r\n")
ldr r1, =paging /* Explicit vaddr, not RIP-relative */
@@ -315,11 +326,53 @@ pt_ready:
mov pc, r1 /* Get a proper vaddr into PC */
paging:
+ /* Now we can install the fixmap and dtb mappings, since we
+ * don't need the 1:1 map any more */
+ dsb
+#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
+ /* Non-boot CPUs don't need to rebuild the fixmap itself, just
+ * the mapping from boot_second to xen_fixmap */
+ teq r12, #0
+ bne 1f
+
+ /* Add UART to the fixmap table */
+ ldr r1, =xen_fixmap /* r1 := vaddr (xen_fixmap) */
+ mov r3, #0
+ lsr r2, r11, #12
+ lsl r2, r2, #12 /* 4K aligned paddr of UART */
+ orr r2, r2, #PT_UPPER(DEV_L3)
+ orr r2, r2, #PT_LOWER(DEV_L3) /* r2:r3 := 4K dev map including UART */
+ strd r2, r3, [r1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+1:
+
+ /* Map fixmap into boot_second */
+ ldr r1, =boot_second /* r1 := vaddr (xen_fixmap) */
+ ldr r2, =xen_fixmap
+ add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
+ orr r2, r2, #PT_UPPER(PT)
+ orr r2, r2, #PT_LOWER(PT) /* r2:r3 := table map of xen_fixmap */
+ ldr r4, =FIXMAP_ADDR(0)
+ mov r4, r4, lsr #18 /* r4 := Slot for FIXMAP(0) */
+ strd r2, r3, [r1, r4] /* Map it in the fixmap's slot */
-#ifdef EARLY_PRINTK
/* Use a virtual address to access the UART. */
ldr r11, =FIXMAP_ADDR(FIXMAP_CONSOLE)
#endif
+ /* Map the DTB in the boot misc slot */
+ teq r12, #0 /* Only on boot CPU */
+ bne 1f
+
+ ldr r1, =boot_second
+ mov r3, #0x0
+ lsr r2, r8, #21
+ lsl r2, r2, #21 /* r2: 2MB-aligned paddr of DTB */
+ orr r2, r2, #PT_UPPER(MEM)
+ orr r2, r2, #PT_LOWER(MEM) /* r2:r3 := 2MB RAM incl. DTB */
+ ldr r4, =BOOT_FDT_VIRT_START
+ mov r4, r4, lsr #18 /* Slot for BOOT_FDT_VIRT_START */
+ strd r2, r3, [r1, r4] /* Map it in the early fdt slot */
+ dsb
+1:
PRINT("- Ready -\r\n")
@@ -327,10 +380,10 @@ paging:
teq r12, #0
beq launch
- /* Non-boot CPUs need to move on to the relocated pagetables */
- mov r0, #0
- ldr r4, =boot_ttbr /* VA of HTTBR value stashed by CPU 0 */
- add r4, r4, r10 /* PA of it */
+ /* Non-boot CPUs need to move on to the proper pagetables, which were
+ * setup in init_secondary_pagetables. */
+
+ ldr r4, =init_ttbr /* VA of HTTBR value stashed by CPU 0 */
ldrd r4, r5, [r4] /* Actual value */
dsb
mcrr CP64(r4, r5, HTTBR)
@@ -342,29 +395,6 @@ paging:
dsb /* Ensure completion of TLB+BP flush */
isb
- /* Non-boot CPUs report that they've got this far */
- ldr r0, =ready_cpus
-1: ldrex r1, [r0] /* { read # of ready CPUs } */
- add r1, r1, #1 /* Atomically { ++ } */
- strex r2, r1, [r0] /* { writeback } */
- teq r2, #0
- bne 1b
- dsb
- mcr CP32(r0, DCCMVAC) /* flush D-Cache */
- dsb
-
- /* Here, the non-boot CPUs must wait again -- they're now running on
- * the boot CPU's pagetables so it's safe for the boot CPU to
- * overwrite the non-relocated copy of Xen. Once it's done that,
- * and brought up the memory allocator, non-boot CPUs can get their
- * own stacks and enter C. */
-1: wfe
- dsb
- ldr r0, =smp_up_cpu
- ldr r1, [r0] /* Which CPU is being booted? */
- teq r1, r12 /* Is it us? */
- bne 1b
-
launch:
ldr r0, =init_data
add r0, #INITINFO_stack /* Find the boot-time stack */
@@ -373,7 +403,7 @@ launch:
sub sp, #CPUINFO_sizeof /* Make room for CPU save record */
mov r0, r10 /* Marshal args: - phys_offset */
mov r1, r8 /* - DTB address */
- movs r2, r12 /* - CPU ID */
+ movs r2, r7 /* - CPU ID */
beq start_xen /* and disappear into the land of C */
b start_secondary /* (to the appropriate entry point) */
@@ -383,6 +413,82 @@ fail: PRINT("- Boot failed -\r\n")
1: wfe
b 1b
+/* Copy Xen to new location and switch TTBR
+ * r1:r0 ttbr
+ * r2 source address
+ * r3 destination address
+ * [sp]=>r4 length
+ *
+ * Source and destination must be word aligned, length is rounded up
+ * to a 16 byte boundary.
+ *
+ * MUST BE VERY CAREFUL when saving things to RAM over the copy */
+ENTRY(relocate_xen)
+ push {r4,r5,r6,r7,r8,r9,r10,r11}
+
+ ldr r4, [sp, #8*4] /* Get 4th argument from stack */
+
+ /* Copy 16 bytes at a time using:
+ * r5: counter
+ * r6: data
+ * r7: data
+ * r8: data
+ * r9: data
+ * r10: source
+ * r11: destination
+ */
+ mov r5, r4
+ mov r10, r2
+ mov r11, r3
+1: ldmia r10!, {r6, r7, r8, r9}
+ stmia r11!, {r6, r7, r8, r9}
+
+ subs r5, r5, #16
+ bgt 1b
+
+ /* Flush destination from dcache using:
+ * r5: counter
+ * r6: step
+ * r7: vaddr
+ */
+ dsb /* So the CPU issues all writes to the range */
+
+ mov r5, r4
+ ldr r6, =cacheline_bytes /* r6 := step */
+ ldr r6, [r6]
+ mov r7, r3
+
+1: mcr CP32(r7, DCCMVAC)
+
+ add r7, r7, r6
+ subs r5, r5, r6
+ bgt 1b
+
+ dsb /* Ensure the flushes happen before
+ * continuing */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
+ mcr CP32(r0, ICIALLU) /* Flush I-cache */
+ mcr CP32(r0, BPIALL) /* Flush branch predictor */
+ dsb /* Ensure completion of TLB+BP flush */
+ isb
+
+ mcrr CP64(r0, r1, HTTBR)
+
+ dsb /* ensure memory accesses do not cross
+ * over the TTBR0 write */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ mcr CP32(r0, TLBIALLH) /* Flush hypervisor TLB */
+ mcr CP32(r0, ICIALLU) /* Flush I-cache */
+ mcr CP32(r0, BPIALL) /* Flush branch predictor */
+ dsb /* Ensure completion of TLB+BP flush */
+ isb
+
+ pop {r4, r5,r6,r7,r8,r9,r10,r11}
+
+ mov pc, lr
#ifdef EARLY_PRINTK
/* Bring up the UART.
@@ -439,9 +545,6 @@ putn: mov pc, lr
#endif /* !EARLY_PRINTK */
-/* Place holder for machine ID */
-machine_id: .word 0x0
-
/*
* Local variables:
* mode: ASM
diff --git a/xen/arch/arm/arm32/mode_switch.S b/xen/arch/arm/arm32/mode_switch.S
deleted file mode 100644
index 2cd5888..0000000
--- a/xen/arch/arm/arm32/mode_switch.S
+++ /dev/null
@@ -1,158 +0,0 @@
-/*
- * xen/arch/arm/mode_switch.S
- *
- * Start-of day code to take a CPU from Secure mode to Hyp mode.
- *
- * Tim Deegan <tim@xen.org>
- * Copyright (c) 2011-2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <asm/config.h>
-#include <asm/page.h>
-#include <asm/platforms/vexpress.h>
-#include <asm/platforms/exynos5.h>
-#include <asm/asm_defns.h>
-#include <asm/gic.h>
-
-/* Wake up secondary cpus
- * This code relies on Machine ID and only works for Vexpress and the Arndale
- * TODO: Move this code either later (via platform specific desc) or in a bootwrapper
- * r5: Machine ID
- * Clobber r0 r2 */
-GLOBAL(kick_cpus)
- ldr r0, =MACH_TYPE_SMDK5250
- teq r5, r0 /* Are we running on the arndale? */
- beq kick_cpus_arndale
- /* otherwise versatile express */
- /* write start paddr to v2m sysreg FLAGSSET register */
- ldr r0, =(V2M_SYS_MMIO_BASE) /* base V2M sysreg MMIO address */
- dsb
- mov r2, #0xffffffff
- str r2, [r0, #(V2M_SYS_FLAGSCLR)]
- dsb
- ldr r2, =start
- add r2, r2, r10
- str r2, [r0, #(V2M_SYS_FLAGSSET)]
- dsb
- ldr r2, =V2M_GIC_BASE_ADDRESS /* r2 := VE gic base address */
- b kick_cpus_sgi
-kick_cpus_arndale:
- /* write start paddr to CPU 1 sysreg register */
- ldr r0, =(S5P_PA_SYSRAM)
- ldr r2, =start
- add r2, r2, r10
- str r2, [r0]
- dsb
- ldr r2, =EXYNOS5_GIC_BASE_ADDRESS /* r2 := Exynos5 gic base address */
-kick_cpus_sgi:
- /* send an interrupt */
- ldr r0, =GIC_DR_OFFSET /* GIC distributor offset */
- add r0, r2 /* r0 := r0 + gic base address */
- mov r2, #0x1
- str r2, [r0, #(GICD_CTLR * 4)] /* enable distributor */
- mov r2, #0xfe0000
- str r2, [r0, #(GICD_SGIR * 4)] /* send IPI to everybody, SGI0 = Event check */
- dsb
- str r2, [r0, #(GICD_CTLR * 4)] /* disable distributor */
- mov pc, lr
-
-
-/* Get up a CPU into Hyp mode. Clobbers r0-r3.
- *
- * r5: Machine ID
- * r12: CPU number
- *
- * This code is specific to the VE model/Arndale, and not intended to be used
- * on production systems. As such it's a bit hackier than the main
- * boot code in head.S. In future it will be replaced by better
- * integration with the bootloader/firmware so that Xen always starts
- * in Hyp mode.
- * Clobber r0 - r4 */
-GLOBAL(enter_hyp_mode)
- mov r3, lr /* Put return address in non-banked reg */
- cpsid aif, #0x16 /* Enter Monitor mode */
- mrc CP32(r0, SCR)
- orr r0, r0, #0x100 /* Set HCE */
- orr r0, r0, #0xb1 /* Set SCD, AW, FW and NS */
- bic r0, r0, #0xe /* Clear EA, FIQ and IRQ */
- mcr CP32(r0, SCR)
-
- ldr r2, =MACH_TYPE_SMDK5250 /* r4 := Arndale machine ID */
- /* By default load Arndale defaults values */
- ldr r0, =EXYNOS5_TIMER_FREQUENCY /* r0 := timer's frequency */
- ldr r1, =EXYNOS5_GIC_BASE_ADDRESS /* r1 := GIC base address */
- /* If it's not the Arndale machine ID, load VE values */
- teq r5, r2
- ldrne r0, =V2M_TIMER_FREQUENCY
- ldrne r1, =V2M_GIC_BASE_ADDRESS
-
- /* Ugly: the system timer's frequency register is only
- * programmable in Secure state. Since we don't know where its
- * memory-mapped control registers live, we can't find out the
- * right frequency. */
- mcr CP32(r0, CNTFRQ)
-
- mrc CP32(r0,NSACR)
- ldr r4, =0x3fff /* Allow access to all co-processors in NS mode */
- orr r0, r0, r4
- orr r0, r0, #(1<<18) /* CA7/CA15: Allow access to ACTLR.SMP in NS mode */
- mcr CP32(r0, NSACR)
-
- add r0, r1, #GIC_DR_OFFSET
- /* Disable the GIC distributor, on the boot CPU only */
- mov r4, #0
- teq r12, #0 /* Is this the boot CPU? */
- streq r4, [r0]
- /* Continuing ugliness: Set up the GIC so NS state owns interrupts,
- * The first 32 interrupts (SGIs & PPIs) must be configured on all
- * CPUs while the remainder are SPIs and only need to be done one, on
- * the boot CPU. */
- add r0, r0, #0x80 /* GICD_IGROUP0 */
- mov r2, #0xffffffff /* All interrupts to group 1 */
- str r2, [r0] /* Interrupts 0-31 (SGI & PPI) */
- teq r12, #0 /* Boot CPU? */
- bne skip_spis /* Don't route SPIs on secondary CPUs */
-
- add r4, r1, #GIC_DR_OFFSET
- ldr r4, [r4, #4] /* r4 := Interrupt Controller Type Reg */
- and r4, r4, #GICD_TYPE_LINES /* r4 := number of SPIs */
-1: teq r4, #0
- beq skip_spis
- add r0, r0, #4 /* Go to the new group */
- str r2, [r0] /* Update the group */
- sub r4, r4, #1
- b 1b
-skip_spis:
- /* Disable the GIC CPU interface on all processors */
- add r0, r1, #GIC_CR_OFFSET
- mov r1, #0
- str r1, [r0]
- /* Must drop priority mask below 0x80 before entering NS state */
- ldr r1, =0xff
- str r1, [r0, #0x4] /* -> GICC_PMR */
- /* Reset a few config registers */
- mov r0, #0
- mcr CP32(r0, FCSEIDR)
- mcr CP32(r0, CONTEXTIDR)
-
- mrs r0, cpsr /* Copy the CPSR */
- add r0, r0, #0x4 /* 0x16 (Monitor) -> 0x1a (Hyp) */
- msr spsr_cxsf, r0 /* into the SPSR */
- movs pc, r3 /* Exception-return into Hyp mode */
-
-/*
- * Local variables:
- * mode: ASM
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile
index 30fb480..5d28bad 100644
--- a/xen/arch/arm/arm64/Makefile
+++ b/xen/arch/arm/arm64/Makefile
@@ -1,7 +1,6 @@
subdir-y += lib
obj-y += entry.o
-obj-y += mode_switch.o
obj-y += traps.o
obj-y += domain.o
diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
index ac1b75a..b2d44cc 100644
--- a/xen/arch/arm/arm64/head.S
+++ b/xen/arch/arm/arm64/head.S
@@ -33,6 +33,41 @@
#include EARLY_PRINTK_INC
#endif
+/*
+ * Common register usage in this file:
+ * x0 -
+ * x1 -
+ * x2 -
+ * x3 -
+ * x4 -
+ * x5 -
+ * x6 -
+ * x7 -
+ * x8 -
+ * x9 -
+ * x10 -
+ * x11 -
+ * x12 -
+ * x13 -
+ * x14 -
+ * x15 -
+ * x16 -
+ * x17 -
+ * x18 -
+ * x19 - paddr(start)
+ * x20 - phys offset
+ * x21 - DTB address (boot cpu only)
+ * x22 - is_secondary_cpu
+ * x23 - UART address
+ * x24 - cpuid
+ * x25 -
+ * x26 -
+ * x27 -
+ * x28 -
+ * x29 -
+ * x30 - lr
+ */
+
/* Macro to print a string to the UART, if there is one.
* Clobbers x0-x3. */
#ifdef EARLY_PRINTK
@@ -65,7 +100,6 @@
.global start
start:
-GLOBAL(init_secondary) /* currently unused */
/*
* DO NOT MODIFY. Image header expected by Linux boot-loaders.
*/
@@ -100,69 +134,73 @@ real_start:
add x21, x21, x20 /* x21 := paddr(DTB) */
#endif
- /* Are we the boot CPU? */
- mov x22, #0 /* x22 := CPU ID */
+ mov x22, #0 /* x22 := is_secondary_cpu */
+
+ b common_start
+
+GLOBAL(init_secondary)
+ msr DAIFSet, 0xf /* Disable all interrupts */
+
+ /* Find out where we are */
+ ldr x0, =start
+ adr x19, start /* x19 := paddr (start) */
+ sub x20, x19, x0 /* x20 := phys-offset */
+
+ mov x22, #1 /* x22 := is_secondary_cpu */
+
+common_start:
+ mov x24, #0 /* x24 := CPU ID. Initialy zero until we
+ * find that multiprocessor extensions are
+ * present and the system is SMP */
mrs x0, mpidr_el1
- tbz x0, 31, boot_cpu /* Multiprocessor extension supported? */
- tbnz x0, 30, boot_cpu /* Uniprocessor system? */
+ tbz x0, 31, 1f /* Multiprocessor extension not supported? */
+ tbnz x0, 30, 1f /* Uniprocessor system? */
mov x13, #(0xff << 24)
- bics x22, x0, x13 /* Mask out flags to get CPU ID */
- b.eq boot_cpu /* If we're CPU 0, boot now */
-
- /* Non-boot CPUs wait here to be woken up one at a time. */
-1: dsb sy
- ldr x0, =smp_up_cpu /* VA of gate */
- add x0, x0, x20 /* PA of gate */
- ldr x1, [x0] /* Which CPU is being booted? */
- cmp x1, x22 /* Is it us? */
- b.eq 2f
+ bic x24, x0, x13 /* Mask out flags to get CPU ID */
+1:
+
+ /* Non-boot CPUs wait here until __cpu_up is ready for them */
+ cbz x22, 1f
+
+ ldr x0, =smp_up_cpu
+ add x0, x0, x20 /* Apply physical offset */
+ dsb sy
+2: ldr x1, [x0]
+ cmp x1, x24
+ beq 1f
wfe
- b 1b
-2:
+ b 2b
+1:
-boot_cpu:
#ifdef EARLY_PRINTK
ldr x23, =EARLY_UART_BASE_ADDRESS /* x23 := UART base address */
cbnz x22, 1f
-#ifdef EARLY_PRINTK_INIT_UART
- bl init_uart /* CPU 0 sets up the UART too */
-#endif
+ bl init_uart /* Boot CPU sets up the UART too */
1: PRINT("- CPU ")
- mov x0, x22
+ mov x0, x24
bl putn
PRINT(" booting -\r\n")
#endif
PRINT("- Current EL ")
- mrs x0, CurrentEL
+ mrs x4, CurrentEL
+ mov x0, x4
bl putn
PRINT(" -\r\n")
- /* Are we in EL3 */
- mrs x0, CurrentEL
- cmp x0, #PSR_MODE_EL3t
- ccmp x0, #PSR_MODE_EL3h, #0x4, ne
- b.eq 1f /* Yes */
-
/* Are we in EL2 */
- cmp x0, #PSR_MODE_EL2t
- ccmp x0, #PSR_MODE_EL2h, #0x4, ne
- b.eq 2f /* Yes */
+ cmp x4, #PSR_MODE_EL2t
+ ccmp x4, #PSR_MODE_EL2h, #0x4, ne
+ b.eq el2 /* Yes */
- /* Otherwise, it must have been EL0 or EL1 */
- PRINT("- CPU is not in EL3 or EL2 -\r\n")
- b fail
+ /* OK, we're boned. */
+ PRINT("- Xen must be entered in NS EL2 mode -\r\n" \
+ "- Please update the bootloader -\r\n")
+ b fail
-1: PRINT("- Started in EL3 -\r\n- Entering EL2 -\r\n")
- ldr x1, =enter_el2_mode /* VA of function */
- add x1, x1, x20 /* PA of function */
- adr x30, el2 /* Set return address for call */
- br x1 /* Call function */
+el2: PRINT("- Xen starting at EL2 -\r\n")
-2: PRINT("- Started in EL2 mode -\r\n")
-
-el2:
/* Zero BSS On the boot CPU to avoid nasty surprises */
cbnz x22, skip_bss
@@ -177,9 +215,10 @@ el2:
b.lo 1b
skip_bss:
-
PRINT("- Setting up control registers -\r\n")
+ /* XXXX call PROCINFO_cpu_init here */
+
/* Set up memory attribute type tables */
ldr x0, =MAIRVAL
msr mair_el2, x0
@@ -193,7 +232,7 @@ skip_bss:
ldr x0, =0x80802500
msr tcr_el2, x0
- /* Set up the HSCTLR:
+ /* Set up the SCTLR_EL2:
* Exceptions in LE ARM,
* Low-latency IRQs disabled,
* Write-implies-XN disabled (for now),
@@ -204,69 +243,90 @@ skip_bss:
ldr x0, =(HSCTLR_BASE|SCTLR_A)
msr SCTLR_EL2, x0
- /* Write Xen's PT's paddr into the HTTBR */
+ /* Rebuild the boot pagetable's first-level entries. The structure
+ * is described in mm.c.
+ *
+ * After the CPU enables paging it will add the fixmap mapping
+ * to these page tables, however this may clash with the 1:1
+ * mapping. So each CPU must rebuild the page tables here with
+ * the 1:1 in place. */
+
+ /* Write Xen's PT's paddr into TTBR0_EL2 */
ldr x4, =boot_pgtable
- add x4, x4, x20 /* x4 := paddr (xen_pagetable) */
+ add x4, x4, x20 /* x4 := paddr (boot_pagetable) */
msr TTBR0_EL2, x4
- /* Non-boot CPUs don't need to rebuild the pagetable */
- cbnz x22, pt_ready
-
+ /* Setup boot_pgtable: */
ldr x1, =boot_first
- add x1, x1, x20 /* x1 := paddr (xen_first) */
- mov x3, #PT_PT /* x2 := table map of xen_first */
- orr x2, x1, x3 /* (+ rights for linear PT) */
- str x2, [x4, #0] /* Map it in slot 0 */
+ add x1, x1, x20 /* x1 := paddr (boot_first) */
- mov x4, x1 /* Next level into xen_first */
+ /* ... map boot_first in boot_pgtable[0] */
+ mov x3, #PT_PT /* x2 := table map of boot_first */
+ orr x2, x1, x3 /* + rights for linear PT */
+ str x2, [x4, #0] /* Map it in slot 0 */
- /* console fixmap */
- ldr x1, =xen_fixmap
- add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
- lsr x2, x23, #12
- lsl x2, x2, #12 /* 4K aligned paddr of UART */
- mov x3, #PT_DEV_L3
- orr x2, x2, x3 /* x2 := 4K dev map including UART */
- str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+ /* ... map of paddr(start) in boot_pgtable */
+ lsr x1, x19, #39 /* Offset of base paddr in boot_pgtable */
+ cbz x1, 1f /* It's in slot 0, map in boot_first
+ * or boot_second later on */
- /* Build the baseline idle pagetable's first-level entries */
- ldr x1, =xen_second
- add x1, x1, x20 /* x1 := paddr (xen_second) */
- mov x3, #PT_PT /* x2 := table map of xen_second */
- orr x2, x1, x3 /* (+ rights for linear PT) */
+ lsl x2, x1, #39 /* Base address for 512GB mapping */
+ mov x3, #PT_MEM /* x2 := Section mapping */
+ orr x2, x2, x3
+ lsl x1, x1, #3 /* x1 := Slot offset */
+ str x2, [x4, x1] /* Mapping of paddr(start)*/
+
+1: /* Setup boot_first: */
+ ldr x4, =boot_first /* Next level into boot_first */
+ add x4, x4, x20 /* x4 := paddr(boot_first) */
+
+ /* ... map boot_second in boot_first[0] */
+ ldr x1, =boot_second
+ add x1, x1, x20 /* x1 := paddr(boot_second) */
+ mov x3, #PT_PT /* x2 := table map of boot_first */
+ orr x2, x1, x3 /* + rights for linear PT */
str x2, [x4, #0] /* Map it in slot 0 */
- add x2, x2, #0x1000
- str x2, [x4, #8] /* Map 2nd page in slot 1 */
- add x2, x2, #0x1000
- str x2, [x4, #16] /* Map 3rd page in slot 2 */
- add x2, x2, #0x1000
- str x2, [x4, #24] /* Map 4th page in slot 3 */
-
- /* Now set up the second-level entries */
- mov x3, #PT_MEM
- orr x2, x19, x3 /* x2 := 2MB normal map of Xen */
- orr x4, xzr, x19, lsr #18
- str x2, [x1, x4] /* Map Xen there */
- ldr x4, =start
- lsr x4, x4, #18 /* Slot for vaddr(start) */
- str x2, [x1, x4] /* Map Xen there too */
-
- /* xen_fixmap pagetable */
- ldr x2, =xen_fixmap
- add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
- mov x3, #PT_PT
- orr x2, x2, x3 /* x2 := table map of xen_fixmap */
- add x4, x4, #8
- str x2, [x1, x4] /* Map it in the fixmap's slot */
- lsr x2, x21, #21
- lsl x2, x2, #21 /* 2MB-aligned paddr of DTB */
- mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
+ /* ... map of paddr(start) in boot_first */
+ lsr x2, x19, #30 /* x2 := Offset of base paddr in boot_first */
+ and x1, x2, 0x1ff /* x1 := Slot to use */
+ cbz x1, 1f /* It's in slot 0, map in boot_second */
+
+ lsl x2, x2, #30 /* Base address for 1GB mapping */
+ mov x3, #PT_MEM /* x2 := Section map */
orr x2, x2, x3
- add x4, x4, #8
- str x2, [x1, x4] /* Map it in the early fdt slot */
+ lsl x1, x1, #3 /* x1 := Slot offset */
+ str x2, [x4, x1] /* Create mapping of paddr(start)*/
+
+1: /* Setup boot_second: */
+ ldr x4, =boot_second
+ add x4, x4, x20 /* x4 := paddr (boot_second) */
+
+ lsr x2, x19, #20 /* Base address for 2MB mapping */
+ lsl x2, x2, #20
+ mov x3, #PT_MEM /* x2 := Section map */
+ orr x2, x2, x3
+
+ /* ... map of vaddr(start) in boot_second */
+ ldr x1, =start
+ lsr x1, x1, #18 /* Slot for vaddr(start) */
+ str x2, [x4, x1] /* Map vaddr(start) */
+
+ /* ... map of paddr(start) in boot_second */
+ lsr x1, x19, #30 /* Base paddr */
+ cbnz x1, 1f /* If paddr(start) is not in slot 0
+ * then the mapping was done in
+ * boot_pgtable or boot_first above */
+
+ lsr x1, x19, #18 /* Slot for paddr(start) */
+ str x2, [x4, x1] /* Map Xen there */
+1:
+
+ /* Defer fixmap and dtb mapping until after paging enabled, to
+ * avoid them clashing with the 1:1 mapping. */
+
+ /* boot pagetable setup complete */
-pt_ready:
PRINT("- Turning on paging -\r\n")
ldr x1, =paging /* Explicit vaddr, not RIP-relative */
@@ -279,17 +339,60 @@ pt_ready:
br x1 /* Get a proper vaddr into PC */
paging:
+ /* Now we can install the fixmap and dtb mappings, since we
+ * don't need the 1:1 map any more */
+ dsb sy
+#if defined(EARLY_PRINTK) /* Fixmap is only used by early printk */
+ /* Non-boot CPUs don't need to rebuild the fixmap itself, just
+ * the mapping from boot_second to xen_fixmap */
+ cbnz x22, 1f
+
+ /* Add UART to the fixmap table */
+ ldr x1, =xen_fixmap
+ add x1, x1, x20 /* x1 := paddr (xen_fixmap) */
+ lsr x2, x23, #12
+ lsl x2, x2, #12 /* 4K aligned paddr of UART */
+ mov x3, #PT_DEV_L3
+ orr x2, x2, x3 /* x2 := 4K dev map including UART */
+ str x2, [x1, #(FIXMAP_CONSOLE*8)] /* Map it in the first fixmap's slot */
+1:
+
+ /* Map fixmap into boot_second */
+ ldr x4, =boot_second /* x4 := vaddr (boot_second) */
+ ldr x2, =xen_fixmap
+ add x2, x2, x20 /* x2 := paddr (xen_fixmap) */
+ mov x3, #PT_PT
+ orr x2, x2, x3 /* x2 := table map of xen_fixmap */
+ ldr x1, =FIXMAP_ADDR(0)
+ lsr x1, x1, #18 /* x1 := Slot for FIXMAP(0) */
+ str x2, [x4, x1] /* Map it in the fixmap's slot */
+
/* Use a virtual address to access the UART. */
ldr x23, =FIXMAP_ADDR(FIXMAP_CONSOLE)
+#endif
+
+ /* Map the DTB in the boot misc slot */
+ cbnz x22, 1f /* Only on boot CPU */
+
+ lsr x2, x21, #21
+ lsl x2, x2, #21 /* x2 := 2MB-aligned paddr of DTB */
+ mov x3, #PT_MEM /* x2 := 2MB RAM incl. DTB */
+ orr x2, x2, x3
+ ldr x1, =BOOT_FDT_VIRT_START
+ lsr x1, x1, #18 /* x4 := Slot for BOOT_FDT_VIRT_START */
+ str x2, [x4, x1] /* Map it in the early fdt slot */
+ dsb sy
+1:
PRINT("- Ready -\r\n")
/* The boot CPU should go straight into C now */
cbz x22, launch
- /* Non-boot CPUs need to move on to the relocated pagetables */
- ldr x4, =boot_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
- add x4, x4, x20 /* PA of it */
+ /* Non-boot CPUs need to move on to the proper pagetables, which were
+ * setup in init_secondary_pagetables. */
+
+ ldr x4, =init_ttbr /* VA of TTBR0_EL2 stashed by CPU 0 */
ldr x4, [x4] /* Actual value */
dsb sy
msr TTBR0_EL2, x4
@@ -299,28 +402,6 @@ paging:
dsb sy /* Ensure completion of TLB flush */
isb
- /* Non-boot CPUs report that they've got this far */
- ldr x0, =ready_cpus
-1: ldaxr x1, [x0] /* { read # of ready CPUs } */
- add x1, x1, #1 /* Atomically { ++ } */
- stlxr w2, x1, [x0] /* { writeback } */
- cbnz w2, 1b
- dsb sy
- dc cvac, x0 /* Flush D-Cache */
- dsb sy
-
- /* Here, the non-boot CPUs must wait again -- they're now running on
- * the boot CPU's pagetables so it's safe for the boot CPU to
- * overwrite the non-relocated copy of Xen. Once it's done that,
- * and brought up the memory allocator, non-boot CPUs can get their
- * own stacks and enter C. */
-1: wfe
- dsb sy
- ldr x0, =smp_up_cpu
- ldr x1, [x0] /* Which CPU is being booted? */
- cmp x1, x22 /* Is it us? */
- b.ne 1b
-
launch:
ldr x0, =init_data
add x0, x0, #INITINFO_stack /* Find the boot-time stack */
@@ -331,7 +412,7 @@ launch:
mov x0, x20 /* Marshal args: - phys_offset */
mov x1, x21 /* - FDT */
- mov x2, x22 /* - CPU ID */
+ mov x2, x24 /* - CPU ID */
cbz x22, start_xen /* and disappear into the land of C */
b start_secondary /* (to the appropriate entry point) */
@@ -341,13 +422,80 @@ fail: PRINT("- Boot failed -\r\n")
1: wfe
b 1b
-#ifdef EARLY_PRINTK
+/* Copy Xen to new location and switch TTBR
+ * x0 ttbr
+ * x1 source address
+ * x2 destination address
+ * x3 length
+ *
+ * Source and destination must be word aligned, length is rounded up
+ * to a 16 byte boundary.
+ *
+ * MUST BE VERY CAREFUL when saving things to RAM over the copy */
+ENTRY(relocate_xen)
+ /* Copy 16 bytes at a time using:
+ * x9: counter
+ * x10: data
+ * x11: data
+ * x12: source
+ * x13: destination
+ */
+ mov x9, x3
+ mov x12, x1
+ mov x13, x2
+1: ldp x10, x11, [x12], #16
+ stp x10, x11, [x13], #16
+
+ subs x9, x9, #16
+ bgt 1b
+
+ /* Flush destination from dcache using:
+ * x9: counter
+ * x10: step
+ * x11: vaddr
+ */
+ dsb sy /* So the CPU issues all writes to the range */
+
+ mov x9, x3
+ ldr x10, =cacheline_bytes /* x10 := step */
+ ldr x10, [x10]
+ mov x11, x2
+
+1: dc cvac, x11
+
+ add x11, x11, x10
+ subs x9, x9, x10
+ bgt 1b
+
+ dsb sy /* Ensure the flushes happen before
+ * continuing */
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ tlbi alle2 /* Flush hypervisor TLB */
+ ic iallu /* Flush I-cache */
+ dsb sy /* Ensure completion of TLB flush */
+ isb
+
+ msr TTBR0_EL2, x0
+
+ isb /* Ensure synchronization with previous
+ * changes to text */
+ tlbi alle2 /* Flush hypervisor TLB */
+ ic iallu /* Flush I-cache */
+ dsb sy /* Ensure completion of TLB flush */
+ isb
+
+ ret
+
+#ifdef EARLY_PRINTK
/* Bring up the UART.
* x23: Early UART base address
* Clobbers x0-x1 */
init_uart:
+#ifdef EARLY_PRINTK_INIT_UART
early_uart_init x23, 0
+#endif
adr x0, 1f
b puts
1: .asciz "- UART enabled -\r\n"
diff --git a/xen/arch/arm/arm64/mode_switch.S b/xen/arch/arm/arm64/mode_switch.S
deleted file mode 100644
index ea64f22..0000000
--- a/xen/arch/arm/arm64/mode_switch.S
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * xen/arch/arm/arm64/mode_switch.S
- *
- * Start-of day code to take a CPU from EL3 to EL2. Largely taken from
- * bootwrapper.
- *
- * Ian Campbell <ian.campbell@citrix.com>
- * Copyright (c) 2012 Citrix Systems.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <asm/config.h>
-#include <asm/page.h>
-#include <asm/asm_defns.h>
-#include <asm/platforms/vexpress.h>
-
-/* Get up a CPU into EL2. Clobbers x0-x3.
- *
- * Expects x22 == CPU number
- * Expects x30 == EL2 entry point
- *
- * This code is specific to the VE model, and not intended to be used
- * on production systems. As such it's a bit hackier than the main
- * boot code in head.S. In future it will be replaced by better
- * integration with the bootloader/firmware so that Xen always starts
- * at EL2.
- */
-GLOBAL(enter_el2_mode)
- mov x0, #0x30 // RES1
- orr x0, x0, #(1 << 0) // Non-secure EL1
- orr x0, x0, #(1 << 8) // HVC enable
- orr x0, x0, #(1 << 10) // 64-bit EL2
- msr scr_el3, x0
-
- msr cptr_el3, xzr // Disable copro. traps to EL3
-
- ldr x0, =0x01800000 // 24Mhz
- msr cntfrq_el0, x0
-
- /*
- * Check for the primary CPU to avoid a race on the distributor
- * registers.
- */
- cbnz x22, 1f
-
- ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET) // GICD_CTLR
- mov w0, #3 // EnableGrp0 | EnableGrp1
- str w0, [x1]
-
-1: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_DR_OFFSET+0x80) // GICD_IGROUPR
- mov w0, #~0 // Grp1 interrupts
- str w0, [x1], #4
- b.ne 2f // Only local interrupts for secondary CPUs
- str w0, [x1], #4
- str w0, [x1], #4
-
-2: ldr x1, =(V2M_GIC_BASE_ADDRESS+GIC_CR_OFFSET) // GICC_CTLR
- ldr w0, [x1]
- mov w0, #3 // EnableGrp0 | EnableGrp1
- str w0, [x1]
-
- mov w0, #1 << 7 // allow NS access to GICC_PMR
- str w0, [x1, #4] // GICC_PMR
-
- msr sctlr_el2, xzr
-
- /*
- * Prepare the switch to the EL2_SP1 mode from EL3
- */
- msr elr_el3, x30 // Return to desired function
- mov x1, #0x3c9 // EL2_SP1 | D | A | I | F
- msr spsr_el3, x1
- eret
-
-/*
- * Local variables:
- * mode: ASM
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 6175b76..cd1fd47 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -43,40 +43,70 @@
struct domain *dom_xen, *dom_io, *dom_cow;
-/* Static start-of-day pagetables that we use before the
- * allocators are up. These go on to become the boot CPU's real pagetables.
+/* Static start-of-day pagetables that we use before the allocators
+ * are up. These are used by all CPUs during bringup before switching
+ * to the CPUs own pagetables.
+ *
+ * These pagetables have a very simple structure. They include:
+ * - a 2MB mapping of xen at XEN_VIRT_START, boot_first and
+ * boot_second are used to populate the trie down to that mapping.
+ * - a 1:1 mapping of xen at its current physical address. This uses a
+ * section mapping at whichever of boot_{pgtable,first,second}
+ * covers that physical address.
+ *
+ * For the boot CPU these mappings point to the address where Xen was
+ * loaded by the bootloader. For secondary CPUs they point to the
+ * relocated copy of Xen for the benefit of secondary CPUs.
+ *
+ * In addition to the above for the boot CPU the device-tree is
+ * initially mapped in the boot misc slot. This mapping is not present
+ * for secondary CPUs.
+ *
+ * Finally, if EARLY_PRINTK is enabled then xen_fixmap will be mapped
+ * by the CPU once it has moved off the 1:1 mapping.
*/
lpae_t boot_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
#ifdef CONFIG_ARM_64
lpae_t boot_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-/* The first page of the first level mapping of the xenheap. The
- * subsequent xenheap first level pages are dynamically allocated, but
- * we need this one to bootstrap ourselves. */
-lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-/* The zeroeth level slot which uses xenheap_first_first. Used because
- * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
- * valid for a non-xenheap mapping. */
-static __initdata int xenheap_first_first_slot = -1;
#endif
+lpae_t boot_second[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+
+/* Main runtime page tables */
/*
- * xen_pgtable and xen_dommap are per-PCPU and are allocated before
- * bringing up each CPU. On 64-bit a first level table is also allocated.
+ * For arm32 xen_pgtable and xen_dommap are per-PCPU and are allocated before
+ * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs.
*
- * xen_second, xen_fixmap and xen_xenmap are shared between all PCPUs.
+ * xen_second, xen_fixmap and xen_xenmap are always shared between all
+ * PCPUs.
*/
#ifdef CONFIG_ARM_64
-#define THIS_CPU_PGTABLE boot_pgtable
+lpae_t xen_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+lpae_t xen_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+#define THIS_CPU_PGTABLE xen_pgtable
#else
/* Per-CPU pagetable pages */
/* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */
static DEFINE_PER_CPU(lpae_t *, xen_pgtable);
#define THIS_CPU_PGTABLE this_cpu(xen_pgtable)
/* xen_dommap == pages used by map_domain_page, these pages contain
- * the second level pagetables which mapp the domheap region
+ * the second level pagetables which map the domheap region
* DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */
static DEFINE_PER_CPU(lpae_t *, xen_dommap);
+/* Root of the trie for cpu0 */
+lpae_t cpu0_pgtable[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+#endif
+
+#ifdef CONFIG_ARM_64
+/* The first page of the first level mapping of the xenheap. The
+ * subsequent xenheap first level pages are dynamically allocated, but
+ * we need this one to bootstrap ourselves. */
+lpae_t xenheap_first_first[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
+/* The zeroeth level slot which uses xenheap_first_first. Used because
+ * setup_xenheap_mappings otherwise relies on mfn_to_virt which isn't
+ * valid for a non-xenheap mapping. */
+static __initdata int xenheap_first_first_slot = -1;
#endif
/* Common pagetable leaves */
@@ -104,9 +134,8 @@ lpae_t xen_fixmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
* as appropriate. */
static lpae_t xen_xenmap[LPAE_ENTRIES] __attribute__((__aligned__(4096)));
-
/* Non-boot CPUs use this to find the correct pagetables. */
-uint64_t boot_ttbr;
+uint64_t init_ttbr;
static paddr_t phys_offset;
@@ -131,6 +160,12 @@ static inline void check_memory_layout_alignment_constraints(void) {
BUILD_BUG_ON(BOOT_RELOC_VIRT_START & ~SECOND_MASK);
/* 1GB aligned regions */
BUILD_BUG_ON(XENHEAP_VIRT_START & ~FIRST_MASK);
+ /* Page table structure constraints */
+#ifdef CONFIG_ARM_64
+ BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START));
+#endif
+ BUILD_BUG_ON(first_table_offset(XEN_VIRT_START));
+ BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= LPAE_ENTRIES);
#ifdef CONFIG_DOMAIN_PAGE
BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK);
#endif
@@ -361,16 +396,6 @@ void __cpuinit setup_virt_paging(void)
WRITE_SYSREG32(0x80002558, VTCR_EL2); isb();
}
-/* This needs to be a macro to stop the compiler spilling to the stack
- * which will change when we change pagetables */
-#define WRITE_TTBR(ttbr) \
- flush_xen_text_tlb(); \
- WRITE_SYSREG64(ttbr, TTBR0_EL2); \
- dsb(); /* ensure memory accesses do not cross over the TTBR0 write */ \
- /* flush_xen_text_tlb contains an initial isb which ensures the \
- * write to TTBR0 has completed. */ \
- flush_xen_text_tlb()
-
static inline lpae_t pte_of_xenaddr(vaddr_t va)
{
paddr_t ma = va + phys_offset;
@@ -385,70 +410,77 @@ void __init remove_early_mappings(void)
flush_xen_data_tlb_range_va(BOOT_FDT_VIRT_START, SECOND_SIZE);
}
+extern void relocate_xen(uint64_t ttbr, void *src, void *dst, size_t len);
+
/* Boot-time pagetable setup.
* Changes here may need matching changes in head.S */
void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
{
+ uint64_t ttbr;
unsigned long dest_va;
lpae_t pte, *p;
int i;
- /* Map the destination in the boot misc area. */
- dest_va = BOOT_RELOC_VIRT_START;
- pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
- write_pte(xen_second + second_table_offset(dest_va), pte);
- flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
-
/* Calculate virt-to-phys offset for the new location */
phys_offset = xen_paddr - (unsigned long) _start;
- /* Copy */
- memcpy((void *) dest_va, _start, _end - _start);
-
- /* Beware! Any state we modify between now and the PT switch may be
- * discarded when we switch over to the copy. */
-
- /* Update the copy of boot_pgtable to use the new paddrs */
- p = (void *) boot_pgtable + dest_va - (unsigned long) _start;
#ifdef CONFIG_ARM_64
- p[0].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
- p = (void *) boot_first + dest_va - (unsigned long) _start;
+ p = (void *) xen_pgtable;
+ p[0] = pte_of_xenaddr((uintptr_t)xen_first);
+ p[0].pt.table = 1;
+ p[0].pt.xn = 0;
+ p = (void *) xen_first;
+#else
+ p = (void *) cpu0_pgtable;
#endif
- for ( i = 0; i < 4; i++)
- p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
- p = (void *) xen_second + dest_va - (unsigned long) _start;
- if ( boot_phys_offset != 0 )
+ /* Initialise first level entries, to point to second level entries */
+ for ( i = 0; i < 4; i++)
{
- /* Remove the old identity mapping of the boot paddr */
- vaddr_t va = (vaddr_t)_start + boot_phys_offset;
- p[second_linear_offset(va)].bits = 0;
+ p[i] = pte_of_xenaddr((uintptr_t)(xen_second+i*LPAE_ENTRIES));
+ p[i].pt.table = 1;
+ p[i].pt.xn = 0;
}
- for ( i = 0; i < 4 * LPAE_ENTRIES; i++)
- /* The FDT is not relocated */
- if ( p[i].pt.valid && i != second_linear_offset(BOOT_FDT_VIRT_START) )
- p[i].pt.base += (phys_offset - boot_phys_offset) >> PAGE_SHIFT;
- /* Change pagetables to the copy in the relocated Xen */
- boot_ttbr = (uintptr_t) boot_pgtable + phys_offset;
- flush_xen_dcache(boot_ttbr);
- flush_xen_dcache_va_range((void*)dest_va, _end - _start);
+ /* Initialise xen second level entries ... */
+ /* ... Xen's text etc */
- WRITE_TTBR(boot_ttbr);
+ pte = mfn_to_xen_entry(xen_paddr>>PAGE_SHIFT);
+ pte.pt.xn = 0;/* Contains our text mapping! */
+ xen_second[second_table_offset(XEN_VIRT_START)] = pte;
- /* Undo the temporary map */
- pte.bits = 0;
- write_pte(xen_second + second_table_offset(dest_va), pte);
- flush_xen_text_tlb();
-
- /* Link in the fixmap pagetable */
+ /* ... Fixmap */
pte = pte_of_xenaddr((vaddr_t)xen_fixmap);
pte.pt.table = 1;
- write_pte(xen_second + second_table_offset(FIXMAP_ADDR(0)), pte);
- /*
- * No flush required here. Individual flushes are done in
- * set_fixmap as entries are used.
- */
+ xen_second[second_table_offset(FIXMAP_ADDR(0))] = pte;
+
+ /* ... DTB */
+ pte = boot_second[second_table_offset(BOOT_FDT_VIRT_START)];
+ xen_second[second_table_offset(BOOT_FDT_VIRT_START)] = pte;
+
+ /* Map the destination in the boot misc area. */
+ dest_va = BOOT_RELOC_VIRT_START;
+ pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT);
+ write_pte(boot_second + second_table_offset(dest_va), pte);
+ flush_xen_data_tlb_range_va(dest_va, SECOND_SIZE);
+#ifdef CONFIG_ARM_64
+ ttbr = (uintptr_t) xen_pgtable + phys_offset;
+#else
+ ttbr = (uintptr_t) cpu0_pgtable + phys_offset;
+#endif
+
+ relocate_xen(ttbr, _start, (void*)dest_va, _end - _start);
+
+ /* Clear the copy of the boot pagetables. Each secondary CPU
+ * rebuilds these itself (see head.S) */
+ memset(boot_pgtable, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_pgtable);
+#ifdef CONFIG_ARM_64
+ memset(boot_pgtable, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_first);
+#endif
+ memset(boot_second, 0x0, PAGE_SIZE);
+ flush_xen_dcache(boot_second);
/* Break up the Xen mapping into 4k pages and protect them separately. */
for ( i = 0; i < LPAE_ENTRIES; i++ )
@@ -469,6 +501,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
write_pte(xen_xenmap + i, pte);
/* No flush required here as page table is not hooked in yet. */
}
+
pte = pte_of_xenaddr((vaddr_t)xen_xenmap);
pte.pt.table = 1;
write_pte(xen_second + second_linear_offset(XEN_VIRT_START), pte);
@@ -480,7 +513,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
flush_xen_text_tlb();
#ifdef CONFIG_ARM_32
- per_cpu(xen_pgtable, 0) = boot_pgtable;
+ per_cpu(xen_pgtable, 0) = cpu0_pgtable;
per_cpu(xen_dommap, 0) = xen_second +
second_linear_offset(DOMHEAP_VIRT_START);
@@ -491,10 +524,14 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr)
DOMHEAP_SECOND_PAGES*PAGE_SIZE);
#endif
}
+
#ifdef CONFIG_ARM_64
int init_secondary_pagetables(int cpu)
{
- /* All CPUs share a single page table on 64 bit */
+ /* Set init_ttbr for this CPU coming up. All CPus share a single setof
+ * pagetables, but rewrite it each time for consistency with 32 bit. */
+ init_ttbr = (uintptr_t) xen_pgtable + phys_offset;
+ flush_xen_dcache(init_ttbr);
return 0;
}
#else
@@ -515,7 +552,7 @@ int init_secondary_pagetables(int cpu)
}
/* Initialise root pagetable from root of boot tables */
- memcpy(first, boot_pgtable, PAGE_SIZE);
+ memcpy(first, cpu0_pgtable, PAGE_SIZE);
/* Ensure the domheap has no stray mappings */
memset(domheap, 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE);
@@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
per_cpu(xen_pgtable, cpu) = first;
per_cpu(xen_dommap, cpu) = domheap;
+ /* Set init_ttbr for this CPU coming up */
+ init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
+ flush_xen_dcache(init_ttbr);
+
return 0;
}
#endif
@@ -542,12 +583,6 @@ int init_secondary_pagetables(int cpu)
/* MMU setup for secondary CPUS (which already have paging enabled) */
void __cpuinit mmu_init_secondary_cpu(void)
{
- uint64_t ttbr;
-
- /* Change to this CPU's pagetables */
- ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
- WRITE_TTBR(ttbr);
-
/* From now on, no mapping may be both writable and executable. */
WRITE_SYSREG32(READ_SYSREG32(SCTLR_EL2) | SCTLR_WXN, SCTLR_EL2);
flush_xen_text_tlb();
@@ -620,7 +655,7 @@ void __init setup_xenheap_mappings(unsigned long base_mfn,
while ( base_mfn < end_mfn )
{
int slot = zeroeth_table_offset(vaddr);
- lpae_t *p = &boot_pgtable[slot];
+ lpae_t *p = &xen_pgtable[slot];
if ( p->pt.valid )
{
@@ -687,7 +722,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe)
{
pte = mfn_to_xen_entry(second_base + i);
pte.pt.table = 1;
- write_pte(&boot_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
+ write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte);
}
create_32mb_mappings(second, 0, base_mfn, frametable_size >> PAGE_SHIFT);
#else
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index d615b4a..b2c4101 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -592,7 +592,7 @@ void __init setup_cache(void)
* MPIDR values related to logical cpus
* Code base on Linux arch/arm/kernel/devtree.c
*/
-static void __init init_cpus_maps(void)
+static void __init smp_init_cpus(void)
{
register_t mpidr;
struct dt_device_node *cpus = dt_find_node_by_path("/cpus");
@@ -604,6 +604,14 @@ static void __init init_cpus_maps(void)
[0 ... NR_CPUS - 1] = MPIDR_INVALID
};
bool_t bootcpu_valid = 0;
+ int rc;
+
+ if ( (rc = arch_smp_init()) < 0 )
+ {
+ printk(XENLOG_WARNING "SMP init failed (%d)\n"
+ "Using only 1 CPU\n", rc);
+ return;
+ }
mpidr = boot_cpu_data.mpidr.bits & MPIDR_HWID_MASK;
@@ -673,13 +681,20 @@ static void __init init_cpus_maps(void)
if ( cpuidx > NR_CPUS )
{
- printk(XENLOG_WARNING "DT /cpu %u node greater than max cores %u, capping them\n",
+ printk(XENLOG_WARNING
+ "DT /cpu %u node greater than max cores %u, capping them\n",
cpuidx, NR_CPUS);
cpuidx = NR_CPUS;
break;
}
- tmp_map[i] = hwid;
+ if ( (rc = arch_cpu_init(i, cpu)) < 0 )
+ {
+ printk("cpu%d init failed (hwid %x): %d\n", i, hwid, rc);
+ tmp_map[i] = MPIDR_INVALID;
+ }
+ else
+ tmp_map[i] = hwid;
}
if ( !bootcpu_valid )
@@ -691,6 +706,8 @@ static void __init init_cpus_maps(void)
for ( i = 0; i < cpuidx; i++ )
{
+ if ( tmp_map[i] == MPIDR_INVALID )
+ continue;
cpumask_set_cpu(i, &cpu_possible_map);
cpu_logical_map(i) = tmp_map[i];
}
@@ -732,15 +749,14 @@ void __init start_xen(unsigned long boot_phys_offset,
processor_id();
- init_cpus_maps();
- cpus = smp_get_max_cpus();
-
platform_init();
+ smp_init_cpus();
+ cpus = smp_get_max_cpus();
+
init_xen_time();
gic_init();
- make_cpus_ready(cpus, boot_phys_offset);
set_current((struct vcpu *)0xfffff000); /* debug sanity */
idle_vcpu[0] = current;
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index 234748e..2cb0f36 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -56,12 +56,10 @@ struct init_info __initdata init_data =
};
/* Shared state for coordinating CPU bringup */
-unsigned long smp_up_cpu = 0;
+unsigned long smp_up_cpu = MPIDR_INVALID;
+/* Shared state for coordinating CPU teardown */
static bool_t cpu_is_dead = 0;
-/* Number of non-boot CPUs ready to enter C */
-unsigned long __initdata ready_cpus = 0;
-
/* ID of the PCPU we're running on */
DEFINE_PER_CPU(unsigned int, cpu_id);
/* XXX these seem awfully x86ish... */
@@ -103,7 +101,6 @@ smp_get_max_cpus (void)
return max_cpus;
}
-
void __init
smp_prepare_cpus (unsigned int max_cpus)
{
@@ -112,32 +109,6 @@ smp_prepare_cpus (unsigned int max_cpus)
setup_cpu_sibling_map(0);
}
-void __init
-make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset)
-{
- unsigned long *gate;
- paddr_t gate_pa;
- int i;
-
- printk("Waiting for %i other CPUs to be ready\n", max_cpus - 1);
- /* We use the unrelocated copy of smp_up_cpu as that's the one the
- * others can see. */
- gate_pa = ((paddr_t) (unsigned long) &smp_up_cpu) + boot_phys_offset;
- gate = map_domain_page(gate_pa >> PAGE_SHIFT) + (gate_pa & ~PAGE_MASK);
- for ( i = 1; i < max_cpus; i++ )
- {
- /* Tell the next CPU to get ready */
- *gate = cpu_logical_map(i);
- flush_xen_dcache(*gate);
- isb();
- sev();
- /* And wait for it to respond */
- while ( ready_cpus < i )
- smp_rmb();
- }
- unmap_domain_page(gate);
-}
-
/* Boot the current CPU */
void __cpuinit start_secondary(unsigned long boot_phys_offset,
unsigned long fdt_paddr,
@@ -176,6 +147,7 @@ void __cpuinit start_secondary(unsigned long boot_phys_offset,
wmb();
/* Now report this CPU is up */
+ smp_up_cpu = MPIDR_INVALID;
cpumask_set_cpu(cpuid, &cpu_online_map);
wmb();
@@ -226,6 +198,8 @@ int __cpu_up(unsigned int cpu)
{
int rc;
+ printk("Bringing up CPU%d\n", cpu);
+
rc = init_secondary_pagetables(cpu);
if ( rc < 0 )
return rc;
@@ -236,14 +210,22 @@ int __cpu_up(unsigned int cpu)
/* Tell the remote CPU what is it's logical CPU ID */
init_data.cpuid = cpu;
- /* Unblock the CPU. It should be waiting in the loop in head.S
- * for an event to arrive when smp_up_cpu matches its cpuid. */
+ /* Open the gate for this CPU */
smp_up_cpu = cpu_logical_map(cpu);
- /* we need to make sure that the change to smp_up_cpu is visible to
- * secondary cpus with D-cache off */
flush_xen_dcache(smp_up_cpu);
- isb();
- sev();
+
+ rc = arch_cpu_up(cpu);
+
+ if ( rc < 0 )
+ {
+ printk("Failed to bring up CPU%d\n", cpu);
+ return rc;
+ }
+
+ /* We don't know the GIC ID of the CPU until it has woken up, so just signal
+ * everyone and rely on our own smp_up_cpu gate to ensure only the one we
+ * want gets through. */
+ send_SGI_allbutself(GIC_SGI_EVENT_CHECK);
while ( !cpu_online(cpu) )
{
@@ -272,7 +254,6 @@ void __cpu_die(unsigned int cpu)
mb();
}
-
/*
* Local variables:
* mode: C
diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
index 0129cd1..ce66099 100644
--- a/xen/include/asm-arm/mm.h
+++ b/xen/include/asm-arm/mm.h
@@ -149,7 +149,8 @@ extern unsigned long total_pages;
extern void setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr);
/* Remove early mappings */
extern void remove_early_mappings(void);
-/* Allocate and initialise pagetables for a secondary CPU */
+/* Allocate and initialise pagetables for a secondary CPU. Sets init_ttbr to the
+ * new page table */
extern int __cpuinit init_secondary_pagetables(int cpu);
/* Switch secondary CPUS to its own pagetables and finalise MMU setup */
extern void __cpuinit mmu_init_secondary_cpu(void);
diff --git a/xen/include/asm-arm/platforms/exynos5.h b/xen/include/asm-arm/platforms/exynos5.h
index ee5bdfa..af30608 100644
--- a/xen/include/asm-arm/platforms/exynos5.h
+++ b/xen/include/asm-arm/platforms/exynos5.h
@@ -14,20 +14,6 @@
#define S5P_PA_SYSRAM 0x02020000
-/* Constants below is only used in assembly because the DTS is not yet parsed */
-#ifdef __ASSEMBLY__
-
-/* GIC Base Address */
-#define EXYNOS5_GIC_BASE_ADDRESS 0x10480000
-
-/* Timer's frequency */
-#define EXYNOS5_TIMER_FREQUENCY (24 * 1000 * 1000) /* 24 MHz */
-
-/* Arndale machine ID */
-#define MACH_TYPE_SMDK5250 3774
-
-#endif /* __ASSEMBLY__ */
-
#endif /* __ASM_ARM_PLATFORMS_EXYNOS5_H */
/*
* Local variables:
diff --git a/xen/include/asm-arm/platforms/vexpress.h b/xen/include/asm-arm/platforms/vexpress.h
index 982a293..5cf3aba 100644
--- a/xen/include/asm-arm/platforms/vexpress.h
+++ b/xen/include/asm-arm/platforms/vexpress.h
@@ -32,17 +32,6 @@
int vexpress_syscfg(int write, int function, int device, uint32_t *data);
#endif
-/* Constants below is only used in assembly because the DTS is not yet parsed */
-#ifdef __ASSEMBLY__
-
-/* GIC base address */
-#define V2M_GIC_BASE_ADDRESS 0x2c000000
-
-/* Timer's frequency */
-#define V2M_TIMER_FREQUENCY 0x5f5e100 /* 100 Mhz */
-
-#endif /* __ASSEMBLY__ */
-
#endif /* __ASM_ARM_PLATFORMS_VEXPRESS_H */
/*
* Local variables:
diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h
index 1added5..83add6c 100644
--- a/xen/include/asm-arm/smp.h
+++ b/xen/include/asm-arm/smp.h
@@ -17,12 +17,6 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);
extern void stop_cpu(void);
-/* Bring the non-boot CPUs up to paging and ready to enter C.
- * Must be called after Xen is relocated but before the original copy of
- * .text gets overwritten. */
-extern void
-make_cpus_ready(unsigned int max_cpus, unsigned long boot_phys_offset);
-
extern int arch_smp_init(void);
extern int arch_cpu_init(int cpu, struct dt_device_node *dn);
extern int arch_cpu_up(int cpu);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 14:38 ` Ian Campbell
@ 2013-09-27 15:17 ` Ian Campbell
2013-09-27 15:30 ` Julien Grall
0 siblings, 1 reply; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 15:17 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 15:38 +0100, Ian Campbell wrote:
> @@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
> per_cpu(xen_pgtable, cpu) = first;
> per_cpu(xen_dommap, cpu) = domheap;
>
> + /* Set init_ttbr for this CPU coming up */
> + init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> + flush_xen_dcache(init_ttbr);
> +
> return 0;
> }
> #endif
/me puts on his donkey ears.
We don't really want to run all 32-bit CPUs on CPU0's pagetables, do we
now...
diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 18fa979..99857ea 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -572,7 +572,7 @@ int init_secondary_pagetables(int cpu)
per_cpu(xen_dommap, cpu) = domheap;
/* Set init_ttbr for this CPU coming up */
- init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
+ init_ttbr = __pa(first);
flush_xen_dcache(init_ttbr);
return 0;
Now, where did I put my brown paper bag.
Ian.
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 15:17 ` Ian Campbell
@ 2013-09-27 15:30 ` Julien Grall
2013-09-27 15:52 ` Ian Campbell
0 siblings, 1 reply; 28+ messages in thread
From: Julien Grall @ 2013-09-27 15:30 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 09/27/2013 04:17 PM, Ian Campbell wrote:
> On Fri, 2013-09-27 at 15:38 +0100, Ian Campbell wrote:
>> @@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
>> per_cpu(xen_pgtable, cpu) = first;
>> per_cpu(xen_dommap, cpu) = domheap;
>>
>> + /* Set init_ttbr for this CPU coming up */
>> + init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
>> + flush_xen_dcache(init_ttbr);
>> +
>> return 0;
>> }
>> #endif
>
> /me puts on his donkey ears.
>
> We don't really want to run all 32-bit CPUs on CPU0's pagetables, do we
> now...
It's now boot on the arndale. With the 2 changes (this one and the
smp_cpus_init...):
Acked-by: Julien Grall <julien.grall@linaro.org>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 18fa979..99857ea 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -572,7 +572,7 @@ int init_secondary_pagetables(int cpu)
> per_cpu(xen_dommap, cpu) = domheap;
>
> /* Set init_ttbr for this CPU coming up */
> - init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> + init_ttbr = __pa(first);
> flush_xen_dcache(init_ttbr);
>
> return 0;
>
> Now, where did I put my brown paper bag.
>
> Ian.
>
>
--
Julien Grall
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up
2013-09-27 15:30 ` Julien Grall
@ 2013-09-27 15:52 ` Ian Campbell
0 siblings, 0 replies; 28+ messages in thread
From: Ian Campbell @ 2013-09-27 15:52 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Fri, 2013-09-27 at 16:30 +0100, Julien Grall wrote:
> On 09/27/2013 04:17 PM, Ian Campbell wrote:
> > On Fri, 2013-09-27 at 15:38 +0100, Ian Campbell wrote:
> >> @@ -535,6 +572,10 @@ int init_secondary_pagetables(int cpu)
> >> per_cpu(xen_pgtable, cpu) = first;
> >> per_cpu(xen_dommap, cpu) = domheap;
> >>
> >> + /* Set init_ttbr for this CPU coming up */
> >> + init_ttbr = (uintptr_t) THIS_CPU_PGTABLE + phys_offset;
> >> + flush_xen_dcache(init_ttbr);
> >> +
> >> return 0;
> >> }
> >> #endif
> >
> > /me puts on his donkey ears.
> >
> > We don't really want to run all 32-bit CPUs on CPU0's pagetables, do we
> > now...
>
> It's now boot on the arndale. With the 2 changes (this one and the
> smp_cpus_init...):
>
> Acked-by: Julien Grall <julien.grall@linaro.org>
Thanks, I applied this series now, plus the EXTRA one which you just
acked. BTW I removed the wording about being untested from the exynos5
patch, since I know you did test it (thanks!).
My plan is to do a sweep of the wiki on Monday (docs day) and update it
to talk about using boot-wrappers on models and reference u-boot patches
etc...
Ian.
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2013-09-27 15:52 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-27 10:16 [PATCH v3 00/11] xen: arm: rework early bring up Ian Campbell
2013-09-27 10:20 ` [PATCH v3 01/11] xen: arm: Load xen under 4GB on 32-bit Ian Campbell
2013-09-27 10:20 ` [PATCH v3 02/11] xen: arm: build platform support only on the relevant arch Ian Campbell
2013-09-27 12:19 ` Julien Grall
2013-09-27 10:20 ` [PATCH v3 03/11] xen: arm: Log the raw MIDR on boot Ian Campbell
2013-09-27 10:20 ` [PATCH v3 04/11] xen: arm: make sure we stay within the memory bank during mm setup Ian Campbell
2013-09-27 10:20 ` [PATCH v3 05/11] xen: arm: add two new device tree helpers Ian Campbell
2013-09-27 10:20 ` [PATCH v3 06/11] xen: arm: implement arch/platform SMP and CPU initialisation framework Ian Campbell
2013-09-27 12:23 ` Julien Grall
2013-09-27 12:35 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 07/11] xen: arm: implement smp initialisation callbacks for exynos5 Ian Campbell
2013-09-27 10:20 ` [PATCH v3 08/11] xen: arm: rewrite start of day page table and cpu bring up Ian Campbell
2013-09-27 12:30 ` Julien Grall
2013-09-27 12:37 ` Ian Campbell
2013-09-27 13:30 ` Julien Grall
2013-09-27 14:10 ` Ian Campbell
2013-09-27 14:21 ` Julien Grall
2013-09-27 14:23 ` Ian Campbell
2013-09-27 14:26 ` Ian Campbell
2013-09-27 14:21 ` Ian Campbell
2013-09-27 14:31 ` Julien Grall
2013-09-27 14:38 ` Ian Campbell
2013-09-27 15:17 ` Ian Campbell
2013-09-27 15:30 ` Julien Grall
2013-09-27 15:52 ` Ian Campbell
2013-09-27 10:20 ` [PATCH v3 09/11] xen: arm: use symbolic names for MPIDR bits Ian Campbell
2013-09-27 10:20 ` [PATCH v3 10/11] xen: arm: configure TCR_EL2 for 40 bit physical address space Ian Campbell
2013-09-27 10:20 ` [PATCH v3 11/11] xen: arm: split cpu0's domheap mapping PTs out from xen_second Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.