new sparse warnings

new sparse warnings

[Steve French]

Any idea what the new sparse "context imbalance" warnings are?  Is
this a bug in sparse?

stevef@smf-t60p:~/kernels/cifs-2.6-devel> make modules C=1
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CHECK   fs/cifs/cifssmb.c
fs/cifs/cifssmb.c:134:2: warning: context imbalance in
'mark_open_files_invalid': wrong count at exit
fs/cifs/cifssmb.c:134:2:    context 'lock': wanted 0, got 1
fs/cifs/cifssmb.c:5191:9: warning: context imbalance in
'CIFSSMBNotify': wrong count at exit
fs/cifs/cifssmb.c:5191:9:    context 'lock': wanted 0, got 1
  CC [M]  fs/cifs/cifssmb.o

The functions it is complaining about don't seem to have a "context
imbalance" see e.g.the one near line 134 of fs/cifs/cifssmb.c

static void mark_open_files_invalid(struct cifsTconInfo *pTcon)
{
        struct cifsFileInfo *open_file = NULL;
        struct list_head *tmp;
        struct list_head *tmp1;

/* list all files open on tree connection and mark them invalid */
        write_lock(&GlobalSMBSeslock);
        list_for_each_safe(tmp, tmp1, &pTcon->openFileList) {
                open_file = list_entry(tmp, struct cifsFileInfo, tlist);
                if (open_file)
                        open_file->invalidHandle = true;
        }
        write_unlock(&GlobalSMBSeslock);
}


-- 
Thanks,

Steve

Re: new sparse warnings

[Kalle Valo]

Johannes Berg <johannes@sipsolutions.net> writes:

> These showed up in the nightly pull from yesterday:
>

[...]

>> +net/mac80211/util.c:355:6: warning: symbol 'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
>> +net/mac80211/util.c:385:6: warning: symbol 'ieee80211_stop_queue_by_reason' was not declared. Should it be static?

Sorry about that, I'll send a fix later this week.

-- 
Kalle Valo

new sparse warnings

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

These showed up in the nightly pull from yesterday:

> +drivers/net/wireless/iwlwifi/iwl3945-base.c:7436:5: warning: symbol 'iwl3945_init_drv' was not declared. Should it be static?
> +drivers/net/wireless/iwlwifi/iwl-3945.c:1325:5: warning: symbol 'iwl3945_apm_reset' was not declared. Should it be static?
> +net/mac80211/util.c:355:6: warning: symbol 'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
> +net/mac80211/util.c:385:6: warning: symbol 'ieee80211_stop_queue_by_reason' was not declared. Should it be static?
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]