* Re: [PATCH V2 02/11] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains
[not found] ` <5c4a3a3fb4bf7320e592aabf582bfb6bdec4ee69.1523273291.git.viresh.kumar@linaro.org>
@ 2018-05-03 4:27 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2018-05-03 4:27 UTC (permalink / raw)
To: Rob Herring
Cc: Viresh Kumar, Nishanth Menon, Ulf Hansson, Stephen Boyd,
Rajendra Nayak, Vincent Guittot, linux-pm, devicetree
On 09-04-18, 17:13, Viresh Kumar wrote:
> The "opp-hz" property is not relevant across all the devices that use
> the OPP tables now. For example, for a power domain a frequency value
> wouldn't mean anything. Though they must have another property, which
> may be implementation defined, which uniquely identifies the OPP nodes.
>
> Make "opp-hz" optional for such devices.
>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index 788052d66c9d..c396c4c0af92 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -82,7 +82,10 @@ This defines voltage-current-frequency combinations along with other related
> properties.
>
> Required properties:
> -- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
> +- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
> + required property for all device nodes but devices like power domains. The
> + power domain nodes must have another (implementation dependent) property which
> + uniquely identifies the OPP nodes.
>
> Optional properties:
> - opp-microvolt: voltage in micro Volts.
Hi Rob,
Can you please review/Ack this patch as well? I can then pick this
series for 4.18 branch.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2 resend] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains
[not found] <cover.1523273291.git.viresh.kumar@linaro.org>
[not found] ` <5c4a3a3fb4bf7320e592aabf582bfb6bdec4ee69.1523273291.git.viresh.kumar@linaro.org>
@ 2018-05-08 3:34 ` Viresh Kumar
2018-05-08 15:42 ` Rob Herring
1 sibling, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-05-08 3:34 UTC (permalink / raw)
To: Rafael Wysocki, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Mark Rutland
Cc: Viresh Kumar, linux-pm, Vincent Guittot, devicetree, Ulf Hansson
The "opp-hz" property is not relevant across all the devices that use
the OPP tables now. For example, for a power domain a frequency value
wouldn't mean anything. Though they must have another property, which
may be implementation defined, which uniquely identifies the OPP nodes.
Make "opp-hz" optional for such devices.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
---
Resending to get Ack from Rob.
Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
index 788052d66c9d..c396c4c0af92 100644
--- a/Documentation/devicetree/bindings/opp/opp.txt
+++ b/Documentation/devicetree/bindings/opp/opp.txt
@@ -82,7 +82,10 @@ This defines voltage-current-frequency combinations along with other related
properties.
Required properties:
-- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer.
+- opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a
+ required property for all device nodes but devices like power domains. The
+ power domain nodes must have another (implementation dependent) property which
+ uniquely identifies the OPP nodes.
Optional properties:
- opp-microvolt: voltage in micro Volts.
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2 resend] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains
2018-05-08 3:34 ` [PATCH V2 resend] " Viresh Kumar
@ 2018-05-08 15:42 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-05-08 15:42 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Mark Rutland, linux-pm, Vincent Guittot, devicetree, Ulf Hansson
On Tue, May 08, 2018 at 09:04:42AM +0530, Viresh Kumar wrote:
> The "opp-hz" property is not relevant across all the devices that use
> the OPP tables now. For example, for a power domain a frequency value
> wouldn't mean anything. Though they must have another property, which
> may be implementation defined, which uniquely identifies the OPP nodes.
>
> Make "opp-hz" optional for such devices.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> Resending to get Ack from Rob.
>
> Documentation/devicetree/bindings/opp/opp.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1523273291.git.viresh.kumar@linaro.org>
[not found] ` <5c4a3a3fb4bf7320e592aabf582bfb6bdec4ee69.1523273291.git.viresh.kumar@linaro.org>
2018-05-03 4:27 ` [PATCH V2 02/11] PM / OPP: dt-bindings: Make "opp-hz" optional for power domains Viresh Kumar
2018-05-08 3:34 ` [PATCH V2 resend] " Viresh Kumar
2018-05-08 15:42 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.