From: Arnd Bergmann <arnd@arndb.de>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
Michal Simek <michals@xilinx.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"yinghai@kernel.org" <yinghai@kernel.org>,
"wangyijing@huawei.com" <wangyijing@huawei.com>,
"robh@kernel.org" <robh@kernel.org>,
"russell.joyce@york.ac.uk" <russell.joyce@york.ac.uk>,
Soren Brinkmann <sorenb@xilinx.com>,
"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Ravikiran Gummaluri <rgummal@xilinx.com>
Subject: Re: [PATCH V2 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze
Date: Wed, 27 Jan 2016 16:14:32 +0100 [thread overview]
Message-ID: <5255218.OREPu5Af3W@wuerfel> (raw)
In-Reply-To: <8520D5D51A55D047800579B09414719825873DA8@XAP-PVEXMBX01.xlnx.xilinx.com>
On Wednesday 27 January 2016 14:33:45 Bharat Kumar Gogada wrote:
> > > @@ -705,7 +715,9 @@ static int xilinx_pcie_probe(struct
> > > platform_device *pdev) #endif
> > > pci_scan_child_bus(bus);
> > > pci_assign_unassigned_bus_resources(bus);
> > > +#ifdef CONFIG_ARM
> > > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> > > +#endif
> > > pci_bus_add_devices(bus);
> > > platform_set_drvdata(pdev, port);
> >
> > Here it looks like microblaze gets it right. I'm not sure why we still need the
> > pci_fixup_irqs() on ARM, but my feeling is that this should be fixed in
> > common code.
> In arm pci_fixup_irqs is called by pci_common_init_dev (arch/arm/kernel/bios32.c), since this API is removed now, I was calling it separately.
But who calls it in microblaze? If it works without the extra call there,
can we make it work the same way for ARM?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
Michal Simek <michals@xilinx.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"paul.burton@imgtec.com" <paul.burton@imgtec.com>,
"yinghai@kernel.org" <yinghai@kernel.org>,
"wangyijing@huawei.com" <wangyijing@huawei.com>,
"robh@kernel.org" <robh@kernel.org>,
"russell.joyce@york.ac.uk" <russell.joyce@york.ac.uk>,
Soren Brinkmann <sorenb@xilinx.com>,
"jiang.liu@linux.intel.com" <jiang.liu@linux.intel.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-p
Subject: Re: [PATCH V2 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze
Date: Wed, 27 Jan 2016 16:14:32 +0100 [thread overview]
Message-ID: <5255218.OREPu5Af3W@wuerfel> (raw)
In-Reply-To: <8520D5D51A55D047800579B09414719825873DA8@XAP-PVEXMBX01.xlnx.xilinx.com>
On Wednesday 27 January 2016 14:33:45 Bharat Kumar Gogada wrote:
> > > @@ -705,7 +715,9 @@ static int xilinx_pcie_probe(struct
> > > platform_device *pdev) #endif
> > > pci_scan_child_bus(bus);
> > > pci_assign_unassigned_bus_resources(bus);
> > > +#ifdef CONFIG_ARM
> > > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> > > +#endif
> > > pci_bus_add_devices(bus);
> > > platform_set_drvdata(pdev, port);
> >
> > Here it looks like microblaze gets it right. I'm not sure why we still need the
> > pci_fixup_irqs() on ARM, but my feeling is that this should be fixed in
> > common code.
> In arm pci_fixup_irqs is called by pci_common_init_dev (arch/arm/kernel/bios32.c), since this API is removed now, I was calling it separately.
But who calls it in microblaze? If it works without the extra call there,
can we make it work the same way for ARM?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze
Date: Wed, 27 Jan 2016 16:14:32 +0100 [thread overview]
Message-ID: <5255218.OREPu5Af3W@wuerfel> (raw)
In-Reply-To: <8520D5D51A55D047800579B09414719825873DA8@XAP-PVEXMBX01.xlnx.xilinx.com>
On Wednesday 27 January 2016 14:33:45 Bharat Kumar Gogada wrote:
> > > @@ -705,7 +715,9 @@ static int xilinx_pcie_probe(struct
> > > platform_device *pdev) #endif
> > > pci_scan_child_bus(bus);
> > > pci_assign_unassigned_bus_resources(bus);
> > > +#ifdef CONFIG_ARM
> > > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
> > > +#endif
> > > pci_bus_add_devices(bus);
> > > platform_set_drvdata(pdev, port);
> >
> > Here it looks like microblaze gets it right. I'm not sure why we still need the
> > pci_fixup_irqs() on ARM, but my feeling is that this should be fixed in
> > common code.
> In arm pci_fixup_irqs is called by pci_common_init_dev (arch/arm/kernel/bios32.c), since this API is removed now, I was calling it separately.
But who calls it in microblaze? If it works without the extra call there,
can we make it work the same way for ARM?
Arnd
next prev parent reply other threads:[~2016-01-27 15:17 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 17:36 [PATCH V2 0/5] PCIe Xilinx generic driver for Microblaze and Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` [PATCH V2 1/5] PCI: xilinx: Removing xilinx_pcie_parse_and_add_res function Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` [PATCH V2 2/5] PCI: xilinx: Removing struct hw_irq structure Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 22:23 ` Arnd Bergmann
2016-01-12 22:23 ` Arnd Bergmann
2016-01-27 14:27 ` Bharat Kumar Gogada
2016-01-27 14:27 ` Bharat Kumar Gogada
2016-01-27 14:27 ` Bharat Kumar Gogada
2016-01-27 14:27 ` Bharat Kumar Gogada
2016-01-12 17:36 ` [PATCH V2 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 22:27 ` Arnd Bergmann
2016-01-12 22:27 ` Arnd Bergmann
2016-01-26 9:59 ` Michal Simek
2016-01-26 9:59 ` Michal Simek
2016-01-26 9:59 ` Michal Simek
2016-01-26 12:11 ` Arnd Bergmann
2016-01-26 12:11 ` Arnd Bergmann
2016-01-26 12:11 ` Arnd Bergmann
2016-01-26 15:21 ` Michal Simek
2016-01-26 15:21 ` Michal Simek
2016-01-26 15:21 ` Michal Simek
2016-01-27 14:41 ` Bharat Kumar Gogada
2016-01-27 14:41 ` Bharat Kumar Gogada
2016-01-27 14:41 ` Bharat Kumar Gogada
2016-01-27 14:41 ` Bharat Kumar Gogada
2016-01-27 14:33 ` Bharat Kumar Gogada
2016-01-27 14:33 ` Bharat Kumar Gogada
2016-01-27 14:33 ` Bharat Kumar Gogada
2016-01-27 14:33 ` Bharat Kumar Gogada
2016-01-27 15:14 ` Arnd Bergmann [this message]
2016-01-27 15:14 ` Arnd Bergmann
2016-01-27 15:14 ` Arnd Bergmann
2016-01-27 15:14 ` Arnd Bergmann
2016-01-28 13:20 ` Bharat Kumar Gogada
2016-01-28 13:20 ` Bharat Kumar Gogada
2016-01-28 13:20 ` Bharat Kumar Gogada
2016-01-28 13:20 ` Bharat Kumar Gogada
2016-01-28 13:49 ` Arnd Bergmann
2016-01-28 13:49 ` Arnd Bergmann
2016-01-28 13:49 ` Arnd Bergmann
2016-01-28 13:49 ` Arnd Bergmann
2016-01-28 14:18 ` Bharat Kumar Gogada
2016-01-28 14:18 ` Bharat Kumar Gogada
2016-01-28 14:18 ` Bharat Kumar Gogada
2016-01-28 14:18 ` Bharat Kumar Gogada
2016-01-28 14:23 ` Arnd Bergmann
2016-01-28 14:23 ` Arnd Bergmann
2016-01-28 14:23 ` Arnd Bergmann
2016-01-28 14:23 ` Arnd Bergmann
2016-01-28 14:49 ` Lorenzo Pieralisi
2016-01-28 14:49 ` Lorenzo Pieralisi
2016-01-28 14:49 ` Lorenzo Pieralisi
2016-01-28 14:49 ` Lorenzo Pieralisi
2016-01-12 17:36 ` [PATCH V2 4/5] PCI: xilinx: Updating Zynq PCI binding documentation with Microblaze node Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-15 2:33 ` Rob Herring
2016-01-15 2:33 ` Rob Herring
2016-01-12 17:36 ` [PATCH V2 5/5] Microblaze: Modifying microblaze PCI subsytem to support generic Xilinx AXI PCIe Host Bridge IP driver Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-01-12 17:36 ` Bharat Kumar Gogada
2016-02-03 15:40 ` Bharat Kumar Gogada
2016-02-03 15:40 ` Bharat Kumar Gogada
2016-02-03 15:40 ` Bharat Kumar Gogada
2016-02-03 15:59 ` Bjorn Helgaas
2016-02-03 15:59 ` Bjorn Helgaas
2016-02-03 15:59 ` Bjorn Helgaas
2016-02-03 15:59 ` Bjorn Helgaas
2016-02-03 16:08 ` Bharat Kumar Gogada
2016-02-03 16:08 ` Bharat Kumar Gogada
2016-02-03 16:08 ` Bharat Kumar Gogada
2016-02-03 16:08 ` Bharat Kumar Gogada
2016-02-03 16:32 ` Bjorn Helgaas
2016-02-03 16:32 ` Bjorn Helgaas
2016-02-03 16:32 ` Bjorn Helgaas
2016-02-03 16:38 ` Bjorn Helgaas
2016-02-03 16:38 ` Bjorn Helgaas
2016-02-03 16:38 ` Bjorn Helgaas
2016-02-04 5:49 ` Bharat Kumar Gogada
2016-02-04 5:49 ` Bharat Kumar Gogada
2016-02-04 5:49 ` Bharat Kumar Gogada
2016-02-04 5:49 ` Bharat Kumar Gogada
2016-02-04 14:51 ` Bjorn Helgaas
2016-02-04 14:51 ` Bjorn Helgaas
2016-02-04 14:51 ` Bjorn Helgaas
2016-02-04 14:51 ` Bjorn Helgaas
2016-02-04 14:56 ` Bharat Kumar Gogada
2016-02-04 14:56 ` Bharat Kumar Gogada
2016-02-04 14:56 ` Bharat Kumar Gogada
2016-02-04 14:56 ` Bharat Kumar Gogada
2016-01-12 22:29 ` [PATCH V2 0/5] PCIe Xilinx generic driver for Microblaze and Arnd Bergmann
2016-01-12 22:29 ` Arnd Bergmann
2016-01-27 14:35 ` Bharat Kumar Gogada
2016-01-27 14:35 ` Bharat Kumar Gogada
2016-01-27 14:35 ` Bharat Kumar Gogada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5255218.OREPu5Af3W@wuerfel \
--to=arnd@arndb.de \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jiang.liu@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=michals@xilinx.com \
--cc=paul.burton@imgtec.com \
--cc=pawel.moll@arm.com \
--cc=rgummal@xilinx.com \
--cc=robh@kernel.org \
--cc=russell.joyce@york.ac.uk \
--cc=sorenb@xilinx.com \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.