From: Matt Porter <matt.porter@linaro.org> To: balbi@ti.com Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <rob.herring@calxeda.com>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Stephen Warren <swarren@nvidia.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Christian Daudt <bcm@fixthebug.org>, Paul Zimmerman <paulz@synopsys.com>, Linux USB List <linux-usb@vger.kernel.org>, Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Devicetree List <devicetree@vger.kernel.org>, Linaro Patches <patches@linaro.org> Subject: Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width Date: Thu, 10 Oct 2013 12:54:40 -0400 [thread overview] Message-ID: <5256DBD0.8030008@linaro.org> (raw) In-Reply-To: <20131010152922.GF28375@radagast> On 10/10/2013 11:29 AM, Felipe Balbi wrote: > On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: >> Extend dwc2 binding with an optional utmi phy width property. >> Enable the s3c-hsotg.c driver to use standard dwc2 binding >> and enable configuration of the UTMI phy width based on the >> property. >> >> Signed-off-by: Matt Porter <matt.porter@linaro.org> >> Reviewed-by: Markus Mayer <markus.mayer@linaro.org> >> Reviewed-by: Tim Kryger <tim.kryger@linaro.org> >> --- >> Documentation/devicetree/bindings/staging/dwc2.txt | 4 ++++ >> drivers/usb/gadget/s3c-hsotg.c | 18 +++++++++++++++++- >> drivers/usb/gadget/s3c-hsotg.h | 1 + >> 3 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt >> index 1a1b7cf..fb6b8ee 100644 >> --- a/Documentation/devicetree/bindings/staging/dwc2.txt >> +++ b/Documentation/devicetree/bindings/staging/dwc2.txt >> @@ -6,10 +6,14 @@ Required properties: >> - reg : Should contain 1 register range (address and length) >> - interrupts : Should contain 1 interrupt >> >> +Optional properties: >> +- snps,phy-utmi-width: Must contain the UTMI data width (either 8 or 16) > > isn't this available in any of the configuration registers ? Yes and no. HWCFG4 has a UTMI data width field. However, it has 3 valid states, "8", "16", or "8 or 16". The BCM281xx implementation is set to the latter and the attached phy is 8-bit. Looking at dwc2 prior to Matthijs Kooijman's patch [1] which starts validating the value of phy_utmi_width in that driver, the pci.c dwc2_module_params .phy_utmi_width field there even had the comment, "/* 16 bits - NOT DETECTABLE */". The autodetect code in dwc2_set_param_phy_utmi_width() will fail if HWCFG4 has the "8 or 16" option as it just decides to default to a phy width of 16 if nothing is configured by the platform glue. This property would also allow this issue to be addressed in that driver. >> Example: >> >> usb@101c0000 { >> compatible = "ralink,rt3050-usb, snps,dwc2"; >> reg = <0x101c0000 40000>; >> interrupts = <18>; >> + snps,phy-utmi-width = <8>; > > indentation. will fix. -Matt [1] de4a193 staging: dwc2: validate the value for phy_utmi_width
WARNING: multiple messages have this Message-ID (diff)
From: matt.porter@linaro.org (Matt Porter) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width Date: Thu, 10 Oct 2013 12:54:40 -0400 [thread overview] Message-ID: <5256DBD0.8030008@linaro.org> (raw) In-Reply-To: <20131010152922.GF28375@radagast> On 10/10/2013 11:29 AM, Felipe Balbi wrote: > On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: >> Extend dwc2 binding with an optional utmi phy width property. >> Enable the s3c-hsotg.c driver to use standard dwc2 binding >> and enable configuration of the UTMI phy width based on the >> property. >> >> Signed-off-by: Matt Porter <matt.porter@linaro.org> >> Reviewed-by: Markus Mayer <markus.mayer@linaro.org> >> Reviewed-by: Tim Kryger <tim.kryger@linaro.org> >> --- >> Documentation/devicetree/bindings/staging/dwc2.txt | 4 ++++ >> drivers/usb/gadget/s3c-hsotg.c | 18 +++++++++++++++++- >> drivers/usb/gadget/s3c-hsotg.h | 1 + >> 3 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt b/Documentation/devicetree/bindings/staging/dwc2.txt >> index 1a1b7cf..fb6b8ee 100644 >> --- a/Documentation/devicetree/bindings/staging/dwc2.txt >> +++ b/Documentation/devicetree/bindings/staging/dwc2.txt >> @@ -6,10 +6,14 @@ Required properties: >> - reg : Should contain 1 register range (address and length) >> - interrupts : Should contain 1 interrupt >> >> +Optional properties: >> +- snps,phy-utmi-width: Must contain the UTMI data width (either 8 or 16) > > isn't this available in any of the configuration registers ? Yes and no. HWCFG4 has a UTMI data width field. However, it has 3 valid states, "8", "16", or "8 or 16". The BCM281xx implementation is set to the latter and the attached phy is 8-bit. Looking at dwc2 prior to Matthijs Kooijman's patch [1] which starts validating the value of phy_utmi_width in that driver, the pci.c dwc2_module_params .phy_utmi_width field there even had the comment, "/* 16 bits - NOT DETECTABLE */". The autodetect code in dwc2_set_param_phy_utmi_width() will fail if HWCFG4 has the "8 or 16" option as it just decides to default to a phy width of 16 if nothing is configured by the platform glue. This property would also allow this issue to be addressed in that driver. >> Example: >> >> usb at 101c0000 { >> compatible = "ralink,rt3050-usb, snps,dwc2"; >> reg = <0x101c0000 40000>; >> interrupts = <18>; >> + snps,phy-utmi-width = <8>; > > indentation. will fix. -Matt [1] de4a193 staging: dwc2: validate the value for phy_utmi_width
next prev parent reply other threads:[~2013-10-10 16:54 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-07 10:12 [PATCH 0/5] USB Device Controller support for BCM281xx Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-07 10:12 ` [PATCH 1/5] usb: gadget: s3c-hsotg: enable build for other platforms Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-07 10:12 ` [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-10 15:29 ` Felipe Balbi 2013-10-10 15:29 ` Felipe Balbi 2013-10-10 15:29 ` Felipe Balbi 2013-10-10 16:54 ` Matt Porter [this message] 2013-10-10 16:54 ` Matt Porter 2013-10-10 17:46 ` Felipe Balbi 2013-10-10 17:46 ` Felipe Balbi 2013-10-10 17:46 ` Felipe Balbi 2013-10-10 17:57 ` Paul Zimmerman 2013-10-10 17:57 ` Paul Zimmerman 2013-10-10 17:57 ` Paul Zimmerman 2013-10-10 18:07 ` Felipe Balbi 2013-10-10 18:07 ` Felipe Balbi 2013-10-10 18:07 ` Felipe Balbi 2013-10-10 18:14 ` Paul Zimmerman 2013-10-10 18:14 ` Paul Zimmerman 2013-10-10 18:57 ` Felipe Balbi 2013-10-10 18:57 ` Felipe Balbi 2013-10-10 18:57 ` Felipe Balbi 2013-10-10 19:07 ` Matt Porter 2013-10-10 19:07 ` Matt Porter 2013-10-11 3:21 ` Matt Porter 2013-10-11 3:21 ` Matt Porter 2013-10-11 3:21 ` Matt Porter 2013-10-11 13:37 ` Felipe Balbi 2013-10-11 13:37 ` Felipe Balbi 2013-10-11 13:37 ` Felipe Balbi 2013-10-17 12:40 ` Matt Porter 2013-10-17 12:40 ` Matt Porter 2013-10-17 12:40 ` Matt Porter 2013-10-07 10:12 ` [PATCH 3/5] usb: phy: add Broadcom Kona USB control driver Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-10 15:31 ` Felipe Balbi 2013-10-10 15:31 ` Felipe Balbi 2013-10-10 15:31 ` Felipe Balbi 2013-10-11 13:47 ` Matt Porter 2013-10-11 13:47 ` Matt Porter 2013-10-07 10:12 ` [PATCH 4/5] usb: phy: add Broadcom Kona USB PHY driver Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-07 10:12 ` [PATCH 5/5] ARM: dts: add usb udc support to bcm281xx Matt Porter 2013-10-07 10:12 ` Matt Porter 2013-10-07 10:12 ` Matt Porter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5256DBD0.8030008@linaro.org \ --to=matt.porter@linaro.org \ --cc=balbi@ti.com \ --cc=bcm@fixthebug.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=patches@linaro.org \ --cc=paulz@synopsys.com \ --cc=pawel.moll@arm.com \ --cc=rob.herring@calxeda.com \ --cc=swarren@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.