[RESEND PATCH V2 0/2] ARM: AM33xx: Add RNG Moudle data

[RESEND PATCH V2 0/2] ARM: AM33xx: Add RNG Moudle data

[Lokesh Vutla]

This Patch series adds HWMOD data and DT data for RNG module.

Reposting these patches as suggested by Paul Walmsley.
http://www.spinics.net/lists/arm-kernel/msg270678.html
Both these patches should go together because after adding 
Patch 1/2, hwmod wouldn't find the register iospace and crash,
and thats added only in dt.

Lokesh Vutla (2):
  ARM: dts: AM33xx: Add RNG node
  ARM: AM33xx: hwmod: Add RNG module data

 .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++
 arch/arm/boot/dts/am33xx.dtsi                      |    7 ++++
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |   36 ++++++++++++++++++++
 3 files changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

-- 
1.7.9.5

[RESEND PATCH V2 0/2] ARM: AM33xx: Add RNG Moudle data

[Lokesh Vutla]

This Patch series adds HWMOD data and DT data for RNG module.

Reposting these patches as suggested by Paul Walmsley.
http://www.spinics.net/lists/arm-kernel/msg270678.html
Both these patches should go together because after adding 
Patch 1/2, hwmod wouldn't find the register iospace and crash,
and thats added only in dt.

Lokesh Vutla (2):
  ARM: dts: AM33xx: Add RNG node
  ARM: AM33xx: hwmod: Add RNG module data

 .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++
 arch/arm/boot/dts/am33xx.dtsi                      |    7 ++++
 arch/arm/mach-omap2/omap_hwmod_33xx_data.c         |   36 ++++++++++++++++++++
 3 files changed, 65 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

-- 
1.7.9.5

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Add the AM33xx RNG module's device tree data.
Also add Documentation file describing the data
for the RNG module.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Changes since V1:
- Drop "status=disabled" entry in dt node, Since
  RNG is present on all AM33xx platforms.

 .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
 arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
 2 files changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
new file mode 100644
index 0000000..6a62acd
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
@@ -0,0 +1,22 @@
+OMAP SoC HWRNG Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  RNG versions:
+  - "ti,omap2-rng" for OMAP2.
+  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the RNG module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt number for the RNG module.
+		Only used for "ti,omap4-rng".
+
+Example:
+/* AM335x */
+rng: rng@48310000 {
+	compatible = "ti,omap4-rng";
+	ti,hwmods = "rng";
+	reg = <0x48310000 0x2000>;
+	interrupts = <111>;
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..26ebe30 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -530,5 +530,12 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		rng: rng@48310000 {
+			compatible = "ti,omap4-rng";
+			ti,hwmods = "rng";
+			reg = <0x48310000 0x2000>;
+			interrupts = <111>;
+		};
 	};
 };
-- 
1.7.9.5

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Add the AM33xx RNG module's device tree data.
Also add Documentation file describing the data
for the RNG module.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Changes since V1:
- Drop "status=disabled" entry in dt node, Since
  RNG is present on all AM33xx platforms.

 .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
 arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
 2 files changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
new file mode 100644
index 0000000..6a62acd
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
@@ -0,0 +1,22 @@
+OMAP SoC HWRNG Module
+
+Required properties:
+
+- compatible : Should contain entries for this and backward compatible
+  RNG versions:
+  - "ti,omap2-rng" for OMAP2.
+  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
+  Note that these two versions are incompatible.
+- ti,hwmods: Name of the hwmod associated with the RNG module
+- reg : Offset and length of the register set for the module
+- interrupts : the interrupt number for the RNG module.
+		Only used for "ti,omap4-rng".
+
+Example:
+/* AM335x */
+rng: rng at 48310000 {
+	compatible = "ti,omap4-rng";
+	ti,hwmods = "rng";
+	reg = <0x48310000 0x2000>;
+	interrupts = <111>;
+};
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..26ebe30 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -530,5 +530,12 @@
 			#size-cells = <1>;
 			status = "disabled";
 		};
+
+		rng: rng at 48310000 {
+			compatible = "ti,omap4-rng";
+			ti,hwmods = "rng";
+			reg = <0x48310000 0x2000>;
+			interrupts = <111>;
+		};
 	};
 };
-- 
1.7.9.5

[RESEND PATCH V2 2/2] ARM: AM33xx: hwmod: Add RNG module data

[Lokesh Vutla]

Add RNG hwmod data for AM33xx SoC.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
* Made am33xx_l4_per__rng structure as static to fix sparse warning

 arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   36 ++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index 215894f..3e32f45 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -2480,6 +2480,41 @@ static struct omap_hwmod_ocp_if am33xx_l3_main__aes0 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
+/* rng */
+static struct omap_hwmod_class_sysconfig am33xx_rng_sysc = {
+	.rev_offs	= 0x1fe0,
+	.sysc_offs	= 0x1fe4,
+	.sysc_flags	= SYSC_HAS_AUTOIDLE | SYSC_HAS_SIDLEMODE,
+	.idlemodes	= SIDLE_FORCE | SIDLE_NO,
+	.sysc_fields	= &omap_hwmod_sysc_type1,
+};
+
+static struct omap_hwmod_class am33xx_rng_hwmod_class = {
+	.name		= "rng",
+	.sysc		= &am33xx_rng_sysc,
+};
+
+static struct omap_hwmod am33xx_rng_hwmod = {
+	.name		= "rng",
+	.class		= &am33xx_rng_hwmod_class,
+	.clkdm_name	= "l4ls_clkdm",
+	.flags		= HWMOD_SWSUP_SIDLE,
+	.main_clk	= "rng_fck",
+	.prcm		= {
+		.omap4	= {
+			.clkctrl_offs	= AM33XX_CM_PER_RNG_CLKCTRL_OFFSET,
+			.modulemode	= MODULEMODE_SWCTRL,
+		},
+	},
+};
+
+static struct omap_hwmod_ocp_if am33xx_l4_per__rng = {
+	.master		= &am33xx_l4_ls_hwmod,
+	.slave		= &am33xx_rng_hwmod,
+	.clk		= "rng_fck",
+	.user		= OCP_USER_MPU,
+};
+
 static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__emif,
 	&am33xx_mpu__l3_main,
@@ -2559,6 +2594,7 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_cpgmac0__mdio,
 	&am33xx_l3_main__sha0,
 	&am33xx_l3_main__aes0,
+	&am33xx_l4_per__rng,
 	NULL,
 };
 
-- 
1.7.9.5

[RESEND PATCH V2 2/2] ARM: AM33xx: hwmod: Add RNG module data

[Lokesh Vutla]

Add RNG hwmod data for AM33xx SoC.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
* Made am33xx_l4_per__rng structure as static to fix sparse warning

 arch/arm/mach-omap2/omap_hwmod_33xx_data.c |   36 ++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
index 215894f..3e32f45 100644
--- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c
@@ -2480,6 +2480,41 @@ static struct omap_hwmod_ocp_if am33xx_l3_main__aes0 = {
 	.user		= OCP_USER_MPU | OCP_USER_SDMA,
 };
 
+/* rng */
+static struct omap_hwmod_class_sysconfig am33xx_rng_sysc = {
+	.rev_offs	= 0x1fe0,
+	.sysc_offs	= 0x1fe4,
+	.sysc_flags	= SYSC_HAS_AUTOIDLE | SYSC_HAS_SIDLEMODE,
+	.idlemodes	= SIDLE_FORCE | SIDLE_NO,
+	.sysc_fields	= &omap_hwmod_sysc_type1,
+};
+
+static struct omap_hwmod_class am33xx_rng_hwmod_class = {
+	.name		= "rng",
+	.sysc		= &am33xx_rng_sysc,
+};
+
+static struct omap_hwmod am33xx_rng_hwmod = {
+	.name		= "rng",
+	.class		= &am33xx_rng_hwmod_class,
+	.clkdm_name	= "l4ls_clkdm",
+	.flags		= HWMOD_SWSUP_SIDLE,
+	.main_clk	= "rng_fck",
+	.prcm		= {
+		.omap4	= {
+			.clkctrl_offs	= AM33XX_CM_PER_RNG_CLKCTRL_OFFSET,
+			.modulemode	= MODULEMODE_SWCTRL,
+		},
+	},
+};
+
+static struct omap_hwmod_ocp_if am33xx_l4_per__rng = {
+	.master		= &am33xx_l4_ls_hwmod,
+	.slave		= &am33xx_rng_hwmod,
+	.clk		= "rng_fck",
+	.user		= OCP_USER_MPU,
+};
+
 static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_l3_main__emif,
 	&am33xx_mpu__l3_main,
@@ -2559,6 +2594,7 @@ static struct omap_hwmod_ocp_if *am33xx_hwmod_ocp_ifs[] __initdata = {
 	&am33xx_cpgmac0__mdio,
 	&am33xx_l3_main__sha0,
 	&am33xx_l3_main__aes0,
+	&am33xx_l4_per__rng,
 	NULL,
 };
 
-- 
1.7.9.5

Re: [RESEND PATCH V2 2/2] ARM: AM33xx: hwmod: Add RNG module data

[Paul Walmsley]

On Thu, 29 Aug 2013, Lokesh Vutla wrote:

> Add RNG hwmod data for AM33xx SoC.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks, queued.

- Paul

[RESEND PATCH V2 2/2] ARM: AM33xx: hwmod: Add RNG module data

[Paul Walmsley]

On Thu, 29 Aug 2013, Lokesh Vutla wrote:

> Add RNG hwmod data for AM33xx SoC.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks, queued.

- Paul

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Hi Benoit,
On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
> Add the AM33xx RNG module's device tree data.
> Also add Documentation file describing the data
> for the RNG module.
Seems you missed this patch. Please consider this for this merge window.
Patch 2/2 is already taken by Paul.
Without this patch AM335x boot will crash as I mentioned in my cover letter.

Thanks and regards,
Lokesh
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> Changes since V1:
> - Drop "status=disabled" entry in dt node, Since
>   RNG is present on all AM33xx platforms.
> 
>  .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>  arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> new file mode 100644
> index 0000000..6a62acd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> @@ -0,0 +1,22 @@
> +OMAP SoC HWRNG Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  RNG versions:
> +  - "ti,omap2-rng" for OMAP2.
> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the RNG module
> +- reg : Offset and length of the register set for the module
> +- interrupts : the interrupt number for the RNG module.
> +		Only used for "ti,omap4-rng".
> +
> +Example:
> +/* AM335x */
> +rng: rng@48310000 {
> +	compatible = "ti,omap4-rng";
> +	ti,hwmods = "rng";
> +	reg = <0x48310000 0x2000>;
> +	interrupts = <111>;
> +};
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..26ebe30 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -530,5 +530,12 @@
>  			#size-cells = <1>;
>  			status = "disabled";
>  		};
> +
> +		rng: rng@48310000 {
> +			compatible = "ti,omap4-rng";
> +			ti,hwmods = "rng";
> +			reg = <0x48310000 0x2000>;
> +			interrupts = <111>;
> +		};
>  	};
>  };
> 

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Hi Benoit,
On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
> Add the AM33xx RNG module's device tree data.
> Also add Documentation file describing the data
> for the RNG module.
Seems you missed this patch. Please consider this for this merge window.
Patch 2/2 is already taken by Paul.
Without this patch AM335x boot will crash as I mentioned in my cover letter.

Thanks and regards,
Lokesh
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> Changes since V1:
> - Drop "status=disabled" entry in dt node, Since
>   RNG is present on all AM33xx platforms.
> 
>  .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>  arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>  2 files changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> new file mode 100644
> index 0000000..6a62acd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> @@ -0,0 +1,22 @@
> +OMAP SoC HWRNG Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  RNG versions:
> +  - "ti,omap2-rng" for OMAP2.
> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the RNG module
> +- reg : Offset and length of the register set for the module
> +- interrupts : the interrupt number for the RNG module.
> +		Only used for "ti,omap4-rng".
> +
> +Example:
> +/* AM335x */
> +rng: rng at 48310000 {
> +	compatible = "ti,omap4-rng";
> +	ti,hwmods = "rng";
> +	reg = <0x48310000 0x2000>;
> +	interrupts = <111>;
> +};
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..26ebe30 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -530,5 +530,12 @@
>  			#size-cells = <1>;
>  			status = "disabled";
>  		};
> +
> +		rng: rng at 48310000 {
> +			compatible = "ti,omap4-rng";
> +			ti,hwmods = "rng";
> +			reg = <0x48310000 0x2000>;
> +			interrupts = <111>;
> +		};
>  	};
>  };
> 

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Paul Walmsley]

On Sat, 12 Oct 2013, Lokesh Vutla wrote:

> Seems you missed this patch. Please consider this for this merge window.
> Patch 2/2 is already taken by Paul.
> Without this patch AM335x boot will crash as I mentioned in my cover letter.

That won't happen since this patch from Suman got merged:

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg96447.html


- Paul

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Paul Walmsley]

On Sat, 12 Oct 2013, Lokesh Vutla wrote:

> Seems you missed this patch. Please consider this for this merge window.
> Patch 2/2 is already taken by Paul.
> Without this patch AM335x boot will crash as I mentioned in my cover letter.

That won't happen since this patch from Suman got merged:

http://www.mail-archive.com/linux-omap at vger.kernel.org/msg96447.html


- Paul

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Benoit Cousson]

Hi Lokesh,

On 12/10/2013 15:26, Lokesh Vutla wrote:
> Hi Benoit,
> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>> Add the AM33xx RNG module's device tree data.
>> Also add Documentation file describing the data
>> for the RNG module.
> Seems you missed this patch. Please consider this for this merge window.

Indeed I missed it. Sorry :-(

> Patch 2/2 is already taken by Paul.
> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>
> Thanks and regards,
> Lokesh
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> ---
>> Changes since V1:
>> - Drop "status=disabled" entry in dt node, Since
>>    RNG is present on all AM33xx platforms.
>>
>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>   2 files changed, 29 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

I do not see the acked-by for the binding part. You do need that for any 
new bindings nowadays.

>>
>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>> new file mode 100644
>> index 0000000..6a62acd
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>> @@ -0,0 +1,22 @@
>> +OMAP SoC HWRNG Module
>> +
>> +Required properties:
>> +
>> +- compatible : Should contain entries for this and backward compatible
>> +  RNG versions:
>> +  - "ti,omap2-rng" for OMAP2.
>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>> +  Note that these two versions are incompatible.
>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>> +- reg : Offset and length of the register set for the module
>> +- interrupts : the interrupt number for the RNG module.
>> +		Only used for "ti,omap4-rng".
>> +
>> +Example:
>> +/* AM335x */
>> +rng: rng@48310000 {
>> +	compatible = "ti,omap4-rng";
>> +	ti,hwmods = "rng";
>> +	reg = <0x48310000 0x2000>;
>> +	interrupts = <111>;
>> +};
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 38b446b..26ebe30 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -530,5 +530,12 @@
>>   			#size-cells = <1>;
>>   			status = "disabled";
>>   		};
>> +
>> +		rng: rng@48310000 {
>> +			compatible = "ti,omap4-rng";
>> +			ti,hwmods = "rng";
>> +			reg = <0x48310000 0x2000>;
>> +			interrupts = <111>;
>> +		};
>>   	};
>>   };
>>
>

It looks good to me, but it does not apply on my branch.
Please rebase it and repost with the proper acked-by.

Thanks,
Benoit


-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Benoit Cousson]

Hi Lokesh,

On 12/10/2013 15:26, Lokesh Vutla wrote:
> Hi Benoit,
> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>> Add the AM33xx RNG module's device tree data.
>> Also add Documentation file describing the data
>> for the RNG module.
> Seems you missed this patch. Please consider this for this merge window.

Indeed I missed it. Sorry :-(

> Patch 2/2 is already taken by Paul.
> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>
> Thanks and regards,
> Lokesh
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> ---
>> Changes since V1:
>> - Drop "status=disabled" entry in dt node, Since
>>    RNG is present on all AM33xx platforms.
>>
>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>   2 files changed, 29 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt

I do not see the acked-by for the binding part. You do need that for any 
new bindings nowadays.

>>
>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>> new file mode 100644
>> index 0000000..6a62acd
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>> @@ -0,0 +1,22 @@
>> +OMAP SoC HWRNG Module
>> +
>> +Required properties:
>> +
>> +- compatible : Should contain entries for this and backward compatible
>> +  RNG versions:
>> +  - "ti,omap2-rng" for OMAP2.
>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>> +  Note that these two versions are incompatible.
>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>> +- reg : Offset and length of the register set for the module
>> +- interrupts : the interrupt number for the RNG module.
>> +		Only used for "ti,omap4-rng".
>> +
>> +Example:
>> +/* AM335x */
>> +rng: rng at 48310000 {
>> +	compatible = "ti,omap4-rng";
>> +	ti,hwmods = "rng";
>> +	reg = <0x48310000 0x2000>;
>> +	interrupts = <111>;
>> +};
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 38b446b..26ebe30 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -530,5 +530,12 @@
>>   			#size-cells = <1>;
>>   			status = "disabled";
>>   		};
>> +
>> +		rng: rng at 48310000 {
>> +			compatible = "ti,omap4-rng";
>> +			ti,hwmods = "rng";
>> +			reg = <0x48310000 0x2000>;
>> +			interrupts = <111>;
>> +		};
>>   	};
>>   };
>>
>

It looks good to me, but it does not apply on my branch.
Please rebase it and repost with the proper acked-by.

Thanks,
Benoit


-- 
Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Hi Benoit,
On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 12/10/2013 15:26, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>>> Add the AM33xx RNG module's device tree data.
>>> Also add Documentation file describing the data
>>> for the RNG module.
>> Seems you missed this patch. Please consider this for this merge window.
> 
> Indeed I missed it. Sorry :-(
> 
>> Patch 2/2 is already taken by Paul.
>> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>>
>> Thanks and regards,
>> Lokesh
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>> Changes since V1:
>>> - Drop "status=disabled" entry in dt node, Since
>>>    RNG is present on all AM33xx platforms.
>>>
>>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>>   2 files changed, 29 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> 
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> new file mode 100644
>>> index 0000000..6a62acd
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> @@ -0,0 +1,22 @@
>>> +OMAP SoC HWRNG Module
>>> +
>>> +Required properties:
>>> +
>>> +- compatible : Should contain entries for this and backward compatible
>>> +  RNG versions:
>>> +  - "ti,omap2-rng" for OMAP2.
>>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>>> +  Note that these two versions are incompatible.
>>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>>> +- reg : Offset and length of the register set for the module
>>> +- interrupts : the interrupt number for the RNG module.
>>> +        Only used for "ti,omap4-rng".
>>> +
>>> +Example:
>>> +/* AM335x */
>>> +rng: rng@48310000 {
>>> +    compatible = "ti,omap4-rng";
>>> +    ti,hwmods = "rng";
>>> +    reg = <0x48310000 0x2000>;
>>> +    interrupts = <111>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 38b446b..26ebe30 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -530,5 +530,12 @@
>>>               #size-cells = <1>;
>>>               status = "disabled";
>>>           };
>>> +
>>> +        rng: rng@48310000 {
>>> +            compatible = "ti,omap4-rng";
>>> +            ti,hwmods = "rng";
>>> +            reg = <0x48310000 0x2000>;
>>> +            interrupts = <111>;
>>> +        };
>>>       };
>>>   };
>>>
>>
> 
> It looks good to me, but it does not apply on my branch.
Can I take this as your Acked-by: ?
Ok, Ill rebase on top of your tree and post it.

Thanks and Regards,
Lokesh
> Please rebase it and repost with the proper acked-by.
> 
> Thanks,
> Benoit
> 
> 

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

Hi Benoit,
On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 12/10/2013 15:26, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>>> Add the AM33xx RNG module's device tree data.
>>> Also add Documentation file describing the data
>>> for the RNG module.
>> Seems you missed this patch. Please consider this for this merge window.
> 
> Indeed I missed it. Sorry :-(
> 
>> Patch 2/2 is already taken by Paul.
>> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>>
>> Thanks and regards,
>> Lokesh
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>> Changes since V1:
>>> - Drop "status=disabled" entry in dt node, Since
>>>    RNG is present on all AM33xx platforms.
>>>
>>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>>   2 files changed, 29 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> 
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> new file mode 100644
>>> index 0000000..6a62acd
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> @@ -0,0 +1,22 @@
>>> +OMAP SoC HWRNG Module
>>> +
>>> +Required properties:
>>> +
>>> +- compatible : Should contain entries for this and backward compatible
>>> +  RNG versions:
>>> +  - "ti,omap2-rng" for OMAP2.
>>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>>> +  Note that these two versions are incompatible.
>>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>>> +- reg : Offset and length of the register set for the module
>>> +- interrupts : the interrupt number for the RNG module.
>>> +        Only used for "ti,omap4-rng".
>>> +
>>> +Example:
>>> +/* AM335x */
>>> +rng: rng at 48310000 {
>>> +    compatible = "ti,omap4-rng";
>>> +    ti,hwmods = "rng";
>>> +    reg = <0x48310000 0x2000>;
>>> +    interrupts = <111>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 38b446b..26ebe30 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -530,5 +530,12 @@
>>>               #size-cells = <1>;
>>>               status = "disabled";
>>>           };
>>> +
>>> +        rng: rng at 48310000 {
>>> +            compatible = "ti,omap4-rng";
>>> +            ti,hwmods = "rng";
>>> +            reg = <0x48310000 0x2000>;
>>> +            interrupts = <111>;
>>> +        };
>>>       };
>>>   };
>>>
>>
> 
> It looks good to me, but it does not apply on my branch.
Can I take this as your Acked-by: ?
Ok, Ill rebase on top of your tree and post it.

Thanks and Regards,
Lokesh
> Please rebase it and repost with the proper acked-by.
> 
> Thanks,
> Benoit
> 
> 

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

+ Rob and Mark
On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 12/10/2013 15:26, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>>> Add the AM33xx RNG module's device tree data.
>>> Also add Documentation file describing the data
>>> for the RNG module.
Can you please review this patch..

Thanks and regards,
Lokesh
>> Seems you missed this patch. Please consider this for this merge window.
> 
> Indeed I missed it. Sorry :-(
> 
>> Patch 2/2 is already taken by Paul.
>> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>>
>> Thanks and regards,
>> Lokesh
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>> Changes since V1:
>>> - Drop "status=disabled" entry in dt node, Since
>>>    RNG is present on all AM33xx platforms.
>>>
>>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>>   2 files changed, 29 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> 
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> new file mode 100644
>>> index 0000000..6a62acd
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> @@ -0,0 +1,22 @@
>>> +OMAP SoC HWRNG Module
>>> +
>>> +Required properties:
>>> +
>>> +- compatible : Should contain entries for this and backward compatible
>>> +  RNG versions:
>>> +  - "ti,omap2-rng" for OMAP2.
>>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>>> +  Note that these two versions are incompatible.
>>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>>> +- reg : Offset and length of the register set for the module
>>> +- interrupts : the interrupt number for the RNG module.
>>> +        Only used for "ti,omap4-rng".
>>> +
>>> +Example:
>>> +/* AM335x */
>>> +rng: rng@48310000 {
>>> +    compatible = "ti,omap4-rng";
>>> +    ti,hwmods = "rng";
>>> +    reg = <0x48310000 0x2000>;
>>> +    interrupts = <111>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 38b446b..26ebe30 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -530,5 +530,12 @@
>>>               #size-cells = <1>;
>>>               status = "disabled";
>>>           };
>>> +
>>> +        rng: rng@48310000 {
>>> +            compatible = "ti,omap4-rng";
>>> +            ti,hwmods = "rng";
>>> +            reg = <0x48310000 0x2000>;
>>> +            interrupts = <111>;
>>> +        };
>>>       };
>>>   };
>>>
>>
> 
> It looks good to me, but it does not apply on my branch.
> Please rebase it and repost with the proper acked-by.
> 
> Thanks,
> Benoit
> 
> 

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Lokesh Vutla]

+ Rob and Mark
On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> Hi Lokesh,
> 
> On 12/10/2013 15:26, Lokesh Vutla wrote:
>> Hi Benoit,
>> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
>>> Add the AM33xx RNG module's device tree data.
>>> Also add Documentation file describing the data
>>> for the RNG module.
Can you please review this patch..

Thanks and regards,
Lokesh
>> Seems you missed this patch. Please consider this for this merge window.
> 
> Indeed I missed it. Sorry :-(
> 
>> Patch 2/2 is already taken by Paul.
>> Without this patch AM335x boot will crash as I mentioned in my cover letter.
>>
>> Thanks and regards,
>> Lokesh
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>> Changes since V1:
>>> - Drop "status=disabled" entry in dt node, Since
>>>    RNG is present on all AM33xx platforms.
>>>
>>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
>>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
>>>   2 files changed, 29 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> 
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> new file mode 100644
>>> index 0000000..6a62acd
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
>>> @@ -0,0 +1,22 @@
>>> +OMAP SoC HWRNG Module
>>> +
>>> +Required properties:
>>> +
>>> +- compatible : Should contain entries for this and backward compatible
>>> +  RNG versions:
>>> +  - "ti,omap2-rng" for OMAP2.
>>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
>>> +  Note that these two versions are incompatible.
>>> +- ti,hwmods: Name of the hwmod associated with the RNG module
>>> +- reg : Offset and length of the register set for the module
>>> +- interrupts : the interrupt number for the RNG module.
>>> +        Only used for "ti,omap4-rng".
>>> +
>>> +Example:
>>> +/* AM335x */
>>> +rng: rng at 48310000 {
>>> +    compatible = "ti,omap4-rng";
>>> +    ti,hwmods = "rng";
>>> +    reg = <0x48310000 0x2000>;
>>> +    interrupts = <111>;
>>> +};
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index 38b446b..26ebe30 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -530,5 +530,12 @@
>>>               #size-cells = <1>;
>>>               status = "disabled";
>>>           };
>>> +
>>> +        rng: rng at 48310000 {
>>> +            compatible = "ti,omap4-rng";
>>> +            ti,hwmods = "rng";
>>> +            reg = <0x48310000 0x2000>;
>>> +            interrupts = <111>;
>>> +        };
>>>       };
>>>   };
>>>
>>
> 
> It looks good to me, but it does not apply on my branch.
> Please rebase it and repost with the proper acked-by.
> 
> Thanks,
> Benoit
> 
> 

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Tony Lindgren]

* Lokesh Vutla <lokeshvutla@ti.com> [131016 04:16]:
> + Rob and Mark
> On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> > Hi Lokesh,
> > 
> > On 12/10/2013 15:26, Lokesh Vutla wrote:
> >> Hi Benoit,
> >> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
> >>> Add the AM33xx RNG module's device tree data.
> >>> Also add Documentation file describing the data
> >>> for the RNG module.
> Can you please review this patch..

OK enough of waiting here, I'm picking this patch into
omap-for-v3.13/dt branch as it removes some boot time warnings
we're seeing.

Regards,

Tony
 
> Thanks and regards,
> Lokesh
> >> Seems you missed this patch. Please consider this for this merge window.
> > 
> > Indeed I missed it. Sorry :-(
> > 
> >> Patch 2/2 is already taken by Paul.
> >> Without this patch AM335x boot will crash as I mentioned in my cover letter.
> >>
> >> Thanks and regards,
> >> Lokesh
> >>>
> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >>> ---
> >>> Changes since V1:
> >>> - Drop "status=disabled" entry in dt node, Since
> >>>    RNG is present on all AM33xx platforms.
> >>>
> >>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
> >>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
> >>>   2 files changed, 29 insertions(+)
> >>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> > 
> > I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> > 
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> >>> new file mode 100644
> >>> index 0000000..6a62acd
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> >>> @@ -0,0 +1,22 @@
> >>> +OMAP SoC HWRNG Module
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible : Should contain entries for this and backward compatible
> >>> +  RNG versions:
> >>> +  - "ti,omap2-rng" for OMAP2.
> >>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> >>> +  Note that these two versions are incompatible.
> >>> +- ti,hwmods: Name of the hwmod associated with the RNG module
> >>> +- reg : Offset and length of the register set for the module
> >>> +- interrupts : the interrupt number for the RNG module.
> >>> +        Only used for "ti,omap4-rng".
> >>> +
> >>> +Example:
> >>> +/* AM335x */
> >>> +rng: rng@48310000 {
> >>> +    compatible = "ti,omap4-rng";
> >>> +    ti,hwmods = "rng";
> >>> +    reg = <0x48310000 0x2000>;
> >>> +    interrupts = <111>;
> >>> +};
> >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> >>> index 38b446b..26ebe30 100644
> >>> --- a/arch/arm/boot/dts/am33xx.dtsi
> >>> +++ b/arch/arm/boot/dts/am33xx.dtsi
> >>> @@ -530,5 +530,12 @@
> >>>               #size-cells = <1>;
> >>>               status = "disabled";
> >>>           };
> >>> +
> >>> +        rng: rng@48310000 {
> >>> +            compatible = "ti,omap4-rng";
> >>> +            ti,hwmods = "rng";
> >>> +            reg = <0x48310000 0x2000>;
> >>> +            interrupts = <111>;
> >>> +        };
> >>>       };
> >>>   };
> >>>
> >>
> > 
> > It looks good to me, but it does not apply on my branch.
> > Please rebase it and repost with the proper acked-by.
> > 
> > Thanks,
> > Benoit
> > 
> > 
> 

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Tony Lindgren]

* Lokesh Vutla <lokeshvutla@ti.com> [131016 04:16]:
> + Rob and Mark
> On Tuesday 15 October 2013 12:19 PM, Benoit Cousson wrote:
> > Hi Lokesh,
> > 
> > On 12/10/2013 15:26, Lokesh Vutla wrote:
> >> Hi Benoit,
> >> On Thursday 29 August 2013 06:22 PM, Lokesh Vutla wrote:
> >>> Add the AM33xx RNG module's device tree data.
> >>> Also add Documentation file describing the data
> >>> for the RNG module.
> Can you please review this patch..

OK enough of waiting here, I'm picking this patch into
omap-for-v3.13/dt branch as it removes some boot time warnings
we're seeing.

Regards,

Tony
 
> Thanks and regards,
> Lokesh
> >> Seems you missed this patch. Please consider this for this merge window.
> > 
> > Indeed I missed it. Sorry :-(
> > 
> >> Patch 2/2 is already taken by Paul.
> >> Without this patch AM335x boot will crash as I mentioned in my cover letter.
> >>
> >> Thanks and regards,
> >> Lokesh
> >>>
> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >>> ---
> >>> Changes since V1:
> >>> - Drop "status=disabled" entry in dt node, Since
> >>>    RNG is present on all AM33xx platforms.
> >>>
> >>>   .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
> >>>   arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
> >>>   2 files changed, 29 insertions(+)
> >>>   create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> > 
> > I do not see the acked-by for the binding part. You do need that for any new bindings nowadays.
> > 
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> >>> new file mode 100644
> >>> index 0000000..6a62acd
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> >>> @@ -0,0 +1,22 @@
> >>> +OMAP SoC HWRNG Module
> >>> +
> >>> +Required properties:
> >>> +
> >>> +- compatible : Should contain entries for this and backward compatible
> >>> +  RNG versions:
> >>> +  - "ti,omap2-rng" for OMAP2.
> >>> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> >>> +  Note that these two versions are incompatible.
> >>> +- ti,hwmods: Name of the hwmod associated with the RNG module
> >>> +- reg : Offset and length of the register set for the module
> >>> +- interrupts : the interrupt number for the RNG module.
> >>> +        Only used for "ti,omap4-rng".
> >>> +
> >>> +Example:
> >>> +/* AM335x */
> >>> +rng: rng at 48310000 {
> >>> +    compatible = "ti,omap4-rng";
> >>> +    ti,hwmods = "rng";
> >>> +    reg = <0x48310000 0x2000>;
> >>> +    interrupts = <111>;
> >>> +};
> >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> >>> index 38b446b..26ebe30 100644
> >>> --- a/arch/arm/boot/dts/am33xx.dtsi
> >>> +++ b/arch/arm/boot/dts/am33xx.dtsi
> >>> @@ -530,5 +530,12 @@
> >>>               #size-cells = <1>;
> >>>               status = "disabled";
> >>>           };
> >>> +
> >>> +        rng: rng at 48310000 {
> >>> +            compatible = "ti,omap4-rng";
> >>> +            ti,hwmods = "rng";
> >>> +            reg = <0x48310000 0x2000>;
> >>> +            interrupts = <111>;
> >>> +        };
> >>>       };
> >>>   };
> >>>
> >>
> > 
> > It looks good to me, but it does not apply on my branch.
> > Please rebase it and repost with the proper acked-by.
> > 
> > Thanks,
> > Benoit
> > 
> > 
> 

Re: [RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Kumar Gala]

On Aug 29, 2013, at 7:52 AM, Lokesh Vutla wrote:

> Add the AM33xx RNG module's device tree data.
> Also add Documentation file describing the data
> for the RNG module.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> Changes since V1:
> - Drop "status=disabled" entry in dt node, Since
>  RNG is present on all AM33xx platforms.
> 
> .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
> arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
> 2 files changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> new file mode 100644
> index 0000000..6a62acd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> @@ -0,0 +1,22 @@
> +OMAP SoC HWRNG Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  RNG versions:
> +  - "ti,omap2-rng" for OMAP2.
> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the RNG module
> +- reg : Offset and length of the register set for the module
> +- interrupts : the interrupt number for the RNG module.
> +		Only used for "ti,omap4-rng".
> +
> +Example:
> +/* AM335x */
> +rng: rng@48310000 {
> +	compatible = "ti,omap4-rng";
> +	ti,hwmods = "rng";
> +	reg = <0x48310000 0x2000>;
> +	interrupts = <111>;
> +};

For the DT-Binding portion:

Acked-by: Kumar Gala <galak@codeaurora.org>

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

[RESEND PATCH V2 1/2] ARM: dts: AM33xx: Add RNG node

[Kumar Gala]

On Aug 29, 2013, at 7:52 AM, Lokesh Vutla wrote:

> Add the AM33xx RNG module's device tree data.
> Also add Documentation file describing the data
> for the RNG module.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> Changes since V1:
> - Drop "status=disabled" entry in dt node, Since
>  RNG is present on all AM33xx platforms.
> 
> .../devicetree/bindings/hwrng/omap_rng.txt         |   22 ++++++++++++++++++++
> arch/arm/boot/dts/am33xx.dtsi                      |    7 +++++++
> 2 files changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwrng/omap_rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwrng/omap_rng.txt b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> new file mode 100644
> index 0000000..6a62acd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwrng/omap_rng.txt
> @@ -0,0 +1,22 @@
> +OMAP SoC HWRNG Module
> +
> +Required properties:
> +
> +- compatible : Should contain entries for this and backward compatible
> +  RNG versions:
> +  - "ti,omap2-rng" for OMAP2.
> +  - "ti,omap4-rng" for OMAP4, OMAP5 and AM33XX.
> +  Note that these two versions are incompatible.
> +- ti,hwmods: Name of the hwmod associated with the RNG module
> +- reg : Offset and length of the register set for the module
> +- interrupts : the interrupt number for the RNG module.
> +		Only used for "ti,omap4-rng".
> +
> +Example:
> +/* AM335x */
> +rng: rng at 48310000 {
> +	compatible = "ti,omap4-rng";
> +	ti,hwmods = "rng";
> +	reg = <0x48310000 0x2000>;
> +	interrupts = <111>;
> +};

For the DT-Binding portion:

Acked-by: Kumar Gala <galak@codeaurora.org>

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation