* [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
@ 2020-06-19 17:38 ` Bodo Stroesser
0 siblings, 0 replies; 6+ messages in thread
From: Bodo Stroesser @ 2020-06-19 17:38 UTC (permalink / raw)
To: Martin K. Petersen, Mike Christie, linux-scsi, target-devel
Cc: Bodo Stroesser
Since
commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
queued commands")
tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
So we can remove it safely.
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
---
drivers/target/target_core_user.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 560bfec933bc..b38da27e033f 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -181,7 +181,6 @@ struct tcmu_cmd {
unsigned long deadline;
#define TCMU_CMD_BIT_EXPIRED 0
-#define TCMU_CMD_BIT_INFLIGHT 1
unsigned long flags;
};
/*
@@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
tcmu_flush_dcache_range(mb, sizeof(*mb));
list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
- set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
/* TODO: only if FLUSH and FUA? */
uio_event_notify(&udev->uio_info);
--
2.12.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
@ 2020-06-19 17:38 ` Bodo Stroesser
0 siblings, 0 replies; 6+ messages in thread
From: Bodo Stroesser @ 2020-06-19 17:38 UTC (permalink / raw)
To: Martin K. Petersen, Mike Christie, linux-scsi, target-devel
Cc: Bodo Stroesser
Since
commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
queued commands")
tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
So we can remove it safely.
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
---
drivers/target/target_core_user.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 560bfec933bc..b38da27e033f 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -181,7 +181,6 @@ struct tcmu_cmd {
unsigned long deadline;
#define TCMU_CMD_BIT_EXPIRED 0
-#define TCMU_CMD_BIT_INFLIGHT 1
unsigned long flags;
};
/*
@@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
tcmu_flush_dcache_range(mb, sizeof(*mb));
list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
- set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
/* TODO: only if FLUSH and FUA? */
uio_event_notify(&udev->uio_info);
--
2.12.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
2020-06-19 17:38 ` Bodo Stroesser
@ 2020-06-19 23:27 ` Michael Christie
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Christie @ 2020-06-19 23:27 UTC (permalink / raw)
To: Bodo Stroesser; +Cc: Martin K. Petersen, linux-scsi, target-devel
> On Jun 19, 2020, at 12:38 PM, Bodo Stroesser <bstroesser@ts.fujitsu.com> wrote:
>
> Since
> commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
> queued commands")
> tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
> So we can remove it safely.
>
> Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
> ---
> drivers/target/target_core_user.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 560bfec933bc..b38da27e033f 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -181,7 +181,6 @@ struct tcmu_cmd {
> unsigned long deadline;
>
> #define TCMU_CMD_BIT_EXPIRED 0
> -#define TCMU_CMD_BIT_INFLIGHT 1
> unsigned long flags;
> };
> /*
> @@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
> tcmu_flush_dcache_range(mb, sizeof(*mb));
>
> list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
> - set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
>
> /* TODO: only if FLUSH and FUA? */
> uio_event_notify(&udev->uio_info);
Acked-by: Mike Christie <michael.crhsitie@oracle.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
@ 2020-06-19 23:27 ` Michael Christie
0 siblings, 0 replies; 6+ messages in thread
From: Michael Christie @ 2020-06-19 23:27 UTC (permalink / raw)
To: Bodo Stroesser; +Cc: Martin K. Petersen, linux-scsi, target-devel
> On Jun 19, 2020, at 12:38 PM, Bodo Stroesser <bstroesser@ts.fujitsu.com> wrote:
>
> Since
> commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
> queued commands")
> tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
> So we can remove it safely.
>
> Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
> ---
> drivers/target/target_core_user.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
> index 560bfec933bc..b38da27e033f 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -181,7 +181,6 @@ struct tcmu_cmd {
> unsigned long deadline;
>
> #define TCMU_CMD_BIT_EXPIRED 0
> -#define TCMU_CMD_BIT_INFLIGHT 1
> unsigned long flags;
> };
> /*
> @@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, sense_reason_t *scsi_err)
> tcmu_flush_dcache_range(mb, sizeof(*mb));
>
> list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
> - set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);
>
> /* TODO: only if FLUSH and FUA? */
> uio_event_notify(&udev->uio_info);
Acked-by: Mike Christie <michael.crhsitie@oracle.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
2020-06-19 17:38 ` Bodo Stroesser
@ 2020-06-20 3:26 ` Martin K. Petersen
-1 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-06-20 3:26 UTC (permalink / raw)
To: linux-scsi, target-devel, Mike Christie, Bodo Stroesser
Cc: Martin K . Petersen
On Fri, 19 Jun 2020 19:38:06 +0200, Bodo Stroesser wrote:
> Since
> commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
> queued commands")
> tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
> So we can remove it safely.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
https://git.kernel.org/mkp/scsi/c/da3f28da1c27
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
@ 2020-06-20 3:26 ` Martin K. Petersen
0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-06-20 3:26 UTC (permalink / raw)
To: linux-scsi, target-devel, Mike Christie, Bodo Stroesser
Cc: Martin K . Petersen
On Fri, 19 Jun 2020 19:38:06 +0200, Bodo Stroesser wrote:
> Since
> commit 61fb24822166 ("scsi: target: tcmu: Userspace must not complete
> queued commands")
> tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never checked.
> So we can remove it safely.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT
https://git.kernel.org/mkp/scsi/c/da3f28da1c27
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-20 3:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 17:38 [PATCH] scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT Bodo Stroesser
2020-06-19 17:38 ` Bodo Stroesser
2020-06-19 23:27 ` Michael Christie
2020-06-19 23:27 ` Michael Christie
2020-06-20 3:26 ` Martin K. Petersen
2020-06-20 3:26 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.