* [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
@ 2013-10-29 17:46 Fabio Estevam
2013-10-29 23:03 ` Eric Nelson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-10-29 17:46 UTC (permalink / raw)
To: u-boot
Currently the HDMI splash screen image quality on mx6solo does not show a
very stable image.
By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
@ 2013-10-29 23:03 ` Eric Nelson
2013-10-30 8:59 ` Stefano Babic
2013-10-30 9:07 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Eric Nelson @ 2013-10-29 23:03 UTC (permalink / raw)
To: u-boot
Thanks Fabio,
On 10/29/2013 10:46 AM, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
> From FSL BSP [1] we have:
>
> if (!sig.clk_pol)
> di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>
It's odd that this doesn't appear to change things for the i.MX6DQ,
but it works on either one, so
Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>
Acked-by: Eric Nelson <eric.nelson@boundarydevices.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
2013-10-29 23:03 ` Eric Nelson
@ 2013-10-30 8:59 ` Stefano Babic
2013-10-30 9:07 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2013-10-30 8:59 UTC (permalink / raw)
To: u-boot
On 29/10/2013 18:46, Fabio Estevam wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
> From FSL BSP [1] we have:
>
> if (!sig.clk_pol)
> di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>
> [1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/video/ipu_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/ipu_disp.c b/drivers/video/ipu_disp.c
> index 2e91356..22ac142 100644
> --- a/drivers/video/ipu_disp.c
> +++ b/drivers/video/ipu_disp.c
> @@ -1178,7 +1178,7 @@ int32_t ipu_init_sync_panel(int disp, uint32_t pixel_clk,
> if (sig.Vsync_pol)
> di_gen |= DI_GEN_POLARITY_3;
>
> - if (sig.clk_pol)
> + if (!sig.clk_pol)
> di_gen |= DI_GEN_POL_CLK;
>
> }
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
2013-10-29 23:03 ` Eric Nelson
2013-10-30 8:59 ` Stefano Babic
@ 2013-10-30 9:07 ` Anatolij Gustschin
2 siblings, 0 replies; 4+ messages in thread
From: Anatolij Gustschin @ 2013-10-30 9:07 UTC (permalink / raw)
To: u-boot
On Tue, 29 Oct 2013 15:46:21 -0200
Fabio Estevam <fabio.estevam@freescale.com> wrote:
> Currently the HDMI splash screen image quality on mx6solo does not show a
> very stable image.
>
> By comparing the IPU driver from U-boot with the one from FSL 4.1.0 BSP,
> we can see that there is an inverted logic for setting the DI_GEN_POL_CLK bit.
>
> From FSL BSP [1] we have:
>
> if (!sig.clk_pol)
> di_gen |= DI_GEN_POLARITY_DISP_CLK;
>
> Applying the same logic into U-boot fixes the HDMI image stability.
>
> [1] git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/tree/drivers/mxc/ipu3/ipu_disp.c?h=imx_3.0.35_4.1.0
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/video/ipu_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to u-boot-video/master.
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-30 9:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-29 17:46 [U-Boot] [PATCH] video: ipu_disp: Fix clock polarity logic Fabio Estevam
2013-10-29 23:03 ` Eric Nelson
2013-10-30 8:59 ` Stefano Babic
2013-10-30 9:07 ` Anatolij Gustschin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.