From: Paul Moore <paul@paul-moore.com> To: David Miller <davem@davemloft.net> Cc: geert@linux-m68k.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sel_netif_init: 'err' is used uninitialized Date: Thu, 07 Aug 2014 21:01:19 -0400 [thread overview] Message-ID: <5275439.odfNAhPpkP@sifl> (raw) In-Reply-To: <20140807.120454.1646328149054855088.davem@davemloft.net> On Thursday, August 07, 2014 12:04:54 PM David Miller wrote: > From: Paul Moore <paul@paul-moore.com> > Date: Thu, 07 Aug 2014 10:26:14 -0400 > > > On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote: > > > >> > >> security/selinux/netif.c: In function ‘sel_netif_init’: > >> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning: > >> ‘err’ is used uninitialized in this function > >> > >> Should it just return 0, like before? > >> Or should it return the return value of register_netdevice_notifier() > >> instead, which also returns an error code? Or is that failure > >> non-critical? > > > > Hi, > > > > I posted a fix for this two days ago to the SELinux list (see below). As > > soon as -rc1 is released and linux-next is back in business I'll be > > pushing the patch to the SELinux #next branch. > > > > * http://marc.info/?l=selinux&m=140727033030054&w=2 > > With respect to this and the lack-of-inline warning fix we spoke about > yesterday, why are you waiting and only pushing such bug fixes into your > "next" branch? Simply put, I didn't think the patches were significant enough to push at this point in time. > Those sort of things should be sent to Linus now to correct the errors > introduced during the merge window, as I have done last night for all > of the networking merge fallout. I'll (re)post the patches with a pull request in just a moment, CC'ing all the various mailing lists and you guys can figure out who best to merge them. -- paul moore www.paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com> To: David Miller <davem@davemloft.net> Cc: geert@linux-m68k.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: sel_netif_init: 'err' is used uninitialized Date: Thu, 07 Aug 2014 21:01:19 -0400 [thread overview] Message-ID: <5275439.odfNAhPpkP@sifl> (raw) In-Reply-To: <20140807.120454.1646328149054855088.davem@davemloft.net> On Thursday, August 07, 2014 12:04:54 PM David Miller wrote: > From: Paul Moore <paul@paul-moore.com> > Date: Thu, 07 Aug 2014 10:26:14 -0400 > > > On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote: > > > >> > >> security/selinux/netif.c: In function ‘sel_netif_init’: > >> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning: > >> ‘err’ is used uninitialized in this function > >> > >> Should it just return 0, like before? > >> Or should it return the return value of register_netdevice_notifier() > >> instead, which also returns an error code? Or is that failure > >> non-critical? > > > > Hi, > > > > I posted a fix for this two days ago to the SELinux list (see below). As > > soon as -rc1 is released and linux-next is back in business I'll be > > pushing the patch to the SELinux #next branch. > > > > * http://marc.info/?l=selinux&m=140727033030054&w=2 > > With respect to this and the lack-of-inline warning fix we spoke about > yesterday, why are you waiting and only pushing such bug fixes into your > "next" branch? Simply put, I didn't think the patches were significant enough to push at this point in time. > Those sort of things should be sent to Linus now to correct the errors > introduced during the merge window, as I have done last night for all > of the networking merge fallout. I'll (re)post the patches with a pull request in just a moment, CC'ing all the various mailing lists and you guys can figure out who best to merge them. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-08-08 1:01 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-07 10:31 sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize_net() when flushing caches) Geert Uytterhoeven 2014-08-07 10:31 ` Geert Uytterhoeven 2014-08-07 14:26 ` Paul Moore 2014-08-07 14:57 ` Geert Uytterhoeven 2014-08-07 19:04 ` sel_netif_init: 'err' is used uninitialized David Miller 2014-08-07 19:04 ` David Miller 2014-08-08 1:01 ` Paul Moore [this message] 2014-08-08 1:01 ` Paul Moore
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5275439.odfNAhPpkP@sifl \ --to=paul@paul-moore.com \ --cc=davem@davemloft.net \ --cc=geert@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.