* [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c
@ 2014-10-13 2:29 Erich Cordoba Malibran
2014-10-13 3:27 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Erich Cordoba Malibran @ 2014-10-13 2:29 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel, Erich Cordoba Malibran
From: Erich Cordoba Malibran <erich.cordoba@yandex.com>
Renamed function to fix style issues.
Signed-off-by: Erich Cordoba Malibran <erich.cordoba@yandex.com>
---
drivers/staging/wlan-ng/prism2mib.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
index 0163e06..30d224f 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
struct p80211msg_dot11req_mibset *msg,
void *data);
-static int prism2mib_fragmentationthreshold(struct mibrec *mib,
- int isget,
- wlandevice_t *wlandev,
- hfa384x_t *hw,
- struct p80211msg_dot11req_mibset *msg,
- void *data);
+static int prism2mib_fragmenthreshold(struct mibrec *mib,
+ int isget,
+ wlandevice_t *wlandev,
+ hfa384x_t *hw,
+ struct p80211msg_dot11req_mibset *msg,
+ void *data);
static int prism2mib_priv(struct mibrec *mib,
int isget,
@@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
{DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
F_STA | F_READ | F_WRITE,
HFA384x_RID_FRAGTHRESH, 0, 0,
- prism2mib_fragmentationthreshold},
+ prism2mib_fragmenthreshold},
{DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
F_STA | F_READ,
HFA384x_RID_MAXTXLIFETIME, 0, 0,
@@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
*
----------------------------------------------------------------*/
-static int prism2mib_fragmentationthreshold(struct mibrec *mib,
- int isget,
- wlandevice_t *wlandev,
- hfa384x_t *hw,
- struct p80211msg_dot11req_mibset *msg,
- void *data)
+static int prism2mib_fragmenthreshold(struct mibrec *mib,
+ int isget,
+ wlandevice_t *wlandev,
+ hfa384x_t *hw,
+ struct p80211msg_dot11req_mibset *msg,
+ void *data)
{
int result;
u32 *uint32 = (u32 *) data;
--
2.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c
2014-10-13 2:29 [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c Erich Cordoba Malibran
@ 2014-10-13 3:27 ` Greg KH
2014-10-13 19:32 ` Erich Cordoba
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-10-13 3:27 UTC (permalink / raw)
To: Erich Cordoba Malibran; +Cc: linux-kernel, devel
On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
> From: Erich Cordoba Malibran <erich.cordoba@yandex.com>
>
> Renamed function to fix style issues.
Why is changing a name, to a misspelled one, a "style issue fix"?
>
> Signed-off-by: Erich Cordoba Malibran <erich.cordoba@yandex.com>
> ---
> drivers/staging/wlan-ng/prism2mib.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index 0163e06..30d224f 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
> struct p80211msg_dot11req_mibset *msg,
> void *data);
>
> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
> - int isget,
> - wlandevice_t *wlandev,
> - hfa384x_t *hw,
> - struct p80211msg_dot11req_mibset *msg,
> - void *data);
> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
> + int isget,
> + wlandevice_t *wlandev,
> + hfa384x_t *hw,
> + struct p80211msg_dot11req_mibset *msg,
> + void *data);
>
> static int prism2mib_priv(struct mibrec *mib,
> int isget,
> @@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
> {DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
> F_STA | F_READ | F_WRITE,
> HFA384x_RID_FRAGTHRESH, 0, 0,
> - prism2mib_fragmentationthreshold},
> + prism2mib_fragmenthreshold},
> {DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
> F_STA | F_READ,
> HFA384x_RID_MAXTXLIFETIME, 0, 0,
> @@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
> *
> ----------------------------------------------------------------*/
>
> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
> - int isget,
> - wlandevice_t *wlandev,
> - hfa384x_t *hw,
> - struct p80211msg_dot11req_mibset *msg,
> - void *data)
> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
> + int isget,
> + wlandevice_t *wlandev,
> + hfa384x_t *hw,
> + struct p80211msg_dot11req_mibset *msg,
> + void *data)
> {
> int result;
> u32 *uint32 = (u32 *) data;
> --
> 2.1.2
I don't understand the problem you are trying to solve here, what is it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c
2014-10-13 3:27 ` Greg KH
@ 2014-10-13 19:32 ` Erich Cordoba
0 siblings, 0 replies; 3+ messages in thread
From: Erich Cordoba @ 2014-10-13 19:32 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, devel
The idea was to reduce the length of the line (to 80 characters) by renaming this function.
But, now reviewing the result I can see that the name of the function has lost meaning.
Please ignore this patch.
-Erich
12.10.2014, 21:28, "Greg KH" <gregkh@linuxfoundation.org>:
> On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
>> From: Erich Cordoba Malibran <erich.cordoba@yandex.com>
>>
>> Renamed function to fix style issues.
>
> Why is changing a name, to a misspelled one, a "style issue fix"?
>> Signed-off-by: Erich Cordoba Malibran <erich.cordoba@yandex.com>
>> ---
>> drivers/staging/wlan-ng/prism2mib.c | 26 +++++++++++++-------------
>> 1 file changed, 13 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
>> index 0163e06..30d224f 100644
>> --- a/drivers/staging/wlan-ng/prism2mib.c
>> +++ b/drivers/staging/wlan-ng/prism2mib.c
>> @@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
>> struct p80211msg_dot11req_mibset *msg,
>> void *data);
>>
>> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
>> - int isget,
>> - wlandevice_t *wlandev,
>> - hfa384x_t *hw,
>> - struct p80211msg_dot11req_mibset *msg,
>> - void *data);
>> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
>> + int isget,
>> + wlandevice_t *wlandev,
>> + hfa384x_t *hw,
>> + struct p80211msg_dot11req_mibset *msg,
>> + void *data);
>>
>> static int prism2mib_priv(struct mibrec *mib,
>> int isget,
>> @@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
>> {DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
>> F_STA | F_READ | F_WRITE,
>> HFA384x_RID_FRAGTHRESH, 0, 0,
>> - prism2mib_fragmentationthreshold},
>> + prism2mib_fragmenthreshold},
>> {DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
>> F_STA | F_READ,
>> HFA384x_RID_MAXTXLIFETIME, 0, 0,
>> @@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
>> *
>> ----------------------------------------------------------------*/
>>
>> -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
>> - int isget,
>> - wlandevice_t *wlandev,
>> - hfa384x_t *hw,
>> - struct p80211msg_dot11req_mibset *msg,
>> - void *data)
>> +static int prism2mib_fragmenthreshold(struct mibrec *mib,
>> + int isget,
>> + wlandevice_t *wlandev,
>> + hfa384x_t *hw,
>> + struct p80211msg_dot11req_mibset *msg,
>> + void *data)
>> {
>> int result;
>> u32 *uint32 = (u32 *) data;
>> --
>> 2.1.2
>
> I don't understand the problem you are trying to solve here, what is it?
>
> confused,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-13 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-13 2:29 [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c Erich Cordoba Malibran
2014-10-13 3:27 ` Greg KH
2014-10-13 19:32 ` Erich Cordoba
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.