* trivial: remove various pointless things
@ 2013-11-08 0:45 Matthew Daley
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel
No functional changes (hopefully).
extras/mini-os/lwip-net.c | 2 --
tools/libxc/xc_domain.c | 3 +--
tools/libxl/xl_cmdimpl.c | 4 ++--
xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
xen/common/device_tree.c | 2 +-
xen/drivers/video/arm_hdlcd.c | 2 +-
6 files changed, 5 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/6] nestedsvm: remove pointless BUG_ON
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 14:28 ` Boris Ostrovsky
2013-11-08 0:45 ` [PATCH 2/6] xen/arm: remove pointless if subcondition Matthew Daley
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel
Cc: Keir Fraser, Suravee Suthikulpanit, Matthew Daley, xen-devel,
Jan Beulich, Boris Ostrovsky
It's already handled just above.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
index e32c872..705b653 100644
--- a/xen/arch/x86/hvm/svm/nestedsvm.c
+++ b/xen/arch/x86/hvm/svm/nestedsvm.c
@@ -847,7 +847,6 @@ nsvm_vmcb_guest_intercepts_msr(unsigned long *msr_bitmap,
/* MSR not in the permission map: Let the guest handle it. */
return NESTEDHVM_VMEXIT_INJECT;
- BUG_ON(msr_bit == NULL);
msr &= 0x1fff;
if (write)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/6] xen/arm: remove pointless if subcondition
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 0:45 ` [PATCH 3/6] xen/video: " Matthew Daley
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel
Cc: Tim Deegan, Matthew Daley, Stefano Stabellini, Ian Campbell, xen-devel
It's already handled just above.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
xen/common/device_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index f7d0215..44253da 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -906,7 +906,7 @@ static int dt_translate_one(const struct dt_device_node *parent,
dt_printk(XENLOG_ERR "DT: no ranges; cannot translate\n");
return 1;
}
- if ( ranges == NULL || rlen == 0 )
+ if ( rlen == 0 )
{
offset = dt_read_number(addr, na);
memset(addr, 0, pna * 4);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/6] xen/video: remove pointless if subcondition
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
2013-11-08 0:45 ` [PATCH 2/6] xen/arm: remove pointless if subcondition Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 0:45 ` [PATCH 4/6] libxc: remove pointless null pointer check Matthew Daley
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel; +Cc: Matthew Daley, Keir Fraser, xen-devel
It's already handled just above.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
xen/drivers/video/arm_hdlcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/video/arm_hdlcd.c b/xen/drivers/video/arm_hdlcd.c
index dffda9a..647f22c 100644
--- a/xen/drivers/video/arm_hdlcd.c
+++ b/xen/drivers/video/arm_hdlcd.c
@@ -150,7 +150,7 @@ void __init video_init(void)
return;
}
- if ( !hdlcd_start || !framebuffer_start )
+ if ( !framebuffer_start )
{
early_printk(KERN_ERR "HDLCD: framebuffer address missing from device tree, disabling driver\n");
return;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/6] libxc: remove pointless null pointer check
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
` (2 preceding siblings ...)
2013-11-08 0:45 ` [PATCH 3/6] xen/video: " Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 0:45 ` [PATCH 5/6] xl: " Matthew Daley
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel
Cc: xen-devel, Matthew Daley, Ian Jackson, Ian Campbell, Stefano Stabellini
ctxt_buf is guaranteed non-null here.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
tools/libxc/xc_domain.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 2cea6e3..1ccafc5 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -444,8 +444,7 @@ int xc_domain_hvm_getcontext_partial(xc_interface *xch,
ret = do_domctl(xch, &domctl);
- if ( ctxt_buf )
- xc_hypercall_bounce_post(xch, ctxt_buf);
+ xc_hypercall_bounce_post(xch, ctxt_buf);
return ret ? -1 : 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/6] xl: remove pointless null pointer check
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
` (3 preceding siblings ...)
2013-11-08 0:45 ` [PATCH 4/6] libxc: remove pointless null pointer check Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 0:45 ` [PATCH 6/6] mini-os: remove repeated statement in netfront_input Matthew Daley
2013-11-11 16:25 ` trivial: remove various pointless things Ian Campbell
6 siblings, 0 replies; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel
Cc: xen-devel, Matthew Daley, Ian Jackson, Ian Campbell, Stefano Stabellini
poolinfo is guaranteed non-null here.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
tools/libxl/xl_cmdimpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 40feb7d..5bd9b15 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -5095,8 +5095,8 @@ static int sched_domain_output(libxl_scheduler sched, int (*output)(int),
break;
}
}
- if (poolinfo)
- libxl_cpupoolinfo_list_free(poolinfo, n_pools);
+
+ libxl_cpupoolinfo_list_free(poolinfo, n_pools);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/6] mini-os: remove repeated statement in netfront_input
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
` (4 preceding siblings ...)
2013-11-08 0:45 ` [PATCH 5/6] xl: " Matthew Daley
@ 2013-11-08 0:45 ` Matthew Daley
2013-11-08 0:56 ` Samuel Thibault
2013-11-11 16:25 ` trivial: remove various pointless things Ian Campbell
6 siblings, 1 reply; 10+ messages in thread
From: Matthew Daley @ 2013-11-08 0:45 UTC (permalink / raw)
To: xen-devel; +Cc: Samuel Thibault, Matthew Daley, xen-devel, Stefano Stabellini
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
| 2 --
1 file changed, 2 deletions(-)
--git a/extras/mini-os/lwip-net.c b/extras/mini-os/lwip-net.c
index 9fded11..449b70f 100644
--- a/extras/mini-os/lwip-net.c
+++ b/extras/mini-os/lwip-net.c
@@ -194,8 +194,6 @@ netfront_input(struct netif *netif, unsigned char* data, int len)
/* points to packet payload, which starts with an Ethernet header */
ethhdr = p->payload;
-
- ethhdr = p->payload;
switch (htons(ethhdr->type)) {
/* IP packet? */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 6/6] mini-os: remove repeated statement in netfront_input
2013-11-08 0:45 ` [PATCH 6/6] mini-os: remove repeated statement in netfront_input Matthew Daley
@ 2013-11-08 0:56 ` Samuel Thibault
0 siblings, 0 replies; 10+ messages in thread
From: Samuel Thibault @ 2013-11-08 0:56 UTC (permalink / raw)
To: Matthew Daley; +Cc: xen-devel, xen-devel, Stefano Stabellini
Matthew Daley, le Fri 08 Nov 2013 13:45:12 +1300, a écrit :
> Signed-off-by: Matthew Daley <mattjd@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> extras/mini-os/lwip-net.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/extras/mini-os/lwip-net.c b/extras/mini-os/lwip-net.c
> index 9fded11..449b70f 100644
> --- a/extras/mini-os/lwip-net.c
> +++ b/extras/mini-os/lwip-net.c
> @@ -194,8 +194,6 @@ netfront_input(struct netif *netif, unsigned char* data, int len)
>
> /* points to packet payload, which starts with an Ethernet header */
> ethhdr = p->payload;
> -
> - ethhdr = p->payload;
>
> switch (htons(ethhdr->type)) {
> /* IP packet? */
> --
> 1.7.10.4
>
--
Samuel
<studdud> what the fuck is wtf
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] nestedsvm: remove pointless BUG_ON
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
@ 2013-11-08 14:28 ` Boris Ostrovsky
0 siblings, 0 replies; 10+ messages in thread
From: Boris Ostrovsky @ 2013-11-08 14:28 UTC (permalink / raw)
To: Matthew Daley
Cc: xen-devel, Keir Fraser, Jan Beulich, Suravee Suthikulpanit, xen-devel
On 11/07/2013 07:45 PM, Matthew Daley wrote:
> It's already handled just above.
>
> Signed-off-by: Matthew Daley <mattjd@gmail.com>
> ---
> xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
> index e32c872..705b653 100644
> --- a/xen/arch/x86/hvm/svm/nestedsvm.c
> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c
> @@ -847,7 +847,6 @@ nsvm_vmcb_guest_intercepts_msr(unsigned long *msr_bitmap,
> /* MSR not in the permission map: Let the guest handle it. */
> return NESTEDHVM_VMEXIT_INJECT;
>
> - BUG_ON(msr_bit == NULL);
> msr &= 0x1fff;
>
> if (write)
Acked-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: trivial: remove various pointless things
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
` (5 preceding siblings ...)
2013-11-08 0:45 ` [PATCH 6/6] mini-os: remove repeated statement in netfront_input Matthew Daley
@ 2013-11-11 16:25 ` Ian Campbell
6 siblings, 0 replies; 10+ messages in thread
From: Ian Campbell @ 2013-11-11 16:25 UTC (permalink / raw)
To: Matthew Daley; +Cc: xen-devel
On Fri, 2013-11-08 at 13:45 +1300, Matthew Daley wrote:
> No functional changes (hopefully).
Looks like someone picked up the first and last (x86 & mini-os). The
middle 4 (arm + libxl + libxc ones) I've just acked + applied. thanks.
>
> extras/mini-os/lwip-net.c | 2 --
> tools/libxc/xc_domain.c | 3 +--
> tools/libxl/xl_cmdimpl.c | 4 ++--
> xen/arch/x86/hvm/svm/nestedsvm.c | 1 -
> xen/common/device_tree.c | 2 +-
> xen/drivers/video/arm_hdlcd.c | 2 +-
> 6 files changed, 5 insertions(+), 9 deletions(-)
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-11-11 16:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-08 0:45 trivial: remove various pointless things Matthew Daley
2013-11-08 0:45 ` [PATCH 1/6] nestedsvm: remove pointless BUG_ON Matthew Daley
2013-11-08 14:28 ` Boris Ostrovsky
2013-11-08 0:45 ` [PATCH 2/6] xen/arm: remove pointless if subcondition Matthew Daley
2013-11-08 0:45 ` [PATCH 3/6] xen/video: " Matthew Daley
2013-11-08 0:45 ` [PATCH 4/6] libxc: remove pointless null pointer check Matthew Daley
2013-11-08 0:45 ` [PATCH 5/6] xl: " Matthew Daley
2013-11-08 0:45 ` [PATCH 6/6] mini-os: remove repeated statement in netfront_input Matthew Daley
2013-11-08 0:56 ` Samuel Thibault
2013-11-11 16:25 ` trivial: remove various pointless things Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.