[U-Boot-Users] xilinx drivers

[U-Boot-Users] xilinx drivers

[mONStR]

Hi Wolfgang and Stefan,

I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers (drivers/xilinx/xilinx_enet and xilinx_iic) folder and change ifdef label because I use this drivers for Microblaze processor and this drivers are used for ppc405 embedded core like ml300.

Label as #if defined(XPAR_EMAC_0_DEVICE_ID) is board dependent and I would like to remove this define from config files for Microblaze boards.

and then clean Makefiles...

CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic 

OBJS	= $(BOARD).o \
	  serial.o \
	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
	  ../common/xbasic_types.o ../common/xdma_channel.o \
	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
	  ../common/xversion.o \ 


Is it possible do this changes?

And after that add support for other xilinx peripherals as SPI, EMACLITE, etc.

Isn't it problem with Xilinx licence?


Best regards,
Michal Simek

[U-Boot-Users] xilinx drivers

[Stefan Roese]

Hi Michal,

On Monday 26 March 2007 08:10, mONStR wrote:
> I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers
> (drivers/xilinx/xilinx_enet and xilinx_iic) folder

I would prefer something like:

drivers/net/xilinx_enet/*
drivers/i2c/xilinx_iic/*

> and change ifdef label 
> because I use this drivers for Microblaze processor and this drivers are
> used for ppc405 embedded core like ml300.
>
> Label as #if defined(XPAR_EMAC_0_DEVICE_ID) is board dependent and I would
> like to remove this define from config files for Microblaze boards.

But please make sure, that this file is only included in the targets that 
really need it.

> and then clean Makefiles...
>
> CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic
>
> OBJS	= $(BOARD).o \
> 	  serial.o \
> 	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
> 	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
> 	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
> 	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
> 	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
> 	  ../common/xbasic_types.o ../common/xdma_channel.o \
> 	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
> 	  ../common/xversion.o \

You are talking about the current file "board/xilinx/ml300/Makefile", right?

> Is it possible do this changes?

Yes, this is possible to change. This could definitely needs some cleanup.

Maybe Grant wants to add some remarks here? Grant?

> And after that add support for other xilinx peripherals as SPI, EMACLITE,
> etc.
>
> Isn't it problem with Xilinx licence?

I doesn't see to be. But I am not a lawyer.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================

[U-Boot-Users] xilinx drivers

[mONStR]

Hi Stefan,

>Hi Michal,

>On Monday 26 March 2007 08:10, mONStR wrote:
>> I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers
>> (drivers/xilinx/xilinx_enet and xilinx_iic) folder
>
>I would prefer something like:
>
>drivers/net/xilinx_enet/*
>drivers/i2c/xilinx_iic/*

Yes, of course

>> and change ifdef label 
>> because I use this drivers for Microblaze processor and this drivers are
>> used for ppc405 embedded core like ml300.
>>
>> Label as #if defined(XPAR_EMAC_0_DEVICE_ID) is board dependent and I would
>> like to remove this define from config files for Microblaze boards.
>
>But please make sure, that this file is only included in the targets that 
>really need it.

OK.

>> and then clean Makefiles...
>>
>> CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic
>>
>> OBJS	= $(BOARD).o \
>> 	  serial.o \
>> 	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
>> 	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
>> 	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
>> 	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
>> 	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
>> 	  ../common/xbasic_types.o ../common/xdma_channel.o \
>> 	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
>> 	  ../common/xversion.o \
>
>You are talking about the current file "board/xilinx/ml300/Makefile", right?

Yes about current board/xilinx/ml300/Makefile and Makefile, which are only in u-boot-microblaze repository board/xilinx/xupv2p/Makefile and board/xilinx/ml401/Makefile.

>> Is it possible do this changes?
>
>Yes, this is possible to change. This could definitely needs some cleanup.

OK.

>Maybe Grant wants to add some remarks here? Grant?

I am waiting for Grant.

>> And after that add support for other xilinx peripherals as SPI, EMACLITE,
>> etc.
>>
>> Isn't it problem with Xilinx licence?
>
>I doesn't see to be. But I am not a lawyer.
 OK.

>Best regards,
>Stefan
>
>=====================================================================
>DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
>Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
>=====================================================================
>

Michal Simek

[U-Boot-Users] xilinx drivers

[Grant Likely]

On 3/26/07, Stefan Roese <sr@denx.de> wrote:
> > Is it possible do this changes?
>
> Yes, this is possible to change. This could definitely needs some cleanup.
>
> Maybe Grant wants to add some remarks here? Grant?

Yes, I'd like to make some comments; but I'm tired now and must sleep.
 I'll can be more coherent tomorrow morning.  :-)

But in general, I'm not at all opposed to reworking the xilinx support
code.  It needs it.

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195

[U-Boot-Users] xilinx drivers

[Wolfgang Denk]

In message <3275.5961-16246-190946868-1174889434@seznam.cz> you wrote:
> 
> and then clean Makefiles...
> 
> CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic 
> 
> OBJS	= $(BOARD).o \
> 	  serial.o \
> 	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
> 	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
> 	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
> 	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
> 	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
> 	  ../common/xbasic_types.o ../common/xdma_channel.o \
> 	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
> 	  ../common/xversion.o \ 

This looks broken to me. It seems you forgot to add support for
building in external directories.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Disobedience:  The silver lining to the cloud of servitude.
- Ambrose Bierce

[U-Boot-Users] xilinx drivers

[Wolfgang Denk]

In message <200703260828.11757.sr@denx.de> you wrote:
> 
> On Monday 26 March 2007 08:10, mONStR wrote:
> > I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers
> > (drivers/xilinx/xilinx_enet and xilinx_iic) folder
> 
> I would prefer something like:
> 
> drivers/net/xilinx_enet/*
> drivers/i2c/xilinx_iic/*

Me too, except that we should remove the redundancy, i. e. plase make
this:

	drivers/net/xilinx/*
	drivers/i2c/xilinx/*

[Especially mixing i2c and iic in one path name looks pretty awkward
to me.]

> > CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic
> >
> > OBJS	= $(BOARD).o \
> > 	  serial.o \
> > 	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
> > 	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
> > 	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
> > 	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
> > 	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
> > 	  ../common/xbasic_types.o ../common/xdma_channel.o \
> > 	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
> > 	  ../common/xversion.o \
> 
> You are talking about the current file "board/xilinx/ml300/Makefile", right?

No, he must some obsolete version.

> > Isn't it problem with Xilinx licence?
> 
> I doesn't see to be. But I am not a lawyer.

Any code included with U-Boot  shall  come  under  a  GPL  compatible
license. If there is a doubt, I will reject it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Killing is wrong.
	-- Losira, "That Which Survives", stardate unknown

[U-Boot-Users] xilinx drivers

[Stefan Roese]

On Monday 26 March 2007 09:12, Wolfgang Denk wrote:
> > > Isn't it problem with Xilinx licence?
> >
> > I doesn't see to be. But I am not a lawyer.
>
> Any code included with U-Boot  shall  come  under  a  GPL  compatible
> license. If there is a doubt, I will reject it.

It already in and I rechecked it (e.g. board/xilinx/xilinx_enet/xemac_g.c):

/*******************************************************************
*
* CAUTION: This file is automatically generated by libgen.
* Version: Xilinx EDK 6.1.2 EDK_G.14
* DO NOT EDIT.
*
*     Author: Xilinx, Inc.
*
*
*     This program is free software; you can redistribute it and/or modify it
*     under the terms of the GNU General Public License as published by the
*     Free Software Foundation; either version 2 of the License, or (at your
*     option) any later version.
*
*
*     XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
*     COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
*     ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
*     XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
*     FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
*     ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
*     XILINX EXPRESSLY DISCLAIMS ANY WARRANTY WHATSOEVER WITH RESPECT TO
*     THE ADEQUACY OF THE IMPLEMENTATION, INCLUDING BUT NOT LIMITED TO ANY
*     WARRANTIES OR REPRESENTATIONS THAT THIS IMPLEMENTATION IS FREE FROM
*     CLAIMS OF INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND
*     FITNESS FOR A PARTICULAR PURPOSE.
*
*
*     Xilinx hardware products are not intended for use in life support
*     appliances, devices, or systems. Use in such applications is
*     expressly prohibited.
*
*     (c) Copyright 2002-2004 Xilinx Inc.
*     All rights reserved.
*
*
*     You should have received a copy of the GNU General Public License along
*     with this program; if not, write to the Free Software Foundation, Inc.,
*     675 Mass Ave, Cambridge, MA 02139, USA.
*
* Description: Driver configuration
*
*******************************************************************/

So it's GPL. I didn't check all the files though.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
=====================================================================

[U-Boot-Users] xilinx drivers

[Monstr at seznam.cz]

I think that this file isn't under GPL too. 
Please look to git. This is not obsolete code.

/board/xilinx/ml300/xparameters.h

/*******************************************************************
 *
 * CAUTION: This file is automatically generated by libgen.
 * Version: Xilinx EDK 6.2 EDK_Gm.11
 * DO NOT EDIT.
 *
 * Copyright (c) 2003 Xilinx, Inc.  All rights reserved.
 *
 * Description: Driver parameters
 *
 *******************************************************************/

Best regards,
Michal Simek

>On Monday 26 March 2007 09:12, Wolfgang Denk wrote:
>> > > Isn't it problem with Xilinx licence?
>> >
>> > I doesn't see to be. But I am not a lawyer.
>>
>> Any code included with U-Boot  shall  come  under  a  GPL  compatible
>> license. If there is a doubt, I will reject it.
>
>It already in and I rechecked it (e.g. board/xilinx/xilinx_enet/xemac_g.c):

>/*******************************************************************
>*
>* CAUTION: This file is automatically generated by libgen.
>* Version: Xilinx EDK 6.1.2 EDK_G.14
>* DO NOT EDIT.
>*
>*     Author: Xilinx, Inc.
>*
>*
>*     This program is free software; you can redistribute it and/or modify it
>*     under the terms of the GNU General Public License as published by the
>*     Free Software Foundation; either version 2 of the License, or (at your
>*     option) any later version.
>*
>*
>*     XILINX IS PROVIDING THIS DESIGN, CODE, OR INFORMATION "AS IS" AS A
>*     COURTESY TO YOU. BY PROVIDING THIS DESIGN, CODE, OR INFORMATION AS
>*     ONE POSSIBLE IMPLEMENTATION OF THIS FEATURE, APPLICATION OR STANDARD,
>*     XILINX IS MAKING NO REPRESENTATION THAT THIS IMPLEMENTATION IS FREE
>*     FROM ANY CLAIMS OF INFRINGEMENT, AND YOU ARE RESPONSIBLE FOR OBTAINING
>*     ANY THIRD PARTY RIGHTS YOU MAY REQUIRE FOR YOUR IMPLEMENTATION.
>*     XILINX EXPRESSLY DISCLAIMS ANY WARRANTY WHATSOEVER WITH RESPECT TO
>*     THE ADEQUACY OF THE IMPLEMENTATION, INCLUDING BUT NOT LIMITED TO ANY
>*     WARRANTIES OR REPRESENTATIONS THAT THIS IMPLEMENTATION IS FREE FROM
>*     CLAIMS OF INFRINGEMENT, IMPLIED WARRANTIES OF MERCHANTABILITY AND
>*     FITNESS FOR A PARTICULAR PURPOSE.
>*
>*
>*     Xilinx hardware products are not intended for use in life support
>*     appliances, devices, or systems. Use in such applications is
>*     expressly prohibited.
>*
>*     (c) Copyright 2002-2004 Xilinx Inc.
>*     All rights reserved.
>*
>*
>*     You should have received a copy of the GNU General Public License along
>*     with this program; if not, write to the Free Software Foundation, Inc.,
>*     675 Mass Ave, Cambridge, MA 02139, USA.
>*
>* Description: Driver configuration
>*
>*******************************************************************/
>
>So it's GPL. I didn't check all the files though.
>
>Best regards,
>Stefan
>
>=====================================================================
>DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
>Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
>=====================================================================

[U-Boot-Users] xilinx drivers

[Monstr at seznam.cz]

>> > I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers
>> > (drivers/xilinx/xilinx_enet and xilinx_iic) folder
>> 
>> I would prefer something like:
>> 
>> drivers/net/xilinx_enet/*
>> drivers/i2c/xilinx_iic/*
>
>Me too, except that we should remove the redundancy, i. e. plase make
>this:
>
>	drivers/net/xilinx/*
>	drivers/i2c/xilinx/*
>
>[Especially mixing i2c and iic in one path name looks pretty awkward
>to me.]

OK a then /board/xilinx/common/.
Where is the right place for this files?
These files are supported files for xilinx drivers.

>> > CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic
>> >
>> > OBJS	= $(BOARD).o \
>> > 	  serial.o \
>> > 	  ../xilinx_enet/emac_adapter.o  ../xilinx_enet/xemac.o \
>> > 	  ../xilinx_enet/xemac_options.o ../xilinx_enet/xemac_polled.o \
>> > 	  ../xilinx_enet/xemac_intr.o ../xilinx_enet/xemac_g.o \
>> > 	  ../xilinx_enet/xemac_intr_dma.o ../xilinx_iic/iic_adapter.o \
>> > 	  ../xilinx_iic/xiic_l.o ../common/xipif_v1_23_b.o \
>> > 	  ../common/xbasic_types.o ../common/xdma_channel.o \
>> > 	  ../common/xdma_channel_sg.o ../common/xpacket_fifo_v1_00_b.o \
>> > 	  ../common/xversion.o \
>>
>> You are talking about the current file "board/xilinx/ml300/Makefile", right?
>
>No, he must some obsolete version.

It is only part of Makefile. This is not obsolete version. 
Please look at [u-boot.git]/board/xilinx/ml300/Makefile

Best regards,
Michal Simek

[U-Boot-Users] xilinx drivers

[Wolfgang Denk]

In message <3217.5913-29012-2003177803-1174895860@seznam.cz> you wrote:
> 
> I think that this file isn't under GPL too. 
> Please look to git. This is not obsolete code.
> 
> /board/xilinx/ml300/xparameters.h

Yes, you are right. We already have licensing issues in some files
that need to be cleaned up urgently.

But this is not an argument to allow for adding to the existing mess.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lack of skill dictates economy of style.                - Joey Ramone

[U-Boot-Users] xilinx drivers

[Wolfgang Denk]

In message <3211.5908-32301-1640680331-1174897401@seznam.cz> you wrote:
>
> >> I would prefer something like:
> >> 
> >> drivers/net/xilinx_enet/*
> >> drivers/i2c/xilinx_iic/*
> >
> >Me too, except that we should remove the redundancy, i. e. plase make
> >this:
> >
> >	drivers/net/xilinx/*
> >	drivers/i2c/xilinx/*
> >
> >[Especially mixing i2c and iic in one path name looks pretty awkward
> >to me.]
> 
> OK a then /board/xilinx/common/.

No. The suggestion was to put this in

	drivers/net/xilinx/*
	drivers/i2c/xilinx/*
etc.

> >> > CFLAGS   += -I../ml300 -I../common -I../xilinx_enet -I../xilinx_iic
...
> It is only part of Makefile. This is not obsolete version. 
> Please look at [u-boot.git]/board/xilinx/ml300/Makefile

I do, and I see this:

	CFLAGS          += $(INCS)

Now compare with what you posted...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is is no reason for any individual to have a computer in  their
home.      -- Ken Olsen (President of Digital Equipment Corporation),
              Convention of the World Future Society, in Boston, 1977

[U-Boot-Users] xilinx drivers

[Grant Likely]

On 3/26/07, mONStR <Monstr@seznam.cz> wrote:
> Is it possible do this changes?
>
> And after that add support for other xilinx peripherals as SPI, EMACLITE, etc.
>
> Isn't it problem with Xilinx licence?

Latest code generated by the Xilinx EDK tools (at least for the Linux
BSP) are licensed under the GPL.  The old files can be replaced with
the newer ones if someone can take on the work.

However, I am concerned about the size/complexity of the Xilinx
supplied drivers.  The Xilinx drivers are designed to be cross
platform, and as such they carry with them a fair amount of
boilerplate and wrapping code to make it easy to adapt them to new
environments.  While this is a good approach for Xilinx to get
customers up and running quickly, I don't think it is appropriate for
code integrated into the u-boot tree (including the code already
there).  The extra wrapping code adds additional layers of redirection
and complexity that are not desireable within u-boot (and utterly
unnecessary; once the driver is ported to the u-boot environment, it
stays there.  The code no longer needs to compile in other
environments)

I think we can do better.

In particular, a UARTLITE driver is trivial to write.

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195

[U-Boot-Users] xilinx drivers

[Grant Likely]

On 3/26/07, Stefan Roese <sr@denx.de> wrote:
> On Monday 26 March 2007 08:10, mONStR wrote:
> > I would like to add xilinx drivers xilinx_enet and xilinx_iic to drivers
> > (drivers/xilinx/xilinx_enet and xilinx_iic) folder
>
> I would prefer something like:
>
> drivers/net/xilinx_enet/*
> drivers/i2c/xilinx_iic/*

I 100% agree

<snip>

> Yes, this is possible to change. This could definitely needs some cleanup.
>
> Maybe Grant wants to add some remarks here? Grant?

Yes, this stuff *absolutely* needs some clean up.  :-)

Nobody has taken it on just now, so feel free to start firing off patches.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195

[U-Boot-Users] xilinx drivers

[Michal Simek]

> In message <3217.5913-29012-2003177803-1174895860@seznam.cz> you wrote:
>> 
>> I think that this file isn't under GPL too. 
>> Please look to git. This is not obsolete code.
>> 
>> /board/xilinx/ml300/xparameters.h
> 
> Yes, you are right. We already have licensing issues in some files
> that need to be cleaned up urgently.

Yes, you are absolutely right.
 
> But this is not an argument to allow for adding to the existing mess.
> 
> Best regards,
> 
> Wolfgang Denk

I urgently resolve licencing issues in Microblaze code.

Best regards
Michal Simek

[U-Boot-Users] xilinx drivers

[Michal Simek]

Conclusion:

Rewrite xilinx drivers xilinx_enet and xilinx_iic to standart U-BOOT style 
and add this repair drivers to

drivers/net/xilinx/*
drivers/i2c/xilinx/*

and clean and remove Xilinx drivers for standalone application.
I will concern for it.

And Xilinx licence is compatible with GPL.

And automatic generation files are OK, if the licence is under GPL.

Best regards and thanks for your opinions.
Michal Simek