From: Martin Doucha <mdoucha@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/7] Add user/group ID lookup helper functions
Date: Mon, 6 Sep 2021 14:40:11 +0200 [thread overview]
Message-ID: <528952e4-bebf-617e-4d3f-0aea39797584@suse.cz> (raw)
Message-ID: <20210906124011.TW5uXkYLJQgdiSBZwjgdbPUW3Nn1d1d8heu9iDb2rx4@z> (raw)
In-Reply-To: <YTYH4DdeUqsYeglK@yuki>
On 06. 09. 21 14:21, Cyril Hrubis wrote:
> Hi!
>> + if (!ret) {
>> + if (errno) {
>> + tst_brk_(file, lineno, TBROK | TERRNO,
>> + "getpwent() failed");
>> + } else {
>> + tst_brk_(file, lineno, TBROK,
>> + "getpwent() failed: end of file");
>> + }
>
> I'm not sure if "no more users in the /etc/passwd" should be reported as
> an error.
The alternative would be that pretty much every test that calls
SAFE_GETPWENT() in setup() will need to check for NULL and explicitly
call tst_brk(). I don't see any use for allowing SAFE_GETPWENT() to
return NULL outside cleanup().
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-06 12:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 15:48 [LTP] [PATCH 0/7] UID/GID lookup fixes Martin Doucha
2021-09-03 15:48 ` [LTP] [PATCH 1/7] chmod05, fchmod05: Use free GID instead of "bin" group Martin Doucha
2021-09-06 12:20 ` Cyril Hrubis
2021-09-06 12:20 ` Cyril Hrubis
2021-09-03 15:48 ` [LTP] [PATCH 2/7] Simplify syscalls/mkdir02 Martin Doucha
2021-09-06 12:20 ` Cyril Hrubis
2021-09-06 12:20 ` Cyril Hrubis
2021-09-03 15:48 ` [LTP] [PATCH 3/7] Add user/group ID lookup helper functions Martin Doucha
2021-09-06 12:21 ` Cyril Hrubis
2021-09-06 12:21 ` Cyril Hrubis
2021-09-06 12:40 ` Martin Doucha [this message]
2021-09-06 12:40 ` Martin Doucha
2021-09-03 15:48 ` [LTP] [PATCH 4/7] syscalls/kill05: Use any two unprivileged users Martin Doucha
2021-09-06 12:28 ` Cyril Hrubis
2021-09-06 12:28 ` Cyril Hrubis
2021-09-06 12:47 ` Martin Doucha
2021-09-06 12:47 ` Martin Doucha
2021-09-06 12:50 ` Cyril Hrubis
2021-09-06 12:50 ` Cyril Hrubis
2021-09-06 13:01 ` Martin Doucha
2021-09-06 13:01 ` Martin Doucha
2021-09-06 13:05 ` Cyril Hrubis
2021-09-06 13:05 ` Cyril Hrubis
2021-09-06 13:27 ` Martin Doucha
2021-09-06 13:27 ` Martin Doucha
2021-09-06 13:02 ` Cyril Hrubis
2021-09-06 13:02 ` Cyril Hrubis
2021-09-03 15:48 ` [LTP] [PATCH 5/7] syscalls/mkdir04: Simplify test and use any existing users Martin Doucha
2021-09-03 15:48 ` [LTP] [PATCH 6/7] syscalls/setregid02-04: Simplify GID handling Martin Doucha
2021-09-03 15:48 ` [LTP] [PATCH 7/7] syscalls/setregid02-04: Eliminate named group lookups Martin Doucha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528952e4-bebf-617e-4d3f-0aea39797584@suse.cz \
--to=mdoucha@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.