[PATCH v2 06/20] ppp: slight optimization of addr compare

[PATCH v2 06/20] ppp: slight optimization of addr compare

[Ding Tianhong]

Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Michal Ostrowski <mostrows@earthlink.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
 drivers/net/ppp/pppoe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 82ee6ed..1808a10 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
 
 static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
 {
-	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
+	return a->sid == b->sid && ether_addr_equal(a->remote,
+							      b->remote);
 }
 
 static inline int cmp_addr(struct pppoe_addr *a, __be16 sid, char *addr)
 {
-	return a->sid == sid && !memcmp(a->remote, addr, ETH_ALEN);
+	return a->sid == sid && ether_addr_equal(a->remote, addr);
 }
 
 #if 8 % PPPOE_HASH_BITS
-- 
1.8.0

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

[Sergei Shtylyov]

Hello.

On 24-12-2013 15:28, Ding Tianhong wrote:

> Use possibly more efficient ether_addr_equal
> to instead of memcmp.

> Cc: Michal Ostrowski <mostrows@earthlink.net>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
> ---
>   drivers/net/ppp/pppoe.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> index 82ee6ed..1808a10 100644
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
>
>   static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
>   {
> -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
> +	return a->sid == b->sid && ether_addr_equal(a->remote,
> +							      b->remote);

    If it really doesn't fit insto single line, the continuation line should 
start right under 'a->remote'.

WBR, Sergei

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

[Joe Perches]

On Tue, 2013-12-24 at 20:24 +0400, Sergei Shtylyov wrote:
> On 24-12-2013 15:28, Ding Tianhong wrote:
[]
> > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
[]
> > @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
> >
> >   static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
> >   {
> > -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
> > +	return a->sid == b->sid && ether_addr_equal(a->remote,
> > +							      b->remote);
> 
>     If it really doesn't fit insto single line, the continuation line should 
> start right under 'a->remote'.

Better still might be

	return a->sid == b->sid &&
	       ether_addr_equal(a->remote, b->remote);

Re: [PATCH v2 06/20] ppp: slight optimization of addr compare

[Sergei Shtylyov]

Hello.

On 24-12-2013 20:35, Joe Perches wrote:

> []
>>> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> []
>>> @@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
>>>
>>>    static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
>>>    {
>>> -	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
>>> +	return a->sid == b->sid && ether_addr_equal(a->remote,
>>> +							      b->remote);

>>      If it really doesn't fit insto single line, the continuation line should
>> start right under 'a->remote'.

> Better still might be
>
> 	return a->sid == b->sid &&
> 	       ether_addr_equal(a->remote, b->remote);

    Actually, after the second look, I don't know why the line was broken at all.

WBR, Sergei