* [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table()
@ 2014-01-10 15:18 Jan Beulich
2014-01-10 16:31 ` Keir Fraser
2014-01-10 17:02 ` Tim Deegan
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2014-01-10 15:18 UTC (permalink / raw)
To: xen-devel; +Cc: Tim Deegan, CHENG Yueqiang, Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
Slot 0 got updated when slot 3 was meant. The mistake was hidden by
create_pae_xen_mappings() correcting things immediately afterwards
(i.e. before the new entries could get used the first time).
Reported-by: CHENG Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -1488,7 +1488,7 @@ static int alloc_l2_table(struct page_in
l2e_write(&pl2e[l2_table_offset(PERDOMAIN_VIRT_START) + i],
l2e_from_page(perdomain_pt_page(d, i),
__PAGE_HYPERVISOR));
- pl2e[l2_table_offset(LINEAR_PT_VIRT_START)] =
+ pl2e[l2_table_offset(LINEAR_PT_VIRT_START) + 3] =
l2e_from_pfn(pfn, __PAGE_HYPERVISOR);
#else
memcpy(&pl2e[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)],
[-- Attachment #2: ix86-linear-pt-construction.patch --]
[-- Type: text/plain, Size: 925 bytes --]
ix86: fix linear page table construction in alloc_l2_table()
Slot 0 got updated when slot 3 was meant. The mistake was hidden by
create_pae_xen_mappings() correcting things immediately afterwards
(i.e. before the new entries could get used the first time).
Reported-by: CHENG Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -1488,7 +1488,7 @@ static int alloc_l2_table(struct page_in
l2e_write(&pl2e[l2_table_offset(PERDOMAIN_VIRT_START) + i],
l2e_from_page(perdomain_pt_page(d, i),
__PAGE_HYPERVISOR));
- pl2e[l2_table_offset(LINEAR_PT_VIRT_START)] =
+ pl2e[l2_table_offset(LINEAR_PT_VIRT_START) + 3] =
l2e_from_pfn(pfn, __PAGE_HYPERVISOR);
#else
memcpy(&pl2e[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)],
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table()
2014-01-10 15:18 [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table() Jan Beulich
@ 2014-01-10 16:31 ` Keir Fraser
2014-01-10 17:02 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2014-01-10 16:31 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: CHENG Yueqiang, Tim Deegan
On 10/01/2014 15:18, "Jan Beulich" <JBeulich@suse.com> wrote:
> Slot 0 got updated when slot 3 was meant. The mistake was hidden by
> create_pae_xen_mappings() correcting things immediately afterwards
> (i.e. before the new entries could get used the first time).
>
> Reported-by: CHENG Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1488,7 +1488,7 @@ static int alloc_l2_table(struct page_in
> l2e_write(&pl2e[l2_table_offset(PERDOMAIN_VIRT_START) + i],
> l2e_from_page(perdomain_pt_page(d, i),
> __PAGE_HYPERVISOR));
> - pl2e[l2_table_offset(LINEAR_PT_VIRT_START)] =
> + pl2e[l2_table_offset(LINEAR_PT_VIRT_START) + 3] =
> l2e_from_pfn(pfn, __PAGE_HYPERVISOR);
> #else
> memcpy(&pl2e[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)],
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table()
2014-01-10 15:18 [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table() Jan Beulich
2014-01-10 16:31 ` Keir Fraser
@ 2014-01-10 17:02 ` Tim Deegan
1 sibling, 0 replies; 3+ messages in thread
From: Tim Deegan @ 2014-01-10 17:02 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, CHENG Yueqiang, Keir Fraser
At 15:18 +0000 on 10 Jan (1389363524), Jan Beulich wrote:
> Slot 0 got updated when slot 3 was meant. The mistake was hidden by
> create_pae_xen_mappings() correcting things immediately afterwards
> (i.e. before the new entries could get used the first time).
>
> Reported-by: CHENG Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Tim Deegan <tim@xen.org>
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1488,7 +1488,7 @@ static int alloc_l2_table(struct page_in
> l2e_write(&pl2e[l2_table_offset(PERDOMAIN_VIRT_START) + i],
> l2e_from_page(perdomain_pt_page(d, i),
> __PAGE_HYPERVISOR));
> - pl2e[l2_table_offset(LINEAR_PT_VIRT_START)] =
> + pl2e[l2_table_offset(LINEAR_PT_VIRT_START) + 3] =
> l2e_from_pfn(pfn, __PAGE_HYPERVISOR);
> #else
> memcpy(&pl2e[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)],
>
>
>
> ix86: fix linear page table construction in alloc_l2_table()
>
> Slot 0 got updated when slot 3 was meant. The mistake was hidden by
> create_pae_xen_mappings() correcting things immediately afterwards
> (i.e. before the new entries could get used the first time).
>
> Reported-by: CHENG Yueqiang <yqcheng.2008@phdis.smu.edu.sg>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -1488,7 +1488,7 @@ static int alloc_l2_table(struct page_in
> l2e_write(&pl2e[l2_table_offset(PERDOMAIN_VIRT_START) + i],
> l2e_from_page(perdomain_pt_page(d, i),
> __PAGE_HYPERVISOR));
> - pl2e[l2_table_offset(LINEAR_PT_VIRT_START)] =
> + pl2e[l2_table_offset(LINEAR_PT_VIRT_START) + 3] =
> l2e_from_pfn(pfn, __PAGE_HYPERVISOR);
> #else
> memcpy(&pl2e[COMPAT_L2_PAGETABLE_FIRST_XEN_SLOT(d)],
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-10 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-10 15:18 [PATCH 4.2] ix86: fix linear page table construction in alloc_l2_table() Jan Beulich
2014-01-10 16:31 ` Keir Fraser
2014-01-10 17:02 ` Tim Deegan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.