All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
@ 2014-01-26 10:53 ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-26 10:53 UTC (permalink / raw)
  To: Felix Fietkau, John W. Linville, QCA ath9k Development
  Cc: linux-wireless, ath9k-devel, netdev, linux-kernel, Geert Uytterhoeven

drivers/net/wireless/ath/ath9k/main.c: In function ‘ath9k_has_tx_pending’:
drivers/net/wireless/ath/ath9k/main.c:1869: warning: ‘npend’ may be used uninitialized in this function

Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
optimize ath9k_flush").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
This doesn't look like a false positive to me

 drivers/net/wireless/ath/ath9k/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 5924f72dd493..f08d5051c13f 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1866,7 +1866,7 @@ static void ath9k_set_coverage_class(struct ieee80211_hw *hw, u8 coverage_class)
 
 static bool ath9k_has_tx_pending(struct ath_softc *sc)
 {
-	int i, npend;
+	int i, npend = 0;
 
 	for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++) {
 		if (!ATH_TXQ_SETUP(sc, i))
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
@ 2014-01-26 10:53 ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-26 10:53 UTC (permalink / raw)
  To: Felix Fietkau, John W. Linville, QCA ath9k Development
  Cc: linux-wireless, ath9k-devel, netdev, linux-kernel, Geert Uytterhoeven

drivers/net/wireless/ath/ath9k/main.c: In function ‘ath9k_has_tx_pending’:
drivers/net/wireless/ath/ath9k/main.c:1869: warning: ‘npend’ may be used uninitialized in this function

Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
optimize ath9k_flush").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
This doesn't look like a false positive to me

 drivers/net/wireless/ath/ath9k/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 5924f72dd493..f08d5051c13f 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1866,7 +1866,7 @@ static void ath9k_set_coverage_class(struct ieee80211_hw *hw, u8 coverage_class)
 
 static bool ath9k_has_tx_pending(struct ath_softc *sc)
 {
-	int i, npend;
+	int i, npend = 0;
 
 	for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++) {
 		if (!ATH_TXQ_SETUP(sc, i))
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
@ 2014-01-26 10:53 ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2014-01-26 10:53 UTC (permalink / raw)
  To: ath9k-devel

drivers/net/wireless/ath/ath9k/main.c: In function ?ath9k_has_tx_pending?:
drivers/net/wireless/ath/ath9k/main.c:1869: warning: ?npend? may be used uninitialized in this function

Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
optimize ath9k_flush").

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
This doesn't look like a false positive to me

 drivers/net/wireless/ath/ath9k/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 5924f72dd493..f08d5051c13f 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1866,7 +1866,7 @@ static void ath9k_set_coverage_class(struct ieee80211_hw *hw, u8 coverage_class)
 
 static bool ath9k_has_tx_pending(struct ath_softc *sc)
 {
-	int i, npend;
+	int i, npend = 0;
 
 	for (i = 0; i < ATH9K_NUM_TX_QUEUES; i++) {
 		if (!ATH_TXQ_SETUP(sc, i))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
  2014-01-26 10:53 ` Geert Uytterhoeven
  (?)
@ 2014-01-30  6:55   ` Felix Fietkau
  -1 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2014-01-30  6:55 UTC (permalink / raw)
  To: Geert Uytterhoeven, John W. Linville, QCA ath9k Development
  Cc: linux-wireless, ath9k-devel, netdev, linux-kernel

On 2014-01-26 11:53, Geert Uytterhoeven wrote:
> drivers/net/wireless/ath/ath9k/main.c: In function ‘ath9k_has_tx_pending’:
> drivers/net/wireless/ath/ath9k/main.c:1869: warning: ‘npend’ may be used uninitialized in this function
> 
> Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
> optimize ath9k_flush").
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Felix Fietkau <nbd@openwrt.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
@ 2014-01-30  6:55   ` Felix Fietkau
  0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2014-01-30  6:55 UTC (permalink / raw)
  To: Geert Uytterhoeven, John W. Linville, QCA ath9k Development
  Cc: linux-wireless, ath9k-devel, netdev, linux-kernel

On 2014-01-26 11:53, Geert Uytterhoeven wrote:
> drivers/net/wireless/ath/ath9k/main.c: In function ‘ath9k_has_tx_pending’:
> drivers/net/wireless/ath/ath9k/main.c:1869: warning: ‘npend’ may be used uninitialized in this function
> 
> Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
> optimize ath9k_flush").
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Felix Fietkau <nbd@openwrt.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [ath9k-devel] [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending()
@ 2014-01-30  6:55   ` Felix Fietkau
  0 siblings, 0 replies; 6+ messages in thread
From: Felix Fietkau @ 2014-01-30  6:55 UTC (permalink / raw)
  To: ath9k-devel

On 2014-01-26 11:53, Geert Uytterhoeven wrote:
> drivers/net/wireless/ath/ath9k/main.c: In function ?ath9k_has_tx_pending?:
> drivers/net/wireless/ath/ath9k/main.c:1869: warning: ?npend? may be used uninitialized in this function
> 
> Introduced by commit 10e2318103f5941aa70c318afe34bc41f1b98529 ("ath9k:
> optimize ath9k_flush").
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Felix Fietkau <nbd@openwrt.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-30  6:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-26 10:53 [PATCH] ath9k: Fix uninitialized variable in ath9k_has_tx_pending() Geert Uytterhoeven
2014-01-26 10:53 ` [ath9k-devel] " Geert Uytterhoeven
2014-01-26 10:53 ` Geert Uytterhoeven
2014-01-30  6:55 ` Felix Fietkau
2014-01-30  6:55   ` [ath9k-devel] " Felix Fietkau
2014-01-30  6:55   ` Felix Fietkau

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.