From: Kukjin Kim <kgene.kim@samsung.com> To: Mark Rutland <mark.rutland@arm.com> Cc: Kukjin Kim <kgene.kim@samsung.com>, Ilho Lee <ilho215.lee@samsung.com>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Thomas Abraham <thomas.ab@samsung.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Catalin Marinas <Catalin.Marinas@arm.com> Subject: Re: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board Date: Tue, 11 Feb 2014 12:16:26 +0900 [thread overview] Message-ID: <52F9960A.2090802@samsung.com> (raw) In-Reply-To: <20140211181529.GC15200@e106331-lin.cambridge.arm.com> On 02/12/14 03:15, Mark Rutland wrote: > On Tue, Feb 11, 2014 at 06:29:41AM +0000, Kukjin Kim wrote: >> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com> >> Reviewed-by: Thomas Abraham<thomas.ab@samsung.com> >> Cc: Catalin Marinas<catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ >> 2 files changed, 134 insertions(+) >> create mode 100644 arch/arm64/boot/dts/samsung-gh7.dtsi >> create mode 100644 arch/arm64/boot/dts/samsung-ssdk-gh7.dts >> >> diff --git a/arch/arm64/boot/dts/samsung-gh7.dtsi b/arch/arm64/boot/dts/samsung-gh7.dtsi >> new file mode 100644 >> index 0000000..5b8785c >> --- /dev/null >> +++ b/arch/arm64/boot/dts/samsung-gh7.dtsi >> @@ -0,0 +1,108 @@ >> +/* >> + * SAMSUNG GH7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +/dts-v1/; >> + >> +/memreserve/ 0x80000000 0x0C400000; > > That looks _very_ large. What is this for? > Yes, I know but we need to reserve that for EL3 monitor, UEFI services, secure, hypervisor and scan chanin... > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts =<1 13 0xff01>, /* Secure Phys IRQ */ >> + <1 14 0xff01>, /* Non-secure Phys IRQ */ >> + <1 11 0xff01>, /* Virt IRQ */ >> + <1 10 0xff01>; /* Hyp IRQ */ >> + clock-frequency =<100000000>; > > Please, get your bootloader to set CNTFREQ. The clock frequency property > for the timer node is a horrible hack for buggy firmware. > You're right. OK. > [...] > >> + amba { >> + compatible = "arm,amba-bus"; >> + #address-cells =<1>; >> + #size-cells =<1>; >> + ranges; >> + >> + serial@12c00000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg =<0x12c00000 0x10000>; >> + interrupts =<418>; >> + }; >> + >> + serial@12c20000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg =<0x12c20000 0x10000>; >> + interrupts =<420>; >> + }; > > Don't these need clocks? > We don't need and the clocks will be handled by bootloader... > [...] > >> + memory@80000000 { >> + device_type = "memory"; >> + reg =<0x00000000 0x80000000 0 0x80000000>; > > Minor nit, but it would be nice for the 0 values to be consistently padded. > OK. Thanks, Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board Date: Tue, 11 Feb 2014 12:16:26 +0900 [thread overview] Message-ID: <52F9960A.2090802@samsung.com> (raw) In-Reply-To: <20140211181529.GC15200@e106331-lin.cambridge.arm.com> On 02/12/14 03:15, Mark Rutland wrote: > On Tue, Feb 11, 2014 at 06:29:41AM +0000, Kukjin Kim wrote: >> Signed-off-by: Kukjin Kim<kgene.kim@samsung.com> >> Reviewed-by: Thomas Abraham<thomas.ab@samsung.com> >> Cc: Catalin Marinas<catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/samsung-gh7.dtsi | 108 ++++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/samsung-ssdk-gh7.dts | 26 +++++++ >> 2 files changed, 134 insertions(+) >> create mode 100644 arch/arm64/boot/dts/samsung-gh7.dtsi >> create mode 100644 arch/arm64/boot/dts/samsung-ssdk-gh7.dts >> >> diff --git a/arch/arm64/boot/dts/samsung-gh7.dtsi b/arch/arm64/boot/dts/samsung-gh7.dtsi >> new file mode 100644 >> index 0000000..5b8785c >> --- /dev/null >> +++ b/arch/arm64/boot/dts/samsung-gh7.dtsi >> @@ -0,0 +1,108 @@ >> +/* >> + * SAMSUNG GH7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +/dts-v1/; >> + >> +/memreserve/ 0x80000000 0x0C400000; > > That looks _very_ large. What is this for? > Yes, I know but we need to reserve that for EL3 monitor, UEFI services, secure, hypervisor and scan chanin... > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts =<1 13 0xff01>, /* Secure Phys IRQ */ >> + <1 14 0xff01>, /* Non-secure Phys IRQ */ >> + <1 11 0xff01>, /* Virt IRQ */ >> + <1 10 0xff01>; /* Hyp IRQ */ >> + clock-frequency =<100000000>; > > Please, get your bootloader to set CNTFREQ. The clock frequency property > for the timer node is a horrible hack for buggy firmware. > You're right. OK. > [...] > >> + amba { >> + compatible = "arm,amba-bus"; >> + #address-cells =<1>; >> + #size-cells =<1>; >> + ranges; >> + >> + serial at 12c00000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg =<0x12c00000 0x10000>; >> + interrupts =<418>; >> + }; >> + >> + serial at 12c20000 { >> + compatible = "arm,pl011", "arm,primecell"; >> + reg =<0x12c20000 0x10000>; >> + interrupts =<420>; >> + }; > > Don't these need clocks? > We don't need and the clocks will be handled by bootloader... > [...] > >> + memory at 80000000 { >> + device_type = "memory"; >> + reg =<0x00000000 0x80000000 0 0x80000000>; > > Minor nit, but it would be nice for the 0 values to be consistently padded. > OK. Thanks, Kukjin
next prev parent reply other threads:[~2014-02-13 1:20 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-11 6:29 [PATCH 0/3] arm64: add new support Samsung GH7 SoC and SSDK board Kukjin Kim 2014-02-11 6:29 ` Kukjin Kim 2014-02-11 6:29 ` [PATCH 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board Kukjin Kim 2014-02-11 6:29 ` Kukjin Kim 2014-02-11 18:15 ` Mark Rutland 2014-02-11 18:15 ` Mark Rutland 2014-02-11 3:16 ` Kukjin Kim [this message] 2014-02-11 3:16 ` Kukjin Kim 2014-02-18 10:30 ` Mark Rutland 2014-02-18 10:30 ` Mark Rutland 2014-02-24 23:56 ` Kukjin Kim 2014-02-24 23:56 ` Kukjin Kim 2014-02-11 23:36 ` Olof Johansson 2014-02-11 23:36 ` Olof Johansson 2014-02-11 3:25 ` Kukjin Kim 2014-02-11 3:25 ` Kukjin Kim 2014-02-12 11:13 ` Marc Zyngier 2014-02-12 11:13 ` Marc Zyngier 2014-02-12 11:29 ` Mark Rutland 2014-02-12 11:29 ` Mark Rutland 2014-02-12 11:40 ` Marc Zyngier 2014-02-12 11:40 ` Marc Zyngier 2014-02-11 3:03 ` Kukjin Kim 2014-02-11 3:03 ` Kukjin Kim 2014-02-11 6:29 ` [PATCH 2/3] arm64: Add Kconfig option for Samsung GH7 SoC family Kukjin Kim 2014-02-11 6:29 ` Kukjin Kim 2014-02-11 23:39 ` Olof Johansson 2014-02-11 23:39 ` Olof Johansson 2014-02-12 10:38 ` Catalin Marinas 2014-02-12 10:38 ` Catalin Marinas 2014-02-12 16:25 ` Kumar Gala 2014-02-12 16:25 ` Kumar Gala 2014-02-12 18:12 ` Catalin Marinas 2014-02-12 18:12 ` Catalin Marinas 2014-02-12 19:04 ` Kumar Gala 2014-02-12 19:04 ` Kumar Gala 2014-02-12 19:14 ` Arnd Bergmann 2014-02-12 19:14 ` Arnd Bergmann 2014-02-11 2:52 ` Kukjin Kim 2014-02-11 2:52 ` Kukjin Kim 2014-02-13 19:26 ` Olof Johansson 2014-02-13 19:26 ` Olof Johansson 2014-02-14 17:06 ` Arnd Bergmann 2014-02-14 17:06 ` Arnd Bergmann 2014-02-18 1:10 ` Kukjin Kim 2014-02-18 1:10 ` Kukjin Kim 2014-02-18 10:53 ` Arnd Bergmann 2014-02-18 10:53 ` Arnd Bergmann 2014-02-18 16:16 ` Olof Johansson 2014-02-18 16:16 ` Olof Johansson 2014-02-18 18:13 ` Arnd Bergmann 2014-02-18 18:13 ` Arnd Bergmann 2014-02-18 19:52 ` John Stultz 2014-02-18 19:52 ` John Stultz 2014-02-18 20:00 ` Olof Johansson 2014-02-18 20:00 ` Olof Johansson 2014-02-18 20:06 ` John Stultz 2014-02-18 20:06 ` John Stultz 2014-02-20 9:03 ` Olof Johansson 2014-02-20 9:03 ` Olof Johansson 2014-02-20 11:22 ` Catalin Marinas 2014-02-20 11:22 ` Catalin Marinas 2014-02-20 12:07 ` Arnd Bergmann 2014-02-20 12:07 ` Arnd Bergmann 2014-02-20 17:09 ` Olof Johansson 2014-02-20 17:09 ` Olof Johansson 2014-02-20 18:58 ` Catalin Marinas 2014-02-20 18:58 ` Catalin Marinas 2014-02-25 0:19 ` Kukjin Kim 2014-02-25 0:19 ` Kukjin Kim 2014-02-25 0:20 ` Kukjin Kim 2014-02-25 0:20 ` Kukjin Kim 2014-02-25 0:10 ` Kukjin Kim 2014-02-25 0:10 ` Kukjin Kim 2014-02-18 16:40 ` Catalin Marinas 2014-02-18 16:40 ` Catalin Marinas 2014-02-13 20:08 ` Rob Herring 2014-02-13 20:08 ` Rob Herring 2014-02-13 20:19 ` Olof Johansson 2014-02-13 20:19 ` Olof Johansson 2014-02-11 6:29 ` [PATCH 3/3] Documentation: DT: add new entry for Samsung GH7 SoC and SSDK board Kukjin Kim 2014-02-11 6:29 ` Kukjin Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=52F9960A.2090802@samsung.com \ --to=kgene.kim@samsung.com \ --cc=Catalin.Marinas@arm.com \ --cc=ilho215.lee@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=thomas.ab@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.