All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon: (lm95245) Avoid initializing the same field twice
@ 2014-02-12  9:05 Jean Delvare
  2014-02-12 11:25 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2014-02-12  9:05 UTC (permalink / raw)
  To: lm-sensors

data is kzalloc'd, so data->valid is already 0.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
 drivers/hwmon/lm95245.c |    1 -
 1 file changed, 1 deletion(-)

--- linux-3.14-rc1.orig/drivers/hwmon/lm95245.c	2014-02-12 09:47:05.791692082 +0100
+++ linux-3.14-rc1/drivers/hwmon/lm95245.c	2014-02-12 09:47:38.143402204 +0100
@@ -447,7 +447,6 @@ static int lm95245_detect(struct i2c_cli
 static void lm95245_init_client(struct i2c_client *client,
 				struct lm95245_data *data)
 {
-	data->valid = 0;
 	data->interval = lm95245_read_conversion_rate(client);
 
 	data->config1 = i2c_smbus_read_byte_data(client,


-- 
Jean Delvare
Suse L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: (lm95245) Avoid initializing the same field twice
  2014-02-12  9:05 [lm-sensors] [PATCH] hwmon: (lm95245) Avoid initializing the same field twice Jean Delvare
@ 2014-02-12 11:25 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2014-02-12 11:25 UTC (permalink / raw)
  To: lm-sensors

On 02/12/2014 01:05 AM, Jean Delvare wrote:
> data is kzalloc'd, so data->valid is already 0.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>

Thanks, applied.

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-12 11:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-12  9:05 [lm-sensors] [PATCH] hwmon: (lm95245) Avoid initializing the same field twice Jean Delvare
2014-02-12 11:25 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.