From: Gu Zheng <guz.fnst@cn.fujitsu.com> To: Andrey Tsyvarev <tsyvarev@ispras.ru> Cc: jaegeuk.kim@samsung.com, linux-kernel <linux-kernel@vger.kernel.org>, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall Date: Thu, 13 Feb 2014 17:48:00 +0800 [thread overview] Message-ID: <52FC94D0.2050705@cn.fujitsu.com> (raw) In-Reply-To: <52FC9315.2090707@ispras.ru> Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > Hi, > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path >> of init_inode_metadata? >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index e095a4f..d5a2c9e 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/dir.c >> @@ -375,6 +375,7 @@ put_error: >> /* once the failed inode becomes a bad inode, i_mode is S_IFREG */ >> truncate_inode_pages(&inode->i_data, 0); >> truncate_blocks(inode, 0); >> + remove_dirty_dir_inode(inode); >> error: >> remove_inode_page(inode); >> return ERR_PTR(err); > Yes, i have tested that case. Fail in init_inode_metadata has been processed correctly. Thanks. If no other regressions, maybe you can send out the fix patch about this issue.:) Thanks, Gu >
WARNING: multiple messages have this Message-ID (diff)
From: Gu Zheng <guz.fnst@cn.fujitsu.com> To: Andrey Tsyvarev <tsyvarev@ispras.ru> Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-f2fs-devel@lists.sourceforge.net Subject: Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall Date: Thu, 13 Feb 2014 17:48:00 +0800 [thread overview] Message-ID: <52FC94D0.2050705@cn.fujitsu.com> (raw) In-Reply-To: <52FC9315.2090707@ispras.ru> Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > Hi, > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path >> of init_inode_metadata? >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index e095a4f..d5a2c9e 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/dir.c >> @@ -375,6 +375,7 @@ put_error: >> /* once the failed inode becomes a bad inode, i_mode is S_IFREG */ >> truncate_inode_pages(&inode->i_data, 0); >> truncate_blocks(inode, 0); >> + remove_dirty_dir_inode(inode); >> error: >> remove_inode_page(inode); >> return ERR_PTR(err); > Yes, i have tested that case. Fail in init_inode_metadata has been processed correctly. Thanks. If no other regressions, maybe you can send out the fix patch about this issue.:) Thanks, Gu > ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2014-02-13 9:56 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-06 5:43 f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall Andrey Tsyvarev 2014-02-06 5:43 ` Andrey Tsyvarev 2014-02-06 6:02 ` Jaegeuk Kim 2014-02-06 6:02 ` Jaegeuk Kim 2014-02-06 12:17 ` Andrey Tsyvarev 2014-02-06 12:17 ` Andrey Tsyvarev 2014-02-07 0:49 ` Jaegeuk Kim 2014-02-07 5:12 ` [f2fs-dev] " Jaegeuk Kim 2014-02-07 5:12 ` Jaegeuk Kim 2014-02-11 8:29 ` [f2fs-dev] " Andrey Tsyvarev 2014-02-11 8:29 ` Andrey Tsyvarev 2014-02-13 8:32 ` [f2fs-dev] " Gu Zheng 2014-02-13 8:32 ` Gu Zheng 2014-02-13 9:40 ` [f2fs-dev] " Andrey Tsyvarev 2014-02-13 9:40 ` Andrey Tsyvarev 2014-02-13 9:48 ` Gu Zheng [this message] 2014-02-13 9:48 ` Gu Zheng 2014-02-14 2:00 ` [f2fs-dev] " Jaegeuk Kim 2014-02-14 1:58 ` Jaegeuk Kim 2014-02-14 1:58 ` Jaegeuk Kim 2014-04-14 11:12 ` f2fs: BUG_ON() is triggered when mount valid f2fs filesystem Andrey Tsyvarev 2014-04-15 11:04 ` Jaegeuk Kim 2014-04-15 11:04 ` Jaegeuk Kim 2014-04-16 9:11 ` Andrey Tsyvarev 2014-04-16 9:11 ` Andrey Tsyvarev 2014-04-16 23:35 ` Jaegeuk Kim 2014-04-16 23:35 ` Jaegeuk Kim 2014-04-17 1:11 ` Alexey Khoroshilov 2014-04-17 1:11 ` Alexey Khoroshilov 2014-04-17 7:45 ` Jaegeuk Kim 2014-04-17 7:45 ` Jaegeuk Kim 2014-04-18 6:04 ` Alexey Khoroshilov 2014-04-18 6:04 ` Alexey Khoroshilov 2014-04-18 6:35 ` Jaegeuk Kim 2014-04-18 6:35 ` Jaegeuk Kim 2014-04-18 6:40 ` Gu Zheng 2014-04-18 6:40 ` Gu Zheng 2014-07-21 10:56 ` f2fs: Possible use-after-free when umount filesystem Andrey Tsyvarev 2014-07-21 11:09 ` Fwd: " Andrey Tsyvarev 2014-07-22 2:17 ` Gu Zheng 2014-07-22 2:17 ` Gu Zheng 2014-07-22 10:04 ` Andrey Tsyvarev 2014-07-22 10:04 ` Andrey Tsyvarev 2014-07-23 2:12 ` [f2fs-dev] " Chao Yu 2014-07-23 2:12 ` Chao Yu 2014-07-23 3:39 ` [f2fs-dev] " Gu Zheng 2014-07-23 3:39 ` Gu Zheng 2014-07-24 10:14 ` Andrey Tsyvarev 2014-07-24 10:14 ` Andrey Tsyvarev 2014-07-25 3:22 ` [f2fs-dev] " Chao Yu 2014-07-25 3:22 ` Chao Yu 2014-07-25 5:49 ` [f2fs-dev] " Gu Zheng 2014-07-25 5:49 ` Gu Zheng 2014-07-25 15:37 ` [f2fs-dev] " Jaegeuk Kim 2014-07-25 15:37 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=52FC94D0.2050705@cn.fujitsu.com \ --to=guz.fnst@cn.fujitsu.com \ --cc=jaegeuk.kim@samsung.com \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ --cc=tsyvarev@ispras.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.