* [PATCH] hwmon: (ntc_thermistor): Avoid overflow
@ 2014-02-13 22:39 ` Doug Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2014-02-13 22:39 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare; +Cc: Doug Anderson, lm-sensors, linux-kernel
The ntc thermistor code was doing math whose temporary result might
have overflowed 32-bits. We need some casts in there to make it safe.
In one example I found:
- pullup_uV: 1800000
- result of iio_read_channel_raw: 3226
- 1800000 * 3226 => 0x15a1cbc80
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/hwmon/ntc_thermistor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8c23203..8a17f01 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -145,7 +145,7 @@ struct ntc_data {
static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
{
struct iio_channel *channel = pdata->chan;
- unsigned int result;
+ s64 result;
int val, ret;
ret = iio_read_channel_raw(channel, &val);
@@ -155,10 +155,10 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
}
/* unit: mV */
- result = pdata->pullup_uv * val;
+ result = pdata->pullup_uv * (s64) val;
result >>= 12;
- return result;
+ return (int)result;
}
static const struct of_device_id ntc_match[] = {
--
1.9.0.rc1.175.g0b1dcb5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [lm-sensors] [PATCH] hwmon: (ntc_thermistor): Avoid overflow
@ 2014-02-13 22:39 ` Doug Anderson
0 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2014-02-13 22:39 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare; +Cc: Doug Anderson, lm-sensors, linux-kernel
The ntc thermistor code was doing math whose temporary result might
have overflowed 32-bits. We need some casts in there to make it safe.
In one example I found:
- pullup_uV: 1800000
- result of iio_read_channel_raw: 3226
- 1800000 * 3226 => 0x15a1cbc80
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/hwmon/ntc_thermistor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 8c23203..8a17f01 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -145,7 +145,7 @@ struct ntc_data {
static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
{
struct iio_channel *channel = pdata->chan;
- unsigned int result;
+ s64 result;
int val, ret;
ret = iio_read_channel_raw(channel, &val);
@@ -155,10 +155,10 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
}
/* unit: mV */
- result = pdata->pullup_uv * val;
+ result = pdata->pullup_uv * (s64) val;
result >>= 12;
- return result;
+ return (int)result;
}
static const struct of_device_id ntc_match[] = {
--
1.9.0.rc1.175.g0b1dcb5
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (ntc_thermistor): Avoid overflow
2014-02-13 22:39 ` [lm-sensors] " Doug Anderson
@ 2014-02-14 2:51 ` Guenter Roeck
-1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-02-14 2:51 UTC (permalink / raw)
To: Doug Anderson, Jean Delvare; +Cc: lm-sensors, linux-kernel
On 02/13/2014 02:39 PM, Doug Anderson wrote:
> The ntc thermistor code was doing math whose temporary result might
> have overflowed 32-bits. We need some casts in there to make it safe.
>
> In one example I found:
> - pullup_uV: 1800000
> - result of iio_read_channel_raw: 3226
> - 1800000 * 3226 => 0x15a1cbc80
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Nice catch. Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] hwmon: (ntc_thermistor): Avoid overflow
@ 2014-02-14 2:51 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-02-14 2:51 UTC (permalink / raw)
To: Doug Anderson, Jean Delvare; +Cc: lm-sensors, linux-kernel
On 02/13/2014 02:39 PM, Doug Anderson wrote:
> The ntc thermistor code was doing math whose temporary result might
> have overflowed 32-bits. We need some casts in there to make it safe.
>
> In one example I found:
> - pullup_uV: 1800000
> - result of iio_read_channel_raw: 3226
> - 1800000 * 3226 => 0x15a1cbc80
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Nice catch. Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-14 2:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-13 22:39 [PATCH] hwmon: (ntc_thermistor): Avoid overflow Doug Anderson
2014-02-13 22:39 ` [lm-sensors] " Doug Anderson
2014-02-14 2:51 ` Guenter Roeck
2014-02-14 2:51 ` [lm-sensors] " Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.