All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Michal Simek <michal.simek@xilinx.com>,
	alexandre.torgue@foss.st.com,
	Collabora Kernel ML <kernel@collabora.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Marek Vasut <marex@denx.de>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml
Date: Wed, 23 Jun 2021 08:11:51 +0200	[thread overview]
Message-ID: <52caf3779aa5b764bf193264cd5c5b8a542dea0a.camel@collabora.com> (raw)
In-Reply-To: <YMxekschULB87LKa@pendragon.ideasonboard.com>

Hi,
 
> On Fri, Jun 18, 2021 at 09:55:38AM +0200, Geert Uytterhoeven wrote:
> > This causes lots of failures like:
> > 
> >     arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dt.yaml: hdmi@39:
> > 'avdd-supply' is a required property
> > 
> > Should all supplies be required?
> > Looking at the driver, missing supplies are automatically replaced by
> > dummy regulators by the regulator framework.
> 
> Generally speaking, I like DT bindings to be descriptive of the
> hardware, and thus require power supplies that are needed for the device
> to function, even if they are fixed supplies.
> 
> This being said, I think there's also room to group some power supplies
> together in the bindings, when they are not meant by the device to be
> controlled separately. In this specific case, we also need to take into
> account that the adv7511 and adv7533 have different supplies.

Thanks for the review, guys. Yes, there were some dtbs check warnings to
be expected, the consensus in a previous version of the patch was that
that shouldn't be a blocker for a binding conversion and that the *.dts
definitions should eventually be fixed to comply with the binding, which
is, IMO, a more reasonable process to keep the binding conversion
effort progressing.

Cheers,
Ricardo



WARNING: multiple messages have this Message-ID (diff)
From: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Michal Simek <michal.simek@xilinx.com>,
	alexandre.torgue@foss.st.com,
	Collabora Kernel ML <kernel@collabora.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Marek Vasut <marex@denx.de>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml
Date: Wed, 23 Jun 2021 08:11:51 +0200	[thread overview]
Message-ID: <52caf3779aa5b764bf193264cd5c5b8a542dea0a.camel@collabora.com> (raw)
In-Reply-To: <YMxekschULB87LKa@pendragon.ideasonboard.com>

Hi,
 
> On Fri, Jun 18, 2021 at 09:55:38AM +0200, Geert Uytterhoeven wrote:
> > This causes lots of failures like:
> > 
> >     arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dt.yaml: hdmi@39:
> > 'avdd-supply' is a required property
> > 
> > Should all supplies be required?
> > Looking at the driver, missing supplies are automatically replaced by
> > dummy regulators by the regulator framework.
> 
> Generally speaking, I like DT bindings to be descriptive of the
> hardware, and thus require power supplies that are needed for the device
> to function, even if they are fixed supplies.
> 
> This being said, I think there's also room to group some power supplies
> together in the bindings, when they are not meant by the device to be
> controlled separately. In this specific case, we also need to take into
> account that the adv7511 and adv7533 have different supplies.

Thanks for the review, guys. Yes, there were some dtbs check warnings to
be expected, the consensus in a previous version of the patch was that
that shouldn't be a blocker for a binding conversion and that the *.dts
definitions should eventually be fixed to comply with the binding, which
is, IMO, a more reasonable process to keep the binding conversion
effort progressing.

Cheers,
Ricardo



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-23  6:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 13:13 [RESEND PATCH v4 0/3] Convert adi,adv7511.txt DT bindings to yaml Ricardo Cañuelo
2021-06-15 13:13 ` Ricardo Cañuelo
2021-06-15 13:13 ` [RESEND PATCH v4 1/3] ARM: dts: zynq: add port definitions to hdmi-tx@39 Ricardo Cañuelo
2021-06-15 13:13   ` Ricardo Cañuelo
2021-06-15 13:13 ` [RESEND PATCH v4 2/3] ARM: dts: stm32: make hdmi-transmitter node compliant with DT bindings Ricardo Cañuelo
2021-06-15 13:13   ` Ricardo Cañuelo
2021-06-15 13:13 ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: convert to yaml Ricardo Cañuelo
2021-06-15 13:13   ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi, adv7511.txt: " Ricardo Cañuelo
2021-06-17 14:46   ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: " Rob Herring
2021-06-17 14:46     ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi, adv7511.txt: " Rob Herring
2021-06-18  7:55   ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: " Geert Uytterhoeven
2021-06-18  7:55     ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi, adv7511.txt: " Geert Uytterhoeven
2021-06-18  8:51     ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: " Laurent Pinchart
2021-06-18  8:51       ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi, adv7511.txt: " Laurent Pinchart
2021-06-23  6:11       ` Ricardo Cañuelo [this message]
2021-06-23  6:11         ` [RESEND PATCH v4 3/3] dt-bindings: drm: bridge: adi,adv7511.txt: " Ricardo Cañuelo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52caf3779aa5b764bf193264cd5c5b8a542dea0a.camel@collabora.com \
    --to=ricardo.canuelo@collabora.com \
    --cc=airlied@linux.ie \
    --cc=alexandre.torgue@foss.st.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.