* [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15
@ 2016-09-02 18:51 Nishanth Menon
2016-09-02 19:08 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nishanth Menon @ 2016-09-02 18:51 UTC (permalink / raw)
To: u-boot
When beagleboard-X15 is booted, we see the following log:
Unidentified board claims BBRDX15_ in eeprom header
This is because of the missing check for x15 (the default) and reports
an error for a valid board configuration. Fix the same.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Changes since V1:
- move the x15 check higher up in the list.
V1: https://patchwork.ozlabs.org/patch/665144/
board/ti/am57xx/board.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
index 927d1364fe46..64de60254136 100644
--- a/board/ti/am57xx/board.c
+++ b/board/ti/am57xx/board.c
@@ -338,7 +338,9 @@ static void setup_board_eeprom_env(void)
if (rc)
goto invalid_eeprom;
- if (board_is_am572x_evm())
+ if (board_is_x15())
+ name = "beagle_x15";
+ else if (board_is_am572x_evm())
name = "am57xx_evm";
else if (board_is_am572x_idk())
name = "am572x_idk";
--
2.9.1.200.gb1ec08f
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15
2016-09-02 18:51 [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15 Nishanth Menon
@ 2016-09-02 19:08 ` Tom Rini
2016-09-03 16:54 ` Lokesh Vutla
2016-09-07 18:00 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-09-02 19:08 UTC (permalink / raw)
To: u-boot
On Fri, Sep 02, 2016 at 01:51:33PM -0500, Nishanth Menon wrote:
> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
>
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160902/15ad57f4/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15
2016-09-02 18:51 [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15 Nishanth Menon
2016-09-02 19:08 ` Tom Rini
@ 2016-09-03 16:54 ` Lokesh Vutla
2016-09-07 18:00 ` [U-Boot] [U-Boot, " Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Lokesh Vutla @ 2016-09-03 16:54 UTC (permalink / raw)
To: u-boot
On Saturday 03 September 2016 12:21 AM, Nishanth Menon wrote:
> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
>
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
> ---
> Changes since V1:
> - move the x15 check higher up in the list.
>
> V1: https://patchwork.ozlabs.org/patch/665144/
>
> board/ti/am57xx/board.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
> index 927d1364fe46..64de60254136 100644
> --- a/board/ti/am57xx/board.c
> +++ b/board/ti/am57xx/board.c
> @@ -338,7 +338,9 @@ static void setup_board_eeprom_env(void)
> if (rc)
> goto invalid_eeprom;
>
> - if (board_is_am572x_evm())
> + if (board_is_x15())
> + name = "beagle_x15";
> + else if (board_is_am572x_evm())
> name = "am57xx_evm";
> else if (board_is_am572x_idk())
> name = "am572x_idk";
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, V2] board: am57xx: Fix missing check for beagle_x15
2016-09-02 18:51 [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15 Nishanth Menon
2016-09-02 19:08 ` Tom Rini
2016-09-03 16:54 ` Lokesh Vutla
@ 2016-09-07 18:00 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2016-09-07 18:00 UTC (permalink / raw)
To: u-boot
On Fri, Sep 02, 2016 at 01:51:33PM -0500, Nishanth Menon wrote:
> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
>
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160907/8000e332/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-07 18:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 18:51 [U-Boot] [PATCH V2] board: am57xx: Fix missing check for beagle_x15 Nishanth Menon
2016-09-02 19:08 ` Tom Rini
2016-09-03 16:54 ` Lokesh Vutla
2016-09-07 18:00 ` [U-Boot] [U-Boot, " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.