* [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 11:43 ` Vinod Koul
2021-05-18 6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
` (6 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add label "thermal_zones" for thermal-zones node.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index ed0b51b..47c6c0b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1317,7 +1317,7 @@
};
};
- thermal-zones {
+ thermal_zones: thermal-zones {
cpu0-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node
2021-05-18 6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
@ 2021-05-18 11:43 ` Vinod Koul
2021-05-20 6:24 ` skakit
0 siblings, 1 reply; 22+ messages in thread
From: Vinod Koul @ 2021-05-18 11:43 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 18-05-21, 11:50, satya priya wrote:
> Add label "thermal_zones" for thermal-zones node.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in RESEND V4:
> - No Changes.
>
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index ed0b51b..47c6c0b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -1317,7 +1317,7 @@
> };
> };
>
> - thermal-zones {
> + thermal_zones: thermal-zones {
is this label used anywhere in this series? If not lets drop it
> cpu0-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
--
~Vinod
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node
2021-05-18 11:43 ` Vinod Koul
@ 2021-05-20 6:24 ` skakit
0 siblings, 0 replies; 22+ messages in thread
From: skakit @ 2021-05-20 6:24 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 2021-05-18 17:13, Vinod Koul wrote:
> On 18-05-21, 11:50, satya priya wrote:
>> Add label "thermal_zones" for thermal-zones node.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> Changes in RESEND V4:
>> - No Changes.
>>
>> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi
>> b/arch/arm64/boot/dts/qcom/sm8350.dtsi
>> index ed0b51b..47c6c0b 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
>> @@ -1317,7 +1317,7 @@
>> };
>> };
>>
>> - thermal-zones {
>> + thermal_zones: thermal-zones {
>
> is this label used anywhere in this series? If not lets drop it
>
yes, it is used in pm8350c.dtsi, pmk8350.dtsi and pmr735a.dtsi files
which are included in sm8350 board dts.
>> cpu0-thermal {
>> polling-delay-passive = <250>;
>> polling-delay = <1000>;
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 11:44 ` Vinod Koul
2021-05-18 6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
` (5 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add thermal-zones node for SC7280 SoC.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 2cc4785..2a7d488 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -1125,4 +1125,7 @@
<GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
<GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
};
+
+ thermal_zones: thermal-zones {
+ };
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
2021-05-18 6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
@ 2021-05-18 11:44 ` Vinod Koul
2021-05-18 16:27 ` Matthias Kaehlcke
0 siblings, 1 reply; 22+ messages in thread
From: Vinod Koul @ 2021-05-18 11:44 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 18-05-21, 11:50, satya priya wrote:
> Add thermal-zones node for SC7280 SoC.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in RESEND V4:
> - No Changes.
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 2cc4785..2a7d488 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1125,4 +1125,7 @@
> <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> };
> +
> + thermal_zones: thermal-zones {
> + };
Empty node..? what am i missing here...
--
~Vinod
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
2021-05-18 11:44 ` Vinod Koul
@ 2021-05-18 16:27 ` Matthias Kaehlcke
2021-05-18 21:16 ` Dmitry Baryshkov
2021-05-20 6:25 ` skakit
0 siblings, 2 replies; 22+ messages in thread
From: Matthias Kaehlcke @ 2021-05-18 16:27 UTC (permalink / raw)
To: Vinod Koul
Cc: satya priya, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote:
> On 18-05-21, 11:50, satya priya wrote:
> > Add thermal-zones node for SC7280 SoC.
> >
> > Signed-off-by: satya priya <skakit@codeaurora.org>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > Changes in RESEND V4:
> > - No Changes.
> >
> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 2cc4785..2a7d488 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -1125,4 +1125,7 @@
> > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
> > };
> > +
> > + thermal_zones: thermal-zones {
> > + };
>
> Empty node..? what am i missing here...
The 'thermal-zones' node with the SoC thermal zones is usually created
in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings
and device tree nodes for TSENS in SC7280' series
(https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225)
is creating it, but the series hasn't landed yet.
The node is needed by other patches in this series that add non-SoC
thermal zones. Hence either an empty node needs to be added (for now)
or this series should 'officially' depend on the TSENS series mentioned
above.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
2021-05-18 16:27 ` Matthias Kaehlcke
@ 2021-05-18 21:16 ` Dmitry Baryshkov
2021-05-20 6:25 ` skakit
1 sibling, 0 replies; 22+ messages in thread
From: Dmitry Baryshkov @ 2021-05-18 21:16 UTC (permalink / raw)
To: Matthias Kaehlcke, Vinod Koul
Cc: satya priya, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
On 18/05/2021 19:27, Matthias Kaehlcke wrote:
> On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote:
>> On 18-05-21, 11:50, satya priya wrote:
>>> Add thermal-zones node for SC7280 SoC.
>>>
>>> Signed-off-by: satya priya <skakit@codeaurora.org>
>>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> Changes in RESEND V4:
>>> - No Changes.
>>>
>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 2cc4785..2a7d488 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -1125,4 +1125,7 @@
>>> <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>>> <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>>> };
>>> +
>>> + thermal_zones: thermal-zones {
>>> + };
>>
>> Empty node..? what am i missing here...
>
> The 'thermal-zones' node with the SoC thermal zones is usually created
> in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings
> and device tree nodes for TSENS in SC7280' series
> (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225)
> is creating it, but the series hasn't landed yet.
>
> The node is needed by other patches in this series that add non-SoC
> thermal zones. Hence either an empty node needs to be added (for now)
> or this series should 'officially' depend on the TSENS series mentioned
> above.
You can reference the TZ node as /thermal-zones/ even from non-SoC
includes. See pm8150.dtsi for example.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add thermal-zones node
2021-05-18 16:27 ` Matthias Kaehlcke
2021-05-18 21:16 ` Dmitry Baryshkov
@ 2021-05-20 6:25 ` skakit
1 sibling, 0 replies; 22+ messages in thread
From: skakit @ 2021-05-20 6:25 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Vinod Koul, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
Hi Matthias,
On 2021-05-18 21:57, Matthias Kaehlcke wrote:
> On Tue, May 18, 2021 at 05:14:03PM +0530, Vinod Koul wrote:
>> On 18-05-21, 11:50, satya priya wrote:
>> > Add thermal-zones node for SC7280 SoC.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > ---
>> > Changes in RESEND V4:
>> > - No Changes.
>> >
>> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > index 2cc4785..2a7d488 100644
>> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> > @@ -1125,4 +1125,7 @@
>> > <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>> > <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>> > };
>> > +
>> > + thermal_zones: thermal-zones {
>> > + };
>>
>> Empty node..? what am i missing here...
>
> The 'thermal-zones' node with the SoC thermal zones is usually created
> in the <soc>.dtsi, however it doesn't exist yet. The 'Add DT bindings
> and device tree nodes for TSENS in SC7280' series
> (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225)
> is creating it, but the series hasn't landed yet.
>
> The node is needed by other patches in this series that add non-SoC
> thermal zones. Hence either an empty node needs to be added (for now)
> or this series should 'officially' depend on the TSENS series mentioned
> above.
I will add the dependency in cover letter and drop this patch.
Thanks,
Satya Priya
^ permalink raw reply [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 11:46 ` Vinod Koul
2021-05-18 6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
` (4 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
new file mode 100644
index 0000000..e7f64a9
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+ pm7325: pmic@1 {
+ compatible = "qcom,pm7325", "qcom,spmi-pmic";
+ reg = <0x1 SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pm7325_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ pm7325_gpios: gpios@8800 {
+ compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pm7325_gpios 0 0 10>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+ };
+};
+
+&thermal_zones {
+ pm7325_thermal: pm7325-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm7325_temp_alarm>;
+
+ trips {
+ pm7325_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pm7325_crit: pm7325-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-18 6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
@ 2021-05-18 11:46 ` Vinod Koul
2021-05-18 16:42 ` Matthias Kaehlcke
0 siblings, 1 reply; 22+ messages in thread
From: Vinod Koul @ 2021-05-18 11:46 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 18-05-21, 11:50, satya priya wrote:
> Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in RESEND V4:
> - No Changes.
>
> arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> new file mode 100644
> index 0000000..e7f64a9
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> + pm7325: pmic@1 {
> + compatible = "qcom,pm7325", "qcom,spmi-pmic";
where is qcom,pm7325 documented?
> + reg = <0x1 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pm7325_temp_alarm: temp-alarm@a00 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0xa00>;
> + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> + pm7325_gpios: gpios@8800 {
> + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
where is qcom,pm7325-gpio documented?
> + reg = <0x8800>;
> + gpio-controller;
> + gpio-ranges = <&pm7325_gpios 0 0 10>;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + };
> +};
--
~Vinod
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-18 11:46 ` Vinod Koul
@ 2021-05-18 16:42 ` Matthias Kaehlcke
2021-05-20 6:32 ` skakit
0 siblings, 1 reply; 22+ messages in thread
From: Matthias Kaehlcke @ 2021-05-18 16:42 UTC (permalink / raw)
To: Vinod Koul
Cc: satya priya, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
> On 18-05-21, 11:50, satya priya wrote:
> > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
> >
> > Signed-off-by: satya priya <skakit@codeaurora.org>
> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > Changes in RESEND V4:
> > - No Changes.
> >
> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > new file mode 100644
> > index 0000000..e7f64a9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > @@ -0,0 +1,53 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > +
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/spmi/spmi.h>
> > +
> > +&spmi_bus {
> > + pm7325: pmic@1 {
> > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>
> where is qcom,pm7325 documented?
good point, I missed that one.
> > + reg = <0x1 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pm7325_temp_alarm: temp-alarm@a00 {
> > + compatible = "qcom,spmi-temp-alarm";
> > + reg = <0xa00>;
> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> > + #thermal-sensor-cells = <0>;
> > + };
> > +
> > + pm7325_gpios: gpios@8800 {
> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
>
> where is qcom,pm7325-gpio documented?
It's added by the 'Add GPIO support for PM7325' series
(https://patchwork.kernel.org/project/linux-arm-msm/list/?series=481133)
The binding change was acked by Rob and the code by Bjorn, so it can be
expected to land, but it would still be good to mention the dependency
explicitly.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-18 16:42 ` Matthias Kaehlcke
@ 2021-05-20 6:32 ` skakit
2021-05-20 7:20 ` Vinod Koul
0 siblings, 1 reply; 22+ messages in thread
From: skakit @ 2021-05-20 6:32 UTC (permalink / raw)
To: Matthias Kaehlcke, Vinod Koul
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 2021-05-18 22:12, Matthias Kaehlcke wrote:
> On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
>> On 18-05-21, 11:50, satya priya wrote:
>> > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > ---
>> > Changes in RESEND V4:
>> > - No Changes.
>> >
>> > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
>> > 1 file changed, 53 insertions(+)
>> > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>> >
>> > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > new file mode 100644
>> > index 0000000..e7f64a9
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > @@ -0,0 +1,53 @@
>> > +// SPDX-License-Identifier: BSD-3-Clause
>> > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> > +
>> > +#include <dt-bindings/interrupt-controller/irq.h>
>> > +#include <dt-bindings/spmi/spmi.h>
>> > +
>> > +&spmi_bus {
>> > + pm7325: pmic@1 {
>> > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>>
>> where is qcom,pm7325 documented?
>
> good point, I missed that one.
>
Actually this point was discussed during V2(
https://lore.kernel.org/patchwork/patch/1406186/#1607321 ).
As far as I understand it is not mandatory to add "qcom,pm7325" as we
are adding "qcom,spmi-pmic". It is just a good to have change.
I could not find the documentation for pm8350c, pmk8350 and pmr735a as
well.
>> > + reg = <0x1 SPMI_USID>;
>> > + #address-cells = <1>;
>> > + #size-cells = <0>;
>> > +
>> > + pm7325_temp_alarm: temp-alarm@a00 {
>> > + compatible = "qcom,spmi-temp-alarm";
>> > + reg = <0xa00>;
>> > + interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> > + #thermal-sensor-cells = <0>;
>> > + };
>> > +
>> > + pm7325_gpios: gpios@8800 {
>> > + compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
>>
>> where is qcom,pm7325-gpio documented?
>
> It's added by the 'Add GPIO support for PM7325' series
> (https://patchwork.kernel.org/project/linux-arm-msm/list/?series=481133)
>
> The binding change was acked by Rob and the code by Bjorn, so it can be
> expected to land, but it would still be good to mention the dependency
> explicitly.
The binding patch is applied now.
Thanks,
Satya Priya
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-20 6:32 ` skakit
@ 2021-05-20 7:20 ` Vinod Koul
2021-05-21 12:22 ` skakit
0 siblings, 1 reply; 22+ messages in thread
From: Vinod Koul @ 2021-05-20 7:20 UTC (permalink / raw)
To: skakit
Cc: Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
On 20-05-21, 12:02, skakit@codeaurora.org wrote:
> On 2021-05-18 22:12, Matthias Kaehlcke wrote:
> > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
> > > On 18-05-21, 11:50, satya priya wrote:
> > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
> > > >
> > > > Signed-off-by: satya priya <skakit@codeaurora.org>
> > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > > ---
> > > > Changes in RESEND V4:
> > > > - No Changes.
> > > >
> > > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> > > > 1 file changed, 53 insertions(+)
> > > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > new file mode 100644
> > > > index 0000000..e7f64a9
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > @@ -0,0 +1,53 @@
> > > > +// SPDX-License-Identifier: BSD-3-Clause
> > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > > > +
> > > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > > +#include <dt-bindings/spmi/spmi.h>
> > > > +
> > > > +&spmi_bus {
> > > > + pm7325: pmic@1 {
> > > > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
> > >
> > > where is qcom,pm7325 documented?
>
> >
> > good point, I missed that one.
> >
>
> Actually this point was discussed during V2(
> https://lore.kernel.org/patchwork/patch/1406186/#1607321 ).
> As far as I understand it is not mandatory to add "qcom,pm7325" as we are
> adding "qcom,spmi-pmic". It is just a good to have change.
> I could not find the documentation for pm8350c, pmk8350 and pmr735a as well.
Yes that is a miss too, IMO all of these should be added to
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml
file replacing this
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file
2021-05-20 7:20 ` Vinod Koul
@ 2021-05-21 12:22 ` skakit
0 siblings, 0 replies; 22+ messages in thread
From: skakit @ 2021-05-21 12:22 UTC (permalink / raw)
To: Vinod Koul
Cc: Matthias Kaehlcke, Andy Gross, Bjorn Andersson, Rob Herring,
linux-arm-msm, linux-kernel, devicetree, kgunda
On 2021-05-20 12:50, Vinod Koul wrote:
> On 20-05-21, 12:02, skakit@codeaurora.org wrote:
>> On 2021-05-18 22:12, Matthias Kaehlcke wrote:
>> > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
>> > > On 18-05-21, 11:50, satya priya wrote:
>> > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
>> > > >
>> > > > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> > > > ---
>> > > > Changes in RESEND V4:
>> > > > - No Changes.
>> > > >
>> > > > arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
>> > > > 1 file changed, 53 insertions(+)
>> > > > create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > > >
>> > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > > > new file mode 100644
>> > > > index 0000000..e7f64a9
>> > > > --- /dev/null
>> > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
>> > > > @@ -0,0 +1,53 @@
>> > > > +// SPDX-License-Identifier: BSD-3-Clause
>> > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> > > > +
>> > > > +#include <dt-bindings/interrupt-controller/irq.h>
>> > > > +#include <dt-bindings/spmi/spmi.h>
>> > > > +
>> > > > +&spmi_bus {
>> > > > + pm7325: pmic@1 {
>> > > > + compatible = "qcom,pm7325", "qcom,spmi-pmic";
>> > >
>> > > where is qcom,pm7325 documented?
>>
>> >
>> > good point, I missed that one.
>> >
>>
>> Actually this point was discussed during V2(
>> https://lore.kernel.org/patchwork/patch/1406186/#1607321 ).
>> As far as I understand it is not mandatory to add "qcom,pm7325" as we
>> are
>> adding "qcom,spmi-pmic". It is just a good to have change.
>> I could not find the documentation for pm8350c, pmk8350 and pmr735a as
>> well.
>
> Yes that is a miss too, IMO all of these should be added to
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml
> file replacing this
>
Okay, will add those four pmics to qcom,spmi-pmic.txt.
> Thanks
^ permalink raw reply [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
` (2 preceding siblings ...)
2021-05-18 6:20 ` [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 11:48 ` Vinod Koul
2021-05-18 6:20 ` [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
` (3 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add temp-alarm node for PM8350C pmic and also modify gpio
node to add gpio ranges and "qcom,spmi-gpio" compatible.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index 2b9b75e..e1b75ae 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -13,13 +13,43 @@
#address-cells = <1>;
#size-cells = <0>;
+ pm8350c_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
pm8350c_gpios: gpio@8800 {
- compatible = "qcom,pm8350c-gpio";
+ compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
+ gpio-ranges = <&pm8350c_gpios 0 0 9>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
};
};
};
+
+&thermal_zones {
+ pm8350c_thermal: pm8350c-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pm8350c_temp_alarm>;
+
+ trips {
+ pm8350c_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pm8350c_crit: pm8350c-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support
2021-05-18 6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
@ 2021-05-18 11:48 ` Vinod Koul
2021-05-20 6:25 ` skakit
0 siblings, 1 reply; 22+ messages in thread
From: Vinod Koul @ 2021-05-18 11:48 UTC (permalink / raw)
To: satya priya
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 18-05-21, 11:50, satya priya wrote:
> Add temp-alarm node for PM8350C pmic and also modify gpio
> node to add gpio ranges and "qcom,spmi-gpio" compatible.
These should be two patches explaining why things are done like that
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in RESEND V4:
> - No Changes.
>
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32 +++++++++++++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> index 2b9b75e..e1b75ae 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> @@ -13,13 +13,43 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pm8350c_temp_alarm: temp-alarm@a00 {
> + compatible = "qcom,spmi-temp-alarm";
> + reg = <0xa00>;
> + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> + #thermal-sensor-cells = <0>;
> + };
> +
> pm8350c_gpios: gpio@8800 {
> - compatible = "qcom,pm8350c-gpio";
> + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
why is this changed?
> reg = <0x8800>;
> gpio-controller;
> + gpio-ranges = <&pm8350c_gpios 0 0 9>;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> };
> };
> +
> +&thermal_zones {
> + pm8350c_thermal: pm8350c-thermal {
> + polling-delay-passive = <100>;
> + polling-delay = <0>;
> + thermal-sensors = <&pm8350c_temp_alarm>;
> +
> + trips {
> + pm8350c_trip0: trip0 {
> + temperature = <95000>;
> + hysteresis = <0>;
> + type = "passive";
> + };
> +
> + pm8350c_crit: pm8350c-crit {
> + temperature = <115000>;
> + hysteresis = <0>;
> + type = "critical";
> + };
> + };
> + };
> +};
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
--
~Vinod
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support
2021-05-18 11:48 ` Vinod Koul
@ 2021-05-20 6:25 ` skakit
0 siblings, 0 replies; 22+ messages in thread
From: skakit @ 2021-05-20 6:25 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, Bjorn Andersson, Rob Herring, mka, linux-arm-msm,
linux-kernel, devicetree, kgunda
On 2021-05-18 17:18, Vinod Koul wrote:
> On 18-05-21, 11:50, satya priya wrote:
>> Add temp-alarm node for PM8350C pmic and also modify gpio
>> node to add gpio ranges and "qcom,spmi-gpio" compatible.
>
> These should be two patches explaining why things are done like that
>
Okay, will split them.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> Changes in RESEND V4:
>> - No Changes.
>>
>> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32
>> +++++++++++++++++++++++++++++++-
>> 1 file changed, 31 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> index 2b9b75e..e1b75ae 100644
>> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
>> @@ -13,13 +13,43 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> + pm8350c_temp_alarm: temp-alarm@a00 {
>> + compatible = "qcom,spmi-temp-alarm";
>> + reg = <0xa00>;
>> + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>> + #thermal-sensor-cells = <0>;
>> + };
>> +
>> pm8350c_gpios: gpio@8800 {
>> - compatible = "qcom,pm8350c-gpio";
>> + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
>
> why is this changed?
As per the Documentation[1], either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
must be added based on whether the device is on an spmi bus or an ssbi
bus respectively.
[1]
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/qcom%2Cpmic-gpio.txt#L41
>
>> reg = <0x8800>;
>> gpio-controller;
>> + gpio-ranges = <&pm8350c_gpios 0 0 9>;
>> #gpio-cells = <2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> };
>> };
>> +
>> +&thermal_zones {
>> + pm8350c_thermal: pm8350c-thermal {
>> + polling-delay-passive = <100>;
>> + polling-delay = <0>;
>> + thermal-sensors = <&pm8350c_temp_alarm>;
>> +
>> + trips {
>> + pm8350c_trip0: trip0 {
>> + temperature = <95000>;
>> + hysteresis = <0>;
>> + type = "passive";
>> + };
>> +
>> + pm8350c_crit: pm8350c-crit {
>> + temperature = <115000>;
>> + hysteresis = <0>;
>> + type = "critical";
>> + };
>> + };
>> + };
>> +};
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: Add temp-alarm support
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
` (3 preceding siblings ...)
2021-05-18 6:20 ` [RESEND PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
` (2 subsequent siblings)
7 siblings, 0 replies; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add temp-alarm node for PMR735A pmic and also modify gpio
node to add gpio ranges and "qcom,spmi-gpio" compatible.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/pmr735a.dtsi | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
index 1c675af1..b4b6ba24 100644
--- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
@@ -13,13 +13,43 @@
#address-cells = <1>;
#size-cells = <0>;
+ pmr735a_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
pmr735a_gpios: gpio@8800 {
- compatible = "qcom,pmr735a-gpio";
+ compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
reg = <0x8800>;
gpio-controller;
+ gpio-ranges = <&pmr735a_gpios 0 0 4>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
};
};
};
+
+&thermal_zones {
+ pmr735a_thermal: pmr735a-thermal {
+ polling-delay-passive = <100>;
+ polling-delay = <0>;
+ thermal-sensors = <&pmr735a_temp_alarm>;
+
+ trips {
+ pmr735a_trip0: trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ pmr735a_crit: pmr735a-crit {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
` (4 preceding siblings ...)
2021-05-18 6:20 ` [RESEND PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya
7 siblings, 0 replies; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add PON, RTC, VADC and ACD_TM support for PMK8350.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- No Changes.
arch/arm64/boot/dts/qcom/pmk8350.dtsi | 51 ++++++++++++++++++++++++++++++++++-
1 file changed, 50 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
index 1530b8f..04fc263 100644
--- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
@@ -3,6 +3,8 @@
* Copyright (c) 2021, Linaro Limited
*/
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/spmi/spmi.h>
@@ -13,10 +15,57 @@
#address-cells = <1>;
#size-cells = <0>;
+ pmk8350_pon: pon@1300 {
+ compatible = "qcom,pm8998-pon";
+ reg = <0x1300>;
+
+ pwrkey {
+ compatible = "qcom,pmk8350-pwrkey";
+ interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
+ linux,code = <KEY_POWER>;
+ };
+
+ resin {
+ compatible = "qcom,pmk8350-resin";
+ interrupts = <0x0 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
+ linux,code = <KEY_VOLUMEDOWN>;
+ };
+ };
+
+ pmk8350_vadc: adc@3100 {
+ compatible = "qcom,spmi-adc7";
+ reg = <0x3100>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "eoc-int-en-set";
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+ };
+
+ pmk8350_adc_tm: adc-tm@3400 {
+ compatible = "qcom,adc-tm7";
+ reg = <0x3400>;
+ interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "threshold";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #thermal-sensor-cells = <1>;
+ status = "disabled";
+ };
+
+ pmk8350_rtc: rtc@6100 {
+ compatible = "qcom,pmk8350-rtc";
+ reg = <0x6100>, <0x6200>;
+ reg-names = "rtc", "alarm";
+ interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
+ };
+
pmk8350_gpios: gpio@b000 {
- compatible = "qcom,pmk8350-gpio";
+ compatible = "qcom,pmk8350-gpio", "qcom,spmi-gpio";
reg = <0xb000>;
gpio-controller;
+ gpio-ranges = <&pmk8350_gpios 0 0 4>;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
` (5 preceding siblings ...)
2021-05-18 6:20 ` [RESEND PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
@ 2021-05-18 6:20 ` satya priya
2021-05-18 6:20 ` [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp satya priya
7 siblings, 0 replies; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
The sc7280-idp has four PMICs, include their .dtsi files.
Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in RESEND V4:
- As per Matthias comments moved this patch before 'Add ADC channel nodes
for PMIC temperatures to sc7280-idp'
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index 54d2cb3..f295580 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -8,6 +8,10 @@
/dts-v1/;
#include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
/ {
model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [RESEND PATCH V4 8/8] arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp
2021-05-18 6:20 [RESEND PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
` (6 preceding siblings ...)
2021-05-18 6:20 ` [RESEND PATCH V4 7/8] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp satya priya
@ 2021-05-18 6:20 ` satya priya
7 siblings, 0 replies; 22+ messages in thread
From: satya priya @ 2021-05-18 6:20 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring
Cc: mka, linux-arm-msm, linux-kernel, devicetree, kgunda, satya priya
Add channel nodes for the on die temperatures of PMICS
pmk8350, pm8350, pmr735a and pmr735b.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in RESEND V4:
- As per Matthias comments, changed the commit text.
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
index f295580..704fb9a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
@@ -7,6 +7,10 @@
/dts-v1/;
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
#include "pmr735a.dtsi"
@@ -238,6 +242,32 @@
};
};
+&pmk8350_vadc {
+ pm8350_die_temp {
+ reg = <PM8350_ADC7_DIE_TEMP>;
+ label = "pm8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmk8350_die_temp {
+ reg = <PMK8350_ADC7_DIE_TEMP>;
+ label = "pmk8350_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735a_die_temp {
+ reg = <PMR735A_ADC7_DIE_TEMP>;
+ label = "pmr735a_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+
+ pmr735b_die_temp {
+ reg = <PMR735B_ADC7_DIE_TEMP>;
+ label = "pmr735b_die_temp";
+ qcom,pre-scaling = <1 1>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 22+ messages in thread