From: Leonard Crestez <leonard.crestez@nxp.com>
To: "festevam@gmail.com" <festevam@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dongas86@gmail.com" <dongas86@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/4] arm64: dts: imx: add imx8qxp support
Date: Mon, 15 Oct 2018 07:30:09 +0000 [thread overview]
Message-ID: <52eaa4ac563ad5114ebd99b286cdbe0495dba7ec.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5BEwNQy0HA80qOzm_w-c63tFK1eL+cOHNCxKYq9PHGsqw@mail.gmail.com>
On Sun, 2018-10-14 at 20:13 -0300, Fabio Estevam wrote:
> > + imx8qx-pm {
> > + compatible = "fsl,scu-pd";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pd_lsio: lsio-power-domain {
> > + #power-domain-cells = <0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pd_lsio_pwm0: lsio-pwm0@191 {
> > + reg = <191>;
>
> The number after @ is in hex, so the reg property should be 0x191.
These are SC_R_* resource ids from include/linux/firmware/imx/types.h
and they are almost everywhere referenced as decimals.
Is this really not acceptable for DT?
--
Regards,
Leonard
WARNING: multiple messages have this Message-ID (diff)
From: leonard.crestez@nxp.com (Leonard Crestez)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/4] arm64: dts: imx: add imx8qxp support
Date: Mon, 15 Oct 2018 07:30:09 +0000 [thread overview]
Message-ID: <52eaa4ac563ad5114ebd99b286cdbe0495dba7ec.camel@nxp.com> (raw)
In-Reply-To: <CAOMZO5BEwNQy0HA80qOzm_w-c63tFK1eL+cOHNCxKYq9PHGsqw@mail.gmail.com>
On Sun, 2018-10-14 at 20:13 -0300, Fabio Estevam wrote:
> > + imx8qx-pm {
> > + compatible = "fsl,scu-pd";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pd_lsio: lsio-power-domain {
> > + #power-domain-cells = <0>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + pd_lsio_pwm0: lsio-pwm0 at 191 {
> > + reg = <191>;
>
> The number after @ is in hex, so the reg property should be 0x191.
These are SC_R_* resource ids from include/linux/firmware/imx/types.h
and they are almost everywhere referenced as decimals.
Is this really not acceptable for DT?
--
Regards,
Leonard
next prev parent reply other threads:[~2018-10-15 7:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-14 14:34 [PATCH V2 0/4] arm64: imx: add imx8qxp support A.s. Dong
2018-10-14 14:34 ` [PATCH V2 1/4] " A.s. Dong
2018-10-14 14:34 ` [PATCH V2 2/4] arm64: dts: " A.s. Dong
2018-10-14 14:34 ` A.s. Dong
2018-10-14 23:13 ` Fabio Estevam
2018-10-14 23:13 ` Fabio Estevam
2018-10-15 6:27 ` Daniel Baluta
2018-10-15 6:27 ` Daniel Baluta
2018-10-15 7:30 ` Leonard Crestez [this message]
2018-10-15 7:30 ` Leonard Crestez
2018-10-15 9:29 ` A.s. Dong
2018-10-15 9:29 ` A.s. Dong
2018-10-15 7:57 ` A.s. Dong
2018-10-15 7:57 ` A.s. Dong
2018-10-18 0:51 ` Rob Herring
2018-10-18 0:51 ` Rob Herring
2018-10-18 2:32 ` A.s. Dong
2018-10-18 2:32 ` A.s. Dong
2018-10-15 6:58 ` Sascha Hauer
2018-10-15 6:58 ` Sascha Hauer
2018-10-15 8:08 ` A.s. Dong
2018-10-15 8:08 ` A.s. Dong
2018-10-15 8:27 ` Sascha Hauer
2018-10-15 8:27 ` Sascha Hauer
2018-10-15 9:03 ` A.s. Dong
2018-10-15 9:03 ` A.s. Dong
2018-10-15 9:40 ` Sascha Hauer
2018-10-15 9:40 ` Sascha Hauer
2018-10-15 16:09 ` A.s. Dong
2018-10-15 16:09 ` A.s. Dong
2018-10-16 7:08 ` Sascha Hauer
2018-10-16 7:08 ` Sascha Hauer
2018-10-14 14:34 ` [PATCH V2 3/4] arm64: dts: imx: add imx8qxp mek support A.s. Dong
2018-10-14 14:34 ` A.s. Dong
2018-10-15 7:01 ` Sascha Hauer
2018-10-15 7:01 ` Sascha Hauer
2018-10-15 8:40 ` A.s. Dong
2018-10-15 8:40 ` A.s. Dong
2018-10-14 14:35 ` [PATCH V2 4/4] defconfig: arm64: add imx8qxp support A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52eaa4ac563ad5114ebd99b286cdbe0495dba7ec.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.