Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init

From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>,
	Maksim Kozlov <m.kozlov@samsung.com>,
	Dmitry Solodkiy <d.solodkiy@samsung.com>,
	Evgeny Voevodin <e.voevodin@samsung.com>,
	patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init
Date: Mon, 17 Feb 2014 19:07:19 +0100	[thread overview]
Message-ID: <53024FD7.3060100@redhat.com> (raw)
In-Reply-To: <1392659611-8439-1-git-send-email-peter.maydell@linaro.org>

Il 17/02/2014 18:53, Peter Maydell ha scritto:
> The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs;
> use the correct constant in the loop initializing our output
> sysbus IRQs so that we don't overrun the output_irq[] array.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/intc/exynos4210_combiner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
> index ef5e8eb..3287479 100644
> --- a/hw/intc/exynos4210_combiner.c
> +++ b/hw/intc/exynos4210_combiner.c
> @@ -418,7 +418,7 @@ static int exynos4210_combiner_init(SysBusDevice *sbd)
>      qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ);
>
>      /* Connect SysBusDev irqs to device specific irqs */
> -    for (i = 0; i < IIC_NIRQ; i++) {
> +    for (i = 0; i < IIC_NGRP; i++) {
>          sysbus_init_irq(sbd, &s->output_irq[i]);
>      }
>
> -- 1.8.5

I think I saw more of these in Coverity output.

Paolo