From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org, Igor Mitsyanko <i.mitsyanko@gmail.com>,
qemu-stable <qemu-stable@nongnu.org>,
Dmitry Solodkiy <d.solodkiy@samsung.com>,
Maksim Kozlov <m.kozlov@samsung.com>
Subject: Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init
Date: Tue, 18 Feb 2014 02:17:36 +0100 [thread overview]
Message-ID: <5302B4B0.7050507@suse.de> (raw)
In-Reply-To: <1392659611-8439-1-git-send-email-peter.maydell@linaro.org>
Am 17.02.2014 18:53, schrieb Peter Maydell:
> The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs;
> use the correct constant in the loop initializing our output
> sysbus IRQs so that we don't overrun the output_irq[] array.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/intc/exynos4210_combiner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
> index ef5e8eb..3287479 100644
> --- a/hw/intc/exynos4210_combiner.c
> +++ b/hw/intc/exynos4210_combiner.c
> @@ -418,7 +418,7 @@ static int exynos4210_combiner_init(SysBusDevice *sbd)
> qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ);
>
> /* Connect SysBusDev irqs to device specific irqs */
> - for (i = 0; i < IIC_NIRQ; i++) {
> + for (i = 0; i < IIC_NGRP; i++) {
Reviewed-by: Andreas Färber <afaerber@suse.de>
It seems that IIC_NIRQ == IIC_NGRP * 8, so please don't forget to Cc
qemu-stable@nongnu.org in the commit message for 1.7.1.
Regards,
Andreas
> sysbus_init_irq(sbd, &s->output_irq[i]);
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-18 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 17:53 [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init Peter Maydell
2014-02-17 18:07 ` Paolo Bonzini
2014-02-18 1:17 ` Andreas Färber [this message]
2014-02-24 15:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5302B4B0.7050507@suse.de \
--to=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@gmail.com \
--cc=m.kozlov@samsung.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.