* [RFC v5,2/3] controls.xml : add addtional Flash fault bits
@ 2014-02-21 4:49 Daniel Jeong
2014-02-21 9:57 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jeong @ 2014-02-21 4:49 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Landley, Sakari Ailus, Andy Shevchenko
Cc: Hans Verkuil, Daniel Jeong, linux-media, linux-doc
Added more comment about Input voltage flash monitor and external temp function.
Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
---
Documentation/DocBook/media/v4l/controls.xml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
index a5a3188..145a127 100644
--- a/Documentation/DocBook/media/v4l/controls.xml
+++ b/Documentation/DocBook/media/v4l/controls.xml
@@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
<entry>The flash controller has detected a short or open
circuit condition on the indicator LED.</entry>
</row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
+ <entry>Flash controller voltage to the flash LED
+ has been below the minimum limit specific to the flash
+ controller.</entry>
+ </row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
+ <entry>The flash controller has detected adjustment by IVFM
+ (Input Voltage Flash Monitor) block.
+ If during the flash current turn-on, the input voltage falls
+ below the threshold input voltage, IVFM adjust level</entry>
+ </row>
+ <row>
+ <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
+ <entry>The flash controller has detected that TEMP input has
+ crossed threshold by external temperature sensor.</entry>
+ </row>
</tbody>
</entrytbl>
</row>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC v5,2/3] controls.xml : add addtional Flash fault bits
2014-02-21 4:49 [RFC v5,2/3] controls.xml : add addtional Flash fault bits Daniel Jeong
@ 2014-02-21 9:57 ` Sakari Ailus
2014-02-24 4:12 ` Daniel Jeong
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2014-02-21 9:57 UTC (permalink / raw)
To: Daniel Jeong, Mauro Carvalho Chehab, Rob Landley, Andy Shevchenko
Cc: Hans Verkuil, linux-media, linux-doc
Hi Daniel,
Daniel Jeong wrote:
> Added more comment about Input voltage flash monitor and external temp function.
>
> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
> ---
> Documentation/DocBook/media/v4l/controls.xml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml
> index a5a3188..145a127 100644
> --- a/Documentation/DocBook/media/v4l/controls.xml
> +++ b/Documentation/DocBook/media/v4l/controls.xml
> @@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
> <entry>The flash controller has detected a short or open
> circuit condition on the indicator LED.</entry>
> </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
> + <entry>Flash controller voltage to the flash LED
> + has been below the minimum limit specific to the flash
> + controller.</entry>
> + </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
> + <entry>The flash controller has detected adjustment by IVFM
> + (Input Voltage Flash Monitor) block.
> + If during the flash current turn-on, the input voltage falls
> + below the threshold input voltage, IVFM adjust level</entry>
Could you add an explanation what does this fault actually mean to the user?
"IVFM" at least doesn't say anything to me...
> + </row>
> + <row>
> + <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
> + <entry>The flash controller has detected that TEMP input has
> + crossed threshold by external temperature sensor.</entry>
How about this instead?
"The temperature of the LED has exceeded its allowed upper limit."
--
Kind regards,
Sakari Ailus
sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC v5,2/3] controls.xml : add addtional Flash fault bits
2014-02-21 9:57 ` Sakari Ailus
@ 2014-02-24 4:12 ` Daniel Jeong
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jeong @ 2014-02-24 4:12 UTC (permalink / raw)
To: Sakari Ailus
Cc: Mauro Carvalho Chehab, Rob Landley, Andy Shevchenko,
Hans Verkuil, linux-media, linux-doc
Hi Sakari
Thank you for your comments.
> Hi Daniel,
>
> Daniel Jeong wrote:
>> Added more comment about Input voltage flash monitor and external
>> temp function.
>>
>> Signed-off-by: Daniel Jeong <gshark.jeong@gmail.com>
>> ---
>> Documentation/DocBook/media/v4l/controls.xml | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/DocBook/media/v4l/controls.xml
>> b/Documentation/DocBook/media/v4l/controls.xml
>> index a5a3188..145a127 100644
>> --- a/Documentation/DocBook/media/v4l/controls.xml
>> +++ b/Documentation/DocBook/media/v4l/controls.xml
>> @@ -4370,6 +4370,24 @@ interface and may change in the future.</para>
>> <entry>The flash controller has detected a short or open
>> circuit condition on the indicator LED.</entry>
>> </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_UNDER_VOLTAGE</constant></entry>
>> + <entry>Flash controller voltage to the flash LED
>> + has been below the minimum limit specific to the flash
>> + controller.</entry>
>> + </row>
>> + <row>
>> + <entry><constant>V4L2_FLASH_FAULT_INPUT_VOLTAGE</constant></entry>
>> + <entry>The flash controller has detected adjustment by
>> IVFM
>> + (Input Voltage Flash Monitor) block.
>> + If during the flash current turn-on, the input voltage falls
>> + below the threshold input voltage, IVFM adjust level</entry>
>
> Could you add an explanation what does this fault actually mean to the
> user?
>
> "IVFM" at least doesn't say anything to me...
>
How about this ?
"The flash current can't reach to the target current due to the input
voltage falling below lower limit
and flash controller adjusted the flash current not to occur low voltage
envent"
>> + </row>
>> + <row>
>> +
>> <entry><constant>V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE</constant></entry>
>> + <entry>The flash controller has detected that TEMP
>> input has
>> + crossed threshold by external temperature sensor.</entry>
>
> How about this instead?
>
> "The temperature of the LED has exceeded its allowed upper limit."
>
Ok.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-24 4:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-21 4:49 [RFC v5,2/3] controls.xml : add addtional Flash fault bits Daniel Jeong
2014-02-21 9:57 ` Sakari Ailus
2014-02-24 4:12 ` Daniel Jeong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.