From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <ilya.dryomov@inktank.com>, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 3/6] libceph: bump CEPH_OSD_MAX_OP to 3
Date: Mon, 24 Feb 2014 08:59:06 -0600 [thread overview]
Message-ID: <530B5E3A.9040503@ieee.org> (raw)
In-Reply-To: <1393008946-7931-4-git-send-email-ilya.dryomov@inktank.com>
On 02/21/2014 12:55 PM, Ilya Dryomov wrote:
> Our longest osd request now contains 3 ops: copyup+hint+write.
This is pretty trivial and could be squashed into the
patch that actually starts using more than two ops.
It could certainly be squashed together with the next
patch (that fixes the assertion).
That being said, I appreciate your breaking up the
functionality into logically separate changes, it's
important.
So I guess, do what you like...
Reviewed-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
> ---
> include/linux/ceph/osd_client.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ceph/osd_client.h b/include/linux/ceph/osd_client.h
> index 6bfcb0eca8ab..bc874b2398d7 100644
> --- a/include/linux/ceph/osd_client.h
> +++ b/include/linux/ceph/osd_client.h
> @@ -43,7 +43,7 @@ struct ceph_osd {
> };
>
>
> -#define CEPH_OSD_MAX_OP 2
> +#define CEPH_OSD_MAX_OP 3
>
> enum ceph_osd_data_type {
> CEPH_OSD_DATA_TYPE_NONE = 0,
>
next prev parent reply other threads:[~2014-02-24 14:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 18:55 [PATCH 0/6] libceph: CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-21 18:55 ` [PATCH 1/6] libceph: encode CEPH_OSD_OP_FLAG_* op flags Ilya Dryomov
2014-02-24 14:58 ` Alex Elder
2014-02-21 18:55 ` [PATCH 2/6] libceph: add support for CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-23 16:03 ` Sage Weil
2014-02-24 14:59 ` Alex Elder
2014-02-25 12:52 ` Ilya Dryomov
2014-02-25 13:05 ` Alex Elder
2014-02-25 13:38 ` Ilya Dryomov
2014-02-25 17:12 ` Sage Weil
2014-02-25 17:12 ` Sage Weil
2014-02-21 18:55 ` [PATCH 3/6] libceph: bump CEPH_OSD_MAX_OP to 3 Ilya Dryomov
2014-02-24 14:59 ` Alex Elder [this message]
2014-02-21 18:55 ` [PATCH 4/6] rbd: do not hard-code CEPH_OSD_MAX_OP in rbd_osd_req_callback() Ilya Dryomov
2014-02-24 14:59 ` Alex Elder
2014-02-25 12:53 ` Ilya Dryomov
2014-02-21 18:55 ` [PATCH 5/6] rbd: num_ops parameter for rbd_osd_req_create() Ilya Dryomov
2014-02-24 14:59 ` Alex Elder
2014-02-21 18:55 ` [PATCH 6/6] rbd: prefix rbd writes with CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-24 14:59 ` Alex Elder
2014-02-25 12:58 ` Ilya Dryomov
2014-02-25 13:19 ` Alex Elder
2014-02-23 16:14 ` [PATCH 0/6] libceph: " Sage Weil
2014-02-23 16:15 ` Alex Elder
2014-02-24 14:58 ` Alex Elder
2014-02-25 12:50 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B5E3A.9040503@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.