All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Dryomov <ilya.dryomov@inktank.com>
To: Alex Elder <elder@ieee.org>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 4/6] rbd: do not hard-code CEPH_OSD_MAX_OP in rbd_osd_req_callback()
Date: Tue, 25 Feb 2014 14:53:12 +0200	[thread overview]
Message-ID: <CALFYKtA7jNHk1OoPtvEd+SC-UK-sELBqJBhn=Ybbs5nzu61srg@mail.gmail.com> (raw)
In-Reply-To: <530B5E3E.7010101@ieee.org>

On Mon, Feb 24, 2014 at 4:59 PM, Alex Elder <elder@ieee.org> wrote:
> On 02/21/2014 12:55 PM, Ilya Dryomov wrote:
>> CEPH_OSD_MAX_OP value in rbd_osd_req_callback() is hard-coded to 2.
>> Fix it.
>
> Please squash this in with the previous patch (at least).
> Change the BUG_ON() to rbd_assert() while you're at it
> (and invert the logic).

Done.

Thanks,

                Ilya

  reply	other threads:[~2014-02-25 12:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 18:55 [PATCH 0/6] libceph: CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-21 18:55 ` [PATCH 1/6] libceph: encode CEPH_OSD_OP_FLAG_* op flags Ilya Dryomov
2014-02-24 14:58   ` Alex Elder
2014-02-21 18:55 ` [PATCH 2/6] libceph: add support for CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-23 16:03   ` Sage Weil
2014-02-24 14:59   ` Alex Elder
2014-02-25 12:52     ` Ilya Dryomov
2014-02-25 13:05       ` Alex Elder
2014-02-25 13:38         ` Ilya Dryomov
2014-02-25 17:12           ` Sage Weil
2014-02-25 17:12       ` Sage Weil
2014-02-21 18:55 ` [PATCH 3/6] libceph: bump CEPH_OSD_MAX_OP to 3 Ilya Dryomov
2014-02-24 14:59   ` Alex Elder
2014-02-21 18:55 ` [PATCH 4/6] rbd: do not hard-code CEPH_OSD_MAX_OP in rbd_osd_req_callback() Ilya Dryomov
2014-02-24 14:59   ` Alex Elder
2014-02-25 12:53     ` Ilya Dryomov [this message]
2014-02-21 18:55 ` [PATCH 5/6] rbd: num_ops parameter for rbd_osd_req_create() Ilya Dryomov
2014-02-24 14:59   ` Alex Elder
2014-02-21 18:55 ` [PATCH 6/6] rbd: prefix rbd writes with CEPH_OSD_OP_SETALLOCHINT osd op Ilya Dryomov
2014-02-24 14:59   ` Alex Elder
2014-02-25 12:58     ` Ilya Dryomov
2014-02-25 13:19       ` Alex Elder
2014-02-23 16:14 ` [PATCH 0/6] libceph: " Sage Weil
2014-02-23 16:15   ` Alex Elder
2014-02-24 14:58 ` Alex Elder
2014-02-25 12:50   ` Ilya Dryomov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALFYKtA7jNHk1OoPtvEd+SC-UK-sELBqJBhn=Ybbs5nzu61srg@mail.gmail.com' \
    --to=ilya.dryomov@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=elder@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.