From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> To: Dinh Nguyen <dinh.linux@gmail.com>, David Miller <davem@davemloft.net>, <dinguyen@altera.com> Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>, <vbridgers2013@gmail.com> Subject: Re: [PATCHv3 1/2] net: stmmac: Add SOCFPGA glue driver Date: Wed, 26 Feb 2014 10:44:33 +0100 [thread overview] Message-ID: <530DB781.9050901@st.com> (raw) In-Reply-To: <52FC4B0A.4010406@gmail.com> On 2/13/2014 5:33 AM, Dinh Nguyen wrote: > > On 2/12/14 6:35 PM, David Miller wrote: >> From: <dinguyen@altera.com> >> Date: Mon, 10 Feb 2014 13:48:16 -0600 >> >>> From: Dinh Nguyen <dinguyen@altera.com> >>> >>> Like the STi series SOCs, Altera's SOCFPGA also needs a glue layer on top of the >>> Synopsys gmac IP. >>> >>> This patch adds the platform driver for the glue layer which configures the IP >>> before the generic STMMAC driver takes over. >>> >>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com> >>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Pawel Moll <pawel.moll@arm.com> >>> Cc: Mark Rutland <mark.rutland@arm.com> >>> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >>> Cc: Kumar Gala <galak@codeaurora.org> >>> Cc: Vince Bridgers <vbridgers2013@gmail.com> >>> --- >>> v3: Remove stray empty line at end of dwmac-socfpga.c. >>> v2: Use the dwmac-sti as an example for a glue layer and split patch up >>> to have dts as a separate patch. Also cc dts maintainers since there is >>> a new binding. >> The second patch for the DTS update doesn't apply cleanly at all to >> mainline. > Yes, I'm planning to take the DTS bindings patch through arm-soc/next-dt > tree, so that is where patch 2 is based on. >> >> Why don't you push both of these patches through whatever tree that >> file is maintained under. You can add my ack: > I'm not sure if Peppe has a tree, but it should go into his tree > if there is one. If not, can you apply patch 1 to your tree? Hello I have not own tree but I am using net.git and net-next to do my patches and experiments. I ask you to keep these patches aligned to net-next. Also I ask you to review the glue-layer that is not in-line with what have been currently added for dwmac-sti and dwmac-sunxi.c. BR Peppe >> >> Acked-by: David S. Miller <davem@davemloft.net> > Thanks, > Dinh >
WARNING: multiple messages have this Message-ID (diff)
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> To: Dinh Nguyen <dinh.linux@gmail.com>, David Miller <davem@davemloft.net>, dinguyen@altera.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, vbridgers2013@gmail.com Subject: Re: [PATCHv3 1/2] net: stmmac: Add SOCFPGA glue driver Date: Wed, 26 Feb 2014 10:44:33 +0100 [thread overview] Message-ID: <530DB781.9050901@st.com> (raw) In-Reply-To: <52FC4B0A.4010406@gmail.com> On 2/13/2014 5:33 AM, Dinh Nguyen wrote: > > On 2/12/14 6:35 PM, David Miller wrote: >> From: <dinguyen@altera.com> >> Date: Mon, 10 Feb 2014 13:48:16 -0600 >> >>> From: Dinh Nguyen <dinguyen@altera.com> >>> >>> Like the STi series SOCs, Altera's SOCFPGA also needs a glue layer on top of the >>> Synopsys gmac IP. >>> >>> This patch adds the platform driver for the glue layer which configures the IP >>> before the generic STMMAC driver takes over. >>> >>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com> >>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Pawel Moll <pawel.moll@arm.com> >>> Cc: Mark Rutland <mark.rutland@arm.com> >>> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >>> Cc: Kumar Gala <galak@codeaurora.org> >>> Cc: Vince Bridgers <vbridgers2013@gmail.com> >>> --- >>> v3: Remove stray empty line at end of dwmac-socfpga.c. >>> v2: Use the dwmac-sti as an example for a glue layer and split patch up >>> to have dts as a separate patch. Also cc dts maintainers since there is >>> a new binding. >> The second patch for the DTS update doesn't apply cleanly at all to >> mainline. > Yes, I'm planning to take the DTS bindings patch through arm-soc/next-dt > tree, so that is where patch 2 is based on. >> >> Why don't you push both of these patches through whatever tree that >> file is maintained under. You can add my ack: > I'm not sure if Peppe has a tree, but it should go into his tree > if there is one. If not, can you apply patch 1 to your tree? Hello I have not own tree but I am using net.git and net-next to do my patches and experiments. I ask you to keep these patches aligned to net-next. Also I ask you to review the glue-layer that is not in-line with what have been currently added for dwmac-sti and dwmac-sunxi.c. BR Peppe >> >> Acked-by: David S. Miller <davem@davemloft.net> > Thanks, > Dinh >
next prev parent reply other threads:[~2014-02-26 10:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-10 19:48 [PATCHv3 1/2] net: stmmac: Add SOCFPGA glue driver dinguyen 2014-02-10 19:48 ` dinguyen 2014-02-10 19:48 ` [PATCHv3 2/2] dts: socfpga: Add DTS entry for adding the stmmac glue layer for stmmac dinguyen 2014-02-10 19:48 ` dinguyen 2014-02-13 0:35 ` [PATCHv3 1/2] net: stmmac: Add SOCFPGA glue driver David Miller [not found] ` <20140212.193539.38124529344029793.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> 2014-02-13 4:33 ` Dinh Nguyen 2014-02-13 4:47 ` David Miller 2014-02-26 9:44 ` Giuseppe CAVALLARO [this message] 2014-02-26 9:44 ` Giuseppe CAVALLARO
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=530DB781.9050901@st.com \ --to=peppe.cavallaro@st.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@altera.com \ --cc=dinh.linux@gmail.com \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=mark.rutland@arm.com \ --cc=netdev@vger.kernel.org \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=vbridgers2013@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.